Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Anthony Fieroni 


> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.
> 
> Anthony Fieroni wrote:
> This code is needed. QKeySequence is about *only* for keyboard keys. 
> Mouse buttons *must* me handled by event, as far i know.
> 
> Sven Brauch wrote:
> Did you actually try that in the shortcut dialog? Please do. I don't have 
> a mouse with extra keys here right now ...
> 
> Kai Uwe Broulik wrote:
> Just tried, I cannot assign any mouse buttons to shortcuts, including 
> back/forward.
> 
> Anthony Fieroni wrote:
> Not only try, i saw the code in kxmlgui who set this shortcuts. It's used 
> QKeySequence who is keyboard specific. You can see the same code as this 
> patch in Dolphin for for/backward.
> 
> Sven Brauch wrote:
> Hmm, ok then. I'm undecided, let's wait for a few other opinions. On the 
> one hand, it sounds sensible, on the other hand I don't like hardcoded 
> shortcuts and the use case to switch documents with mouse is ... not a huge 
> one imo. Code looks ok.
> 
> Nicolás Alvarez wrote:
> My mouse has back/forward buttons (by tilting the scroll wheel sideways) 
> and I find it super useful in a web browser. But if the buttons were 
> supported in Kate, it's more likely I'd want to configure it for undo/redo 
> rather than document switching.

I was thinking to make a module for kxmlgui, to install event listener for all 
kxmlgui client and providing configurable mouse + keyboard shortcuts. But 
i'dont know Martin G or someone else not works on that in KWin ?!
I prefer document switch because ctrl+z fits left hand action + mouse ese, 
alt+left not.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On Март 28, 2016, 11:20 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated Март 28, 2016, 11:20 след обяд)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Nicolás Alvarez 


> On March 28, 2016, 5:22 p.m., Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.
> 
> Anthony Fieroni wrote:
> This code is needed. QKeySequence is about *only* for keyboard keys. 
> Mouse buttons *must* me handled by event, as far i know.
> 
> Sven Brauch wrote:
> Did you actually try that in the shortcut dialog? Please do. I don't have 
> a mouse with extra keys here right now ...
> 
> Kai Uwe Broulik wrote:
> Just tried, I cannot assign any mouse buttons to shortcuts, including 
> back/forward.
> 
> Anthony Fieroni wrote:
> Not only try, i saw the code in kxmlgui who set this shortcuts. It's used 
> QKeySequence who is keyboard specific. You can see the same code as this 
> patch in Dolphin for for/backward.
> 
> Sven Brauch wrote:
> Hmm, ok then. I'm undecided, let's wait for a few other opinions. On the 
> one hand, it sounds sensible, on the other hand I don't like hardcoded 
> shortcuts and the use case to switch documents with mouse is ... not a huge 
> one imo. Code looks ok.

My mouse has back/forward buttons (by tilting the scroll wheel sideways) and I 
find it super useful in a web browser. But if the buttons were supported in 
Kate, it's more likely I'd want to configure it for undo/redo rather than 
document switching.


- Nicolás


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On March 28, 2016, 5:20 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated March 28, 2016, 5:20 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 21:02:47 +
Build duration: 15 min

CHANGE SET
Revision 7c478d0304c2c7b3484668941e2b63e2fb6ba6ac by mail: (highlighting: add 
size_t to C type list)
  change: edit src/syntax/data/c.xml
Revision dab39de265388d48b74b8a984154b14fc9cdedc0 by dhaumann: 
(KateRenderer::lineHeight() returns an int)
  change: edit src/view/kateviewinternal.cpp
Revision 06b38872452d91622eb3fc7d324e6a265bb9e05f by dhaumann: (Change year to 
2016)
  change: edit src/utils/kateglobal.cpp
Revision 8004a22379165c4796cdef4f2b52a8a416052ff3 by dhaumann: (doxygen.xml: 
use default style Documentation (one hardcoded color less))
  change: edit src/syntax/data/doxygen.xml
Revision c56aaa12eeffe3e6287341ed40702e12cc9423c6 by Pino Toscano: (c/isocpp: 
add more C standard types)
  change: edit src/syntax/data/isocpp.xml
  change: edit src/syntax/data/c.xml
Revision 62e40aa7881f45039f575d9d4695385cc5a8e061 by dhaumann: (isocpp.xml: use 
default style "dsControlFlow" for control flow keywords)
  change: edit src/syntax/data/isocpp.xml
Revision 9d6982f758a2d06a9f20087fc6f927f171c2a335 by dhaumann: (c.xml: use 
default style for control flow keywords)
  change: edit src/syntax/data/c.xml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.bug205447Failed: TestSuite.katesyntaxtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29522/46332 
(64%)CONDITIONAL 15564/21351 (73%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3937/4263 
(92%)CONDITIONAL 1880/3522 (53%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3149/3164 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1560 (80%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1746/3111 
(56%)CONDITIONAL 1206/1618 (75%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 183/465 (39%)CONDITIONAL 
77/132 (58%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/931 (0%)CONDITIONAL 0/0 
(100%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1783/3205 
(56%)CONDITIONAL 1475/2046 (72%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 191/230 
(83%)CONDITIONAL 144/178 (81%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/73 (75%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/115 (84%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 
(100%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 897/1225 
(73%)CONDITIONAL 598/756 (79%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/8 (88%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 696/1055 
(66%)CONDITIONAL 292/408 (72%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 892/1384 
(64%)CONDITIONAL 519/675 (77%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/328 (63%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/74 (77%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1661/2135 
(78%)CONDITIONAL 1057/1262 (84%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/400 (80%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2484/3851 
(65%)CONDITIONAL 1248/1685 (74%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/659 (0%)CONDITIONAL 0/0 
(100%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3064/6089 
(50%)CONDITIONAL 1369/1839 (74%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2300/3093 
(74%)CONDITIONAL 1298/1651 (79%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/0 
(100%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3243/3738 
(87%)CONDITIONAL 1851/2145 (86%)___
Kde-frameworks-devel mailing list
Kde-frameworks-deve

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 4 - Still Unstable!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 21:02:47 +
Build duration: 14 min

CHANGE SET
Revision 58b0927ac69b172a82dace1bc28990abbaa45a3e by Alex Richardson: (Fix typo 
introduced in 578b95adc43a278b320660ba12ec9bf58395fb0b)
  change: edit src/syntax/data/cmake.xml
Revision 7c478d0304c2c7b3484668941e2b63e2fb6ba6ac by mail: (highlighting: add 
size_t to C type list)
  change: edit src/syntax/data/c.xml
Revision dab39de265388d48b74b8a984154b14fc9cdedc0 by dhaumann: 
(KateRenderer::lineHeight() returns an int)
  change: edit src/view/kateviewinternal.cpp
Revision 06b38872452d91622eb3fc7d324e6a265bb9e05f by dhaumann: (Change year to 
2016)
  change: edit src/utils/kateglobal.cpp
Revision 8004a22379165c4796cdef4f2b52a8a416052ff3 by dhaumann: (doxygen.xml: 
use default style Documentation (one hardcoded color less))
  change: edit src/syntax/data/doxygen.xml
Revision c56aaa12eeffe3e6287341ed40702e12cc9423c6 by Pino Toscano: (c/isocpp: 
add more C standard types)
  change: edit src/syntax/data/isocpp.xml
  change: edit src/syntax/data/c.xml
Revision 62e40aa7881f45039f575d9d4695385cc5a8e061 by dhaumann: (isocpp.xml: use 
default style "dsControlFlow" for control flow keywords)
  change: edit src/syntax/data/isocpp.xml
Revision 9d6982f758a2d06a9f20087fc6f927f171c2a335 by dhaumann: (c.xml: use 
default style for control flow keywords)
  change: edit src/syntax/data/c.xml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.bug205447Failed: TestSuite.katesyntaxtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29522/46332 
(64%)CONDITIONAL 15564/21351 (73%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 3937/4263 
(92%)CONDITIONAL 1880/3522 (53%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3149/3164 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1560 (80%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1746/3111 
(56%)CONDITIONAL 1206/1618 (75%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 183/465 (39%)CONDITIONAL 
77/132 (58%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/931 (0%)CONDITIONAL 0/0 
(100%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1783/3205 
(56%)CONDITIONAL 1475/2046 (72%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 191/230 
(83%)CONDITIONAL 144/178 (81%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/73 (75%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/115 (84%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/882 (0%)CONDITIONAL 0/0 
(100%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 897/1225 
(73%)CONDITIONAL 598/756 (79%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/8 (88%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 696/1055 
(66%)CONDITIONAL 292/408 (72%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 892/1384 
(64%)CONDITIONAL 519/675 (77%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/328 (63%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/74 (77%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1661/2135 
(78%)CONDITIONAL 1057/1262 (84%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/400 (80%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2484/3851 
(65%)CONDITIONAL 1248/1685 (74%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/659 (0%)CONDITIONAL 0/0 
(100%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3064/6089 
(50%)CONDITIONAL 1369/1839 (74%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2300/3093 
(74%)CONDITIONAL 1298/1651 (79%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/0 
(100%)
src.vimode.modes
FILES 10/10 (100

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 20:46:54 +
Build duration: 41 min

CHANGE SET
Revision f2d6a8a78d0bc3ab0575174777945bd1f351b953 by Hrvoje Senjan: (Don't 
leak Qt5::Network as required lib for the rest of the)
  change: edit src/ConfigureChecks.cmake


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptestFailed: TestSuite.kmimetypetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21667/42783 
(51%)CONDITIONAL 14640/24845 (59%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11495/11763 
(98%)CONDITIONAL 8467/16510 (51%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9218/16860 
(55%)CONDITIONAL 5710/7613 (75%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9831 
(10%)CONDITIONAL 460/716 (64%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/6 (50%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/0 
(100%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/0 
(100%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 20:46:54 +
Build duration: 15 min

CHANGE SET
Revision f2d6a8a78d0bc3ab0575174777945bd1f351b953 by Hrvoje Senjan: (Don't 
leak Qt5::Network as required lib for the rest of the)
  change: edit src/ConfigureChecks.cmake


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptestFailed: TestSuite.kmimetypetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21667/42783 
(51%)CONDITIONAL 14640/24845 (59%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11495/11763 
(98%)CONDITIONAL 8467/16510 (51%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9218/16860 
(55%)CONDITIONAL 5710/7613 (75%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9831 
(10%)CONDITIONAL 460/716 (64%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/6 (50%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/0 
(100%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/0 
(100%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 3 - Fixed!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 20:46:14 +
Build duration: 1 min 11 sec

CHANGE SET
Revision 467556d006dc44b8d4c0374779132ca715df4149 by kainz.a: (add xpi support 
for firefox addons BUG: 359913)
  change: add icons-dark/mimetypes/64/application-x-xpinstall.svg
  change: add icons/mimetypes/16/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/32/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/22/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/16/application-x-xpinstall.svg
  change: add icons/mimetypes/32/application-x-xpinstall.svg
  change: add icons/mimetypes/64/application-x-xpinstall.svg
  change: add icons/mimetypes/22/application-x-xpinstall.svg
Revision 126afd54496afe39d59ebe0aea29f5f24c68b917 by kainz.a: (update broken 
linked files)
  change: add icons-dark/mimetypes/22/none.svg
  change: add icons-dark/actions/24/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/64/none.svg
  change: edit icons/actions/22/step_object_Controller.svg
  change: add icons/actions/32/configure-shortcuts.svg
  change: add icons/mimetypes/16/none.svg
  change: add icons/actions/32/help-keybord-shortcuts.svg
  change: edit icons-dark/actions/16/configure-shortcuts.svg
  change: add icons/actions/24/help-keybord-shortcuts.svg
  change: add icons-dark/actions/32/games-config-options.svg
  change: edit icons/actions/22/games-config-options.svg
  change: add icons-dark/actions/24/games-config-options.svg
  change: add icons/mimetypes/32/none.svg
  change: add icons/actions/24/games-config-options.svg
  change: edit icons/actions/16/configure-shortcuts.svg
  change: add icons/actions/32/games-config-options.svg
  change: add icons-dark/actions/32/help-keybord-shortcuts.svg
  change: edit icons-dark/actions/22/games-config-options.svg
  change: add icons-dark/mimetypes/32/none.svg
  change: edit icons-dark/actions/16/games-config-options.svg
  change: add icons-dark/actions/24/configure-shortcuts.svg
  change: add icons/mimetypes/64/none.svg
  change: delete icons-dark/actions/48/document-open-recent.svg
  change: add icons-dark/actions/22/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/16/none.svg
  change: edit icons-dark/actions/22/configure-shortcuts.svg
  change: add icons/mimetypes/22/none.svg
  change: edit icons/actions/22/configure-shortcuts.svg
  change: add icons-dark/actions/32/configure-shortcuts.svg
  change: edit icons/actions/16/games-config-options.svg
  change: add icons/actions/24/configure-shortcuts.svg
  change: add icons/actions/22/help-keybord-shortcuts.svg
Revision c0025b77e4076955944527de28b1721df006fd53 by kainz.a: (add qt icons)
  change: add icons/apps/48/qdbusviewer.svg
  change: add icons/apps/48/assistant.svg
  change: add icons/apps/32/kde-gtk-config.svg
  change: add icons-dark/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/48/assistant.svg
  change: add icons-dark/apps/48/qdbusviewer.svg
  change: add icons/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/32/kde-gtk-config.svg
  change: add icons/apps/48/linguist.svg
  change: add icons-dark/apps/48/linguist.svg
Revision c41dfa6baae9f80cdf3578f6510e8fc52ae8b3a5 by Hrvoje Senjan: (One more 
broken symlink)
  change: edit icons-dark/actions/22/step_object_Controller.svg
Revision c738ee697f343cc6a4972f368dafcfbc617006cf by alessandro.longo: (New 
apps' icons at 48px)
  change: add icons/apps/48/planetkde.svgz
  change: add icons/apps/48/kile.svg
  change: add icons/apps/48/artikulate.svg
  change: add icons/apps/48/umbrello.svg
  change: add icons/apps/48/kde-frameworks.svg
  change: add icons/apps/48/ring.svg
  change: add icons/apps/48/blogilo.svg
  change: add icons/apps/48/ardour.svg
  change: add icons/apps/48/kaffeine.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 
(65%)CONDITIONAL 14/20 (70%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 (65%)CONDITIONAL 
14/20 (70%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 3 - Fixed!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 20:46:14 +
Build duration: 1 min 11 sec

CHANGE SET
Revision 467556d006dc44b8d4c0374779132ca715df4149 by kainz.a: (add xpi support 
for firefox addons BUG: 359913)
  change: add icons-dark/mimetypes/64/application-x-xpinstall.svg
  change: add icons/mimetypes/16/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/32/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/22/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/16/application-x-xpinstall.svg
  change: add icons/mimetypes/32/application-x-xpinstall.svg
  change: add icons/mimetypes/64/application-x-xpinstall.svg
  change: add icons/mimetypes/22/application-x-xpinstall.svg
Revision 126afd54496afe39d59ebe0aea29f5f24c68b917 by kainz.a: (update broken 
linked files)
  change: add icons-dark/mimetypes/22/none.svg
  change: add icons-dark/actions/24/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/64/none.svg
  change: edit icons/actions/22/step_object_Controller.svg
  change: add icons/actions/32/configure-shortcuts.svg
  change: add icons/mimetypes/16/none.svg
  change: add icons/actions/32/help-keybord-shortcuts.svg
  change: edit icons-dark/actions/16/configure-shortcuts.svg
  change: add icons/actions/24/help-keybord-shortcuts.svg
  change: add icons-dark/actions/32/games-config-options.svg
  change: edit icons/actions/22/games-config-options.svg
  change: add icons-dark/actions/24/games-config-options.svg
  change: add icons/mimetypes/32/none.svg
  change: add icons/actions/24/games-config-options.svg
  change: edit icons/actions/16/configure-shortcuts.svg
  change: add icons/actions/32/games-config-options.svg
  change: add icons-dark/actions/32/help-keybord-shortcuts.svg
  change: edit icons-dark/actions/22/games-config-options.svg
  change: add icons-dark/mimetypes/32/none.svg
  change: edit icons-dark/actions/16/games-config-options.svg
  change: add icons-dark/actions/24/configure-shortcuts.svg
  change: add icons/mimetypes/64/none.svg
  change: delete icons-dark/actions/48/document-open-recent.svg
  change: add icons-dark/actions/22/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/16/none.svg
  change: edit icons-dark/actions/22/configure-shortcuts.svg
  change: add icons/mimetypes/22/none.svg
  change: edit icons/actions/22/configure-shortcuts.svg
  change: add icons-dark/actions/32/configure-shortcuts.svg
  change: edit icons/actions/16/games-config-options.svg
  change: add icons/actions/24/configure-shortcuts.svg
  change: add icons/actions/22/help-keybord-shortcuts.svg
Revision c0025b77e4076955944527de28b1721df006fd53 by kainz.a: (add qt icons)
  change: add icons/apps/48/qdbusviewer.svg
  change: add icons/apps/48/assistant.svg
  change: add icons/apps/32/kde-gtk-config.svg
  change: add icons-dark/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/48/assistant.svg
  change: add icons-dark/apps/48/qdbusviewer.svg
  change: add icons/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/32/kde-gtk-config.svg
  change: add icons/apps/48/linguist.svg
  change: add icons-dark/apps/48/linguist.svg
Revision c41dfa6baae9f80cdf3578f6510e8fc52ae8b3a5 by Hrvoje Senjan: (One more 
broken symlink)
  change: edit icons-dark/actions/22/step_object_Controller.svg
Revision c738ee697f343cc6a4972f368dafcfbc617006cf by alessandro.longo: (New 
apps' icons at 48px)
  change: add icons/apps/48/planetkde.svgz
  change: add icons/apps/48/kile.svg
  change: add icons/apps/48/artikulate.svg
  change: add icons/apps/48/umbrello.svg
  change: add icons/apps/48/kde-frameworks.svg
  change: add icons/apps/48/ring.svg
  change: add icons/apps/48/blogilo.svg
  change: add icons/apps/48/ardour.svg
  change: add icons/apps/48/kaffeine.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 
(65%)CONDITIONAL 14/20 (70%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 (65%)CONDITIONAL 
14/20 (70%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 4 - Fixed!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 20:46:14 +
Build duration: 1 min 2 sec

CHANGE SET
Revision 467556d006dc44b8d4c0374779132ca715df4149 by kainz.a: (add xpi support 
for firefox addons BUG: 359913)
  change: add icons-dark/mimetypes/16/application-x-xpinstall.svg
  change: add icons/mimetypes/32/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/22/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/64/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/32/application-x-xpinstall.svg
  change: add icons/mimetypes/16/application-x-xpinstall.svg
  change: add icons/mimetypes/22/application-x-xpinstall.svg
  change: add icons/mimetypes/64/application-x-xpinstall.svg
Revision 126afd54496afe39d59ebe0aea29f5f24c68b917 by kainz.a: (update broken 
linked files)
  change: add icons/actions/24/help-keybord-shortcuts.svg
  change: edit icons/actions/16/configure-shortcuts.svg
  change: add icons/mimetypes/16/none.svg
  change: add icons/mimetypes/32/none.svg
  change: add icons/actions/24/games-config-options.svg
  change: add icons/mimetypes/64/none.svg
  change: edit icons/actions/16/games-config-options.svg
  change: add icons/actions/24/configure-shortcuts.svg
  change: add icons-dark/actions/24/games-config-options.svg
  change: edit icons-dark/actions/16/configure-shortcuts.svg
  change: add icons-dark/actions/32/configure-shortcuts.svg
  change: edit icons/actions/22/games-config-options.svg
  change: add icons-dark/actions/24/help-keybord-shortcuts.svg
  change: add icons-dark/actions/22/help-keybord-shortcuts.svg
  change: add icons/actions/32/games-config-options.svg
  change: edit icons-dark/actions/22/configure-shortcuts.svg
  change: edit icons-dark/actions/22/games-config-options.svg
  change: add icons/actions/22/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/32/none.svg
  change: add icons-dark/actions/32/games-config-options.svg
  change: add icons-dark/mimetypes/16/none.svg
  change: delete icons-dark/actions/48/document-open-recent.svg
  change: add icons/mimetypes/22/none.svg
  change: add icons-dark/actions/24/configure-shortcuts.svg
  change: edit icons/actions/22/configure-shortcuts.svg
  change: add icons-dark/actions/32/help-keybord-shortcuts.svg
  change: edit icons/actions/22/step_object_Controller.svg
  change: add icons/actions/32/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/64/none.svg
  change: edit icons-dark/actions/16/games-config-options.svg
  change: add icons/actions/32/configure-shortcuts.svg
  change: add icons-dark/mimetypes/22/none.svg
Revision c0025b77e4076955944527de28b1721df006fd53 by kainz.a: (add qt icons)
  change: add icons/apps/32/kde-gtk-config.svg
  change: add icons/apps/48/qdbusviewer.svg
  change: add icons-dark/apps/48/linguist.svg
  change: add icons/apps/48/linguist.svg
  change: add icons/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/48/qdbusviewer.svg
  change: add icons-dark/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/32/kde-gtk-config.svg
  change: add icons-dark/apps/48/assistant.svg
  change: add icons/apps/48/assistant.svg
Revision c41dfa6baae9f80cdf3578f6510e8fc52ae8b3a5 by Hrvoje Senjan: (One more 
broken symlink)
  change: edit icons-dark/actions/22/step_object_Controller.svg
Revision c738ee697f343cc6a4972f368dafcfbc617006cf by alessandro.longo: (New 
apps' icons at 48px)
  change: add icons/apps/48/ardour.svg
  change: add icons/apps/48/kde-frameworks.svg
  change: add icons/apps/48/artikulate.svg
  change: add icons/apps/48/blogilo.svg
  change: add icons/apps/48/kaffeine.svg
  change: add icons/apps/48/planetkde.svgz
  change: add icons/apps/48/kile.svg
  change: add icons/apps/48/ring.svg
  change: add icons/apps/48/umbrello.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 
(65%)CONDITIONAL 14/20 (70%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 (65%)CONDITIONAL 
14/20 (70%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 4 - Fixed!

2016-03-28 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Mar 2016 20:46:14 +
Build duration: 1 min 2 sec

CHANGE SET
Revision 467556d006dc44b8d4c0374779132ca715df4149 by kainz.a: (add xpi support 
for firefox addons BUG: 359913)
  change: add icons-dark/mimetypes/16/application-x-xpinstall.svg
  change: add icons/mimetypes/32/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/22/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/64/application-x-xpinstall.svg
  change: add icons-dark/mimetypes/32/application-x-xpinstall.svg
  change: add icons/mimetypes/16/application-x-xpinstall.svg
  change: add icons/mimetypes/22/application-x-xpinstall.svg
  change: add icons/mimetypes/64/application-x-xpinstall.svg
Revision 126afd54496afe39d59ebe0aea29f5f24c68b917 by kainz.a: (update broken 
linked files)
  change: add icons/actions/24/help-keybord-shortcuts.svg
  change: edit icons/actions/16/configure-shortcuts.svg
  change: add icons/mimetypes/16/none.svg
  change: add icons/mimetypes/32/none.svg
  change: add icons/actions/24/games-config-options.svg
  change: add icons/mimetypes/64/none.svg
  change: edit icons/actions/16/games-config-options.svg
  change: add icons/actions/24/configure-shortcuts.svg
  change: add icons-dark/actions/24/games-config-options.svg
  change: edit icons-dark/actions/16/configure-shortcuts.svg
  change: add icons-dark/actions/32/configure-shortcuts.svg
  change: edit icons/actions/22/games-config-options.svg
  change: add icons-dark/actions/24/help-keybord-shortcuts.svg
  change: add icons-dark/actions/22/help-keybord-shortcuts.svg
  change: add icons/actions/32/games-config-options.svg
  change: edit icons-dark/actions/22/configure-shortcuts.svg
  change: edit icons-dark/actions/22/games-config-options.svg
  change: add icons/actions/22/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/32/none.svg
  change: add icons-dark/actions/32/games-config-options.svg
  change: add icons-dark/mimetypes/16/none.svg
  change: delete icons-dark/actions/48/document-open-recent.svg
  change: add icons/mimetypes/22/none.svg
  change: add icons-dark/actions/24/configure-shortcuts.svg
  change: edit icons/actions/22/configure-shortcuts.svg
  change: add icons-dark/actions/32/help-keybord-shortcuts.svg
  change: edit icons/actions/22/step_object_Controller.svg
  change: add icons/actions/32/help-keybord-shortcuts.svg
  change: add icons-dark/mimetypes/64/none.svg
  change: edit icons-dark/actions/16/games-config-options.svg
  change: add icons/actions/32/configure-shortcuts.svg
  change: add icons-dark/mimetypes/22/none.svg
Revision c0025b77e4076955944527de28b1721df006fd53 by kainz.a: (add qt icons)
  change: add icons/apps/32/kde-gtk-config.svg
  change: add icons/apps/48/qdbusviewer.svg
  change: add icons-dark/apps/48/linguist.svg
  change: add icons/apps/48/linguist.svg
  change: add icons/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/48/qdbusviewer.svg
  change: add icons-dark/apps/48/QtProject-designer.svg
  change: add icons-dark/apps/32/kde-gtk-config.svg
  change: add icons-dark/apps/48/assistant.svg
  change: add icons/apps/48/assistant.svg
Revision c41dfa6baae9f80cdf3578f6510e8fc52ae8b3a5 by Hrvoje Senjan: (One more 
broken symlink)
  change: edit icons-dark/actions/22/step_object_Controller.svg
Revision c738ee697f343cc6a4972f368dafcfbc617006cf by alessandro.longo: (New 
apps' icons at 48px)
  change: add icons/apps/48/ardour.svg
  change: add icons/apps/48/kde-frameworks.svg
  change: add icons/apps/48/artikulate.svg
  change: add icons/apps/48/blogilo.svg
  change: add icons/apps/48/kaffeine.svg
  change: add icons/apps/48/planetkde.svgz
  change: add icons/apps/48/kile.svg
  change: add icons/apps/48/ring.svg
  change: add icons/apps/48/umbrello.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 
(65%)CONDITIONAL 14/20 (70%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 22/34 (65%)CONDITIONAL 
14/20 (70%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Sven Brauch 


> On March 28, 2016, 8:22 p.m., Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.
> 
> Anthony Fieroni wrote:
> This code is needed. QKeySequence is about *only* for keyboard keys. 
> Mouse buttons *must* me handled by event, as far i know.
> 
> Sven Brauch wrote:
> Did you actually try that in the shortcut dialog? Please do. I don't have 
> a mouse with extra keys here right now ...
> 
> Kai Uwe Broulik wrote:
> Just tried, I cannot assign any mouse buttons to shortcuts, including 
> back/forward.
> 
> Anthony Fieroni wrote:
> Not only try, i saw the code in kxmlgui who set this shortcuts. It's used 
> QKeySequence who is keyboard specific. You can see the same code as this 
> patch in Dolphin for for/backward.

Hmm, ok then. I'm undecided, let's wait for a few other opinions. On the one 
hand, it sounds sensible, on the other hand I don't like hardcoded shortcuts 
and the use case to switch documents with mouse is ... not a huge one imo. Code 
looks ok.


- Sven


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On March 28, 2016, 8:20 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated March 28, 2016, 8:20 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Anthony Fieroni 


> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.
> 
> Anthony Fieroni wrote:
> This code is needed. QKeySequence is about *only* for keyboard keys. 
> Mouse buttons *must* me handled by event, as far i know.
> 
> Sven Brauch wrote:
> Did you actually try that in the shortcut dialog? Please do. I don't have 
> a mouse with extra keys here right now ...
> 
> Kai Uwe Broulik wrote:
> Just tried, I cannot assign any mouse buttons to shortcuts, including 
> back/forward.

Not only try, i saw the code in kxmlgui who set this shortcuts. It's used 
QKeySequence who is keyboard specific. You can see the same code as this patch 
in Dolphin for for/backward.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On Март 28, 2016, 11:20 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated Март 28, 2016, 11:20 след обяд)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Kai Uwe Broulik 


> On März 28, 2016, 8:22 nachm., Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.
> 
> Anthony Fieroni wrote:
> This code is needed. QKeySequence is about *only* for keyboard keys. 
> Mouse buttons *must* me handled by event, as far i know.
> 
> Sven Brauch wrote:
> Did you actually try that in the shortcut dialog? Please do. I don't have 
> a mouse with extra keys here right now ...

Just tried, I cannot assign any mouse buttons to shortcuts, including 
back/forward.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On März 28, 2016, 8:20 nachm., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated März 28, 2016, 8:20 nachm.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Sven Brauch 


> On March 28, 2016, 8:22 p.m., Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.
> 
> Anthony Fieroni wrote:
> This code is needed. QKeySequence is about *only* for keyboard keys. 
> Mouse buttons *must* me handled by event, as far i know.

Did you actually try that in the shortcut dialog? Please do. I don't have a 
mouse with extra keys here right now ...


- Sven


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On March 28, 2016, 8:20 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated March 28, 2016, 8:20 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Anthony Fieroni 


> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons 
> > to the forward / backward actions as shortcuts? Try setting them as 
> > alternate shortcuts by default.

This code is needed. QKeySequence is about *only* for keyboard keys. Mouse 
buttons *must* me handled by event, as far i know.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---


On Март 28, 2016, 11:20 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated Март 28, 2016, 11:20 след обяд)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Sven Brauch 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/#review94084
---



Hmm. Do we really need code for that? Can't you simply assign those buttons to 
the forward / backward actions as shortcuts? Try setting them as alternate 
shortcuts by default.

- Sven Brauch


On March 28, 2016, 8:20 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127122/
> ---
> 
> (Updated March 28, 2016, 8:20 p.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
> and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> Show prev/next tab on mouse back/forward buttons
> 
> 
> Diffs
> -
> 
>   kate/katemainwindow.h ece0db8 
>   kate/katemainwindow.cpp f630e28 
> 
> Diff: https://git.reviewboard.kde.org/r/127122/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

2016-03-28 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127122/
---

(Updated Март 28, 2016, 11:20 след обяд)


Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, 
and Kåre Särs.


Changes
---

Makes sense for mouse with forward/backward button, like mine :)


Repository: kate


Description
---

Show prev/next tab on mouse back/forward buttons


Diffs (updated)
-

  kate/katemainwindow.h ece0db8 
  kate/katemainwindow.cpp f630e28 

Diff: https://git.reviewboard.kde.org/r/127122/diff/


Testing (updated)
---


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-03-28 Thread Stephen Kelly 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126610/#review94076
---



Do you still have the sample application you made to test/verify this? I'd like 
to try it and it should probably be committed too.

- Stephen Kelly


On March 28, 2016, 1:41 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126610/
> ---
> 
> (Updated March 28, 2016, 1:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Stephen Kelly.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> ---
> 
> When indexes are removed and their widgets deleted, the event filter on each 
> widget is not removed, leading to the "you should not delete widgets 
> manually"-alike warning.
> 
> Add an helper forgetAbout() function which performs all the actions done 
> per-widget before deleting each, additionally removing also the event filter.
> 
> 
> Diffs
> -
> 
>   src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 
>   src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 
>   src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126610/diff/
> 
> 
> Testing
> ---
> 
> A sample application with widgets for items in the model, removing indexes: 
> no more warning at removal time.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Sandro Knauß 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

(Updated March 28, 2016, 3:47 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Submitted with commit 50f191eaba9b076675a52252dd8f2a5aaf5b1bb0 by Sandro Knauß 
to branch master.


Repository: kconfig


Description
---

Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.


Diffs
-

  autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing
---

Adding tests for QT_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Sandro Knauß 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

(Updated März 28, 2016, 3:21 nachm.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

Get rid of explitly ask XDG_*_HOME variables.


Repository: kconfig


Description
---

Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.


Diffs (updated)
-

  autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing (updated)
---

Adding tests for QT_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Matthew Dawson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review94075
---



LGTM.  Two minor issues with the documentation, then it is good to go in.  
Please also add a CHANGELOG line to the commit message.  Thanks for taking care 
of this.


docs/options.md (line 94)


Grammer nitpick, maybe instead:

There are three environment variables that have a fallback strategy if the
environment variable is not set. They instead map to a location from 
QStanardPaths.  They are:



docs/options.md (line 96)


Nitpick: s/QStandardsPath/QStandardPaths/


- Matthew Dawson


On March 28, 2016, 11:21 a.m., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> ---
> 
> (Updated March 28, 2016, 11:21 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Inside desktop files we want to reach also data, cache and config home
> to create files inside these directories.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> ---
> 
> Adding tests for QT_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Matthew Dawson 


> On March 28, 2016, 1:39 a.m., Matthew Dawson wrote:
> > Much better!  I don't think this should handle XDG* variables explicitly, 
> > as they won't be used on other platforms and may cause confusion there.  On 
> > platforms using XDG* variables, Qt handles this for us internally.  I 
> > opened issues accordingly below.  Other then that, looks good to me.
> 
> Sandro Knauß wrote:
> But where does Qt handles these internally? At the moment Qt isn't doing 
> this at all. If we don't respect XDG_*_Home it is a unexpected result for XDG 
> conform desktops. Do you suggest to #ifdef the XDG handling?

In the qtbase repository, look at the src/corelib/io/qstandardpaths_unix.cpp 
file (http://osxr.org/qt/source/qtbase/src/corelib/io/qstandardpaths_unix.cpp, 
line 84 for instance.  Also in git).  It returns the path for QStandardPaths, 
and checks the value of the XDG variables.  Considering there is lots of other 
software that relies on this functionality, either everything else in the Qt 
world is not XDG compliant, or Qt handles it for us.


> On March 28, 2016, 1:39 a.m., Matthew Dawson wrote:
> > autotests/kconfigtest.cpp, line 581
> > 
> >
> > We unfortunately can't test XDG* variables due to Qt, but I think we'll 
> > be ok for now.  The rest of the looks fine.
> 
> Sandro Knauß wrote:
> Well the test is green, so this works :D

Right, but if/when you remove the explicit variable handling below, it will 
break.


- Matthew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review94057
---


On March 27, 2016, 10:22 a.m., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> ---
> 
> (Updated March 27, 2016, 10:22 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Inside desktop files we want to reach also data, cache and config home
> to create files inside these directories.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> ---
> 
> Adding tests for XDG_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-28 Thread Albert Astals Cid 


> On March 27, 2016, 10:03 a.m., David Faure wrote:
> > Given how the socket API works, you should only call error() after a call 
> > that returns false (e.g. waitForConnected, etc.). As you found out, calling 
> > error() at random points in time doesn't give useful information, you get 
> > the last error that was ever set, even after 10 successful calls following 
> > the call that had an error.
> > 
> > Calling setError ourselves is a workaround, which doesn't fit with the Qt 
> > socket API (there is no "No error" error code).
> > UnknownSocketError *means* error, it doesn't mean no error.
> > 
> > It seems to me (from the description, I didn't read the code attentively) 
> > that the right solution is to actually disconnect after a 
> > RemoteHostClosedError. Then the state won't be ConnectedState anymore, and 
> > isConnected() will work as intended :-)
> 
> Albert Astals Cid wrote:
> But it won't, even if you disconnect, the error will still be 
> RemoteHostClosedError given that Qt does not reset the error after 
> disconnectFromHost (since there's basically no way to mark "no error"), so if 
> we reconnect after disconnection we will still have RemoteHostClosedError if 
> we ask for the error even if it's not true for this session. Of you mean this 
> in connection with the above hack?
> 
> Andreas Hartmetz wrote:
> Yeah, what happens here is working around two API mistakes in QTcpSocket: 
> that there is no proper "no error" code, and that the error isn't cleared 
> when starting a new connection. Apart from settings that may reasonably be 
> persistent like e.g. proxy or buffer size settings, a new connection should 
> behave exactly the same as deleting and recreating the socket. Otherwise the 
> API effectively requires you to delete and recreate a socket to get a clean 
> state, which isn't very nice in such a widely used API. (I sometimes do this 
> in internal interfaces, it's a nice technique to avoid errors in reset and 
> clean up code paths - but it causes a little overhead and more work for 
> consumers)
> Since the check here is for a specific error code, UnknownError works as 
> a code that isn't that specific one. And if we hack the error code reset, we 
> have what we need. I consider that self defense against bad API, not a real 
> hack.
> 
> David Faure wrote:
> My suggestion is about using the API the way it was intended to be used: 
> never calling error() unless a QAbstractSocket method returns false. So 
> definitely not calling error() in isConnected(), but only after specific API 
> calls that return false.
> 
> Albert: if we disconnect, then state() == ConnectedState will be false, 
> and therefore isConnected will return false, as intended.
> No need to call error() in that method.
> 
> Andreas Hartmetz wrote:
> There does seem to be a way to check whether the socket error is for the 
> current connection, sort of... check if the errorString() is empty. That one 
> is cleared on close() and AFAICS also set each time a socket error occurs. It 
> is also never set on its own - every error is a socket error in 
> QAbstractSocket.
> So QAbstractSocket does support lazy error checks, it's just a bit 
> strange.
> 
> Albert Astals Cid wrote:
> Andreas, that doesn't work, see the code of QIODevice::errorString
> 
> if (d->errorString.isEmpty()) {
> #ifdef QT_NO_QOBJECT
> return QLatin1String(QT_TRANSLATE_NOOP(QIODevice, "Unknown 
> error"));
> #else
> return tr("Unknown error");
> #endif
> }

> My suggestion is about using the API the way it was intended to be used: 
> never calling error() unless a QAbstractSocket method returns false. So 
> definitely not calling error() in isConnected(), but only after specific API 
> calls that return false.

You can not do that, there's no API call that will return false in this case, 
socket.write returns a valid number of bytes, waitForBytesWritten returns true, 
but if you ask for the error after that, it has been set to 
RemoteHostClosedError, you may argue that is a bug in Qt and that calling 
waitForBytesWritten should properly return false if the calls to 
QAbstractSocketPrivate::canReadNotification, 
QAbstractSocketPrivate::readFromSocket and QNativeSocketEngine::read end up 
setting an error.

> Albert: if we disconnect, then state() == ConnectedState will be false, and 
> therefore isConnected will return false, as intended. No need to call error() 
> in that method.

Yes, we could do that and it would fix isConnected for the first time, the 
problem is that if after you try to reuse the socket, error() will still be set 
and as there's no way to unset it (or check we have to read it, unless as said 
on the paragraph above, we consider the Qt behaviour a bug and fix it)


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-28 Thread Albert Astals Cid 


> On March 27, 2016, 10:03 a.m., David Faure wrote:
> > Given how the socket API works, you should only call error() after a call 
> > that returns false (e.g. waitForConnected, etc.). As you found out, calling 
> > error() at random points in time doesn't give useful information, you get 
> > the last error that was ever set, even after 10 successful calls following 
> > the call that had an error.
> > 
> > Calling setError ourselves is a workaround, which doesn't fit with the Qt 
> > socket API (there is no "No error" error code).
> > UnknownSocketError *means* error, it doesn't mean no error.
> > 
> > It seems to me (from the description, I didn't read the code attentively) 
> > that the right solution is to actually disconnect after a 
> > RemoteHostClosedError. Then the state won't be ConnectedState anymore, and 
> > isConnected() will work as intended :-)
> 
> Albert Astals Cid wrote:
> But it won't, even if you disconnect, the error will still be 
> RemoteHostClosedError given that Qt does not reset the error after 
> disconnectFromHost (since there's basically no way to mark "no error"), so if 
> we reconnect after disconnection we will still have RemoteHostClosedError if 
> we ask for the error even if it's not true for this session. Of you mean this 
> in connection with the above hack?
> 
> Andreas Hartmetz wrote:
> Yeah, what happens here is working around two API mistakes in QTcpSocket: 
> that there is no proper "no error" code, and that the error isn't cleared 
> when starting a new connection. Apart from settings that may reasonably be 
> persistent like e.g. proxy or buffer size settings, a new connection should 
> behave exactly the same as deleting and recreating the socket. Otherwise the 
> API effectively requires you to delete and recreate a socket to get a clean 
> state, which isn't very nice in such a widely used API. (I sometimes do this 
> in internal interfaces, it's a nice technique to avoid errors in reset and 
> clean up code paths - but it causes a little overhead and more work for 
> consumers)
> Since the check here is for a specific error code, UnknownError works as 
> a code that isn't that specific one. And if we hack the error code reset, we 
> have what we need. I consider that self defense against bad API, not a real 
> hack.
> 
> David Faure wrote:
> My suggestion is about using the API the way it was intended to be used: 
> never calling error() unless a QAbstractSocket method returns false. So 
> definitely not calling error() in isConnected(), but only after specific API 
> calls that return false.
> 
> Albert: if we disconnect, then state() == ConnectedState will be false, 
> and therefore isConnected will return false, as intended.
> No need to call error() in that method.
> 
> Andreas Hartmetz wrote:
> There does seem to be a way to check whether the socket error is for the 
> current connection, sort of... check if the errorString() is empty. That one 
> is cleared on close() and AFAICS also set each time a socket error occurs. It 
> is also never set on its own - every error is a socket error in 
> QAbstractSocket.
> So QAbstractSocket does support lazy error checks, it's just a bit 
> strange.

Andreas, that doesn't work, see the code of QIODevice::errorString

if (d->errorString.isEmpty()) {
#ifdef QT_NO_QOBJECT
return QLatin1String(QT_TRANSLATE_NOOP(QIODevice, "Unknown error"));
#else
return tr("Unknown error");
#endif
}


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127501/#review94042
---


On March 26, 2016, 5:29 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127501/
> ---
> 
> (Updated March 26, 2016, 5:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Qt sockets returns ConnectedState even when error is set to 
> RemoteHostClosedError after a write operation.
> 
> So make ::isConnected also check for RemoteHostClosedError.
> 
> This has the consequence that we have to create/delete the socket since Qt 
> sockets have no way to reset their error state so if we want to reuse the 
> slave to connect again it will never work with the same socket since it will 
> always say RemoteHostClosedError.
> 
> I need this for https://git.reviewboard.kde.org/r/127502/
> 
> 
> Diffs
> -
> 
>   src/core/tcpslavebase.cpp b9be69d 
> 
> Diff: https://git.reviewboard.kde.org/r/127501/diff/
> 
> 
> Testing
> ---
> 
> Seesms to work fine and the pop3 bugfix i have also works fine.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___

Review Request 127514: Skip category test if no restriction is set.

2016-03-28 Thread Andreas Cord-Landwehr 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127514/
---

Review request for KDE Frameworks.


Repository: kcmutils


Description
---

Align the method's logic with the API documentation for
KPluginSelector::addPlugins. The intended behavior is that
if no categoryKey is set, the category key test is skipped.


Diffs
-

  src/kpluginselector.cpp a893e381d1376ccc5c8189b638609e141c198282 

Diff: https://git.reviewboard.kde.org/r/127514/diff/


Testing
---

Manual testing in Parley.


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-03-28 Thread Pino Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126610/#review94071
---



ping

- Pino Toscano


On Mar. 28, 2016, 1:39 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126610/
> ---
> 
> (Updated Mar. 28, 2016, 1:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> ---
> 
> When indexes are removed and their widgets deleted, the event filter on each 
> widget is not removed, leading to the "you should not delete widgets 
> manually"-alike warning.
> 
> Add an helper forgetAbout() function which performs all the actions done 
> per-widget before deleting each, additionally removing also the event filter.
> 
> 
> Diffs
> -
> 
>   src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 
>   src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 
>   src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126610/diff/
> 
> 
> Testing
> ---
> 
> A sample application with widgets for items in the model, removing indexes: 
> no more warning at removal time.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: oxygen icon name clasheroo

2016-03-28 Thread Jonathan Riddell 
I'm coming across more of these clashes.  Just had one in Calligra.
So yes I think it's a good idea to move the frameworks Oxygen icons to
a new path.

Jonathan


On 21 March 2016 at 08:30, Harald Sitter  wrote:
> On Sun, Mar 20, 2016 at 10:08 AM, David Faure  wrote:
>> On Wednesday 16 March 2016 15:57:45 Harald Sitter wrote:
>>> Hola!
>>>
>>> Our most awesome icon maintainers wanted to carry over icon symlinking
>>> from breeze to oxygen, alas that turned up a whole slew of
>>> compatibility problems.
>>>
>>> examples:
>>> https://bugs.kde.org/show_bug.cgi?id=360605
>>> https://bugs.kde.org/show_bug.cgi?id=360510
>>>
>>> # Problem
>>> In kde4 software people used oxygen as the standard icon set and
>>> installed their own icons there. Since breeze covers all icons ever,
>>> replicating its coverage into oxygen means we have a million conflicts
>>> with (older?) tarballs of existing software that also install icons
>>> into oxygen under the same name.
>>>
>>> # Proposal
>>> We could get rid of this and all future conflicts if we shift the
>>> default oxygen icons into a subdirectory.
>>>
>>> So, we install the default icons to
>>>
>>> $prefix/share/icons/oxygen/base/22x22
>>> $prefix/share/icons/oxygen/base/32x32
>>> $prefix/share/icons/oxygen/base/...
>>>
>>> applications can thus continue to install to
>>>
>>> $prefix/share/icons/oxygen/22x22
>>> $prefix/share/icons/oxygen/32x32
>>> $prefix/share/icons/oxygen/...
>>>
>>> without conflicting with our base files what so ever.
>>>
>>> Downside of this is that the index.theme basically needs to list
>>> everything twice (once for base and once for main directory), which
>>> unfortunately incurs a bit of a runtime overhead. This is a bit of a
>>> crap situation we are in and I can't think of another solution to
>>> this.
>>
>> This doesn't sound like it matches the freedesktop.org icon theme spec.
>
> How so?
> https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
>
> Directories
> list of subdirectories for this theme. For every subdirectory there
> must be a section in the index.theme file describing that directory.
>
> e.g. Directories=base/32x32/actions,32x32/actions
>
> and then Table 2. Per-Directory Keys
>
> [base/32x32/actions]
> Size=32
> Context=Actions
>
> [32x32/actions]
> Size=32
> Context=Actions
>
>> But if you rename oxygen/base/ to oxygen, and oxygen/ to hicolor, then it 
>> does, AFAIK
>
> We can't really change oxygen/ at all, that's kind of the problem.
> Since existing apps install stuff into oxygen/ and expect it to be
> used by default in a kdelibs4 context. What we could do is make
> oxygen-base a standalone theme and link "oxygen" with "oxygen-base"
> through inheritance.
> That's not quite as good though because we want to override
> application icons through the actual theme. So what we would need is
> "oxygen-base" to be the selected theme and then inherit "oxygen"
> (where apps install icons) to be the fallback. Since the uid of a
> theme is its folder name and we can't feasibly change that without
> breaking something that's not really useful either.
>
> That said, we could go down the two theme route and simply accept that
> applications that install to "oxygen" will be overriding consistent
> theme icons from "oxygen-base". I'd rather deal with the directories
> approach outlined above.
>
> HS
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-28 Thread R.Harish Navnit 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125570/
---

(Updated March 28, 2016, 4:14 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDEPIM, Aleix Pol Gonzalez, and Laurent 
Montel.


Changes
---

Submitted with commit 5a9193879ea5a779f2e8887c65c666d2f2721d3b by R. Harish 
Navnit to branch master.


Repository: kde-dev-scripts


Description
---

A lot of KABC classes are deprecated in KF5. The porting script only replaces 
kabc occurences to kcontacts, but overlooks if the class being used still 
exists in kcontact or not. This leads to a lot of compile time #include<> 
errors. I feel this should and can be avoided by modifying the script. Was this 
overlooked on purpose or did we just miss it out ?

I've really no prior knowledge or experience of working with perl and I've 
tried to handle the above mentioned scenario, by manually checking for 
deprecated classnames and replacing them with a blank space or commenting them 
out.


Diffs
-

  kf5/convert-kabc-to-kcontacts.pl 321fdf2c92745a3aece8e66085994458720f9dfd 

Diff: https://git.reviewboard.kde.org/r/125570/diff/


Testing
---

Ran the script on the kopete codebase which uses deprecated classes like 
addressbook, stdaddressbook, resource etc. 
Works fine, but takes a bit of time to execute.


Thanks,

R.Harish  Navnit

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2016-03-28 Thread R.Harish Navnit 


> On March 26, 2016, 3:23 p.m., David Faure wrote:
> > Looks good to me, although this could all be a single perl script instead 
> > of a bash script calling perl so many times ;) But that's unrelated to this 
> > commit.
> > 
> > Also in its current form, it should be a .sh rather than a .pl 
> 
> R.Harish  Navnit wrote:
> Yes, it makes sense for this to be a .sh. 
> I'm behind a firewall, on my university's WiFi and as a result, I can't 
> push(unless I tether via some other source, which is not always possible). 
> Can you push it on my behalf, when you find the time ?
> 
> Thanks.

Okay, I'm pushing this as it is. Other things are not relevant to this commit, 
right ?


- R.Harish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125570/#review94011
---


On March 26, 2016, 12:31 p.m., R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125570/
> ---
> 
> (Updated March 26, 2016, 12:31 p.m.)
> 
> 
> Review request for KDE Frameworks, KDEPIM, Aleix Pol Gonzalez, and Laurent 
> Montel.
> 
> 
> Repository: kde-dev-scripts
> 
> 
> Description
> ---
> 
> A lot of KABC classes are deprecated in KF5. The porting script only replaces 
> kabc occurences to kcontacts, but overlooks if the class being used still 
> exists in kcontact or not. This leads to a lot of compile time #include<> 
> errors. I feel this should and can be avoided by modifying the script. Was 
> this overlooked on purpose or did we just miss it out ?
> 
> I've really no prior knowledge or experience of working with perl and I've 
> tried to handle the above mentioned scenario, by manually checking for 
> deprecated classnames and replacing them with a blank space or commenting 
> them out.
> 
> 
> Diffs
> -
> 
>   kf5/convert-kabc-to-kcontacts.pl 321fdf2c92745a3aece8e66085994458720f9dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/125570/diff/
> 
> 
> Testing
> ---
> 
> Ran the script on the kopete codebase which uses deprecated classes like 
> addressbook, stdaddressbook, resource etc. 
> Works fine, but takes a bit of time to execute.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-28 Thread Sandro Knauß 


> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote:
> > Much better!  I don't think this should handle XDG* variables explicitly, 
> > as they won't be used on other platforms and may cause confusion there.  On 
> > platforms using XDG* variables, Qt handles this for us internally.  I 
> > opened issues accordingly below.  Other then that, looks good to me.

But where does Qt handles these internally? At the moment Qt isn't doing this 
at all. If we don't respect XDG_*_Home it is a unexpected result for XDG 
conform desktops. Do you suggest to #ifdef the XDG handling?


> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote:
> > autotests/kconfigtest.cpp, line 581
> > 
> >
> > We unfortunately can't test XDG* variables due to Qt, but I think we'll 
> > be ok for now.  The rest of the looks fine.

Well the test is green, so this works :D


- Sandro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/#review94057
---


On März 27, 2016, 2:22 nachm., Sandro Knauß wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127462/
> ---
> 
> (Updated März 27, 2016, 2:22 nachm.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Inside desktop files we want to reach also data, cache and config home
> to create files inside these directories.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.h be0a17ea66fbca989a53c68481c4252c9546dd45 
>   autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
>   docs/options.md c7a6c061b700fd7a23b5dd1628cd22a18dec79da 
>   src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 
> 
> Diff: https://git.reviewboard.kde.org/r/127462/diff/
> 
> 
> Testing
> ---
> 
> Adding tests for XDG_*_HOME variables.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel