Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Kåre Särs


> On April 8, 2016, 7:29 a.m., Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.
> 
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
> 
> I can reproduce this problem
> 
> Anthony Fieroni wrote:
> Drag file from Dolphin to Kate. When drag ends (drop or cancel) cursor 
> stays pointer. Plays Kate on bottom right corner, maximize with double click 
> on title => cursor stays pointer. Context menu has a stupid Qt bug, if cursor 
> is over him and hit ESC cursor became caret, but if you cancel context menu 
> and curson is not over him stays pointer. I try to fix it but setCursor not 
> works in that way. https://bugreports.qt.io/browse/QTBUG-4514
> 
> Kåre Särs wrote:
> Sorry I can not reproduce the problems even the more detailed 
> description. This is on Kubuntu 15.10 with neon repos and on Windows.
> 
> What version of Qt and distro are you using and is it Wayland/X11/...?
> 
> David Rosca wrote:
> > 3. Context menu is closed
> 
> This is regression in Qt 5.6 https://bugreports.qt.io/browse/QTBUG-49222
> 
> Anthony Fieroni wrote:
> KaOS here, Qt 5.6, kf 5.21 Drag, maximize happens every time.
> 
> Anthony Fieroni wrote:
> I can't image you can't reproduce since it has many ways to do it.
> https://youtu.be/WYwhVDJKpMo

It seems quite clear to me that it is Qt 5.6 that has a regression in the xcb 
platform plugin. My kubuntu uses Qt 5.5.1 and does not seem to be effected. The 
patch makes it work, but it is not the "proper" fix. I hope Qt 5.6.1 will fix 
it, but if not we might have to make a temporary workaround... I feel a bit 
uncomfortable with adding workarounds that might not be needed in a couple of 
weeks...


- Kåre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On April 8, 2016, 4:36 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated April 8, 2016, 4:36 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 126480: Fix assorted memory leaks and undefined accesses

2016-04-08 Thread Martin Tobias Holmedahl Sandsmark

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126480/#review94440
---


Ship it!




Ship It!

- Martin Tobias Holmedahl Sandsmark


On Feb. 14, 2016, 8:06 p.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126480/
> ---
> 
> (Updated Feb. 14, 2016, 8:06 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Martin Tobias Holmedahl 
> Sandsmark, and Patrick Spendrin.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> This is a compendium of proposed fixes to the outstanding "High Impact" 
> issues Coverity has reported against KHTML, and which I in my unilateral and 
> infinite wisdom have judged are actually valid (more opinions are welcome! It 
> should be possible to register for Coverity access to KDE runs if you ask 
> from your kde.org address).
> 
> Coverity issues issues include CID #s: 257995, 257996, 259759, 257994, 
> 257927, 257928, 1019703, 1019704, 1340892, 1340908
> 
> Fix-specific notes:
> 
> A few fixes for leaked auxiliary structs used to calculate a return value 
> simply used a QScopedPointer, unless a mere "delete foo" was all that was 
> required.
> 
> CID 259759, tiled pixmap cache misusage: QCache can in theory delete an 
> object you insert as soon as you insert it, so we must guard against that 
> possibility. If re-entrancy or concurrent use of the cache were possible then 
> we would also need to guard against objects obtained from the cache being 
> deleted, but I don't think that's possible so I didn't add sanity checking 
> for that.
> 
> CID 257994, leaked font face during CSS parsing: I'm not completely sure this 
> is possible but if it is, malicious web sites could induce possibly-large 
> memory leaks. The leak would occur if a font with an empty/invalid name 
> leaked into this routine (I think it would be even more restrictive than 
> that, the leak would only be possible if no other font family were valid).
> 
> CID 257928, leak (mis-parse?) during CSS background property parsing: In 
> essence we manually parse a list of value pairs, which are read into 
> currValue{,2} and then migrated from currValue{,2} into value{,2} (a single 
> value) and values{,2} (a list) in turn. The end of the procedure assumes that 
> value{,2} are either both single values or both value lists, but the code 
> path might result in a value list for the first with only a single value for 
> the second. That single value for the second part of the pair would then be 
> leaked (since the values2 list is empty at this point).
> 
> CID 1019703, 1019704, DTD Tag IDs: Potentially serious? At some point we 
> added a tag type for "COMMENT" (which I would think the parser would 
> eliminate from the AST, but maybe that is no longer the case?). However we 
> didn't expand out some auxiliary data vectors we use for the tags, which 
> Coverity flagged as a potential invalid memory access.
> 
> 
> Diffs
> -
> 
>   src/css/css_webfont.cpp 6754a30 
>   src/css/cssparser.cpp 112c867 
>   src/ecma/kjs_html.cpp cc3c08a 
>   src/editing/htmlediting_impl.cpp d56c4a8 
>   src/html/dtd.cpp 71cad5c 
>   src/rendering/render_object.cpp 06dba1a 
>   src/xml/dom_docimpl.cpp 4f0be5c 
> 
> Diff: https://git.reviewboard.kde.org/r/126480/diff/
> 
> 
> Testing
> ---
> 
> Everything compiles, clicking around in Konq on various websites and opening 
> local XML files seems to work fine. I can't get CMake to build the autotests 
> however (though there aren't very many anyways).
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Anthony Fieroni


> On Април 8, 2016, 10:29 преди обяд, Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.
> 
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
> 
> I can reproduce this problem
> 
> Anthony Fieroni wrote:
> Drag file from Dolphin to Kate. When drag ends (drop or cancel) cursor 
> stays pointer. Plays Kate on bottom right corner, maximize with double click 
> on title => cursor stays pointer. Context menu has a stupid Qt bug, if cursor 
> is over him and hit ESC cursor became caret, but if you cancel context menu 
> and curson is not over him stays pointer. I try to fix it but setCursor not 
> works in that way. https://bugreports.qt.io/browse/QTBUG-4514
> 
> Kåre Särs wrote:
> Sorry I can not reproduce the problems even the more detailed 
> description. This is on Kubuntu 15.10 with neon repos and on Windows.
> 
> What version of Qt and distro are you using and is it Wayland/X11/...?
> 
> David Rosca wrote:
> > 3. Context menu is closed
> 
> This is regression in Qt 5.6 https://bugreports.qt.io/browse/QTBUG-49222
> 
> Anthony Fieroni wrote:
> KaOS here, Qt 5.6, kf 5.21 Drag, maximize happens every time.

I can't image you can't reproduce since it has many ways to do it.
https://youtu.be/WYwhVDJKpMo


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On Април 8, 2016, 7:36 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated Април 8, 2016, 7:36 преди обяд)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Misbehavior when unloading KStyle

2016-04-08 Thread Aleix Pol
On Fri, Apr 8, 2016 at 3:42 PM, Andreas Hartmetz  wrote:
> On Donnerstag, 7. April 2016 20:33:19 CEST Andreas Hartmetz wrote:
>> On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote:
>> > Hi,
>> > I've seen a couple of times such backtrace [1] which shows Qt
>> > waiting
>> > for something that never happens. An easy way to reproduce is to
>> > load
>> > konversation (or any application with KDBusService::Unique), hide it
>> > and run it again. The exit call will never be fulfilled in the
>> > second
>> > process.
>> >
>> > Any idea of what could be the cause of this? Or why it's happening?
>> >
>> > Regards,
>> > Aleix
>> >
>> > [1] https://paste.kde.org/pstps66fj
>> > [2] (gdb) thread 2
>> > [Switching to thread 2 (Thread 0x7fffe180f700 (LWP 1))]
>> > #0  0x708a3c3d in poll () from /usr/lib/libc.so.6
>> > (gdb) where
>> > #0  0x708a3c3d in poll () from /usr/lib/libc.so.6
>> > #1  0x7fffedb4fae2 in ?? () from /usr/lib/libxcb.so.1
>> > #2  0x7fffedb51757 in xcb_wait_for_event () from
>> > /usr/lib/libxcb.so.1 #3  0x7fffe513b269 in QXcbEventReader::run
>> > (this=0xe54730) at
>> > /home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforms/xcb/qxc
>> > b
>> > connection.cpp:1321 #4  0x714ae2f9 in QThreadPrivate::start
>> > (arg=0xe54730) at
>> > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/thread/qthread_un
>> > i
>> > x.cpp:340 #5  0x7fffee827424 in start_thread () from
>> > /usr/lib/libpthread.so.0 #6  0x708accbd in clone () from
>> > /usr/lib/libc.so.6
>> > ___
>> > Kde-frameworks-devel mailing list
>> > Kde-frameworks-devel@kde.org
>> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>>
>> I've seen this happening as well. It looks it's triggered by a certain
>> destruction order of global statics (as in Q_GLOBAL_STATIC) and
>> involves a QObject::destroyed() (not sure about that one) signal sent
>> to the (new in 5.6) DBus thread (aka QDBusConnectionManager) which is
>> moveToThread(Q_NULLPTR)-ed into some kind of limbo state when shutting
>> down because its global static container is destroyed, where it stops
>> event processing. The connection is a BlockingQueuedConnection, so it
>> hangs indefinitely.
>> If you have your environment set up in a way that Qt applications use
>> a KStyle, you only need a main function consisting of
>>
>> QApplication(argc, argv);
>> exit(EXIT_SUCCESS /* doesn't matter */);
>>
>> to trigger it.
>> Note: you should not exit() with a QApplication around, it's asking
>> for problems anyway. kactivitmanagerd does it extensively and hangs
>> very reliably currently... I have a request to change this on
>> Phabricator. Note 2: you should NEVER try to handle signals by
>> calling
>> QApplication::quit() to exit cleanly. That is very much not something
>> that's safe to do in a signal context. I have seen this in two
>> different KDE daemons so far.
>>
>> I've talked to Thiago about the apparent Qt bug. He said he'd get to
>> it next week and so I haven't filed a bug yet. I'm still planning to
>> do that.
>>
>
> https://bugreports.qt.io/browse/QTBUG-52473
>
> Good place to add any additional useful information :)

The bug report Martin pointed out leads here:
https://bugreports.qt.io/browse/QTBUG-51648

Is it the same?

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Misbehavior when unloading KStyle

2016-04-08 Thread Andreas Hartmetz
On Donnerstag, 7. April 2016 20:33:19 CEST Andreas Hartmetz wrote:
> On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote:
> > Hi,
> > I've seen a couple of times such backtrace [1] which shows Qt
> > waiting
> > for something that never happens. An easy way to reproduce is to
> > load
> > konversation (or any application with KDBusService::Unique), hide it
> > and run it again. The exit call will never be fulfilled in the
> > second
> > process.
> > 
> > Any idea of what could be the cause of this? Or why it's happening?
> > 
> > Regards,
> > Aleix
> > 
> > [1] https://paste.kde.org/pstps66fj
> > [2] (gdb) thread 2
> > [Switching to thread 2 (Thread 0x7fffe180f700 (LWP 1))]
> > #0  0x708a3c3d in poll () from /usr/lib/libc.so.6
> > (gdb) where
> > #0  0x708a3c3d in poll () from /usr/lib/libc.so.6
> > #1  0x7fffedb4fae2 in ?? () from /usr/lib/libxcb.so.1
> > #2  0x7fffedb51757 in xcb_wait_for_event () from
> > /usr/lib/libxcb.so.1 #3  0x7fffe513b269 in QXcbEventReader::run
> > (this=0xe54730) at
> > /home/apol/devel/frameworks/qt5/qtbase/src/plugins/platforms/xcb/qxc
> > b
> > connection.cpp:1321 #4  0x714ae2f9 in QThreadPrivate::start
> > (arg=0xe54730) at
> > /home/apol/devel/frameworks/qt5/qtbase/src/corelib/thread/qthread_un
> > i
> > x.cpp:340 #5  0x7fffee827424 in start_thread () from
> > /usr/lib/libpthread.so.0 #6  0x708accbd in clone () from
> > /usr/lib/libc.so.6
> > ___
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
> I've seen this happening as well. It looks it's triggered by a certain
> destruction order of global statics (as in Q_GLOBAL_STATIC) and
> involves a QObject::destroyed() (not sure about that one) signal sent
> to the (new in 5.6) DBus thread (aka QDBusConnectionManager) which is
> moveToThread(Q_NULLPTR)-ed into some kind of limbo state when shutting
> down because its global static container is destroyed, where it stops
> event processing. The connection is a BlockingQueuedConnection, so it
> hangs indefinitely.
> If you have your environment set up in a way that Qt applications use
> a KStyle, you only need a main function consisting of
> 
> QApplication(argc, argv);
> exit(EXIT_SUCCESS /* doesn't matter */);
> 
> to trigger it.
> Note: you should not exit() with a QApplication around, it's asking
> for problems anyway. kactivitmanagerd does it extensively and hangs
> very reliably currently... I have a request to change this on
> Phabricator. Note 2: you should NEVER try to handle signals by
> calling
> QApplication::quit() to exit cleanly. That is very much not something
> that's safe to do in a signal context. I have seen this in two
> different KDE daemons so far.
> 
> I've talked to Thiago about the apparent Qt bug. He said he'd get to
> it next week and so I haven't filed a bug yet. I'm still planning to
> do that.
> 

https://bugreports.qt.io/browse/QTBUG-52473

Good place to add any additional useful information :)
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kmediaplayer master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 10:13:28 +
Build duration: 1 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/236 
(78%)CONDITIONAL 78/144 (54%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/127 (89%)CONDITIONAL 
59/118 (50%)
src
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 
19/26 (73%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kmediaplayer master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kmediaplayer%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 10:13:28 +
Build duration: 1 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/236 
(78%)CONDITIONAL 78/144 (54%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/127 (89%)CONDITIONAL 
59/118 (50%)
src
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 
19/26 (73%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 09:55:40 +
Build duration: 5 min 14 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 09:55:40 +
Build duration: 5 min 14 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 17 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 09:38:50 +
Build duration: 13 min

CHANGE SET
Revision 2a52682e83cc704ff70be032425cfc8681a56120 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/ioslaves/trash/trash.json


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26545/50379 
(53%)CONDITIONAL 14695/22801 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7394/7710 
(96%)CONDITIONAL 4065/7462 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7627/13951 
(55%)CONDITIONAL 4090/5662 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/463 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/1872 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/529 (71%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/194 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10595 
(25%)CONDITIONAL 1306/1910 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 09:38:50 +
Build duration: 13 min

CHANGE SET
Revision 2a52682e83cc704ff70be032425cfc8681a56120 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/ioslaves/trash/trash.json


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kdirlistertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26517/50379 
(53%)CONDITIONAL 14658/22739 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7361/7710 
(95%)CONDITIONAL 4033/7410 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7635/13951 
(55%)CONDITIONAL 4090/5662 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/463 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/1858 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/529 (71%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/194 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10595 
(25%)CONDITIONAL 1306/1910 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 17 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 08 Apr 2016 09:38:50 +
Build duration: 13 min

CHANGE SET
Revision 2a52682e83cc704ff70be032425cfc8681a56120 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/ioslaves/trash/trash.json


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26545/50379 
(53%)CONDITIONAL 14695/22801 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7394/7710 
(96%)CONDITIONAL 4065/7462 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7627/13951 
(55%)CONDITIONAL 4090/5662 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/463 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/1872 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/529 (71%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/194 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10595 
(25%)CONDITIONAL 1306/1910 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Anthony Fieroni


> On Април 8, 2016, 10:29 преди обяд, Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.
> 
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
> 
> I can reproduce this problem
> 
> Anthony Fieroni wrote:
> Drag file from Dolphin to Kate. When drag ends (drop or cancel) cursor 
> stays pointer. Plays Kate on bottom right corner, maximize with double click 
> on title => cursor stays pointer. Context menu has a stupid Qt bug, if cursor 
> is over him and hit ESC cursor became caret, but if you cancel context menu 
> and curson is not over him stays pointer. I try to fix it but setCursor not 
> works in that way. https://bugreports.qt.io/browse/QTBUG-4514
> 
> Kåre Särs wrote:
> Sorry I can not reproduce the problems even the more detailed 
> description. This is on Kubuntu 15.10 with neon repos and on Windows.
> 
> What version of Qt and distro are you using and is it Wayland/X11/...?
> 
> David Rosca wrote:
> > 3. Context menu is closed
> 
> This is regression in Qt 5.6 https://bugreports.qt.io/browse/QTBUG-49222

KaOS here, Qt 5.6, kf 5.21 Drag, maximize happens every time.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On Април 8, 2016, 7:36 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated Април 8, 2016, 7:36 преди обяд)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread David Rosca


> On April 8, 2016, 7:29 a.m., Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.
> 
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
> 
> I can reproduce this problem
> 
> Anthony Fieroni wrote:
> Drag file from Dolphin to Kate. When drag ends (drop or cancel) cursor 
> stays pointer. Plays Kate on bottom right corner, maximize with double click 
> on title => cursor stays pointer. Context menu has a stupid Qt bug, if cursor 
> is over him and hit ESC cursor became caret, but if you cancel context menu 
> and curson is not over him stays pointer. I try to fix it but setCursor not 
> works in that way. https://bugreports.qt.io/browse/QTBUG-4514
> 
> Kåre Särs wrote:
> Sorry I can not reproduce the problems even the more detailed 
> description. This is on Kubuntu 15.10 with neon repos and on Windows.
> 
> What version of Qt and distro are you using and is it Wayland/X11/...?

> 3. Context menu is closed

This is regression in Qt 5.6 https://bugreports.qt.io/browse/QTBUG-49222


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On April 8, 2016, 4:36 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated April 8, 2016, 4:36 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Kåre Särs


> On April 8, 2016, 7:29 a.m., Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.
> 
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
> 
> I can reproduce this problem
> 
> Anthony Fieroni wrote:
> Drag file from Dolphin to Kate. When drag ends (drop or cancel) cursor 
> stays pointer. Plays Kate on bottom right corner, maximize with double click 
> on title => cursor stays pointer. Context menu has a stupid Qt bug, if cursor 
> is over him and hit ESC cursor became caret, but if you cancel context menu 
> and curson is not over him stays pointer. I try to fix it but setCursor not 
> works in that way. https://bugreports.qt.io/browse/QTBUG-4514

Sorry I can not reproduce the problems even the more detailed description. This 
is on Kubuntu 15.10 with neon repos and on Windows.

What version of Qt and distro are you using and is it Wayland/X11/...?


- Kåre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On April 8, 2016, 4:36 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated April 8, 2016, 4:36 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Anthony Fieroni


> On Април 8, 2016, 10:29 преди обяд, Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.
> 
> Emmanuel Pescosta wrote:
> > 3. Context menu is closed
> 
> I can reproduce this problem

Drag file from Dolphin to Kate. When drag ends (drop or cancel) cursor stays 
pointer. Plays Kate on bottom right corner, maximize with double click on title 
=> cursor stays pointer. Context menu has a stupid Qt bug, if cursor is over 
him and hit ESC cursor became caret, but if you cancel context menu and curson 
is not over him stays pointer. I try to fix it but setCursor not works in that 
way. https://bugreports.qt.io/browse/QTBUG-4514


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On Април 8, 2016, 7:36 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated Април 8, 2016, 7:36 преди обяд)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Emmanuel Pescosta


> On April 8, 2016, 9:29 a.m., Kåre Särs wrote:
> > What is it that needs fixing?
> > 
> > I don't have a problem in either case listed.

> 3. Context menu is closed

I can reproduce this problem


- Emmanuel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---


On April 8, 2016, 6:36 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated April 8, 2016, 6:36 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread Kåre Särs

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127587/#review94421
---



What is it that needs fixing?

I don't have a problem in either case listed.

- Kåre Särs


On April 8, 2016, 4:36 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127587/
> ---
> 
> (Updated April 8, 2016, 4:36 a.m.)
> 
> 
> Review request for Kate, KDE Frameworks, Dominik Haumann, and Kåre Särs.
> 
> 
> Bugs: 361075
> https://bugs.kde.org/show_bug.cgi?id=361075
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Currsor must be override after these conditions:
> 1. Drag move ends
> 2. Minimize / restore / maximize
> 3. Context menu is closed
> 
> 
> Diffs
> -
> 
>   src/view/kateviewinternal.cpp ca5acfc 
> 
> Diff: https://git.reviewboard.kde.org/r/127587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-08 Thread Heiko Becker

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127597/#review94420
---


Ship it!




Ship It!

- Heiko Becker


On April 8, 2016, 6:28 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127597/
> ---
> 
> (Updated April 8, 2016, 6:28 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The path was wrong which is the reason why X11 windows don't have
> icons in kwin_wayland.
> 
> 
> Diffs
> -
> 
>   src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164 
> 
> Diff: https://git.reviewboard.kde.org/r/127597/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 11 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/11/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 08 Apr 2016 06:37:47 +
Build duration: 2 min 3 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 40/46 (87%)CLASSES 40/46 (87%)LINE 6608/8859 
(75%)CONDITIONAL 3651/5670 (64%)

By packages
  
autotests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 2814/2875 
(98%)CONDITIONAL 1508/2841 (53%)
src
FILES 13/15 (87%)CLASSES 13/15 (87%)LINE 748/1400 
(53%)CONDITIONAL 307/462 (66%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/0 
(100%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3046/4495 
(68%)CONDITIONAL 1836/2367 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 11 - Fixed!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/11/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 08 Apr 2016 06:37:47 +
Build duration: 2 min 3 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 40/46 (87%)CLASSES 40/46 (87%)LINE 6608/8859 
(75%)CONDITIONAL 3651/5670 (64%)

By packages
  
autotests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 2814/2875 
(98%)CONDITIONAL 1508/2841 (53%)
src
FILES 13/15 (87%)CLASSES 13/15 (87%)LINE 748/1400 
(53%)CONDITIONAL 307/462 (66%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/0 
(100%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3046/4495 
(68%)CONDITIONAL 1836/2367 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 10 - Failure!

2016-04-08 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/10/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 08 Apr 2016 06:29:55 +
Build duration: 2 min 18 sec

CHANGE SET
Revision cdbb3857bd31d68efb09b76795b966985cb26e22 by Martin Gräßlin: (Add a 
test case for KWindowEffects::isEffectAvailable)
  change: edit autotests/kwindoweffectstest.cpp
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127602: Add a test case for KWindowEffects::isEffectAvailable

2016-04-08 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127602/
---

(Updated April 8, 2016, 6:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit cdbb3857bd31d68efb09b76795b966985cb26e22 by Martin 
Gräßlin to branch master.


Repository: kwindowsystem


Description
---

Just verifies that reading the property on the root window works as
expected.


Diffs
-

  autotests/kwindoweffectstest.cpp 06a52a1e6e3d0fb4c967ff9c5295bb3a0381ee51 

Diff: https://git.reviewboard.kde.org/r/127602/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127597: Fix generation of path to xcb plugin

2016-04-08 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127597/
---

(Updated April 8, 2016, 8:28 a.m.)


Review request for KDE Frameworks.


Changes
---

Use KDE_INSTALL_FULL_PLUGINDIR


Repository: kwindowsystem


Description
---

The path was wrong which is the reason why X11 windows don't have
icons in kwin_wayland.


Diffs (updated)
-

  src/config-kwindowsystem.h.cmake 9afe81f9757de5e8e2d9387aa5c641955da08164 

Diff: https://git.reviewboard.kde.org/r/127597/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel