Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas 


> On Abril 23, 2016, 11:40 p.m., Michael Pyne wrote:
> > This is a duplicate of RR 127598, which is about to get marked as 'change 
> > then commit' (I missed that it was updated a few days ago when my email was 
> > futzy :( ).

Thanks! I'm discarding this one, then.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/#review94797
---


On Abril 23, 2016, 11:54 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127729/
> ---
> 
> (Updated Abril 23, 2016, 11:54 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Although there is currently no problem on building kcoreaddons, when building 
> okular (and possibly other apps) the compiler gets confused when it reaches 
> std::numeric_limits::max() as  is also included and it 
> defines a 'max' macro.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 3c9ff00 
> 
> Diff: https://git.reviewboard.kde.org/r/127729/diff/
> 
> 
> Testing
> ---
> 
> Okular is buildable on MSVC after this patch. No further testing done.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/
---

(Updated Abril 23, 2016, 11:54 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and kdewin.


Repository: kcoreaddons


Description
---

Although there is currently no problem on building kcoreaddons, when building 
okular (and possibly other apps) the compiler gets confused when it reaches 
std::numeric_limits::max() as  is also included and it defines 
a 'max' macro.


Diffs
-

  src/lib/util/kuser.h 3c9ff00 

Diff: https://git.reviewboard.kde.org/r/127729/diff/


Testing
---

Okular is buildable on MSVC after this patch. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-23 Thread Michael Pyne 
On Sat, April 23, 2016 13:09:00 Ben Cooksley wrote:
> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil  wrote:
> > any chance to get this patch into our Qt build on the CI since it has been
> > integrated upstream now? As it affects all tests that interact with DBus
> > it
> > would be nice to resolve this on the CI.
> 
> We'll need upstream to update qt5.git (I think that's still required
> for changes to fully flow through) I think.
> We could try to hack the patch in, but then we'll end up having to
> undo that in a few weeks time.

If we're talking about Qt commit 1b9d082b, that appears to already be in the 
5.6 branch (though not dev). I'm not sure which the CI uses though, if it's 
not 5.6 or less then it is probably more work than its worth to try to 
downgrade (something I've run into too much myself).

Regards,
 - Michael Pyne
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Michael Pyne 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/#review94797
---



This is a duplicate of RR 127598, which is about to get marked as 'change then 
commit' (I missed that it was updated a few days ago when my email was futzy :( 
).

- Michael Pyne


On April 23, 2016, 5:46 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127729/
> ---
> 
> (Updated April 23, 2016, 5:46 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Although there is currently no problem on building kcoreaddons, when building 
> okular (and possibly other apps) the compiler gets confused when it reaches 
> std::numeric_limits::max() as  is also included and it 
> defines a 'max' macro.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 3c9ff00 
> 
> Diff: https://git.reviewboard.kde.org/r/127729/diff/
> 
> 
> Testing
> ---
> 
> Okular is buildable on MSVC after this patch. No further testing done.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-23 Thread Andrius da Costa Ribas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

(Updated April 23, 2016, 8:21 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Changes
---

Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by Andrius da 
Costa Ribas to branch master.


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


File Attachments


Native Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
Icoutils Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: sonnet master kf5-qt5 » Linux,gcc - Build # 14 - Fixed!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/sonnet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 12:32:52 +
Build duration: 1 min 25 sec

CHANGE SET
Revision a14d5eb52c0e3ff81244aada88252703894fc3e3 by martin.sandsmark: 
(configwidget: fix saving when ignore words updated)
  change: edit src/ui/configwidget.cpp
Revision e7612911aa7b4a21bcb5507308e6a18d1bb18b6a by martin.sandsmark: 
(settings: dont immediately save the config when updating ignore list)
  change: edit src/core/settings.cpp
Revision a0a2a0ee9d717f6c5606007748f3ad74f580eea3 by martin.sandsmark: 
(configwidget: notify about changed config when ignored words updated)
  change: edit src/ui/configwidget.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 23/26 (88%)CLASSES 23/26 (88%)LINE 849/1444 
(59%)CONDITIONAL 298/823 (36%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 335/338 (99%)CONDITIONAL 
101/180 (56%)
data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 
12/14 (86%)
src.core
FILES 11/14 (79%)CLASSES 11/14 (79%)LINE 436/1003 
(43%)CONDITIONAL 158/571 (28%)
src.plugins.hunspell
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 55/80 (69%)CONDITIONAL 
27/58 (47%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: sonnet master kf5-qt5 » Linux,gcc - Build # 14 - Fixed!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/sonnet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 12:32:52 +
Build duration: 1 min 25 sec

CHANGE SET
Revision a14d5eb52c0e3ff81244aada88252703894fc3e3 by martin.sandsmark: 
(configwidget: fix saving when ignore words updated)
  change: edit src/ui/configwidget.cpp
Revision e7612911aa7b4a21bcb5507308e6a18d1bb18b6a by martin.sandsmark: 
(settings: dont immediately save the config when updating ignore list)
  change: edit src/core/settings.cpp
Revision a0a2a0ee9d717f6c5606007748f3ad74f580eea3 by martin.sandsmark: 
(configwidget: notify about changed config when ignored words updated)
  change: edit src/ui/configwidget.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 23/26 (88%)CLASSES 23/26 (88%)LINE 849/1444 
(59%)CONDITIONAL 298/823 (36%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 335/338 (99%)CONDITIONAL 
101/180 (56%)
data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 
12/14 (86%)
src.core
FILES 11/14 (79%)CLASSES 11/14 (79%)LINE 436/1003 
(43%)CONDITIONAL 158/571 (28%)
src.plugins.hunspell
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 55/80 (69%)CONDITIONAL 
27/58 (47%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 13 - Fixed!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 12:32:52 +
Build duration: 1 min 31 sec

CHANGE SET
Revision a14d5eb52c0e3ff81244aada88252703894fc3e3 by martin.sandsmark: 
(configwidget: fix saving when ignore words updated)
  change: edit src/ui/configwidget.cpp
Revision e7612911aa7b4a21bcb5507308e6a18d1bb18b6a by martin.sandsmark: 
(settings: dont immediately save the config when updating ignore list)
  change: edit src/core/settings.cpp
Revision a0a2a0ee9d717f6c5606007748f3ad74f580eea3 by martin.sandsmark: 
(configwidget: notify about changed config when ignored words updated)
  change: edit src/ui/configwidget.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 23/26 (88%)CLASSES 23/26 (88%)LINE 849/1444 
(59%)CONDITIONAL 298/823 (36%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 335/338 (99%)CONDITIONAL 
101/180 (56%)
data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 
12/14 (86%)
src.core
FILES 11/14 (79%)CLASSES 11/14 (79%)LINE 436/1003 
(43%)CONDITIONAL 158/571 (28%)
src.plugins.hunspell
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 55/80 (69%)CONDITIONAL 
27/58 (47%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: sonnet master stable-kf5-qt5 » Linux,gcc - Build # 13 - Fixed!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/sonnet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 12:32:52 +
Build duration: 1 min 31 sec

CHANGE SET
Revision a14d5eb52c0e3ff81244aada88252703894fc3e3 by martin.sandsmark: 
(configwidget: fix saving when ignore words updated)
  change: edit src/ui/configwidget.cpp
Revision e7612911aa7b4a21bcb5507308e6a18d1bb18b6a by martin.sandsmark: 
(settings: dont immediately save the config when updating ignore list)
  change: edit src/core/settings.cpp
Revision a0a2a0ee9d717f6c5606007748f3ad74f580eea3 by martin.sandsmark: 
(configwidget: notify about changed config when ignored words updated)
  change: edit src/ui/configwidget.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 23/26 (88%)CLASSES 23/26 (88%)LINE 849/1444 
(59%)CONDITIONAL 298/823 (36%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 335/338 (99%)CONDITIONAL 
101/180 (56%)
data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 
12/14 (86%)
src.core
FILES 11/14 (79%)CLASSES 11/14 (79%)LINE 436/1003 
(43%)CONDITIONAL 158/571 (28%)
src.plugins.hunspell
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 55/80 (69%)CONDITIONAL 
27/58 (47%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127699: Set the xscreensaver plugin as valid only if the dbus interface org.freedesktop.ScreenSaver is present

2016-04-23 Thread Paulo Lieuthier 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127699/#review94780
---



Plasma itself will probably not benefit from this, because it will always have 
a screen locker (so org.freedesktop.ScreenSaver will always be present), but 
other environments, like LXQt, which currently has no screen locker, need this 
fix.

- Paulo Lieuthier


On April 20, 2016, 1:54 p.m., Paulo Lieuthier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127699/
> ---
> 
> (Updated April 20, 2016, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> If the dbus interface org.freedesktop.ScreenSaver is not present, it makes no 
> sense to use the plugin.
> 
> 
> Diffs
> -
> 
>   src/plugins/xscreensaver/xscreensaverbasedpoller.h 05b9a23 
>   src/plugins/xscreensaver/xscreensaverbasedpoller.cpp f56396c 
>   src/widgetbasedpoller.h 68fc7dc 
> 
> Diff: https://git.reviewboard.kde.org/r/127699/diff/
> 
> 
> Testing
> ---
> 
> Tested minimal application using KIdleTime using the xscreensaver plugin.
> 
> 
> Thanks,
> 
> Paulo Lieuthier
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdewebkit master kf5-qt5 » Linux,gcc - Build # 38 - Failure!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 09:58:07 +
Build duration: 15 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 39 - Still Unstable!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 09:52:31 +
Build duration: 1 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.frameworkintegration-kfiledialogqml_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1140/1717 
(66%)CONDITIONAL 451/1085 (42%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 387/395 (98%)CONDITIONAL 
199/375 (53%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)
src.platformtheme
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 706/1144 
(62%)CONDITIONAL 223/548 (41%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 34 - Still Unstable!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 09:47:21 +
Build duration: 5 min 32 sec

CHANGE SET
Revision 6661596a26056e30bd5286ece2e9d5f914d8276b by David Faure: (fix clang 
warning (I hate C casts))
  change: edit src/core/kcoredirlister.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26652/50545 
(53%)CONDITIONAL 14806/37245 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7463/7776 
(96%)CONDITIONAL 4113/8020 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7667/14047 
(55%)CONDITIONAL 4148/8917 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/4395 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 37 - Still Unstable!

2016-04-23 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 23 Apr 2016 09:47:21 +
Build duration: 4 min 48 sec

CHANGE SET
Revision 6661596a26056e30bd5286ece2e9d5f914d8276b by David Faure: (fix clang 
warning (I hate C casts))
  change: edit src/core/kcoredirlister.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26379/50564 
(52%)CONDITIONAL 14470/37269 (39%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7220/7795 
(93%)CONDITIONAL 3792/8044 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7680/14047 
(55%)CONDITIONAL 4155/8917 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2213/7554 
(29%)CONDITIONAL 886/4395 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-23 Thread Ben Cooksley 
On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin  wrote:
> On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote:
>> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil  wrote:
>> > On Saturday, April 23, 2016 1:44:16 AM CEST Ben Cooksley wrote:
>> >> On Fri, Apr 22, 2016 at 11:11 PM, David Faure  wrote:
>> >> > On Thursday 21 April 2016 14:57:52 no-re...@kde.org wrote:
>> >> >> GENERAL INFO
>> >> >>
>> >> >> BUILD UNSTABLE
>> >> >> Build URL:
>> >> >> https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linu
>> >> >> x,
>> >> >> compiler=gcc/11/>
>> >> >
>> >> > Wow, ASAN detected a real bug in Qt here.
>> >> >
>> >> > Fixed in https://codereview.qt-project.org/156728
>> >>
>> >> As this issue essentially breaks any test on the CI system that
>> >> depends on Qt I suggest all developers affected by this indicate this
>> >> on the relevant reviews.
>> >
>> > Hey guys,
>>
>> Hi David,
>>
>> > any chance to get this patch into our Qt build on the CI since it has been
>> > integrated upstream now? As it affects all tests that interact with DBus
>> > it
>> > would be nice to resolve this on the CI.
>>
>> We'll need upstream to update qt5.git (I think that's still required
>> for changes to fully flow through) I think.
>> We could try to hack the patch in, but then we'll end up having to
>> undo that in a few weeks time.
>
> Could we disable that ASAN check please[1]? I have two of my projects failing
> due to the DBus problem and one further failing due to a similar problem in
> QQuickStyleItem [2]. It's nice that we find errors, but I rather not have my
> tests fail due to errors in Qt.

That would just cover up the issue.
Also, it isn't that simple, as we already export ASAN_OPTIONS with a
different value, and changing that will break quite a lot more.

If QQuickStyleItem is broken as well, then the Qt developers need to
be asked to fix that as well then.

If it is that much of an issue, I suggest we simply do away with ASAN
testing altogether, as if our upstreams aren't going to bother with
it, it makes it pointless for us.

>
> Cheers
> Martin

Regards,
Ben

>
> [1] just export ASAN_OPTIONS=new_delete_type_mismatch=0
> [2] https://build.kde.org/user/graesslin/my-views/view/mgraesslin
> %20maintained/job/plasma-integration%20master%20kf5-qt5/
> PLATFORM=Linux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/
> TestSuite/frameworkintegration_kfiledialogqml_unittest/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

2016-04-23 Thread Martin Graesslin 
On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote:
> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil  wrote:
> > On Saturday, April 23, 2016 1:44:16 AM CEST Ben Cooksley wrote:
> >> On Fri, Apr 22, 2016 at 11:11 PM, David Faure  wrote:
> >> > On Thursday 21 April 2016 14:57:52 no-re...@kde.org wrote:
> >> >> GENERAL INFO
> >> >> 
> >> >> BUILD UNSTABLE
> >> >> Build URL:
> >> >> https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linu
> >> >> x,
> >> >> compiler=gcc/11/>
> >> > 
> >> > Wow, ASAN detected a real bug in Qt here.
> >> > 
> >> > Fixed in https://codereview.qt-project.org/156728
> >> 
> >> As this issue essentially breaks any test on the CI system that
> >> depends on Qt I suggest all developers affected by this indicate this
> >> on the relevant reviews.
> > 
> > Hey guys,
> 
> Hi David,
> 
> > any chance to get this patch into our Qt build on the CI since it has been
> > integrated upstream now? As it affects all tests that interact with DBus
> > it
> > would be nice to resolve this on the CI.
> 
> We'll need upstream to update qt5.git (I think that's still required
> for changes to fully flow through) I think.
> We could try to hack the patch in, but then we'll end up having to
> undo that in a few weeks time.

Could we disable that ASAN check please[1]? I have two of my projects failing 
due to the DBus problem and one further failing due to a similar problem in 
QQuickStyleItem [2]. It's nice that we find errors, but I rather not have my 
tests fail due to errors in Qt.

Cheers
Martin

[1] just export ASAN_OPTIONS=new_delete_type_mismatch=0
[2] https://build.kde.org/user/graesslin/my-views/view/mgraesslin
%20maintained/job/plasma-integration%20master%20kf5-qt5/
PLATFORM=Linux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/
TestSuite/frameworkintegration_kfiledialogqml_unittest/


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel