Improving performance under breeze icons

[Aleix Pol]

Hi,
As assessed lately, one penalty we have when starting an application
is the icons look-up. It's not really Breeze's fault, the intersection
of the standard we're using and how we're using it makes the situation
slightly complex, hence simplifying it would improve the situation
already.

To get some context, the problem is that whenever we request an icon,
what we do is go through all the provided directories hoping we'll
find it.

Now I'm mentioning breeze because on one hand, it's really awesome how
we're using scalable icons directly but on the other hand we could
look into leveraging it better. Here's some ideas, I'd especially like
the icon designers' opinions so we can find the best situation.

* There's some sizes that we can probably trim right away. Are icons
in the 12 and 16 directory substantially different? Or 22 and 24? I've
checked and pruning these would get us about 5% of failed accesses
back.

* Furthermore, I see there's some icons that aren't on every size (for
example, vcs-added is only in 16 but not in 8 or 22). All in all,
feels like it could be specifying broader categories, especially
considering the scalable nature, such as emblems/small, emblems/big.

* Last, slightly unrelated, there's a risk when the icon differs
greatly (e.g. system-help) from a size to another we'll end up with
unpredictable UI's, maybe it would be possible to rename them to
reflect this.

Do you think there's any possibility we could improve there?

Thanks a lot!
Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Re[2]: Review Request 127632: Prioritize correct extension per theme

[Aleix Pol]

On Wed, Apr 27, 2016 at 12:58 AM, Nick Shaforostoff  wrote:
> sorry, I'm a bit late. I think having extensions without dots is preferred 
> from common sense POV:
>
> KDE-Extensions=svg
> KDE-Extensions=svg,png
>
> what do you think?
>
> also, the spec would like additional params to start with X-, e.g.
>
> X-KDE-Extensions=svg
> X-KDE-Extensions=svg,png

Works for me.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: ECM metainfo path

[Stephen Kelly]

Harald Sitter wrote:
> I am actually not sure how we handle this for ECM.  CCing Stephen
> Kelly who I think is semi-maintaining ECM right now.

Hi,

Thanks for the heads-up.

I'm afraid I'm way out of the loop. I don't know what appstream or /metainfo 
are. However, let's see if I can contribute.

> The way I see it this could be done by adding a new variable that uses
> /metainfo (which probably will look awkward given the current variable
> is what we should be using for /metainfo ;)) and make usage of the old
> variable raise a bazillion warnings, expecting the individual devs to
> transition their apps.

From a few minutes reading about appstream and /metainfo, it seems that 
distros expect certain things to be in /metainfo. Are they still going to 
look for things in /appdata? If not, then we need to try to ensure that we 
install things in /metadata, right? And using the (already aptly named) 
variable for that seems sensible.

Also, I'm not in favor of adding more variables which are hard to remove 
later, especially if they are hard to remove, or as you propose below, are 
designed to have a 'short' life in use. I already don't understand the 
KDEInstallDirs.cmake file, and it's not consistent in some ways which I find 
makes the whole thing hard to maintain and understand (eg see

 http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/9130/focus=9183

)

> Since that is slightly meh, considering the "wholesale" platform
> decision this is, I'd suggest the following:
> - _METAINFO points to /metainfo
> - add a compile-time switch to ECM which forces _METAINFO back to
> /appdata (i.e. opt-in backwards compat on a platform level)

There is an existing variable for this, right? 

KDE_INSTALL_METAINFODIR.

A user needing that to be /appdata can just set it to be that, right? No new 
variable needed?

Otherwise I'm missing something here.

> - make sure this change is visibly noted in release changelog

If I'm right about the above, a note in the changelog for people affected 
sounds like a fine idea.

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re[2]: Review Request 127632: Prioritize correct extension per theme

[Nick Shaforostoff]

sorry, I'm a bit late. I think having extensions without dots is preferred from 
common sense POV:

KDE-Extensions=svg
KDE-Extensions=svg,png

what do you think?

also, the spec would like additional params to start with X-, e.g.

X-KDE-Extensions=svg
X-KDE-Extensions=svg,png
 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
---

(Updated April 27, 2016, 12:36 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.


Changes
---

Submitted with commit 536d707981ada478b583f91f31a9dca741881a36 by Aleix Pol to 
branch master.


Repository: kiconthemes


Description
---

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to 
bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs
-

  src/kiconengine.h 5b9badb 
  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
---

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
almost as good as the RR #127236, but with a much smaller memory impact, since 
we're not caching all the icon names (which was specially bad as it was 
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94881
---


Ship it!




Ship It!

- Albert Astals Cid


On April 26, 2016, 8:51 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> ---
> 
> (Updated April 26, 2016, 8:51 p.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense 
> to bindly use an extensions vector that is statically defined.
> 
> Prioritizes the extensions that work, so it will find the icons sooner.
> 
> 
> Diffs
> -
> 
>   src/kiconengine.h 5b9badb 
>   src/kiconloader.cpp 37528ad 
>   src/kicontheme.h 3190665 
>   src/kicontheme.cpp e7e003b 
> 
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
> almost as good as the RR #127236, but with a much smaller memory impact, 
> since we're not caching all the icon names (which was specially bad as it was 
> per-process).
> ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
---

(Updated April 26, 2016, 10:51 p.m.)


Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.


Changes
---

Address Albert issues.


Repository: kiconthemes


Description
---

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to 
bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs (updated)
-

  src/kiconengine.h 5b9badb 
  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
---

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
almost as good as the RR #127236, but with a much smaller memory impact, since 
we're not caching all the icon names (which was specially bad as it was 
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Aleix Pol Gonzalez]

> On April 26, 2016, 10:02 p.m., Andreas Kainz wrote:
> > Sorry someone add my but I can't follow the discussion. I don't know what 
> > this is doing. sorry.

I wanted to make you aware of this change:
`Needs patching in Breeze & Oxygen: https://paste.kde.org/py5kqvppv`


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94875
---


On April 26, 2016, 10:51 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> ---
> 
> (Updated April 26, 2016, 10:51 p.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense 
> to bindly use an extensions vector that is statically defined.
> 
> Prioritizes the extensions that work, so it will find the icons sooner.
> 
> 
> Diffs
> -
> 
>   src/kiconengine.h 5b9badb 
>   src/kiconloader.cpp 37528ad 
>   src/kicontheme.h 3190665 
>   src/kicontheme.cpp e7e003b 
> 
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
> almost as good as the RR #127236, but with a much smaller memory impact, 
> since we're not caching all the icon names (which was specially bad as it was 
> per-process).
> ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94875
---



Sorry someone add my but I can't follow the discussion. I don't know what this 
is doing. sorry.

- Andreas Kainz


On April 26, 2016, 7:12 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> ---
> 
> (Updated April 26, 2016, 7:12 nachm.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense 
> to bindly use an extensions vector that is statically defined.
> 
> Prioritizes the extensions that work, so it will find the icons sooner.
> 
> 
> Diffs
> -
> 
>   src/kiconengine.h 5b9badb 
>   src/kiconloader.cpp 37528ad 
>   src/kicontheme.h 3190665 
>   src/kicontheme.cpp e7e003b 
> 
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
> almost as good as the RR #127236, but with a much smaller memory impact, 
> since we're not caching all the icon names (which was specially bad as it was 
> per-process).
> ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/#review94873
---




src/kicontheme.h (line 173)


@since missing



src/kicontheme.cpp (line 407)


constBegin + constEnd + const_iterator (or auto?)


- Albert Astals Cid


On April 26, 2016, 7:12 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127632/
> ---
> 
> (Updated April 26, 2016, 7:12 p.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> Usually themes will have 1 kind of extension (2 tops) it doesn't make sense 
> to bindly use an extensions vector that is statically defined.
> 
> Prioritizes the extensions that work, so it will find the icons sooner.
> 
> 
> Diffs
> -
> 
>   src/kiconengine.h 5b9badb 
>   src/kiconloader.cpp 37528ad 
>   src/kicontheme.h 3190665 
>   src/kicontheme.cpp e7e003b 
> 
> Diff: https://git.reviewboard.kde.org/r/127632/diff/
> 
> 
> Testing
> ---
> 
> Builds and tests still pass.
> Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
> almost as good as the RR #127236, but with a much smaller memory impact, 
> since we're not caching all the icon names (which was specially bad as it was 
> per-process).
> ```
> $ strace kwrite |& grep ENOENT | wc -l
> 4699
> $ strace kwrite |& grep ENOENT | wc -l
> 2119
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
---

(Updated April 26, 2016, 9:12 p.m.)


Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.


Repository: kiconthemes


Description
---

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to 
bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs (updated)
-

  src/kiconengine.h 5b9badb 
  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
---

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
almost as good as the RR #127236, but with a much smaller memory impact, since 
we're not caching all the icon names (which was specially bad as it was 
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

case in filenames

[René J . V . Bertin]

Hi,

Is there an official guideline concerning the use of case for distinguishing 
between filenames? There are (or have been) a few ports that do this for header 
files (or directories). In that case it's relatively easy to catch once you 
build on a case-insensitive FS like found on OS X (default) or MS Windows. But 
I just realised this might also happen with configuration or temporary 
files/sockets and there it would probably be less evident. 

CHeers,
R.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126362: Allow timeout in reset_oom_protection while waiting for SIGUSR1

[Martin Gräßlin]

> On April 26, 2016, 3:09 a.m., Michael Pyne wrote:
> > Any news on this one? I can commit it if you like (I'm still running the 
> > patched code a few months later so it certainly seems safe enough!).

> (I'm still running the patched code a few months later so it certainly seems 
> safe enough!)

ah yeah, that's a good note! I was kind of too scared to push it ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126362/#review94847
---


On Dec. 15, 2015, 11:19 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126362/
> ---
> 
> (Updated Dec. 15, 2015, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> If for whatever reason the child process does not get SIGUSR1, it
> should not block an infinite time, but timeout and continue.
> 
> 
> Diffs
> -
> 
>   src/kdeinit/kinit.cpp a18008a11bf00a35aa0cab450180926217cd58f5 
> 
> Diff: https://git.reviewboard.kde.org/r/126362/diff/
> 
> 
> Testing
> ---
> 
> Seems to not work correctly yet as I don't hit the timeout condition with the 
> broken kwin_wayland.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
---

(Updated April 26, 2016, 5:42 p.m.)


Review request for KDE Frameworks, Andreas Kainz and Christoph Feck.


Changes
---

Let themes specify their own extensions to be looked up.

The strace test results are quite similar and doesn't break standards.

Needs patching in Breeze & Oxygen though: https://paste.kde.org/py5kqvppv


Repository: kiconthemes


Description
---

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to 
bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs (updated)
-

  src/kiconengine.h 5b9badb 
  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
---

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
almost as good as the RR #127236, but with a much smaller memory impact, since 
we're not caching all the icon names (which was specially bad as it was 
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 43 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 09:53:51 +
Build duration: 1 min 38 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.frameworkintegration-kfiledialogqml_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1140/1717 
(66%)CONDITIONAL 451/1085 (42%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 387/395 (98%)CONDITIONAL 
199/375 (53%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)
src.platformtheme
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 706/1144 
(62%)CONDITIONAL 223/548 (41%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 39 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 09:46:26 +
Build duration: 6 min 16 sec

CHANGE SET
Revision 90e8bb655f98722f6904c4aeb5b1089249814224 by sitter: (mkpath instead of 
mkdir)
  change: edit src/ioslaves/http/kcookiejar/kcookieserver.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26426/50610 
(52%)CONDITIONAL 14507/37351 (39%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7275/7850 
(93%)CONDITIONAL 3840/8140 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7672/14038 
(55%)CONDITIONAL 4146/8903 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2213/7554 
(29%)CONDITIONAL 886/4395 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 36 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 09:46:26 +
Build duration: 4 min 14 sec

CHANGE SET
Revision 90e8bb655f98722f6904c4aeb5b1089249814224 by sitter: (mkpath instead of 
mkdir)
  change: edit src/ioslaves/http/kcookiejar/kcookieserver.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26706/50591 
(53%)CONDITIONAL 14840/37327 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7831 
(96%)CONDITIONAL 4163/8116 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7669/14038 
(55%)CONDITIONAL 4140/8903 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/4395 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1305/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127743: mkpath instead of mkdir

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127743/
---

(Updated April 26, 2016, 9:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 90e8bb655f98722f6904c4aeb5b1089249814224 by Harald Sitter 
to branch master.


Repository: kio


Description
---

if the parent directory/ies does not exist yet mkdir would fail even when
technically it could construct the path.

this in particular occurs in test setups with xvfb&openbox&kded:
- http_jobtest would attempt to talk to the cookiejar
- kded5 gets autostarted & jar loaded
- jar module runs getOrCreate on a path that is relative to a fake home
  (e.g. /tmp/kitten-test-123/.local/share/cache
- creation fails
- jar displays dialog that will not ever be run
- test stuck and will time out eventually
- the particular kded used is now defunct


Diffs
-

  src/ioslaves/http/kcookiejar/kcookieserver.cpp 
9f9d9449b2f06f33ac479b0b5fb47f26c169fb41 

Diff: https://git.reviewboard.kde.org/r/127743/diff/


Testing
---

tested the at the outlined scenario works

make test still passes


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 42 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 09:12:35 +
Build duration: 6 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.frameworkintegration-kfiledialogqml_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1140/1717 
(66%)CONDITIONAL 451/1085 (42%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 387/395 (98%)CONDITIONAL 
199/375 (53%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)
src.platformtheme
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 706/1144 
(62%)CONDITIONAL 223/548 (41%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127743: mkpath instead of mkdir

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127743/#review94854
---


Ship it!




Ship It!

- David Faure


On April 25, 2016, 9:02 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127743/
> ---
> 
> (Updated April 25, 2016, 9:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> if the parent directory/ies does not exist yet mkdir would fail even when
> technically it could construct the path.
> 
> this in particular occurs in test setups with xvfb&openbox&kded:
> - http_jobtest would attempt to talk to the cookiejar
> - kded5 gets autostarted & jar loaded
> - jar module runs getOrCreate on a path that is relative to a fake home
>   (e.g. /tmp/kitten-test-123/.local/share/cache
> - creation fails
> - jar displays dialog that will not ever be run
> - test stuck and will time out eventually
> - the particular kded used is now defunct
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/kcookiejar/kcookieserver.cpp 
> 9f9d9449b2f06f33ac479b0b5fb47f26c169fb41 
> 
> Diff: https://git.reviewboard.kde.org/r/127743/diff/
> 
> 
> Testing
> ---
> 
> tested the at the outlined scenario works
> 
> make test still passes
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Tags tag tags, not commits

[David Faure]

On Monday 25 April 2016 08:51:04 Stephen Kelly wrote:
> David Faure wrote:
> > You can see it all in the release-tools.git repo, branch frameworks/5.0
> 
> Thanks, I had looked around for it but didn't find it. I can't seem to 
> access that though.
> 
> $ git clone kde:release-tools
> Cloning into 'release-tools'...
> fatal: remote error: access denied or repository not exported: /release-
> tools

Try this:
git clone g...@git.kde.org:sysadmin/release-tools

> > Why is this an actual problem btw?
> 
> It just seems like a bug.

Seems like a harmless one to me, unless I'm missing something.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 38 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 08:55:19 +
Build duration: 16 min

CHANGE SET
Revision 35fa6b366f861eb005c2c1f89e960ec8b56073db by David Faure: (KFileItem: 
remove separate storage of times, use UDSEntry instead.)
  change: edit src/core/kfileitem.cpp
  change: edit autotests/kfileitemtest.cpp
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26758/50610 
(53%)CONDITIONAL 14886/37351 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7537/7850 
(96%)CONDITIONAL 4177/8140 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7687/14038 
(55%)CONDITIONAL 4158/8903 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2261/7554 
(30%)CONDITIONAL 911/4395 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
285/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 35 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 08:55:19 +
Build duration: 6 min 53 sec

CHANGE SET
Revision 35fa6b366f861eb005c2c1f89e960ec8b56073db by David Faure: (KFileItem: 
remove separate storage of times, use UDSEntry instead.)
  change: edit autotests/jobtest.h
  change: edit autotests/jobtest.cpp
  change: edit autotests/kfileitemtest.cpp
  change: edit src/core/kfileitem.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26683/50591 
(53%)CONDITIONAL 14829/37327 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7831 
(96%)CONDITIONAL 4161/8116 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7651/14038 
(55%)CONDITIONAL 4134/8903 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/4395 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux, gcc - Build # 11 - Still Unstable!

[Ben Cooksley]

On Tue, Apr 26, 2016 at 8:51 AM, Albert Astals Cid  wrote:
> El dilluns, 25 d’abril de 2016, a les 19:14:00 CEST, Ben Cooksley va escriure:
>> On Mon, Apr 25, 2016 at 5:59 PM, Martin Graesslin 
> wrote:
>> > On Saturday, April 23, 2016 8:48:17 PM CEST Ben Cooksley wrote:
>> >> On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin 
>> >
>> > wrote:
>> >> > On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote:
>> >> >> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil 
> wrote:
>> >> >> > On Saturday, April 23, 2016 1:44:16 AM CEST Ben Cooksley wrote:
>> >> >> >> On Fri, Apr 22, 2016 at 11:11 PM, David Faure 
> wrote:
>> >> >> >> > On Thursday 21 April 2016 14:57:52 no-re...@kde.org wrote:
>> >> >> >> >> GENERAL INFO
>> >> >> >> >>
>> >> >> >> >> BUILD UNSTABLE
>> >> >> >> >> Build URL:
>> >> >> >> >> https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFOR
>> >> >> >> >> M=L
>> >> >> >> >> inu
>> >> >> >> >> x,
>> >> >> >> >> compiler=gcc/11/>
>> >> >> >> >
>> >> >> >> > Wow, ASAN detected a real bug in Qt here.
>> >> >> >> >
>> >> >> >> > Fixed in https://codereview.qt-project.org/156728
>> >> >> >>
>> >> >> >> As this issue essentially breaks any test on the CI system that
>> >> >> >> depends on Qt I suggest all developers affected by this indicate
>> >> >> >> this
>> >> >> >> on the relevant reviews.
>> >> >> >
>> >> >> > Hey guys,
>> >> >>
>> >> >> Hi David,
>> >> >>
>> >> >> > any chance to get this patch into our Qt build on the CI since it
>> >> >> > has
>> >> >> > been
>> >> >> > integrated upstream now? As it affects all tests that interact with
>> >> >> > DBus
>> >> >> > it
>> >> >> > would be nice to resolve this on the CI.
>> >> >>
>> >> >> We'll need upstream to update qt5.git (I think that's still required
>> >> >> for changes to fully flow through) I think.
>> >> >> We could try to hack the patch in, but then we'll end up having to
>> >> >> undo that in a few weeks time.
>> >> >
>> >> > Could we disable that ASAN check please[1]? I have two of my projects
>> >> > failing due to the DBus problem and one further failing due to a
>> >> > similar
>> >> > problem in QQuickStyleItem [2]. It's nice that we find errors, but I
>> >> > rather not have my tests fail due to errors in Qt.
>> >>
>> >> That would just cover up the issue.
>> >
>> > Yes it would and that's exactly what I want.
>> >
>> > To me the CI is currently producing false positives. It started to break
>> > from one moment to the other. It costs time to look into why it started
>> > to fail. It means that till that problem is fixed in Qt I cannot trust
>> > the CI system. It results in nobody noticing real breakage, because the
>> > build is broken anyway.
>> >
>> > Then there is the problem of responsibility: I look at the output, I have
>> > no idea why that thing is broken, I have no idea how to build a minimal
>> > example which would reproduce it, even less on how to fix it. That's just
>> > a really bad situation to have a CI which can be trusted.
>> >
>> > In summary: I don't want spend time to investigate false positives. If an
>> > option results in false positives, I think that we should disable it.
>>
>> Understandable.
>>
>> > Of course Qt should get those bugs fixed, but for that Qt should enable
>> > ASAN on their CI system. If we get libraries which are free of ASAN
>> > problems, then we can enable it on our side. But false positives are just
>> > bad.
>>
>> Based on this i'm going to assume Qt is not ASAN compliant, and will
>> therefore be disabling ASAN for all KDE projects across the entire KDE
>> CI system in 24 hours unless nobody objects.
>
> Instead of an axe let's be more precise and disable the check that's giving us
> problems
>
> https://phabricator.kde.org/D1489
>
> And reenable it in a month.

This has now been done.
If someone could send a reminder once the fix has made it's way into
qt5.git that would be much appreciated.

>
> Cheers,
>   Albert

Thanks,
Ben

>
>>
>> Objectors can be expected to place pressure on the appropriate
>> processes within the Qt Project to:
>> a) Get the necessary changes flowed through into qt5.git so we can
>> pick them up (the existing process is painfully slow)
>> b) Get their CI system to check for ASAN issues.
>>
>> > Cheers
>> > Martin
>>
>> Regards,
>> Ben
>> ___
>> Kde-frameworks-devel mailing list
>> Kde-frameworks-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Differential] [Closed] D1465: KFileItem: remove separate storage of times, use UDSEntry instead.

[dfaure (David Faure)]

dfaure closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D1465

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, Frameworks, aacid
Cc: aacid
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 08:31:53 +
Build duration: 2 min 13 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.frameworkintegration-kfiledialogqml_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1140/1717 
(66%)CONDITIONAL 451/1085 (42%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 387/395 (98%)CONDITIONAL 
199/375 (53%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)
src.platformtheme
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 706/1144 
(62%)CONDITIONAL 223/548 (41%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kglobalaccel master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kglobalaccel%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 07:56:32 +
Build duration: 3 min 50 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 19/20 (95%)CLASSES 19/20 (95%)LINE 1093/1534 
(71%)CONDITIONAL 598/1277 (47%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 244/256 (95%)CONDITIONAL 
103/202 (51%)
src
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 279/400 (70%)CONDITIONAL 
161/278 (58%)
src.runtime
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 487/751 
(65%)CONDITIONAL 285/688 (41%)
src.runtime.plugins.xcb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 83/127 (65%)CONDITIONAL 
49/109 (45%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kglobalaccel master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kglobalaccel%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 07:56:32 +
Build duration: 3 min 50 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/4 (100%)FILES 19/20 (95%)CLASSES 19/20 (95%)LINE 1093/1534 
(71%)CONDITIONAL 598/1277 (47%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 244/256 (95%)CONDITIONAL 
103/202 (51%)
src
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 279/400 (70%)CONDITIONAL 
161/278 (58%)
src.runtime
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 487/751 
(65%)CONDITIONAL 285/688 (41%)
src.runtime.plugins.xcb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 83/127 (65%)CONDITIONAL 
49/109 (45%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel