Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-09 Thread Albert Astals Cid


> On April 28, 2016, 8:02 a.m., Olivier Churlaud wrote:
> > Any other feedback? What should I do?
> 
> Allen Winter wrote:
> I suppose I need to find the time to test this out on the actual 
> api.kde.org machine.  can I run it on the old KDE4 kdelibs KDE/4.14 branch?
> 
> Olivier Churlaud wrote:
> Sadly enough it won't work if you don't set all the metadata.yml files.
> 
> I attached a big zip file to the review containing what I generated. Else 
> you can test on some cases by reading what is on the file metainfo-syntax.md.

I can't download the files, can you?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127747/#review94943
---


On April 25, 2016, 9:49 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127747/
> ---
> 
> (Updated April 25, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien 
> Gâteau, and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Keep in mind that it should not plainly replace kgenframeworks but be used by 
> all KDE projects. So in this proposition, the Frameworks are just one project 
> in others.
> 
> The code can be tested directly by checking the branch 
> `olivier/generate_all_repos`.
> 
> This MUST NOT be merged in master, because it will break the currents scripts 
> (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e).
> 
> 
> Diffs
> -
> 
>   konqi_frameworks.png PRE-CREATION 
>   metainfo.yaml 4ff17c8 
>   metainfo_syntax.md PRE-CREATION 
>   src/kapidox/data/htmlresource/default_product.png PRE-CREATION 
>   src/kapidox/data/htmlresource/kde.css b864ef5 
>   src/kapidox/data/templates/doxygen2.html PRE-CREATION 
>   src/kapidox/data/templates/frontpage.html PRE-CREATION 
>   src/kapidox/data/templates/libinfo.html PRE-CREATION 
>   src/kapidox/data/templates/maintainers.html PRE-CREATION 
>   src/kapidox/data/templates/subgroup.html PRE-CREATION 
>   src/kapidox/generator.py 5b8ae40 
>   src/newkapidox.py PRE-CREATION 
>   src/notes PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127747/diff/
> 
> 
> Testing
> ---
> 
> Tested on various scenario cases.
> 
> 
> File Attachments
> 
> 
> This is an example of what I generated. (Threadweaver is duplicated and 
> modified to test different scenarios)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

2016-05-09 Thread Andreas Kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127876/#review95312
---


Ship it!




I can't review the code but this is one of the best features in the past 2 years
+1 from the vdg

- Andreas Kainz


On Mai 9, 2016, 3:32 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127876/
> ---
> 
> (Updated Mai 9, 2016, 3:32 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> with the stylesheet based recoloring for icons, it is possible to make 
> selected icons the same color as the selected text from the palette.
> with the breeze icons style this makes the selected item more readable and 
> more in line with the style.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 403771c 
> 
> Diff: https://git.reviewboard.kde.org/r/127876/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/cfbb4571-ed40-411e-ad89-453d29fa2610__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

2016-05-09 Thread Andreas Kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127878/#review95314
---


Ship it!




I can't review the code but this is one of the best features in the past 2 years

- Andreas Kainz


On Mai 9, 2016, 4:24 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127878/
> ---
> 
> (Updated Mai 9, 2016, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> since now kiconloader can color the icons in the sidebar, by using the 
> "selected" icon mode, when the breeze icon theme is used the icon of the 
> current sidebar item will be of the same color of selected text (white-ish by 
> default), is more in line with breeze style and the monochrome icons become 
> more readable
> 
> 
> Diffs
> -
> 
>   src/filewidgets/kfileplacesview.cpp 03074e0 
> 
> Diff: https://git.reviewboard.kde.org/r/127878/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/41f52d86-6fc5-4799-bd9e-18d17dc5a65a__menu3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-09 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/
---

(Updated Mai 9, 2016, 9:06 nachm.)


Review request for KDE Frameworks and Vishesh Handa.


Changes
---

Avoid mutex around nested event loop


Bugs: 345750
https://bugs.kde.org/show_bug.cgi?id=345750


Repository: kunitconversion


Description
---

QNetworkReply does not implement waitForReadyRead

Also, the code never actually created the cache dir it was trying to create a 
file in.


Diffs (updated)
-

  src/currency.cpp ad325d8 

Diff: https://git.reviewboard.kde.org/r/127251/diff/


Testing
---

Works now. It's downloaded once and then taken from cache file in 
~/.local/share/libkunitconversion/currency.xml

Given it's a Tier 2 framework doesn't make sense to add KIO now, also failed to 
reproduce the crashes mentioned in the code.

Tests pass (only if I run them on English locale btw)

Obviously not happy with this being sync but alas that's how the API works.

Not sure if this is a KRunner bug or KUnitConverison but if I enter "5 USD" it 
converts fine, if I enter "5 usd" it returns zero for all the currencies it 
converted to.


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127875: Selected state concept for icons

2016-05-09 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95297
---




src/kiconloader.cpp (line 311)


was createIconImage in the last frameworks?

if so this is an ABI break.

instead of using a default argument you'll have to have two methods.



src/kiconloader.cpp (line 820)


these should be QStringLiteral ?



src/kiconloader.cpp (line 841)


we're already passing a highlightedText colour for some reason.

Either:
- Kiconloader is responsible for choosing whether to use the normal colour 
or the highlight colour
OR
 - The SVG is

Right now it looks like it's a mixture?


- David Edmundson


On May 9, 2016, 3:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated May 9, 2016, 3:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127875: Selected state concept for icons

2016-05-09 Thread Kai Uwe Broulik


> On Mai 9, 2016, 10:32 nachm., David Edmundson wrote:
> > src/kiconloader.cpp, line 311
> > 
> >
> > was createIconImage in the last frameworks?
> > 
> > if so this is an ABI break.
> > 
> > instead of using a default argument you'll have to have two methods.

Are you sure? This is KIconLoaderPrivate


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95297
---


On Mai 9, 2016, 3:26 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated Mai 9, 2016, 3:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127875: Selected state concept for icons

2016-05-09 Thread Andreas Kainz


> On Mai 9, 2016, 10:21 nachm., Andreas Kainz wrote:
> > Ship It!

I can't review the code but this is one of the best features in the past 2 years


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95309
---


On Mai 9, 2016, 3:26 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated Mai 9, 2016, 3:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-05-09 Thread Kai Uwe Broulik


> On April 24, 2016, 1:57 nachm., David Faure wrote:
> > Better, but I'm still wary of the reentrancy due to the nested event loop 
> > usage.
> > 
> > I bet this leads to a complete deadlock:
> > 
> > QTimer::singleShot(0, this, SLOT(launchConversion()));
> > launchConversion();
> > 
> > where launchConversion() triggers the KUnitConversion code that this patch 
> > is about.
> > 
> > While waiting for the first conversion, the timer will fire (given the 
> > nested QEventLoop usage), and we'll enter this code again, and hit 
> > mutex.lock(), and then wait forever, since we'll never go back to the event 
> > loop to finish the first conversion and unlock the mutex.
> > 
> > Maybe the mutex can be removed, actually. All that needs to be done is for 
> > m_update to be turned into a local variable (there's no reason for it to be 
> > a member variable, right?). The QSaveFile usage fixes the case where two 
> > threads would write to m_cache at the same time, or the case where one 
> > writes and one reads. Or is the mutex needed for the if() at the top? In 
> > any case I recommend not holding the mutex while being in the event loop.
> > 
> > Sorry for not realizing this earlier.
> 
> Kai Uwe Broulik wrote:
> From what I can tell the m_update is so it updates it either on first run 
> or when the cache file is outdated/missing. I don't know the internals of 
> KUnitConversion, ie. if an instance of Currency is shared or not, and how to 
> ensure that for subsequent runs of convert() I don't needlessly probe the 
> cache file again.
> 
> The m_cache variable could also be made local to the convert() function.
> 
> David Faure wrote:
> I don't know much about kunitconversion either, so I had a look, and the 
> reason that code leads to multithreading issue is indeed because all the 
> instances of everything are shared between all threads (the entry point is 
> the Converter class, and all Converter instances share the same global 
> Private, which has maps to unit categories, which have maps to units. So yes, 
> instances of CurrencyPrivate (which is the one that matters, not Currency) 
> are shared (AFAICS).
> 
> The m_cache variable is a constant value set in the constructor, there's 
> no problem with it being a member, and it doesn't need to be read with the 
> mutex locked. The instance of CurrencyPrivate is created by the first thread 
> which creates a Converter... hmm it's converter.cpp itself that is missing a 
> mutex to protect m_categories, but that's another story.
> 
> I see the point about m_update, I was wrong about it not being useful as 
> a member. Forgot the case where the cache already exists on disk, so we need 
> to parse it on first run. That should however be done with the mutex locked, 
> otherwise two threads might be loading the cache and setting the conversion 
> factors into Units at the same time.
> 
> Anyway we're also back to: we need to handle the case of same-thread 
> re-entrancy into this same code, due to the nested event loop. I don't see a 
> way to wait for the download, from a nested event loop. So I see two 
> solutions:
> - starting another download and waiting for it (which requires that the 
> mutex is not locked during the event loop; it has to be relocked before 
> setting m_update though)
> - or returning an error in this case (could be detected by keeping a list 
> of QThread pointers, and adding currentThread to that list before starting 
> the download). It's a corner case hopefully, but an error would certainly be 
> better than a deadlock.
> 
> From a correctness point of view the first solution seems better. It's 
> also simpler, it just means moving the use of the mutex around the data that 
> is written and read by multiple threads (as per definition of mutexes)... and 
> that's only m_update and m_unitMap, AFAICS.

So, in a nutshell I just lock the mutex before writing to m_update / m_unitMap 
and unlock again rather than always locking at the start of the method that may 
spawn a nested event loop?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/#review94808
---


On April 24, 2016, 1:26 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127251/
> ---
> 
> (Updated April 24, 2016, 1:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Bugs: 345750
> https://bugs.kde.org/show_bug.cgi?id=345750
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> QNetworkReply does not implement waitForReadyRead
> 
> Also, the code never actually created the cache dir it was 

Re: Review Request 127875: Selected state concept for icons

2016-05-09 Thread Andreas Kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/#review95309
---


Ship it!




Ship It!

- Andreas Kainz


On Mai 9, 2016, 3:26 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127875/
> ---
> 
> (Updated Mai 9, 2016, 3:26 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> QIcon has a Selected state that wasn't mapped to KIcon, use it and in case 
> for svg based icons that take colors from the palette take the 
> highlightedText color from the palette to color the icon instead of the text 
> color, making it possible for styles to have white icons and white text in 
> selected menu items (need explicit support from the style, patches in breeze 
> and the like coming)
> 
> 
> Diffs
> -
> 
>   src/kiconengine.cpp 7c72ade 
>   src/kiconloader.h cf2f58a 
>   src/kiconloader.cpp b3c7166 
> 
> Diff: https://git.reviewboard.kde.org/r/127875/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> menu.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 127878: use the "selected" icon mode in file open dialog sidebar

2016-05-09 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127878/
---

Review request for KDE Frameworks and Plasma.


Repository: kio


Description
---

since now kiconloader can color the icons in the sidebar, by using the 
"selected" icon mode, when the breeze icon theme is used the icon of the 
current sidebar item will be of the same color of selected text (white-ish by 
default), is more in line with breeze style and the monochrome icons become 
more readable


Diffs
-

  src/filewidgets/kfileplacesview.cpp 03074e0 

Diff: https://git.reviewboard.kde.org/r/127878/diff/


Testing
---


File Attachments


menu3.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/41f52d86-6fc5-4799-bd9e-18d17dc5a65a__menu3.png


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

2016-05-09 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127876/
---

Review request for KDE Frameworks and Plasma.


Repository: breeze


Description
---

with the stylesheet based recoloring for icons, it is possible to make selected 
icons the same color as the selected text from the palette.
with the breeze icons style this makes the selected item more readable and more 
in line with the style.


Diffs
-

  kstyle/breezestyle.cpp 403771c 

Diff: https://git.reviewboard.kde.org/r/127876/diff/


Testing
---


File Attachments


menu.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/cfbb4571-ed40-411e-ad89-453d29fa2610__menu.png


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 127875: Selected state concept for icons

2016-05-09 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127875/
---

Review request for KDE Frameworks and Plasma.


Repository: kiconthemes


Description
---

QIcon has a Selected state that wasn't mapped to KIcon, use it and in case for 
svg based icons that take colors from the palette take the highlightedText 
color from the palette to color the icon instead of the text color, making it 
possible for styles to have white icons and white text in selected menu items 
(need explicit support from the style, patches in breeze and the like coming)


Diffs
-

  src/kiconengine.cpp 7c72ade 
  src/kiconloader.h cf2f58a 
  src/kiconloader.cpp b3c7166 

Diff: https://git.reviewboard.kde.org/r/127875/diff/


Testing
---


File Attachments


menu.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 26 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 13:53:53 +
Build duration: 31 sec

CHANGE SET
Revision 2db5bafdb675e75168a101843620e7416b46cc34 by Marco Martin: (use system 
colors for monochrome icons)
  change: add autotests/coloredsvgicon.svg
  change: edit src/kicontheme.cpp
  change: edit src/CMakeLists.txt
  change: edit autotests/kiconloader_unittest.cpp
  change: edit src/kiconloader.cpp
  change: edit CMakeLists.txt
  change: edit autotests/resources.qrc
  change: edit src/kicontheme.h
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 27 - Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 13:53:53 +
Build duration: 3 min 45 sec

CHANGE SET
Revision 2db5bafdb675e75168a101843620e7416b46cc34 by Marco Martin: (use system 
colors for monochrome icons)
  change: edit autotests/kiconloader_unittest.cpp
  change: edit src/kiconloader.cpp
  change: edit autotests/resources.qrc
  change: edit src/kicontheme.h
  change: edit src/kicontheme.cpp
  change: add autotests/coloredsvgicon.svg
  change: edit src/CMakeLists.txt
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.kiconthemes-kiconloader_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1054/2376 
(44%)CONDITIONAL 669/1852 (36%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 353/355 (99%)CONDITIONAL 
207/414 (50%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 701/2021 (35%)CONDITIONAL 
462/1438 (32%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127779: use system colors for monochrome icons

2016-05-09 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127779/
---

(Updated May 9, 2016, 7:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 2db5bafdb675e75168a101843620e7416b46cc34 by Marco Martin 
to branch master.


Repository: kiconthemes


Description
---

Breeze uses stylesheet information to color its icons with some "named" colors 
that change depending from the current system color scheme, this is already 
used since some time in the icons used by the Plasma shell.
But QWidget applications have the same problem, when the user changes the color 
scheme from breeze to breeze dark (or any color scheme), most of the icons will 
be black on black.
This patch clones (a bit simplified and taking only the most "important" 
colors) the logic used by Plasma::Svg to color icons with the stylesheet.

even tough it's doing more things at icon generation, an application that uses 
a lot of icons like Dolphin doesn't seem to have noticeable startup time 
difference, even when the image cache is not present yet, so i hope is not an 
unacceptable performance tradeoff (successive loads are unchanged as are from 
the image cache).

still some questions and things that can be optimized, like

* an optional key in the theme metadata file to explicitly enable this, to not 
have it running in themes that don't care?

* can i use karchive in this framework?, so it would work with svgz icons as 
well

* right now to refresh icons at runtime it depends from a patch in the colors 
kcm to emit iconchanges as well, alternatively kiconloader could watch for 
kcolorscheme changes as well, but i don't think is strictly necessary


Diffs
-

  CMakeLists.txt 5c7cbe5 
  autotests/coloredsvgicon.svg PRE-CREATION 
  autotests/kiconloader_unittest.cpp ca97559 
  autotests/resources.qrc a19c963 
  src/CMakeLists.txt 0e30a35 
  src/kiconloader.cpp 6ce7ecd 
  src/kicontheme.h 5b1229c 
  src/kicontheme.cpp f8c0a37 

Diff: https://git.reviewboard.kde.org/r/127779/diff/


Testing
---


File Attachments


dadel1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-09c7a703a456__dadel1.png
Gwenview in fullscreen flips colors
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/04/1c0cab70-a54f-4533-b5e9-0b3af07ae087__dadel2.png


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127779: use system colors for monochrome icons

2016-05-09 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127779/
---

(Updated May 9, 2016, 1:01 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kiconthemes


Description
---

Breeze uses stylesheet information to color its icons with some "named" colors 
that change depending from the current system color scheme, this is already 
used since some time in the icons used by the Plasma shell.
But QWidget applications have the same problem, when the user changes the color 
scheme from breeze to breeze dark (or any color scheme), most of the icons will 
be black on black.
This patch clones (a bit simplified and taking only the most "important" 
colors) the logic used by Plasma::Svg to color icons with the stylesheet.

even tough it's doing more things at icon generation, an application that uses 
a lot of icons like Dolphin doesn't seem to have noticeable startup time 
difference, even when the image cache is not present yet, so i hope is not an 
unacceptable performance tradeoff (successive loads are unchanged as are from 
the image cache).

still some questions and things that can be optimized, like

* an optional key in the theme metadata file to explicitly enable this, to not 
have it running in themes that don't care?

* can i use karchive in this framework?, so it would work with svgz icons as 
well

* right now to refresh icons at runtime it depends from a patch in the colors 
kcm to emit iconchanges as well, alternatively kiconloader could watch for 
kcolorscheme changes as well, but i don't think is strictly necessary


Diffs (updated)
-

  CMakeLists.txt 5c7cbe5 
  autotests/coloredsvgicon.svg PRE-CREATION 
  autotests/kiconloader_unittest.cpp ca97559 
  autotests/resources.qrc a19c963 
  src/CMakeLists.txt 0e30a35 
  src/kiconloader.cpp 6ce7ecd 
  src/kicontheme.h 5b1229c 
  src/kicontheme.cpp f8c0a37 

Diff: https://git.reviewboard.kde.org/r/127779/diff/


Testing
---


File Attachments


dadel1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/0fc42425-947c-479e-9759-09c7a703a456__dadel1.png
Gwenview in fullscreen flips colors
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/04/1c0cab70-a54f-4533-b5e9-0b3af07ae087__dadel2.png


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 65 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:46:57 +
Build duration: 1 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 65 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:46:57 +
Build duration: 1 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kparts master stable-kf5-qt5 » Linux,gcc - Build # 59 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:32:46 +
Build duration: 5 min 42 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 20/46 (43%)CLASSES 20/46 (43%)LINE 599/2600 
(23%)CONDITIONAL 197/1420 (14%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 175/186 (94%)CONDITIONAL 
77/156 (49%)
src
FILES 17/43 (40%)CLASSES 17/43 (40%)LINE 424/2414 
(18%)CONDITIONAL 120/1264 (9%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kparts master stable-kf5-qt5 » Linux,gcc - Build # 59 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:32:46 +
Build duration: 5 min 42 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 20/46 (43%)CLASSES 20/46 (43%)LINE 599/2600 
(23%)CONDITIONAL 197/1420 (14%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 175/186 (94%)CONDITIONAL 
77/156 (49%)
src
FILES 17/43 (40%)CLASSES 17/43 (40%)LINE 424/2414 
(18%)CONDITIONAL 120/1264 (9%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-09 Thread Anthony Fieroni

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127809/#review95296
---



Ping. It is ok, now?

- Anthony Fieroni


On Май 6, 2016, 12:08 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127809/
> ---
> 
> (Updated Май 6, 2016, 12:08 след обяд)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 362324
> https://bugs.kde.org/show_bug.cgi?id=362324
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> The api function is KWindowSystem::icon (WId win, int width=-1, int 
> height=-1, bool scale=false) so caller must get best size not worst when 
> width/height is not specified.
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 5b7c65a 
> 
> Diff: https://git.reviewboard.kde.org/r/127809/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/6d718ef6-26cf-4866-94d2-4ffbdfc906fe__Screenshot_20160426_232109.png
> after
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/01/7dcab4ae-e451-4d43-8799-a0fcab471a3d__Screenshot_20160501_224642.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kparts master stable-kf5-qt5 » Linux,gcc - Build # 58 - Still Failing!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:15:10 +
Build duration: 15 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:16:47 +
Build duration: 6 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26747/50642 
(53%)CONDITIONAL 14886/37401 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7539/7855 
(96%)CONDITIONAL 4175/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7659/14036 
(55%)CONDITIONAL 4136/8905 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1308/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:16:47 +
Build duration: 6 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26747/50642 
(53%)CONDITIONAL 14886/37401 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7539/7855 
(96%)CONDITIONAL 4175/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7659/14036 
(55%)CONDITIONAL 4136/8905 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1308/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:15:10 +
Build duration: 1 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/9 (56%)FILES 11/51 (22%)CLASSES 11/51 (22%)LINE 757/4793 
(16%)CONDITIONAL 389/2887 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 76/76 (100%)CONDITIONAL 
41/80 (51%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 20/949 (2%)CONDITIONAL 
3/366 (1%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/248 (0%)CONDITIONAL 0/166 
(0%)
src.core
FILES 3/14 (21%)CLASSES 3/14 (21%)LINE 103/1379 (7%)CONDITIONAL 
55/960 (6%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 398/891 (45%)CONDITIONAL 
206/576 (36%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/115 
(0%)
src.ui
FILES 0/14 (0%)CLASSES 0/14 (0%)LINE 0/790 (0%)CONDITIONAL 
0/346 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/143 (0%)CONDITIONAL 0/86 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:15:10 +
Build duration: 1 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/9 (56%)FILES 11/51 (22%)CLASSES 11/51 (22%)LINE 757/4793 
(16%)CONDITIONAL 389/2887 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 76/76 (100%)CONDITIONAL 
41/80 (51%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 20/949 (2%)CONDITIONAL 
3/366 (1%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/248 (0%)CONDITIONAL 0/166 
(0%)
src.core
FILES 3/14 (21%)CLASSES 3/14 (21%)LINE 103/1379 (7%)CONDITIONAL 
55/960 (6%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 398/891 (45%)CONDITIONAL 
206/576 (36%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/115 
(0%)
src.ui
FILES 0/14 (0%)CLASSES 0/14 (0%)LINE 0/790 (0%)CONDITIONAL 
0/346 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/143 (0%)CONDITIONAL 0/86 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities-stats master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:15:05 +
Build duration: 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities-stats master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:15:05 +
Build duration: 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 60 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/60/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:03:09 +
Build duration: 6 min 51 sec

CHANGE SET
Revision e6e5a935a764c805ee3197daf73cf457800f77a5 by David Faure: 
(kshorturifilter: fix regression with mailto: not prepended when no)
  change: edit src/urifilters/shorturi/kshorturifilter.cpp


JUNIT RESULTS

Name: (root) Failed: 29 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiofilewidgets-kdiroperatortestFailed: 
TestSuite.kiofilewidgets-kfilecopytomenutestFailed: 
TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiofilewidgets-knewfilemenutestFailed: 
TestSuite.kiofilewidgets-kurlcomboboxtestFailed: 
TestSuite.kiofilewidgets-kurlnavigatortestFailed: 
TestSuite.kiogui-favicontestFailed: 
TestSuite.kioslave-httpauthenticationtestFailed: 
TestSuite.kioslave-httpheaderdispositiontestFailed: 
TestSuite.kioslave-httpheadertokenizetestFailed: 
TestSuite.kioslave-httpobjecttestFailed: 
TestSuite.kioslave-kcookiejartestFailed: 
TestSuite.kiowidgets-accessmanagertestFailed: 
TestSuite.kiowidgets-accessmanagertest-qnamFailed: 
TestSuite.kiowidgets-clipboardupdatertestFailed: 
TestSuite.kiowidgets-dropjobtestFailed: 
TestSuite.kiowidgets-fileundomanagertestFailed: 
TestSuite.kiowidgets-jobguitestFailed: 
TestSuite.kiowidgets-kdirlistertestFailed: 
TestSuite.kiowidgets-kdirmodeltestFailed: 
TestSuite.kiowidgets-kfileitemactionstestFailed: 
TestSuite.kiowidgets-krununittestFailed: 
TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: 
TestSuite.kiowidgets-kurifiltertestFailed: 
TestSuite.kiowidgets-kurlcompletiontestFailed: 
TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: 
TestSuite.kiowidgets-kurlrequestertestFailed: 
TestSuite.kiowidgets-pastetestFailed: TestSuite.kpasswdservertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/11 (91%)FILES 144/240 (60%)CLASSES 144/240 (60%)LINE 12318/35334 
(35%)CONDITIONAL 6315/24984 (25%)

By packages
  
autotests
FILES 35/35 (100%)CLASSES 35/35 (100%)LINE 3400/3604 
(94%)CONDITIONAL 1675/3250 (52%)
autotests.http
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 65/65 (100%)CONDITIONAL 
41/80 (51%)
src.core
FILES 85/117 (73%)CLASSES 85/117 (73%)LINE 5792/14036 
(41%)CONDITIONAL 2769/8905 (31%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 407/833 (49%)CONDITIONAL 
290/719 (40%)
src.ioslaves.http
FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 1022/3776 (27%)CONDITIONAL 
635/3433 (18%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 705/1155 (61%)CONDITIONAL 
360/753 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/385 (0%)CONDITIONAL 0/138 
(0%)
src.widgets
FILES 4/62 (6%)CLASSES 4/62 (6%)LINE 193/10598 (2%)CONDITIONAL 
104/6778 (2%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:03:09 +
Build duration: 6 min 4 sec

CHANGE SET
Revision e6e5a935a764c805ee3197daf73cf457800f77a5 by David Faure: 
(kshorturifilter: fix regression with mailto: not prepended when no)
  change: edit src/urifilters/shorturi/kshorturifilter.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26735/50623 
(53%)CONDITIONAL 14887/37377 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7520/7836 
(96%)CONDITIONAL 4166/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7671/14036 
(55%)CONDITIONAL 4149/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1305/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 12:03:09 +
Build duration: 6 min 4 sec

CHANGE SET
Revision e6e5a935a764c805ee3197daf73cf457800f77a5 by David Faure: 
(kshorturifilter: fix regression with mailto: not prepended when no)
  change: edit src/urifilters/shorturi/kshorturifilter.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26735/50623 
(53%)CONDITIONAL 14887/37377 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7520/7836 
(96%)CONDITIONAL 4166/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7671/14036 
(55%)CONDITIONAL 4149/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1305/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:57:39 +
Build duration: 8 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 58 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:57:39 +
Build duration: 8 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kparts master stable-kf5-qt5 » Linux,gcc - Build # 57 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:57:39 +
Build duration: 2 min 55 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 57 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:57:39 +
Build duration: 2 min 56 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:57:39 +
Build duration: 1 min 5 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 59 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:47:03 +
Build duration: 9 min 23 sec

CHANGE SET
Revision 45f60b72301707f69e1398b48392c61c73102313 by David Faure: ([autotest] 
comment out foobar.local test, makes the test take 5s to exit)
  change: edit autotests/kurifiltertest.cpp
Revision 02a34516d38c6d09a6deb65d22b6cfd3c2575dd4 by David Faure: ([autotest] 
Enable kshorturifilter debug output from the unittest)
  change: edit src/urifilters/shorturi/kshorturifilter.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26769/50643 
(53%)CONDITIONAL 14917/37407 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7542/7855 
(96%)CONDITIONAL 4183/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7671/14036 
(55%)CONDITIONAL 4149/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 240/269 (89%)CONDITIONAL 
335/416 (81%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1308/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 56 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:47:03 +
Build duration: 9 min 0 sec

CHANGE SET
Revision 45f60b72301707f69e1398b48392c61c73102313 by David Faure: ([autotest] 
comment out foobar.local test, makes the test take 5s to exit)
  change: edit autotests/kurifiltertest.cpp
Revision 02a34516d38c6d09a6deb65d22b6cfd3c2575dd4 by David Faure: ([autotest] 
Enable kshorturifilter debug output from the unittest)
  change: edit src/urifilters/shorturi/kshorturifilter.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26733/50624 
(53%)CONDITIONAL 14899/37383 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7521/7836 
(96%)CONDITIONAL 4172/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7661/14036 
(55%)CONDITIONAL 4142/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 240/269 (89%)CONDITIONAL 
335/416 (81%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 57 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:24:37 +
Build duration: 15 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kactivities-stats master stable-kf5-qt5 » Linux,gcc - Build # 57 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:11:39 +
Build duration: 15 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 66 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:22:40 +
Build duration: 2 min 13 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 55 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/55/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:13:27 +
Build duration: 8 min 29 sec

CHANGE SET
Revision ead645aafd02466e54c2982d04cedc441f71a1b2 by David Faure: ([autotest] 
Fix random crash in favicontest.)
  change: edit autotests/favicontest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26709/50605 
(53%)CONDITIONAL 14854/37345 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7524/7837 
(96%)CONDITIONAL 4171/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7662/14036 
(55%)CONDITIONAL 4146/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:13:27 +
Build duration: 6 min 30 sec

CHANGE SET
Revision ead645aafd02466e54c2982d04cedc441f71a1b2 by David Faure: ([autotest] 
Fix random crash in favicontest.)
  change: edit autotests/favicontest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26747/50624 
(53%)CONDITIONAL 14871/37369 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7543/7856 
(96%)CONDITIONAL 4179/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7668/14036 
(55%)CONDITIONAL 4142/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1308/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 54 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:56:05 +
Build duration: 11 min

CHANGE SET
Revision 3e0656af5f7cf1c5b1bf6c2d73ba931aef3ad655 by David Faure: ([autotest] 
fix favicontest getting a translated error message)
  change: edit autotests/favicontest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26748/50601 
(53%)CONDITIONAL 14874/37341 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7520/7833 
(96%)CONDITIONAL 4167/8124 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7685/14036 
(55%)CONDITIONAL 4152/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 387/594 (65%)CONDITIONAL 
289/580 (50%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 52 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:03:02 +
Build duration: 1 min 26 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 129/137 
(94%)CONDITIONAL 65/98 (66%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 
33/50 (66%)
src.core
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 73/81 (90%)CONDITIONAL 
32/48 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 52 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 11:03:02 +
Build duration: 1 min 26 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 129/137 
(94%)CONDITIONAL 65/98 (66%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 
33/50 (66%)
src.core
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 73/81 (90%)CONDITIONAL 
32/48 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:49:27 +
Build duration: 12 min

CHANGE SET
Revision 3e0656af5f7cf1c5b1bf6c2d73ba931aef3ad655 by David Faure: ([autotest] 
fix favicontest getting a translated error message)
  change: edit autotests/favicontest.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiogui-favicontestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26754/50620 
(53%)CONDITIONAL 14884/37365 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7529/7852 
(96%)CONDITIONAL 4174/8148 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7687/14036 
(55%)CONDITIONAL 4157/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 99/110 (90%)CONDITIONAL 
44/72 (61%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 51 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:40:51 +
Build duration: 16 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 53 - Failure!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:49:27 +
Build duration: 4 min 26 sec

CHANGE SET
Revision 3e0656af5f7cf1c5b1bf6c2d73ba931aef3ad655 by David Faure: ([autotest] 
fix favicontest getting a translated error message)
  change: edit autotests/favicontest.cpp
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 56 - Still unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:28:23 +
Build duration: 12 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26762/50619 
(53%)CONDITIONAL 14881/37365 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7535/7851 
(96%)CONDITIONAL 4178/8148 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7683/14036 
(55%)CONDITIONAL 4149/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2271/7564 
(30%)CONDITIONAL 915/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 52 - Still unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:28:27 +
Build duration: 5 min 49 sec

CHANGE SET
Revision b032467f0b6fa1168ace180c698b5472f3568aab by David Faure: ([autotest] 
Adapt order to more stable ordering from solid (8de3b3e39))
  change: edit autotests/kfileplacesmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26714/50600 
(53%)CONDITIONAL 14852/37341 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7519/7832 
(96%)CONDITIONAL 4169/8124 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7667/14036 
(55%)CONDITIONAL 4140/8905 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4399 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10599 
(25%)CONDITIONAL 1306/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: ${PROJECT_NAME} - Build # ${BUILD_NUMBER} - ${BUILD_STATUS}!

2016-05-09 Thread no-reply
${JELLY_SCRIPT,template="text"}___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 55 - Aborted!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD ABORTED
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 10:26:18 +
Build duration: 1 min 51 sec

CHANGE SET
Revision b032467f0b6fa1168ace180c698b5472f3568aab by David Faure: ([autotest] 
Adapt order to more stable ordering from solid (8de3b3e39))
  change: edit autotests/kfileplacesmodeltest.cpp
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127843: Properly remove composed characters

2016-05-09 Thread Jan Grulich


> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote:
> > I can see that the patch works, since Qt's QTextLayout functions are used 
> > for cursor navigation.
> > 
> > I dislike the part that exposes the "currentTextLayout()", since it exposes 
> > more API (but ok, maybe we must), and it is not flexible. For instance, 
> > ktexteditor.git has a multicursor branch, and just getting the "current" 
> > text layout is not enough. Could you change it to textLayout(int line), 
> > along with a comment that the returned pointer is possibly a nullptr?
> > 
> > PS: KateViewInternal.cpp also has a KateWrappingCursor. A proper solution 
> > would be to expose this class so that proper text navigation is available 
> > everywhere (e.g. KTextEditor::ViewCursor, just like 
> > KTextEditor::DocumentCursor).

I'm trying to expose KateWrappingCursor class, but problem is that it requires 
access to KateViewInternal which we would still need to expose instead of 
currentTextLayout(). Any idea how to solve that?


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95257
---


On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated Kvě. 5, 2016, 10:53 dop.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 54 - Still Unstable!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:55:32 +
Build duration: 6 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26424/50619 
(52%)CONDITIONAL 14502/37365 (39%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7276/7851 
(93%)CONDITIONAL 3842/8148 (47%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7668/14036 
(55%)CONDITIONAL 4144/8905 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE /7564 
(29%)CONDITIONAL 889/4399 (20%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1250/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/54 (78%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
298/378 (79%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10599 
(25%)CONDITIONAL 1309/6780 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:43:07 +
Build duration: 7 min 27 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 39/68 (57%)CLASSES 39/68 (57%)LINE 3980/9221 
(43%)CONDITIONAL 2152/6392 (34%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 1319/1326 
(99%)CONDITIONAL 580/1174 (49%)
src
FILES 28/57 (49%)CLASSES 28/57 (49%)LINE 2661/7895 
(34%)CONDITIONAL 1572/5218 (30%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:43:07 +
Build duration: 7 min 27 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 39/68 (57%)CLASSES 39/68 (57%)LINE 3980/9221 
(43%)CONDITIONAL 2152/6392 (34%)

By packages
  
autotests
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 1319/1326 
(99%)CONDITIONAL 580/1174 (49%)
src
FILES 28/57 (49%)CLASSES 28/57 (49%)LINE 2661/7895 
(34%)CONDITIONAL 1572/5218 (30%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 32 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:42:42 +
Build duration: 4 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21707/42788 
(51%)CONDITIONAL 14666/36447 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11531/11780 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5722/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 32 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:42:42 +
Build duration: 4 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21707/42788 
(51%)CONDITIONAL 14666/36447 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11531/11780 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16863 
(55%)CONDITIONAL 5722/11783 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:42:45 +
Build duration: 1 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 15/20 (75%)CLASSES 15/20 (75%)LINE 525/793 
(66%)CONDITIONAL 188/396 (47%)

By packages
  
autotests
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 241/260 (93%)CONDITIONAL 
144/246 (59%)
src
FILES 8/11 (73%)CLASSES 8/11 (73%)LINE 191/354 (54%)CONDITIONAL 
27/98 (28%)
src.backends.dbus
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 93/179 (52%)CONDITIONAL 
17/52 (33%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:42:45 +
Build duration: 1 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 15/20 (75%)CLASSES 15/20 (75%)LINE 525/793 
(66%)CONDITIONAL 188/396 (47%)

By packages
  
autotests
FILES 6/7 (86%)CLASSES 6/7 (86%)LINE 241/260 (93%)CONDITIONAL 
144/246 (59%)
src
FILES 8/11 (73%)CLASSES 8/11 (73%)LINE 191/354 (54%)CONDITIONAL 
27/98 (28%)
src.backends.dbus
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 93/179 (52%)CONDITIONAL 
17/52 (33%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:42:39 +
Build duration: 3 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:42:39 +
Build duration: 3 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kcrash master stable-kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcrash%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:39:53 +
Build duration: 3 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 91/376 
(24%)CONDITIONAL 31/241 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 52/68 (76%)CONDITIONAL 
18/38 (47%)
src
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/308 (13%)CONDITIONAL 
13/203 (6%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kcrash master stable-kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcrash%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:39:53 +
Build duration: 3 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 91/376 
(24%)CONDITIONAL 31/241 (13%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 52/68 (76%)CONDITIONAL 
18/38 (47%)
src
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/308 (13%)CONDITIONAL 
13/203 (6%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:40:35 +
Build duration: 1 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 49/49 (100%)CLASSES 49/49 (100%)LINE 2916/3125 
(93%)CONDITIONAL 223/496 (45%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 87/87 (100%)CONDITIONAL 
49/98 (50%)
src
FILES 43/43 (100%)CLASSES 43/43 (100%)LINE 2829/3038 
(93%)CONDITIONAL 174/398 (44%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

2016-05-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 09 May 2016 08:40:35 +
Build duration: 1 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 49/49 (100%)CLASSES 49/49 (100%)LINE 2916/3125 
(93%)CONDITIONAL 223/496 (45%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 87/87 (100%)CONDITIONAL 
49/98 (50%)
src
FILES 43/43 (100%)CLASSES 43/43 (100%)LINE 2829/3038 
(93%)CONDITIONAL 174/398 (44%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127830: use QUrl::fromUserInput to construct sound url

2016-05-09 Thread Harald Sitter

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127830/
---

(Updated May 9, 2016, 7:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Klapetek.


Changes
---

Submitted with commit 9db06adc8114163f401417064b07772139bc36bc by Harald Sitter 
to branch master.


Bugs: 337276
https://bugs.kde.org/show_bug.cgi?id=337276


Repository: knotifications


Description
---

QUrl() would treats it as a parsable uri, but they aren't e.g. # in a uri
separates segments in a local file path it simply is a #.
This "accidentally" worked in Phonon < 4.9 as Phonon obtained string
representations in a way that would bypass internal QUrl checks for
fileyness and URI ambiguity. Since 4.9 Phonon expects scheme-less URLs to
be local files, but QUrl() would most of the time not do that since it
would honestly think the soundfilename is a random (i.e. not necessarily
local) uri.

To fix this use QUrl::fromUserInput which behaves exactly like what we
need to properly resolve relative names, urls, paths, full URIs.

This now works with input of the type:
- Oxygen-Sys-Special.ogg
- /usr/share/sounds/Oxygen-Sys-Special.ogg
- file:///usr/share/sounds/Oxygen-Sys-Special.ogg
- /usr/share/sounds/#KDE-Im-Cant-#Connect.ogg
- file:///usr/share/sounds/#KDE-Im-Cant-#Connect.ogg
- http://people.ubuntu.com/~apachelogger/sounds/sounds-3.5/KDE_Glass_Break.ogg
(yes, we can have http notifications https://xkcd.com/1172/)

CCBUG: 337276


Diffs
-

  src/notifybyaudio.cpp 6ae63b8df8e7aa692e88b03ca7b7538c78101917 

Diff: https://git.reviewboard.kde.org/r/127830/diff/


Testing
---

builds & test pass & I trust my testing in 
https://git.reviewboard.kde.org/r/127829/


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

2016-05-09 Thread Harald Sitter

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127829/
---

(Updated May 9, 2016, 7:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Klapetek.


Changes
---

Submitted with commit 4832f7d9f2f3bd0fa8ab9b9162bf50e855efc448 by Harald Sitter 
to branch master.


Bugs: 337276
https://bugs.kde.org/show_bug.cgi?id=337276


Repository: knotifyconfig


Description
---

QUrl() would treats it as a parsable uri, but they aren't e.g. # in a uri
separates segments in a local file path it simply is a #.
This "accidentally" worked in Phonon < 4.9 as Phonon obtained string
representations in a way that would bypass internal QUrl checks for
fileyness and URI ambiguity. Since 4.9 Phonon expects scheme-less URLs to
be local files, but QUrl() would most of the time not do that since it
would honestly think the soundfilename is a random (i.e. not necessarily
local) uri.

To fix this use QUrl::fromUserInput which behaves exactly like what we
need to properly resolve relative names, urls, paths, full URIs.

This now works with input of the type:
- Oxygen-Sys-Special.ogg
- /usr/share/sounds/Oxygen-Sys-Special.ogg
- file:///usr/share/sounds/Oxygen-Sys-Special.ogg
- /usr/share/sounds/#KDE-Im-Cant-#Connect.ogg
- file:///usr/share/sounds/#KDE-Im-Cant-#Connect.ogg
- http://people.ubuntu.com/~apachelogger/sounds/sounds-3.5/KDE_Glass_Break.ogg
(yes, we can have http notifications https://xkcd.com/1172/)

CCBUG: 337276


Diffs
-

  src/knotifyconfigactionswidget.cpp 98286c4d0e8a7deec5d35986a261222931afb60d 

Diff: https://git.reviewboard.kde.org/r/127829/diff/


Testing
---

built and played all of the above


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel