Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-09 Thread Anthony Fieroni 


> On Юни 9, 2016, 6:22 преди обяд, Anthony Fieroni wrote:
> > Ping.
> 
> Elvis Angelaccio wrote:
> This doesn't seem to fix the crash with Ark 16.04.1

Backtrace?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/#review96305
---


On Юни 10, 2016, 8:07 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128113/
> ---
> 
> (Updated Юни 10, 2016, 8:07 преди обяд)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> + Fix memory leak in finished
> 
> 
> Diffs
> -
> 
>   src/kuiserverjobtracker.cpp ebed3a5 
>   tests/kjobtrackerstest.cpp 7ef9e07 
> 
> Diff: https://git.reviewboard.kde.org/r/128113/diff/
> 
> 
> Testing
> ---
> 
> ark --changetofirstpath --add --autofilename zip kjobwidgets
> Crash before, fix with patch
> 
> 
> File Attachments
> 
> 
> backtrace
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
> memcheck
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
> memcheck 7 errorrs
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-09 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/
---

(Updated Юни 10, 2016, 8:07 преди обяд)


Review request for KDE Frameworks and David Faure.


Changes
---

+ Test case


Repository: kjobwidgets


Description
---

+ Fix memory leak in finished


Diffs (updated)
-

  src/kuiserverjobtracker.cpp ebed3a5 
  tests/kjobtrackerstest.cpp 7ef9e07 

Diff: https://git.reviewboard.kde.org/r/128113/diff/


Testing
---

ark --changetofirstpath --add --autofilename zip kjobwidgets
Crash before, fix with patch


File Attachments


backtrace
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
memcheck
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
memcheck 7 errorrs
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

2016-06-09 Thread René J . V . Bertin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128043/
---

(Updated June 9, 2016, 7:52 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

addresses all but the "should an incomplete audio notification make a sound or 
not" issue.


Repository: knotifications


Description
---

This is a follow-up to discussion on the plasma-devel ML. When not running 
under a Plasma session it would be preferable if generic alert sounds are (can 
be) delivered using the default system sound. The easiest way to do that is to 
call `QApplication::beep()` ; at least on OS X this will play the user's 
selected alert sound.

I have implemented this for now by assuming the existence of a virtual 
(relative) `beep` sound file that always plays the default sound. 

In addition, this patch provides better warning feedback if a soundfile isn't 
found (making it easier to figure out which alert is misconfigured), and will 
play the sysbeep in that case (so that the alert doesn't go lost if it's 
sound-only).
Finally, no Phonon::AudioOutput object is created until that is actually 
required.


Diffs (updated)
-

  src/notifybyaudio.cpp 903e996 

Diff: https://git.reviewboard.kde.org/r/128043/diff/


Testing
---

Works as expected on OS X 10.9.5


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

2016-06-09 Thread René J . V . Bertin 


> On May 30, 2016, 7:38 p.m., Martin Klapetek wrote:
> > src/notifybyaudio.cpp, line 61
> > 
> >
> > But this is not correct, if you disable the sound in the config, the 
> > soundFilename will be empty and this will cause ::beep() to be executed. 
> > But why if I choose no sound?

Hmmm, I didn't think of it that way. The warning message suggests that this is 
a case of an incomplete notification definition. Why would you choose to have 
an audio notification that doesn't make a sound? Shouldn't that be handled by 
another special case, something like `Sound=silent` or `Sound=none`?

Or is the warning text incorrect?


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128043/#review96047
---


On May 29, 2016, 6:15 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128043/
> ---
> 
> (Updated May 29, 2016, 6:15 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> This is a follow-up to discussion on the plasma-devel ML. When not running 
> under a Plasma session it would be preferable if generic alert sounds are 
> (can be) delivered using the default system sound. The easiest way to do that 
> is to call `QApplication::beep()` ; at least on OS X this will play the 
> user's selected alert sound.
> 
> I have implemented this for now by assuming the existence of a virtual 
> (relative) `beep` sound file that always plays the default sound. 
> 
> In addition, this patch provides better warning feedback if a soundfile isn't 
> found (making it easier to figure out which alert is misconfigured), and will 
> play the sysbeep in that case (so that the alert doesn't go lost if it's 
> sound-only).
> Finally, no Phonon::AudioOutput object is created until that is actually 
> required.
> 
> 
> Diffs
> -
> 
>   src/notifybyaudio.cpp 903e996 
> 
> Diff: https://git.reviewboard.kde.org/r/128043/diff/
> 
> 
> Testing
> ---
> 
> Works as expected on OS X 10.9.5
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

2016-06-09 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Jun 2016 17:10:36 +
Build duration: 5 min 39 sec

CHANGE SET
Revision bd3b3c8b8af249c1dc3c020c09b8bab479411503 by rjvbertin: (Fix an 
alignment issue with the OS X native quot;macintoshquot; style)
  change: edit src/filewidgets/kurlnavigatorbuttonbase.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26730/50633 
(53%)CONDITIONAL 14885/37413 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7837 
(96%)CONDITIONAL 4166/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7671/14041 
(55%)CONDITIONAL 4146/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2268/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10604 
(25%)CONDITIONAL 1309/6802 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

2016-06-09 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Jun 2016 17:10:36 +
Build duration: 5 min 39 sec

CHANGE SET
Revision bd3b3c8b8af249c1dc3c020c09b8bab479411503 by rjvbertin: (Fix an 
alignment issue with the OS X native quot;macintoshquot; style)
  change: edit src/filewidgets/kurlnavigatorbuttonbase.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26730/50633 
(53%)CONDITIONAL 14885/37413 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7837 
(96%)CONDITIONAL 4166/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7671/14041 
(55%)CONDITIONAL 4146/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2268/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10604 
(25%)CONDITIONAL 1309/6802 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 81 - Still Unstable!

2016-06-09 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/81/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 09 Jun 2016 17:10:36 +
Build duration: 6 min 39 sec

CHANGE SET
Revision bd3b3c8b8af249c1dc3c020c09b8bab479411503 by rjvbertin: (Fix an 
alignment issue with the OS X native quot;macintoshquot; style)
  change: edit src/filewidgets/kurlnavigatorbuttonbase.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 259/337 (77%)CLASSES 259/337 (77%)LINE 26730/50613 
(53%)CONDITIONAL 14886/37389 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7501/7817 
(96%)CONDITIONAL 4152/8104 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7671/14041 
(55%)CONDITIONAL 4146/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2271/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1769/3781 
(47%)CONDITIONAL 1264/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 720/1155 (62%)CONDITIONAL 
381/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 372/594 (63%)CONDITIONAL 
276/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10604 
(25%)CONDITIONAL 1311/6802 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128005: fix alignment issue with the OS X native "macintosh" style

2016-06-09 Thread René J . V . Bertin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128005/
---

(Updated June 9, 2016, 7:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Software on Mac OS X, KDE Frameworks and Christoph Feck.


Changes
---

Submitted with commit 44d6d6cfcfea5060bfe1676840f1df6e86c235e8 by René J.V. 
Bertin to branch master.


Repository: kwidgetsaddons


Description
---

This patch fixes the size & alignment issue discussed in 
https://bugs.kde.org/show_bug.cgi?id=296810


Diffs
-

  src/kmultitabbar.cpp f7739fa 

Diff: https://git.reviewboard.kde.org/r/128005/diff/


Testing
---

On OS X 10.9.5 with KF5 5.20.0, Qt 5.6.0 and Kate 16.4.01 . No adverse effects 
when used with other themes on this platform.


File Attachments


Kate5 running with the native "macintosh" qpa & theme, showing correct 
alignment.
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/fe90cba8-f6de-4e5c-8732-4cbebf4abe8b__Screen_Shot_2016-05-24_at_18.38.16.png


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128002: address alignment issue with the OS X native "macintosh" style

2016-06-09 Thread René J . V . Bertin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128002/
---

(Updated June 9, 2016, 5:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Software on Mac OS X, KDE Frameworks and Christoph Feck.


Changes
---

Submitted with commit bd3b3c8b8af249c1dc3c020c09b8bab479411503 by René J.V. 
Bertin to branch master.


Repository: kio


Description
---

This patch addresses a misalignment issue in KUrlNavigator when using the 
native "macintosh" widget style on OS X.

Cf. https://bugs.kde.org/show_bug.cgi?id=296845


Diffs
-

  src/filewidgets/kurlnavigatorbuttonbase.cpp 8b06bfa 

Diff: https://git.reviewboard.kde.org/r/128002/diff/


Testing
---

On OS X 10.9 with frameworks 5.20.0 (sic), Qt 5.6.0 using my MacPorts build.

The additional attribute doesn't have any effects for me with other styles, but 
this still has to be verified on other platforms.


File Attachments


The widget concerned in Kate's interface, showing the result with and without 
the patch. It is clear which is which.
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/ca3c7872-68ee-4ed6-b1f4-4d0b05111be1__Screen_Shot_2016-05-24_at_14.37.43.png
other widgets remain to be done
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/24/71b20243-8dda-4f22-89e1-21559b767fd5__Screen_Shot_2016-05-24_at_14.38.30.png


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128139: Silence CMake policy CMP0063 warning

2016-06-09 Thread Heiko Becker 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128139/
---

(Updated June 9, 2016, 3:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit a4de98aa4f77c393116be91ec2fbc8945895f4ff by Heiko Becker 
to branch master.


Repository: kimageformats


Description
---

...by adding the NO_POLICY_SCOPE flag as recommended by ECM's
documentation.


Diffs
-

  CMakeLists.txt ec570193ee5ec0533dc2a0ae7e600ccb5bd9d6d1 

Diff: https://git.reviewboard.kde.org/r/128139/diff/


Testing
---

Warning disappears, still builds successfully.


Thanks,

Heiko Becker

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128139: Silence CMake policy CMP0063 warning

2016-06-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128139/#review96328
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On June 9, 2016, 5:14 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128139/
> ---
> 
> (Updated June 9, 2016, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> ...by adding the NO_POLICY_SCOPE flag as recommended by ECM's
> documentation.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ec570193ee5ec0533dc2a0ae7e600ccb5bd9d6d1 
> 
> Diff: https://git.reviewboard.kde.org/r/128139/diff/
> 
> 
> Testing
> ---
> 
> Warning disappears, still builds successfully.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128139: Silence CMake policy CMP0063 warning

2016-06-09 Thread Heiko Becker 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128139/
---

Review request for KDE Frameworks and Alex Merry.


Repository: kimageformats


Description
---

...by adding the NO_POLICY_SCOPE flag as recommended by ECM's
documentation.


Diffs
-

  CMakeLists.txt ec570193ee5ec0533dc2a0ae7e600ccb5bd9d6d1 

Diff: https://git.reviewboard.kde.org/r/128139/diff/


Testing
---

Warning disappears, still builds successfully.


Thanks,

Heiko Becker

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128085: Fix check that CPU is a valid CPU

2016-06-09 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/
---

(Updated June 9, 2016, 1:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Solid.


Changes
---

Submitted with commit f55f25fc7274722486ff83557b3224c0540523f5 by David 
Edmundson to branch master.


Repository: solid


Description
---

We have a check that an devices/system/cpu/cpuN entry contains a
processor and not just an empty socket, however it relies on somewhat
outdated /sys files.

cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
processor at least).

The docs in the linux kernel imply topology/core_id should always exist,
and should still work as a valid check that we have a populated CPU
socket.


Diffs
-

  src/solid/devices/backends/udev/udevmanager.cpp 
3f3a671798e84e6d577df7c3b9b80150ac4d01fc 

Diff: https://git.reviewboard.kde.org/r/128085/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

2016-06-09 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128084/
---

(Updated June 9, 2016, 1:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Solid.


Changes
---

Submitted with commit 9870418bf299e3c6aede79c81c13cd07bba8e6e7 by David 
Edmundson to branch master.


Repository: solid


Description
---

The /proc/cpuinfo format is wildly different between architectures, our
current method for scraping data only works on x86.

This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
search that works for arm and arm64 architectures.


https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55

https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104


Diffs
-

  src/solid/devices/backends/udev/cpuinfo.h 
e8d5dda729535e767b4640f41a01f4d0e27e6542 
  src/solid/devices/backends/udev/cpuinfo.cpp 
ecaad58ceee34d46343b67015c03d9a3de87ee72 
  src/solid/devices/backends/udev/udevdevice.cpp 
9fb5e092679cd3c6860b2055cf3dedb915addfda 
  src/solid/devices/backends/udev/udevprocessor.cpp 
80d14f5b40b4478a32d7c113747fe9da50e54b6f 

Diff: https://git.reviewboard.kde.org/r/128084/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128083: Find CPUs by subsystem rather than driver

2016-06-09 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128083/
---

(Updated June 9, 2016, 3:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Solid.


Changes
---

Submitted with commit 0cb9b52b89165de7d92b95d0eb7d46879e9e7825 by David 
Edmundson to branch master.


Repository: solid


Description
---

The driver "processor" is part of the ACPI module, which isn't used by
all systems and architectures.

Detecting devices by CPU subsystem seems to work, and whilst
theoretically this change could pick up a non CPU device in the same subsystem 
they
would be filtered out by the udevmanager which has an extra check
that CPUs are valid and not just empty sockets.


Diffs
-

  src/solid/devices/backends/udev/udevdevice.cpp 
9fb5e092679cd3c6860b2055cf3dedb915addfda 
  src/solid/devices/backends/udev/udevmanager.cpp 
3f3a671798e84e6d577df7c3b9b80150ac4d01fc 

Diff: https://git.reviewboard.kde.org/r/128083/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-09 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/#review96312
---



Would it maybe be possible to get an autotest case for this?

- Aleix Pol Gonzalez


On June 8, 2016, 6:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128113/
> ---
> 
> (Updated June 8, 2016, 6:17 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> + Fix memory leak in finished
> 
> 
> Diffs
> -
> 
>   src/kuiserverjobtracker.cpp ebed3a5 
> 
> Diff: https://git.reviewboard.kde.org/r/128113/diff/
> 
> 
> Testing
> ---
> 
> ark --changetofirstpath --add --autofilename zip kjobwidgets
> Crash before, fix with patch
> 
> 
> File Attachments
> 
> 
> backtrace
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
> memcheck
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
> memcheck 7 errorrs
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128113: [kuiserverjobtracker] Fix crash when unregister job

2016-06-09 Thread Elvis Angelaccio 


> On June 9, 2016, 3:22 a.m., Anthony Fieroni wrote:
> > Ping.

This doesn't seem to fix the crash with Ark 16.04.1


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128113/#review96305
---


On June 8, 2016, 4:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128113/
> ---
> 
> (Updated June 8, 2016, 4:17 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> + Fix memory leak in finished
> 
> 
> Diffs
> -
> 
>   src/kuiserverjobtracker.cpp ebed3a5 
> 
> Diff: https://git.reviewboard.kde.org/r/128113/diff/
> 
> 
> Testing
> ---
> 
> ark --changetofirstpath --add --autofilename zip kjobwidgets
> Crash before, fix with patch
> 
> 
> File Attachments
> 
> 
> backtrace
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace
> memcheck
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/ba4b0150-5e01-4cc1-8776-7530d053d6f0__memcheck
> memcheck 7 errorrs
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/07/f8813ccc-8835-4255-842c-29c57c2dea23__memcheck2
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel