date:20160614


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/baloo%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/99/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:28:54 +
Build duration: 3 min 46 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 
37 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 12/12 (100%)FILES 111/144 (77%)CLASSES 111/144 (77%)LINE 4952/6894 
(72%)CONDITIONAL 2562/5085 (50%)

By packages
  
autotests.benchmarks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 18/18 (100%)CONDITIONAL 
6/8 (75%)
autotests.integration
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 242/255 (95%)CONDITIONAL 
140/220 (64%)
autotests.unit.codecs
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 18/18 (100%)CONDITIONAL 
14/26 (54%)
autotests.unit.engine
FILES 17/17 (100%)CLASSES 17/17 (100%)LINE 692/692 
(100%)CONDITIONAL 362/686 (53%)
autotests.unit.file
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 790/809 
(98%)CONDITIONAL 441/864 (51%)
autotests.unit.lib
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 315/326 (97%)CONDITIONAL 
156/302 (52%)
src.codecs
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 106/197 (54%)CONDITIONAL 
26/58 (45%)
src.engine
FILES 39/40 (98%)CLASSES 39/40 (98%)LINE 1614/2039 
(79%)CONDITIONAL 792/1334 (59%)
src.file
FILES 17/44 (39%)CLASSES 17/44 (39%)LINE 685/1507 
(45%)CONDITIONAL 378/986 (38%)
src.file.extractor
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/29 (69%)CONDITIONAL 
7/12 (58%)
src.file.extractor.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 
12/20 (60%)
src.lib
FILES 6/11 (55%)CLASSES 6/11 (55%)LINE 429/981 (44%)CONDITIONAL 
228/569 (40%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

2016-06-14 Thread Albert Astals Cid

El dimarts, 14 de juny de 2016, a les 10:57:19 CEST, David Faure va escriure:
> On mardi 14 juin 2016 01:00:09 CEST Albert Astals Cid wrote:
> > El dilluns, 13 de juny de 2016, a les 11:27:53 CEST, David Faure va
> 
> escriure:
> > > On dimanche 12 juin 2016 22:58:34 CEST Albert Astals Cid wrote:
> > > > El diumenge, 12 de juny de 2016, a les 20:29:56 CEST, Christoph
> > > > Cullmann
> > > > va
> > > > 
> > > > escriure:
> > > > > Hi,
> > > > > 
> > > > > > Having KMessageBox "dontShowMeAgain" feature depend on an
> > > > > > integration
> > > > > > plugin is a very bad idea.
> > > > > > 
> > > > > > Basically it means programs that use KMessageBox can never asusme
> > > > > > it
> > > > > > will
> > > > > > work so basically they have to use alternative methods to have the
> > > > > > "dontShowMeAgain" feature or not have it at all.
> > > > > > 
> > > > > > I understand someone thought that it was a better idea having a
> > > > > > feature
> > > > > > that may work or not randomly that increasing the dependency chain
> > > > > > of
> > > > > > KMessageBox, but I disagree.
> > > > > > 
> > > > > > I don't think the status quo is good at all, my program basically
> > > > > > gets
> > > > > > a
> > > > > > runtime dependency that is not specified anywhere and that makes
> > > > > > some
> > > > > > features work or not randomly.
> > > > > > 
> > > > > > The options I can see are:
> > > > > > * Remove the "dontShowMeAgain" feature from KMessageBox
> > > > > > * Make the "dontShowMeAgain" feature use QSettings (always or if
> > > > > > FrameworkIntegrationPlugin is not available)
> > > > > > * Show a KMessageBox warning when trying to use the
> > > > > > "dontShowMeAgain"
> > > > > > feature and the FrameworkIntegrationPlugin is not available saying
> > > > > > the
> > > > > > user to install that package if he wants to get the functionality.
> > > > > 
> > > > > I would go for the "just use QSettings always" solution.
> > > > 
> > > > This has two problems:
> > > >  * Someone needs to care about a way to read the KConfig and write it
> > > >  to
> > > > 
> > > > QSettings so it still works for people that had already checked "don't
> > > > show
> > > > me again"
> > > > 
> > > >  * There's a KMessageBox::setDontShowAgainConfig(KConfig *cfg) that
> > > >  would
> > > > 
> > > > break, this affects only the kdialog app and KIO::JobUiDelegate
> > > > 
> > > > The second is probably "workaroundable" but i'm not sure how one would
> > > > approach the first.
> > > > 
> > > > Maybe still using the FrameworkIntegrationPlugin to check if the
> > > > option
> > > > has
> > > > been set and if it has and it is not in qsettings, move it there?
> > > > 
> > > > This would "fail" if the FrameworkIntegrationPlugin is not there, but
> > > > that
> > > > would mean that most probably the kconfig was never ever set either
> > > > (unless
> > > > you installed FrameworkIntegrationPlugin used a kmessagebox and then
> > > > uninstalled FrameworkIntegrationPlugin that seems very corner case-y).
> > > > 
> > > > I'll try to work on this in the coming days if noone disagrees.
> > > 
> > > Not sure exactly what is your final approach, from the above.
> > > 
> > > I would go for:
> > >   Make the "dontShowMeAgain" feature use QSettings if
> > >   FrameworkIntegrationPlugin is not available
> > > 
> > > i.e. as a fallback. This preserves the KConfig benefits/integration on a
> > > more complete install, but doesn't lead to a non-working checkbox when
> > > the
> > > plugin is missing.
> > 
> > That is not what i suggested, I suggested using QSettings only.
> > 
> > What's the point of using KConfig for this?
> 
> I can think of the following:
> - not breaking setDontShowAgainConfig(KConfig *cfg)
> - not breaking application code that might be setting or clearing
> these settings directly using KConfig (e.g. to implement "show all
> messageboxes again")

That would still not work if only using QSettings, application is again only 
half working because we support two different places to save the same value.

> - (and then you don't have to handle any migration, so it's actually much
> simpler IHMO)

We still need to handle the migration when/if the user installs 
FrameworksIntegration no? Suddenly all his MessageBoxes will be back without 
any apparent reason.

I guess the other benefit that KConfig brings is that it can support "system 
overrides" of the config options, is that really useful for "dontShowMeAgain" 
settings?

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: baloo master stable-kf5-qt5 » Linux,gcc - Build # 99 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/baloo%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/99/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 22:28:54 +
Build duration: 3 min 46 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 
37 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 12/12 (100%)FILES 111/144 (77%)CLASSES 111/144 (77%)LINE 4952/6894 
(72%)CONDITIONAL 2562/5085 (50%)

By packages
  
autotests.benchmarks
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 18/18 (100%)CONDITIONAL 
6/8 (75%)
autotests.integration
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 242/255 (95%)CONDITIONAL 
140/220 (64%)
autotests.unit.codecs
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 18/18 (100%)CONDITIONAL 
14/26 (54%)
autotests.unit.engine
FILES 17/17 (100%)CLASSES 17/17 (100%)LINE 692/692 
(100%)CONDITIONAL 362/686 (53%)
autotests.unit.file
FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 790/809 
(98%)CONDITIONAL 441/864 (51%)
autotests.unit.lib
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 315/326 (97%)CONDITIONAL 
156/302 (52%)
src.codecs
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 106/197 (54%)CONDITIONAL 
26/58 (45%)
src.engine
FILES 39/40 (98%)CLASSES 39/40 (98%)LINE 1614/2039 
(79%)CONDITIONAL 792/1334 (59%)
src.file
FILES 17/44 (39%)CLASSES 17/44 (39%)LINE 685/1507 
(45%)CONDITIONAL 378/986 (38%)
src.file.extractor
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/29 (69%)CONDITIONAL 
7/12 (58%)
src.file.extractor.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 23/23 (100%)CONDITIONAL 
12/20 (60%)
src.lib
FILES 6/11 (55%)CLASSES 6/11 (55%)LINE 429/981 (44%)CONDITIONAL 
228/569 (40%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 122 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/122/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 20:41:51 +
Build duration: 12 min

CHANGE SET
Revision ef487b17441afc793a0953cbd329aa67bd56044a by dhaumann: (Phabricator arc 
tool: allow changing the git history)
  change: edit .arcconfig


JUNIT RESULTS

Name: (root) Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.completion_testFailed: 
TestSuite.vimode_completionFailed: TestSuite.vimode_keysFailed: 
TestSuite.vimode_modesFailed: TestSuite.vimode_view

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/26 (85%)FILES 247/302 (82%)CLASSES 247/302 (82%)LINE 21580/43334 
(50%)CONDITIONAL 11738/30988 (38%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4068/4383 
(93%)CONDITIONAL 1921/3912 (49%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1615/1759 
(92%)CONDITIONAL 1252/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1627/3111 
(52%)CONDITIONAL 1093/2816 (39%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 183/465 (39%)CONDITIONAL 
77/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/931 (0%)CONDITIONAL 0/278 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1675/3197 
(52%)CONDITIONAL 1353/3149 (43%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/242 
(84%)CONDITIONAL 143/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 82/331 (25%)CONDITIONAL 
16/107 (15%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 876/1225 
(72%)CONDITIONAL 573/926 (62%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
4/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 657/1055 
(62%)CONDITIONAL 274/556 (49%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 889/1389 
(64%)CONDITIONAL 513/904 (57%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1640/2135 
(77%)CONDITIONAL 1037/1766 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 666/772 (86%)CONDITIONAL 
318/448 (71%)
src.utils
FILES 31/36 (86%)CLASSES 31/36 (86%)LINE 2300/3882 
(59%)CONDITIONAL 1120/2706 (41%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/659 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3000/6092 
(49%)CONDITIONAL 1277/3680 (35%)
src.vimode
FILES 22/35 (63%)CLASSES 22/35 (63%)LINE 762/3093 
(25%)CONDITIONAL 189/2387 (8%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.modes
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 509/3738 
(14%)CONDITIONAL 40/2370 (2%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: baloo master stable-kf5-qt5 » Linux,gcc - Build # 98 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/baloo%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 20:49:39 +
Build duration: 9.6 sec

CHANGE SET
Revision c03dfc8bb962b7d8302d10c836f26e3f1457c567 by pinak.ahuja: (Revert 
quot;DocumentUrlDB::del Only assert when children of dir actually)
  change: edit src/engine/documenturldb.h
Revision aa0fde58ea7d75f986cbd0d9708ff3984c9e7289 by pinak.ahuja: (Remove 
useless spaces)
  change: edit src/lib/advancedqueryparser.cpp
  change: edit autotests/unit/lib/advancedqueryparsertest.cpp
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 126 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/126/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 20:41:51 +
Build duration: 13 min

CHANGE SET
Revision ef487b17441afc793a0953cbd329aa67bd56044a by dhaumann: (Phabricator arc 
tool: allow changing the git history)
  change: edit .arcconfig


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.completion_test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 272/308 (88%)CLASSES 272/308 (88%)LINE 29068/46059 
(63%)CONDITIONAL 15258/31300 (49%)

By packages
  
autotests.src
FILES 43/43 (100%)CLASSES 43/43 (100%)LINE 3643/3945 
(92%)CONDITIONAL 1729/3592 (48%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3149/3164 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1630/3111 
(52%)CONDITIONAL 1060/2816 (38%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 67/465 (14%)CONDITIONAL 
30/354 (8%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/931 (0%)CONDITIONAL 0/278 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1798/3197 
(56%)CONDITIONAL 1479/3149 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 202/241 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/107 (51%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 899/1225 
(73%)CONDITIONAL 598/926 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 696/1055 
(66%)CONDITIONAL 292/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 897/1389 
(65%)CONDITIONAL 519/904 (57%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2135 
(78%)CONDITIONAL 1059/1766 (60%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2504/3882 
(65%)CONDITIONAL 1280/2706 (47%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/659 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3082/6092 
(51%)CONDITIONAL 1369/3680 (37%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2300/3093 
(74%)CONDITIONAL 1298/2387 (54%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3243/3738 
(87%)CONDITIONAL 1851/2370 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 124 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/124/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 19:58:03 +
Build duration: 14 min

CHANGE SET
Revision 83c1f995b4018ab2945de1c212868b2773b941db by dhaumann: (Add .arcconfig 
file for phabricator patches)
  change: add .arcconfig


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29752/46498 
(64%)CONDITIONAL 15672/31620 (50%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4070/4383 
(93%)CONDITIONAL 1923/3912 (49%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3149/3164 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1752/3111 
(56%)CONDITIONAL 1206/2816 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/465 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/931 (0%)CONDITIONAL 0/278 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1802/3197 
(56%)CONDITIONAL 1486/3149 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/242 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/107 (51%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 899/1225 
(73%)CONDITIONAL 598/926 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 696/1055 
(66%)CONDITIONAL 292/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 897/1389 
(65%)CONDITIONAL 519/904 (57%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2135 
(78%)CONDITIONAL 1059/1766 (60%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2517/3882 
(65%)CONDITIONAL 1297/2706 (48%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/659 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3082/6092 
(51%)CONDITIONAL 1370/3680 (37%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2300/3093 
(74%)CONDITIONAL 1298/2387 (54%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3243/3738 
(87%)CONDITIONAL 1851/2370 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 124 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/124/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 19:58:03 +
Build duration: 14 min

CHANGE SET
Revision 83c1f995b4018ab2945de1c212868b2773b941db by dhaumann: (Add .arcconfig 
file for phabricator patches)
  change: add .arcconfig


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 278/314 (89%)CLASSES 278/314 (89%)LINE 29752/46498 
(64%)CONDITIONAL 15672/31620 (50%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4070/4383 
(93%)CONDITIONAL 1923/3912 (49%)
autotests.src.vimode
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 3149/3164 
(100%)CONDITIONAL 374/632 (59%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1752/3111 
(56%)CONDITIONAL 1206/2816 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/465 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/931 (0%)CONDITIONAL 0/278 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1802/3197 
(56%)CONDITIONAL 1486/3149 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/242 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 180/331 (54%)CONDITIONAL 
55/107 (51%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 899/1225 
(73%)CONDITIONAL 598/926 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 696/1055 
(66%)CONDITIONAL 292/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 897/1389 
(65%)CONDITIONAL 519/904 (57%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2135 
(78%)CONDITIONAL 1059/1766 (60%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2517/3882 
(65%)CONDITIONAL 1297/2706 (48%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/659 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/18 (83%)CLASSES 15/18 (83%)LINE 3082/6092 
(51%)CONDITIONAL 1370/3680 (37%)
src.vimode
FILES 34/35 (97%)CLASSES 34/35 (97%)LINE 2300/3093 
(74%)CONDITIONAL 1298/2387 (54%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3243/3738 
(87%)CONDITIONAL 1851/2370 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128187: Add a program to convert symbolically linked files to qrc aliases

2016-06-14 Thread Kåre Särs


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128187/
---

Review request for KDE Frameworks, Andreas Kainz and David Faure.


Repository: breeze-icons


Description
---

On windows git converts symbolic links to text files with links to
the actual file. This added application modifies the .qrc to use
aliases for the links.

This change also adds an option to not install the icons.


Diffs
-

  CMakeLists.txt 08cd1a0 
  icons-dark/CMakeLists.txt 5d7e6f8 
  icons/CMakeLists.txt bd4c048 
  main.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128187/diff/


Testing
---

Compiled on windows with BINARY_ICONS_RESOURCE and SKIP_INSTALL_ICONS enabled.

We get the icon .rcc file and the icons where not installed


Thanks,

Kåre Särs

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

2016-06-14 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 14, 2016, 7:22 nachm.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and David Faure.


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review96497
---


Fix it, then Ship it!





docs/qt5options/man-qt5options.7.docbook (line 78)


Missing '.' at end of sentence?



docs/qt5options/man-qt5options.7.docbook (line 257)


This sentence ends with "," instead of "."


- David Faure


On June 14, 2016, 6:41 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> ---
> 
> (Updated June 14, 2016, 6:41 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> All options in this docbook like
> 
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
> title, visual, inputstyle, im, noxim, reverse, stylesheet
> 
> are valid for Qt 3.3 QApplication, see
> 
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
> 
> 
> In Qt 5.6 a QApplication automatically supports a few command line options 
> like 
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
> 
> 
> Do we really want to provide a manpage docbook for that?
> 
> 
> Diffs
> -
> 
>   docs/qt5options/man-qt5options.7.docbook d5891eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Differential] [Commented On] D1863: Remove the first attempt to load library because we will try libraryPaths anyway

aspotashev added a comment.


  David,
  
  libname is hardcoded for each scripting language at the moment to something 
like "krosspython" which is just shared object's basename. It's never an 
absolute path.

BRANCH
  remove-dupl-load-library

REVISION DETAIL
  https://phabricator.kde.org/D1863

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, #frameworks, dfaure
Cc: dfaure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

2016-06-14 Thread Burkhard Lück


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 14, 2016, 6:41 nachm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

update fixing issues spotted by David


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs (updated)
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-06-14 Thread Sune Vuorela



> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote:
> > Do you still have the sample application you made to test/verify this? I'd 
> > like to try it and it should probably be committed too.
> 
> Pino Toscano wrote:
> No I don't :-/ I remember it was just removing indexes with associated 
> widgets.
> 
> Stephen Kelly wrote:
> Maybe you could try to make it again. I'm not familiar with this code but 
> I don't know any reason for adding this complexity.
> 
> I also don't consider myself the maintainer of this repo. I'm just 
> commenting that it doesn't look right to me.
> 
> David Edmundson wrote:
> sample application.
> 
> build system settings with branch davidedmundson/newdesign

a sample applicattion is the kwidgetiemdelegatetest application


- Sune


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126610/#review94076
---


On March 28, 2016, 1:41 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126610/
> ---
> 
> (Updated March 28, 2016, 1:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Stephen Kelly.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> ---
> 
> When indexes are removed and their widgets deleted, the event filter on each 
> widget is not removed, leading to the "you should not delete widgets 
> manually"-alike warning.
> 
> Add an helper forgetAbout() function which performs all the actions done 
> per-widget before deleting each, additionally removing also the event filter.
> 
> 
> Diffs
> -
> 
>   src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 
>   src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 
>   src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126610/diff/
> 
> 
> Testing
> ---
> 
> A sample application with widgets for items in the model, removing indexes: 
> no more warning at removal time.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review96492
---




docs/qt5options/man-qt5options.7.docbook (line 41)


yes there's an arg (the icon)



docs/qt5options/man-qt5options.7.docbook (line 42)


yes, there's an arg (the title)



docs/qt5options/man-qt5options.7.docbook (line 47)


missing '-' in front of "dialogs"?



docs/qt5options/man-qt5options.7.docbook (line 118)


.. => .



docs/qt5options/man-qt5options.7.docbook (line 199)


(the difference with -qwindowgeometry is just that -geometry only exists on 
X11)



docs/qt5options/man-qt5options.7.docbook (line 205)


missing "-" or "--"?



docs/qt5options/man-qt5options.7.docbook (line 227)


The users won't know what setApplicationDescription is. I'd remove the 
second part of the sentence.



docs/qt5options/man-qt5options.7.docbook (line 257)


The correct spelling is QCommandLineParser (titlecase)


- David Faure


On June 8, 2016, 4:57 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> ---
> 
> (Updated June 8, 2016, 4:57 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> All options in this docbook like
> 
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
> title, visual, inputstyle, im, noxim, reverse, stylesheet
> 
> are valid for Qt 3.3 QApplication, see
> 
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
> 
> 
> In Qt 5.6 a QApplication automatically supports a few command line options 
> like 
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
> 
> 
> Do we really want to provide a manpage docbook for that?
> 
> 
> Diffs
> -
> 
>   docs/qt5options/man-qt5options.7.docbook d5891eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-06-14 Thread David Edmundson



> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote:
> > Do you still have the sample application you made to test/verify this? I'd 
> > like to try it and it should probably be committed too.
> 
> Pino Toscano wrote:
> No I don't :-/ I remember it was just removing indexes with associated 
> widgets.
> 
> Stephen Kelly wrote:
> Maybe you could try to make it again. I'm not familiar with this code but 
> I don't know any reason for adding this complexity.
> 
> I also don't consider myself the maintainer of this repo. I'm just 
> commenting that it doesn't look right to me.

sample application.

build system settings with branch davidedmundson/newdesign


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126610/#review94076
---


On March 28, 2016, 1:41 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126610/
> ---
> 
> (Updated March 28, 2016, 1:41 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Stephen Kelly.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> ---
> 
> When indexes are removed and their widgets deleted, the event filter on each 
> widget is not removed, leading to the "you should not delete widgets 
> manually"-alike warning.
> 
> Add an helper forgetAbout() function which performs all the actions done 
> per-widget before deleting each, additionally removing also the event filter.
> 
> 
> Diffs
> -
> 
>   src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 
>   src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 
>   src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e 
> 
> Diff: https://git.reviewboard.kde.org/r/126610/diff/
> 
> 
> Testing
> ---
> 
> A sample application with widgets for items in the model, removing indexes: 
> no more warning at removal time.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-06-14 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128056/
---

(Updated June 14, 2016, 7:20 p.m.)

Review request for KDE Software on Mac OS X, KDE Frameworks and KDevelop.

Changes
---

no longer cancels setting a different style via the command line

Repository: kdevplatform

Description
---

I filed a bug report recently that raises an issue about the QTabBar widget for
the tabbed document interface (https://bugs.kde.org/show_bug.cgi?id=363473).
On OS X, that widget is rendered like the native tab bar widget that should
only be used in dialogs and comparable views where the number of tabs is
preferably fixed and limited. There are also other rendering issues which
probably stem from presumptions KDevelop makes about the tab layout in the
extensions it implements.
Qt does provide a `documentMode` which changes the look to suit use for
document tabs better, but this mode doesn't work well with KDevelop's
extensions either.

For lack of a better solution or workaround I would thus like to explore the
idea to provide a widget style picker, like KDenlive does (presumably not
without reason either). The underlying idea is that it allows users to find an
style that works better for them if they feel a reason to do so. This option
works regardless of whether a platform theme plugin is available.

For now the patch is a proof-of-concept and work in progress. It is still
lacking a mechanism to make the style choice persistent across restarts; I
think I'll need a hand in determining how to do that correctly (it should be a
global setting, not a session-specific setting I think).

Diffs (updated)
-

sublime/CMakeLists.txt 2144087
sublime/kwidgetstyleselector.h PRE-CREATION
sublime/kwidgetstyleselector.cpp PRE-CREATION
sublime/mainwindow_p.cpp 74ef494

Diff: https://git.reviewboard.kde.org/r/128056/diff/

Testing
---

On OS X 10.9.5 and Linux, both with fw. (5.20.0 and) 5.22.0 and Qt 5.6.0

File Attachments

diff for kdevelopui.rc

https://git.reviewboard.kde.org/media/uploaded/files/2016/05/30/cb07a061-aef5-42f5-bc83-68ca7ce2ce3b__patch-kdevplatform-add-style-menu-uirc.diff
This screenshot shows where the menu item appears with the kdevelopui.rc patch
in another attachment. This KDevelop instance was running with my platform
theme plugin and my OS X palette and config for the QtCurve style. Only the UI
fonts change when the p

https://git.reviewboard.kde.org/media/uploaded/files/2016/05/30/543bffc8-26fd-44f8-8bd8-372a24c9b01f__Screen_Shot_2016-05-30_at_15.47.14.png

Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 123 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/123/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:47:59 +
Build duration: 8 min 43 sec

CHANGE SET
Revision 54b3c7c6676271baf2087c70210af6fcce0de9fc by dhaumann: (MiniMap: Use 
QRect::fillRect() to tint hidden text parts in the)
  change: edit src/view/kateviewhelpers.cpp
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 61 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:49:56 +
Build duration: 3 min 52 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 51 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:49:58 +
Build duration: 3 min 52 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 43 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:53:53 +
Build duration: 1 min 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 49 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:53:53 +
Build duration: 1 min 19 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 64 - Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:48:20 +
Build duration: 5 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5458/7983 
(68%)CONDITIONAL 2958/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 892/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1223/2056 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Differential] [Accepted] D1863: Remove the first attempt to load library because we will try libraryPaths anyway

2016-06-14 Thread dfaure (David Faure)

dfaure accepted this revision.
dfaure added a reviewer: dfaure.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks good, assuming that libname is never an absolute path did you check 
that?

BRANCH
  remove-dupl-load-library

REVISION DETAIL
  https://phabricator.kde.org/D1863

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, #frameworks, dfaure
Cc: dfaure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 68 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:47:41 +
Build duration: 1 min 43 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2948/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1225/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 68 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 15:47:41 +
Build duration: 1 min 43 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2948/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1225/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128185: Ensure extraction location to be in subfolder


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/
---

(Updated June 14, 2016, 4:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 0cb243f64eef45565741b27364cece7d5c349c37 by Andreas 
Cord-Landwehr to branch master.


Repository: karchive


Description
---

Behavior change: Switch to Tar's default behavior to avoid extraction
to arbitrary system locations outside of extraction folder. Instead,
extract such files to root location in extraction folder.


Diffs
-

  autotests/karchivetest.h 4b7ecff 
  autotests/karchivetest.cpp c8abddf 
  autotests/tar_relative_path_outside_archive.tar.bz2 PRE-CREATION 
  src/karchive.cpp 5a7cfc6 

Diff: https://git.reviewboard.kde.org/r/128185/diff/


Testing
---

See added unit test


File Attachments


test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/#review96484
---



> connect(applet(), ::Applet::contextualActionsAboutToShow,
>this, ::contextualActionsAboutToShow);
>
>connect(applet(), ::Applet::activated,
>this, ::activated);

This should work with both applet types, though?

> connect(applet(), ::Applet::configurationRequiredChanged,
>this, [this](bool needsConfig, const QString ) {
>emit configurationRequiredChanged();
>emit configurationRequiredReasonChanged();
>});

So, that's where the configuration required thing comes into play but this 
doesn't fix the property access which tries to read from appletInterface() 
which is null becuase it never sets/creates one and the thing in applet() is 
protected.

Also, can we just use delegating constructors instead? (Not sure we can in 
frameworks, though)

- Kai Uwe Broulik


On Juni 14, 2016, 9:03 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128181/
> ---
> 
> (Updated Juni 14, 2016, 9:03 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also the two were slightly out of sync leading to some connections not
> being in each constructor.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> 6a64594cd53cecfbc99ad7562706e1a78d60c138 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> df2d642445bdcc81d7fed463cb38c337380ea25b 
> 
> Diff: https://git.reviewboard.kde.org/r/128181/diff/
> 
> 
> Testing
> ---
> 
> previous code.
> 
> 
> FIRST CTOR ONLY  (normal mode)
> connect(applet(), ::Applet::contextualActionsAboutToShow,
> this, ::contextualActionsAboutToShow);
> 
> connect(applet(), ::Applet::activated,
> this, ::activated);
> 
> 
> connect(this, ::expandedChanged, [=](bool expanded) {
> //if both compactRepresentationItem and fullRepresentationItem exist,
> //the applet is in a popup
> if (expanded) {
> if (compactRepresentationItem() && fullRepresentationItem() &&
> fullRepresentationItem()->window() && 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->window() != 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->installEventFilter(this);
> } else if (fullRepresentationItem() && 
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->removeEventFilter(this);
> }
> }
> });
> }
> 
> SECOND CTOR ONLY (special comic applet path)
> 
> connect(applet(), ::Applet::configurationRequiredChanged,
> this, [this](bool needsConfig, const QString ) {
> emit configurationRequiredChanged();
> emit configurationRequiredReasonChanged();
> });
> 
> }
> 
> DUPLICATED:
> qmlRegisterType();
> 
> connect(this, ::configNeedsSaving,
> applet(), ::Applet::configNeedsSaving);
> connect(applet(), ::Applet::immutabilityChanged,
> this, ::immutabilityChanged);
> 
> connect(applet(), ::Applet::userConfiguringChanged,
> this, ::userConfiguringChanged);
> 
> connect(applet(), ::Applet::statusChanged,
> this, ::statusChanged);
> 
> connect(applet(), ::Applet::destroyedChanged,
> this, ::destroyedChanged);
> 
> 
> connect(applet(), ::Applet::titleChanged,
> this, ::titleChanged);
> 
> connect(applet(), ::Applet::iconChanged,
> this, ::iconChanged);
> 
> connect(applet(), ::Applet::busyChanged,
> this, ::busyChanged);
> 
> connect(appletScript(), ::formFactorChanged,
> this, ::formFactorChanged);
> connect(appletScript(), ::locationChanged,
> this, ::locationChanged);
> connect(appletScript(), ::contextChanged,
> this, ::contextChanged);
> 
> if (applet()->containment()) {
> connect(applet()->containment(), ::Containment::screenChanged,
> this, ::screenChanged);
> }
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128185: Ensure extraction location to be in subfolder


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/#review96483
---


Ship it!





src/karchive.cpp (line 864)


Maybe output the extraction folder as well (curDirName, before setting it), 
for the warning to contain all the information?
I like warnings that simplify debugging ;)


- David Faure


On June 14, 2016, 2:35 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128185/
> ---
> 
> (Updated June 14, 2016, 2:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Behavior change: Switch to Tar's default behavior to avoid extraction
> to arbitrary system locations outside of extraction folder. Instead,
> extract such files to root location in extraction folder.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.h 4b7ecff 
>   autotests/karchivetest.cpp c8abddf 
>   autotests/tar_relative_path_outside_archive.tar.bz2 PRE-CREATION 
>   src/karchive.cpp 5a7cfc6 
> 
> Diff: https://git.reviewboard.kde.org/r/128185/diff/
> 
> 
> Testing
> ---
> 
> See added unit test
> 
> 
> File Attachments
> 
> 
> test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128185: Ensure extraction location to be in subfolder


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/
---

(Updated Juni 14, 2016, 2:35 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
---

Adapt to David's suggestion


Repository: karchive


Description
---

Behavior change: Switch to Tar's default behavior to avoid extraction
to arbitrary system locations outside of extraction folder. Instead,
extract such files to root location in extraction folder.


Diffs (updated)
-

  autotests/karchivetest.h 4b7ecff 
  autotests/karchivetest.cpp c8abddf 
  autotests/tar_relative_path_outside_archive.tar.bz2 PRE-CREATION 
  src/karchive.cpp 5a7cfc6 

Diff: https://git.reviewboard.kde.org/r/128185/diff/


Testing
---

See added unit test


File Attachments


test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread David Edmundson



> On June 14, 2016, 10:59 a.m., Anthony Fieroni wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 67
> > 
> >
> > So, this connect and below must be removed? Same connections in newly 
> > setupConnections

erm yeah..that was the entire point of the patch!

I've got something messed up.

Thanks


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/#review96467
---


On June 14, 2016, 9:03 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128181/
> ---
> 
> (Updated June 14, 2016, 9:03 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also the two were slightly out of sync leading to some connections not
> being in each constructor.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> 6a64594cd53cecfbc99ad7562706e1a78d60c138 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> df2d642445bdcc81d7fed463cb38c337380ea25b 
> 
> Diff: https://git.reviewboard.kde.org/r/128181/diff/
> 
> 
> Testing
> ---
> 
> previous code.
> 
> 
> FIRST CTOR ONLY  (normal mode)
> connect(applet(), ::Applet::contextualActionsAboutToShow,
> this, ::contextualActionsAboutToShow);
> 
> connect(applet(), ::Applet::activated,
> this, ::activated);
> 
> 
> connect(this, ::expandedChanged, [=](bool expanded) {
> //if both compactRepresentationItem and fullRepresentationItem exist,
> //the applet is in a popup
> if (expanded) {
> if (compactRepresentationItem() && fullRepresentationItem() &&
> fullRepresentationItem()->window() && 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->window() != 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->installEventFilter(this);
> } else if (fullRepresentationItem() && 
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->removeEventFilter(this);
> }
> }
> });
> }
> 
> SECOND CTOR ONLY (special comic applet path)
> 
> connect(applet(), ::Applet::configurationRequiredChanged,
> this, [this](bool needsConfig, const QString ) {
> emit configurationRequiredChanged();
> emit configurationRequiredReasonChanged();
> });
> 
> }
> 
> DUPLICATED:
> qmlRegisterType();
> 
> connect(this, ::configNeedsSaving,
> applet(), ::Applet::configNeedsSaving);
> connect(applet(), ::Applet::immutabilityChanged,
> this, ::immutabilityChanged);
> 
> connect(applet(), ::Applet::userConfiguringChanged,
> this, ::userConfiguringChanged);
> 
> connect(applet(), ::Applet::statusChanged,
> this, ::statusChanged);
> 
> connect(applet(), ::Applet::destroyedChanged,
> this, ::destroyedChanged);
> 
> 
> connect(applet(), ::Applet::titleChanged,
> this, ::titleChanged);
> 
> connect(applet(), ::Applet::iconChanged,
> this, ::iconChanged);
> 
> connect(applet(), ::Applet::busyChanged,
> this, ::busyChanged);
> 
> connect(appletScript(), ::formFactorChanged,
> this, ::formFactorChanged);
> connect(appletScript(), ::locationChanged,
> this, ::locationChanged);
> connect(appletScript(), ::contextChanged,
> this, ::contextChanged);
> 
> if (applet()->containment()) {
> connect(applet()->containment(), ::Containment::screenChanged,
> this, ::screenChanged);
> }
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128185: Ensure extraction location to be in subfolder


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/#review96479
---




src/karchive.cpp (line 883)


This test doesn't depend on the current file, so it should be done before 
the for() loop - and if it adjusts curDirName to be destDir (when it would 
otherwise be outside), this will also fix the other code path (symlink 
creation).


- David Faure


On June 14, 2016, 2:01 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128185/
> ---
> 
> (Updated June 14, 2016, 2:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Behavior change: Switch to Tar's default behavior to avoid extraction
> to arbitrary system locations outside of extraction folder. Instead,
> extract such files to root location in extraction folder.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.h 4b7ecff66c9db54239bb2f82cdf0b96e901880ca 
>   autotests/karchivetest.cpp c8abddfc370a283c56766e5a437f3ba69c575563 
>   src/karchive.cpp 5a7cfc6c92d74c77157dd3fd829eb9b98a90936e 
> 
> Diff: https://git.reviewboard.kde.org/r/128185/diff/
> 
> 
> Testing
> ---
> 
> See added unit test
> 
> 
> File Attachments
> 
> 
> test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 84 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 14:04:40 +
Build duration: 5 min 40 sec

CHANGE SET
Revision a3c36e4396522003fd466805c19c51693cd1576d by David Faure: (kio_ftp: 
port to categorized logging, so users can enable debug output)
  change: edit src/ioslaves/ftp/ftp.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26730/50633 
(53%)CONDITIONAL 14883/37413 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7518/7837 
(96%)CONDITIONAL 4164/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7668/14041 
(55%)CONDITIONAL 4141/8907 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2268/7565 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10604 
(25%)CONDITIONAL 1309/6802 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128185: Ensure extraction location to be in subfolder


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/
---

(Updated Juni 14, 2016, 2:01 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
---

added binary test file


Repository: karchive


Description
---

Behavior change: Switch to Tar's default behavior to avoid extraction
to arbitrary system locations outside of extraction folder. Instead,
extract such files to root location in extraction folder.


Diffs
-

  autotests/karchivetest.h 4b7ecff66c9db54239bb2f82cdf0b96e901880ca 
  autotests/karchivetest.cpp c8abddfc370a283c56766e5a437f3ba69c575563 
  src/karchive.cpp 5a7cfc6c92d74c77157dd3fd829eb9b98a90936e 

Diff: https://git.reviewboard.kde.org/r/128185/diff/


Testing
---

See added unit test


File Attachments (updated)


test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128185: Ensure extraction location to be in subfolder


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/
---

Review request for KDE Frameworks and David Faure.


Repository: karchive


Description
---

Behavior change: Switch to Tar's default behavior to avoid extraction
to arbitrary system locations outside of extraction folder. Instead,
extract such files to root location in extraction folder.


Diffs
-

  autotests/karchivetest.h 4b7ecff66c9db54239bb2f82cdf0b96e901880ca 
  autotests/karchivetest.cpp c8abddfc370a283c56766e5a437f3ba69c575563 
  src/karchive.cpp 5a7cfc6c92d74c77157dd3fd829eb9b98a90936e 

Diff: https://git.reviewboard.kde.org/r/128185/diff/


Testing
---

See added unit test


Thanks,

Andreas Cord-Landwehr

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128181: Remove a lot of duplication between both AppletInterface constructors

2016-06-14 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128181/#review96467
---




src/scriptengines/qml/plasmoid/appletinterface.cpp (line 67)


So, this connect and below must be removed? Same connections in newly 
setupConnections


- Anthony Fieroni


On Юни 14, 2016, 12:03 след обяд, David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128181/
> ---
> 
> (Updated Юни 14, 2016, 12:03 след обяд)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Also the two were slightly out of sync leading to some connections not
> being in each constructor.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 
> 6a64594cd53cecfbc99ad7562706e1a78d60c138 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 
> df2d642445bdcc81d7fed463cb38c337380ea25b 
> 
> Diff: https://git.reviewboard.kde.org/r/128181/diff/
> 
> 
> Testing
> ---
> 
> previous code.
> 
> 
> FIRST CTOR ONLY  (normal mode)
> connect(applet(), ::Applet::contextualActionsAboutToShow,
> this, ::contextualActionsAboutToShow);
> 
> connect(applet(), ::Applet::activated,
> this, ::activated);
> 
> 
> connect(this, ::expandedChanged, [=](bool expanded) {
> //if both compactRepresentationItem and fullRepresentationItem exist,
> //the applet is in a popup
> if (expanded) {
> if (compactRepresentationItem() && fullRepresentationItem() &&
> fullRepresentationItem()->window() && 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->window() != 
> compactRepresentationItem()->window() &&
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->installEventFilter(this);
> } else if (fullRepresentationItem() && 
> fullRepresentationItem()->parentItem()) {
> 
> fullRepresentationItem()->parentItem()->removeEventFilter(this);
> }
> }
> });
> }
> 
> SECOND CTOR ONLY (special comic applet path)
> 
> connect(applet(), ::Applet::configurationRequiredChanged,
> this, [this](bool needsConfig, const QString ) {
> emit configurationRequiredChanged();
> emit configurationRequiredReasonChanged();
> });
> 
> }
> 
> DUPLICATED:
> qmlRegisterType();
> 
> connect(this, ::configNeedsSaving,
> applet(), ::Applet::configNeedsSaving);
> connect(applet(), ::Applet::immutabilityChanged,
> this, ::immutabilityChanged);
> 
> connect(applet(), ::Applet::userConfiguringChanged,
> this, ::userConfiguringChanged);
> 
> connect(applet(), ::Applet::statusChanged,
> this, ::statusChanged);
> 
> connect(applet(), ::Applet::destroyedChanged,
> this, ::destroyedChanged);
> 
> 
> connect(applet(), ::Applet::titleChanged,
> this, ::titleChanged);
> 
> connect(applet(), ::Applet::iconChanged,
> this, ::iconChanged);
> 
> connect(applet(), ::Applet::busyChanged,
> this, ::busyChanged);
> 
> connect(appletScript(), ::formFactorChanged,
> this, ::formFactorChanged);
> connect(appletScript(), ::locationChanged,
> this, ::locationChanged);
> connect(appletScript(), ::contextChanged,
> this, ::contextChanged);
> 
> if (applet()->containment()) {
> connect(applet()->containment(), ::Containment::screenChanged,
> this, ::screenChanged);
> }
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Differential] [Updated] D1863: Remove the first attempt to load library because we will try libraryPaths anyway

aspotashev added a reviewer: Frameworks.

REVISION DETAIL
  https://phabricator.kde.org/D1863

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, #frameworks
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Differential] [Updated, 2,392 lines] D1862: Various minor cleanups in Kross

aspotashev updated this revision to Diff .
aspotashev added a comment.


  rebased on top of https://phabricator.kde.org/D1861

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1862?vs=4443=

BRANCH
  cleanups-1

REVISION DETAIL
  https://phabricator.kde.org/D1862

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/main.cpp
  autotests/testguiform.py
  autotests/testguiqt.py
  autotests/testguitk.py
  autotests/testkross.py
  autotests/testobject.cpp
  autotests/testobject.h
  autotests/unittest.es
  autotests/unittest.py
  autotests/unittest.rb
  src/CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/manager.cpp
  src/ui/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, #frameworks
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 95 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 10:35:55 +
Build duration: 4.4 sec

CHANGE SET
Revision 7fa24e1f1cc71bcfd4a38b30dd43b91906a6dd58 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/kioslaves/kded/baloosearchmodule.desktop
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 86 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/86/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 10:33:22 +
Build duration: 4.4 sec

CHANGE SET
Revision 1c72619f09624db3da83e2e2d0fc43f3e1c5c736 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/runner/%{APPNAMELC}.desktop
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: krunner master stable-kf5-qt5 » Linux,gcc - Build # 83 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/krunner%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 14 Jun 2016 10:33:22 +
Build duration: 3.8 sec

CHANGE SET
Revision 1c72619f09624db3da83e2e2d0fc43f3e1c5c736 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/runner/%{APPNAMELC}.desktop
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: The return of ASAN issues

2016-06-14 Thread Ben Cooksley

On Mon, Jun 13, 2016 at 6:25 AM, Albert Astals Cid  wrote:
> El dimarts, 31 de maig de 2016, a les 18:49:29 CEST, Ben Cooksley va escriure:
>> On Tue, May 31, 2016 at 9:36 AM, Albert Astals Cid  wrote:
>> > El dilluns, 30 de maig de 2016, a les 19:42:38 CEST, Ben Cooksley va
> escriure:
>> >> Hi all,
>> >>
>> >> As you may recall, some time ago the CI scripts were adapted to
>> >> forcibly inject ASAN into all test processes launched on the CI system
>> >> to fix Marble's tests, as Marble does not use ECM and thus does not
>> >> enable ASAN as a result.
>> >>
>> >> Unfortunately this has bad effects with certain processes,
>> >> particularly Java based ones. This causes the tests of other projects
>> >> to fail as a result with segmentation faults, as they're incompatible
>> >> with forced ASAN injection - they have to actually be built with ASAN
>> >> for it to work.
>> >>
>> >> Can someone please investigate another solution?
>> >
>> > I know it's a workaround, but given Marble is a bit of an unique snowflake
>> > in that it doesn't want to use ECM because it adds 0.3MB of dependencies,
>> > can't we just apply the LD_PRELOAD workaround on the "marble" job level
>> > (afaik we can do those things)?
>>
>> With a maintenance cost. But yes, it could be done.
>
> A very low maitenance cost IMHO compared to your suggestion, half proof is
> that you got someone that volunteered to implement my suggestion (me and i
> think Friedrich volunteered for something similar) while noone volunteered to
> play with the cmake files.
>
> As I see it what you're asking for is more correct but has a much bigger
> coding cost and the solution to applying the workaround only to marble is
> probably a 5 minute change that alls us to move forward.

Let's hope this isn't a slippery slope. Special cases have a nasty
habit of accumulating.
I've implemented this now. In the event other projects need this sort
of treatment for $whateverReason we'll need to revisit doing this
properly in some form or another.

>
> Cheers,
>   Albert

Regards,
Ben

>
>>
>> > What you suggest would be superb correct-ness wise but it doesn't seem the
>> > more effort/result solution.
>>
>> It would also fix anyone who has compiled Frameworks with ASAN and
>> needs to use a build system from elsewhere which does not use ECM
>> (Such as QMake for instance, although why you'd use ASAN in Frameworks
>> and not your app is another thing altogether of course)
>>
>> > Cheers,
>> >
>> >   Albert
>>
>> Regards,
>> Ben
>>
>> >> As ASAN is contagious, I would suggest that any Framework which is
>> >> compiled using ASAN have adjustments made to it's *Config.cmake files
>> >> to ensure linking for any binary/library built with it is setup
>> >> properly. I've no idea how complicated that is to setup though.
>> >>
>> >> This would fix Marble's tests while allowing Skrooge's tests that
>> >> depend on Java to be unaffected (and I considered the original fix to
>> >> inject ASAN a bit hackish, so i'm not surprised it's had casualties)
>> >>
>> >> Cheers,
>> >> Ben
>> >> ___
>> >> Kde-frameworks-devel mailing list
>> >> Kde-frameworks-devel@kde.org
>> >> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>>
>> ___
>> Kde-frameworks-devel mailing list
>> Kde-frameworks-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[Differential] [Updated] D1861: Fix name of QDialogButtonBox's enumerator "StandardButtons"

aspotashev added a reviewer: Frameworks.

REVISION DETAIL
  https://phabricator.kde.org/D1861

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, #frameworks
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless