Re: Review Request 127813: Reduce string modifications when calling translatePath

2016-07-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- (Updated July 13, 2016, 12:37 a.m.) Status -- This change has been

Re: QIcon::fromTheme() does not load scalable icons

2016-07-12 Thread Antonio Rojas
Olivier Churlaud wrote: > > Can you point me to the right place where to open the bug? > Already fixed in http://commits.kde.org/kiconthemes/0abf1b7a148cf6b27caea01a329631e0f1daa983 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

[Differential] [Closed] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk closed this revision. kfunk added a comment. Pushed. commit 2bdb684a872aff26c01f5e1fc175fbaf663ad8ba Author: Kevin Funk Date: Tue Jul 12 10:18:40 2016 +0200 REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES

[Differential] [Accepted] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added a comment. Looks good to me. I don't think we have the need to use the singleton from other global destructors. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES

Re: QIcon::fromTheme() does not load scalable icons

2016-07-12 Thread Olivier Churlaud
Le 12/07/2016 à 15:54, Elvis Angelaccio a écrit : For some time I was debugging why TeXstudio didn't have an icon in the task manager. After comparing, the only difference with working apps was that TeXStudio has only an icon in /usr/share/icons/hicolor/scalable/apps/texstudio.svg but not in

Re: QIcon::fromTheme() does not load scalable icons

2016-07-12 Thread Elvis Angelaccio
2016-07-12 15:47 GMT+02:00 Olivier Churlaud : > Hello Hi > > For some time I was debugging why TeXstudio didn't have an icon in the task > manager. After comparing, the only difference with working apps was that > TeXStudio has only an icon in > >

QIcon::fromTheme() does not load scalable icons

2016-07-12 Thread Olivier Churlaud
Hello For some time I was debugging why TeXstudio didn't have an icon in the task manager. After comparing, the only difference with working apps was that TeXStudio has only an icon in /usr/share/icons/hicolor/scalable/apps/texstudio.svg but not in

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-12 Thread Martin Gräßlin
> On July 12, 2016, 8:07 a.m., Martin Gräßlin wrote: > > What about shader variants for GLES? There are also two versions, one being > > like the old one and one like core. In KWin we can handle this with the > > same shader code and rewriting e.g. the version statement. Do you know how > >

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-12 Thread David Edmundson
> On July 12, 2016, 6:07 a.m., Martin Gräßlin wrote: > > What about shader variants for GLES? There are also two versions, one being > > like the old one and one like core. In KWin we can handle this with the > > same shader code and rewriting e.g. the version statement. Do you know how > >

[Differential] [Commented On] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added a comment. FYI: There are more issues in other frameworks, the next deadlock is in kiconthemes... BRANCH master REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth,

[Differential] [Commented On] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added a comment. Waiting for a +1 from David. There's one possible point of regression, namely if `KGlobalAccel::self()` is being used after qApp ran all the post routines (and `KGlobalAccelPrivate::cleanup()` has been invoked already). Not sure if this is a problem, though.

[Differential] [Accepted] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. nice one. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES

[Differential] [Updated] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added reviewers: dfaure, vonreth. kfunk added a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

Review Request 128428: KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

2016-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128428/ --- Review request for KDE Frameworks, Laurent Montel and Stephen Kelly.

Re: Review Request 128397: KIconEngine: Fix QIcon::hasThemeIcon always returning true

2016-07-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/ --- (Updated July 12, 2016, 12:55 a.m.) Status -- This change has been

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

2016-07-12 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97303 --- Works here, thanks - Antonio Rojas On Jul. 12, 2016,

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2016-07-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/#review97302 --- What about shader variants for GLES? There are also two