Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review97581 --- Except the trailing spaces that are here and there, I didn't

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated July 18, 2016, 9:55 p.m.) Review request for KDE Frameworks and

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128477/#review97577 --- Ship it! Wow, it never occured to me that someone might

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 2:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128477/ --- Review request for KDE Frameworks and Gleb Popov. Repository: kio

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Review Request 128476: Add scrollbars to kcm started without systemsettings5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128476/ --- Review request for KDE Frameworks and Kai Uwe Broulik. Bugs: 360260

Jenkins-kde-ci: kguiaddons master kf5-qt5 » Linux,gcc - Build # 36 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kguiaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 13:09:58 + Build duration: 2 hr 0 min CHANGE SET No changes

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 75 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/75/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 14:09:55 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 137 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 14:02:29 + Build duration: 1 min 15 sec CHANGE SET No changes

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 74 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 13:37:15 + Build duration: 4 min 24 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Jenkins-kde-ci: kdesu master stable-kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesu%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 13:37:15 + Build duration: 38 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kdesu master stable-kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesu%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 13:37:15 + Build duration: 38 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- (Updated July 18, 2016, 1:48 p.m.) Status -- This change has been

Re: Review Request 128464: Allow scrolling in config windows for small screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- (Updated July 18, 2016, 3:46 p.m.) Review request for KDE Frameworks and

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 71 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 13:20:17 + Build duration: 1 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 71 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/71/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 13:17:41 + Build duration: 1 min 2 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/ --- (Updated July 18, 2016, 1:08 p.m.) Status -- This change has been

Jenkins-kde-ci: kdesu master stable-kf5-qt5 » Linux,gcc - Build # 50 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdesu%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 10:54:07 + Build duration: 2 hr 1 min CHANGE SET No changes

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 85 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 12:50:23 + Build duration: 3 min 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 105 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/105/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 18 Jul 2016 12:48:51 + Build duration: 6 min 23 sec CHANGE SET

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 85 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 12:50:23 + Build duration: 3 min 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 105 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/105/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 18 Jul 2016 12:48:51 + Build duration: 2 min 38 sec CHANGE

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On Juli 18, 2016, 12:05 nachm., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/#review97521 --- Please don't ship it, yet. I find the UI illogical.

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 73 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 10:54:07 + Build duration: 4 min 21 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 70 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 10:41:30 + Build duration: 1 min 20 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 70 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 10:32:39 + Build duration: 1 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 128174: Update AppStream data location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128174/ --- (Updated July 18, 2016, 10:23 a.m.) Status -- This change has been

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 74 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 09:52:00 + Build duration: 13 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 74 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 09:52:00 + Build duration: 13 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 72 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 09:52:00 + Build duration: 3 min 41 sec CHANGE SET Revision

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 69 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 07:54:53 + Build duration: 1 min 43 sec CHANGE SET Revision

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 69 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 18 Jul 2016 07:54:53 + Build duration: 1 min 0 sec CHANGE SET Revision

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

> On July 17, 2016, 10:04 p.m., Mark Gaiser wrote: > > src/kiconloader.cpp, lines 1714-1715 > > > > > > .constFind() > > .constEnd() Haha yes I wrote non-const find/end on purpose because of the erase(it)

Re: Review Request 128465: KIconLoader: massive speed improvement for loading unavailable icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128465/ --- (Updated July 18, 2016, 7:54 a.m.) Status -- This change has been