Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/#review97685 --- I tried writing a small test for it, and it seemed like I

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 76 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 04:17:30 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 76 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 04:17:30 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS

Review Request 128492: [kio] Minor typo in file ioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128492/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 138 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/138/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:46:54 + Build duration: 39 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 138 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/138/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:46:54 + Build duration: 39 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 137 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:19:00 + Build duration: 1 min 21 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 138 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/138/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:02:50 + Build duration: 5 min 39 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 138 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/138/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:02:50 + Build duration: 5 min 39 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 21 Jul 2016 01:35:53 + Build duration: 9 min 58 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 21 Jul 2016 01:35:53 + Build duration: 9 min 58 sec CHANGE SET No

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:49:57 + Build duration: 3 min 10 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:49:57 + Build duration: 3 min 10 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 21 Jul 2016 01:35:53 + Build duration: 2 min 27 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 21 Jul 2016 01:35:53 + Build duration: 2 min 27 sec CHANGE SET No

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 176 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:34:25 + Build duration: 3 min 45 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 176 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:34:25 + Build duration: 3 min 45 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 85 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 23:37:44 + Build duration: 3 min 28 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 175 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/175/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 22:25:33 + Build duration: 16 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 174 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 21:55:12 + Build duration: 27 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 108 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/108/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 20 Jul 2016 15:05:46 + Build duration: 5 min 29 sec CHANGE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 106 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/106/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 20 Jul 2016 15:05:46 + Build duration: 37 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 106 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/106/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 20 Jul 2016 15:05:46 + Build duration: 47 sec CHANGE SET Revision

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 18 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 14:59:56 + Build duration: 1 min 21 sec CHANGE SET Revision

Re: Review Request 128476: Add scrollbars to kcm started without systemsettings5

> On July 20, 2016, 4:20 p.m., David Edmundson wrote: > > This affects the initial size of the showed screen, that needs fixing. > > Previously it showed the entire KCM, now it won't. yes it's written in the description, I would need help for this actually. The good point is that now, I can

Re: Review Request 128476: Add scrollbars to kcm started without systemsettings5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128476/#review97667 --- This affects the initial size of the showed screen, that

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97665 --- +1 It may still scare people, but I think it's a good

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

> On July 20, 2016, 3:48 p.m., Thomas Pfeiffer wrote: > > +1 > > It may still scare people, but I think it's a good compromise. If we get bad feedback , it can be reverted. But I think we won't - Olivier --- This is an automatically

Re: Review Request 120904: [KCharSelect] Handle characters outside BMP

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/ --- (Updated July 20, 2016, 1:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

> On July 16, 2016, 12:30 p.m., Elvis Angelaccio wrote: > > Ping? > > > > (String freeze for frameworks is next Saturday, right?) I would say: replace the [copy] button by a select on click. and then ship it - Olivier --- This is an

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97664 --- Ship it! Ship It! - Olivier Churlaud On July 20, 2016,

Re: Review Request 128466: Rename Checksums tab to Integrity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128466/ --- (Updated July 20, 2016, 1:02 p.m.) Status -- This change has been

Review Request 128490: Checksums tab: replace groupbox with vertical separator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/ --- Review request for KDE Frameworks and KDE Usability. Repository: kio

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 105 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/105/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 20 Jul 2016 12:44:15 + Build duration: 6 min 42 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 20 Jul 2016 12:44:15 + Build duration: 5 min 0 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 20 Jul 2016 12:44:15 + Build duration: 5 min 0 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 20 Jul 2016 12:44:15 + Build duration: 2 min 18 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 107 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/107/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 20 Jul 2016 12:44:15 + Build duration: 2 min 18 sec CHANGE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 105 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/105/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 20 Jul 2016 12:44:15 + Build duration: 32 sec CHANGE SET Revision

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated July 20, 2016, 1:06 p.m.) Status -- This change has been

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/ --- Review request for Extra Cmake Modules, KDE Frameworks and David Faure.

[sysadmin/ci-master-config] /: Change the versions of Qt 5 used on the CI system.

Git commit 0b3511e4c66cce6206b04294c504cfbf93ae7056 by Ben Cooksley. Committed on 20/07/2016 at 07:58. Pushed by bcooksley into branch 'master'. Change the versions of Qt 5 used on the CI system. As Qt's compatibility between versions usually breaks on the CI, expect many things to break until

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

> On July 19, 2016, 5:29 p.m., David Faure wrote: > > src/filewidgets/knewfilemenu.cpp, line 789 > > > > > > The QFile::exists check is redundant. QFile::remove will do nothing if > > the file doesn't exist. >

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 20, 2016, 7:09 a.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 149 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 06:34:14 + Build duration: 1 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 149 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 06:34:14 + Build duration: 1 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 148 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 06:30:32 + Build duration: 2 min 22 sec CHANGE SET Revision

Re: Review Request 128466: Rename Checksums tab to Integrity

> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

> On July 18, 2016, 11:30 p.m., David Faure wrote: > > Wow, it never occured to me that someone might run this test as root. I > > thought it was well known that development should not be done as root ;) > > But I can see how it might happen when creating packages with unittests > > enabled or