Review Request 128660: Add an optional reveal password button to TextField
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Similar to KPasswordWidget in kwidgetaddons Diffs - src/declarativeimports/plasmacomponents/qml/TextField.qml c0d9155df5bb584cd3070a66c99d98465b81a5ef src/declarativeimports/plasmastyle/TextFieldStyle.qml 05ff3d542ad0de6879ec1de832b5e5d9ed33281e tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 Diff: https://git.reviewboard.kde.org/r/128660/diff/ Testing --- Updated manual test. See screenshot. File Attachments Spectacle.B12253.png https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png Thanks, David Edmundson
Re: Review Request 128638: Move kwallet-query docbook to correct subdir
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128638/ --- (Updated Aug. 11, 2016, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Localization and Translation (l10n) and David Faure. Changes --- Submitted with commit 0b8e243efe73fffd1a7c018e24368170d0f9a11d by Burkhard Lück to branch master. Repository: kwallet Description --- move docbook into subdit with matching name in l10n subdir + adapt docs/CMakeLists.txt Rationale: The Translated docbooks in this frameworks are missing in the tarball, see https://todo.kde.org/?controller=task=show_id=520 To find out which subdir of docs/frameworks subdir it should grab translated docs from, the frameworks release script uses the name of the subdir in the sources. On the other hand the script autogen.sh in l10n-kf5/scripts generates the CMakeLists.txt files with the correct install paths/names for the language docbooks using the dirnames in l10n/[lang]/documentation. Diffs - docs/CMakeLists.txt c4ef9c7 docs/kwallet-query/CMakeLists.txt PRE-CREATION docs/kwallet-query/man-kwallet-query.1.docbook PRE-CREATION docs/kwallet-query/using.adoc PRE-CREATION docs/man-kwallet-query.1.docbook eed6e43 docs/using.adoc e2e01e4 Diff: https://git.reviewboard.kde.org/r/128638/diff/ Testing --- builds and installs the manpage to the same dir as before Thanks, Burkhard Lück
Re: Review Request 128652: Fix wording an -> one
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128652/ --- (Updated Aug. 11, 2016, 4:27 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, KDE Utils, Ragnar Thomsen, and Valentin Rusu. Changes --- Submitted with commit 7cc97c7f0b3ee4359175ae21d135d6e8f6dd5367 by Burkhard Lück to branch master. Repository: kwallet Description --- Change "Please set-up at least an encryption key" to "Please set-up at least one encryption key" as requested in RR https://git.reviewboard.kde.org/r/128378/ Diffs - src/runtime/kwalletd/knewwalletdialog.cpp f0c1b36 Diff: https://git.reviewboard.kde.org/r/128652/diff/ Testing --- builds Thanks, Burkhard Lück
Re: Review Request 128656: [solid/backends/udev] Fix reading MPI values
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128656/#review98312 --- Actually, it would only fail, if there is a '<' symbol in the parsed line... - Christoph Feck On Aug. 11, 2016, 11:44 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128656/ > --- > > (Updated Aug. 11, 2016, 11:44 a.m.) > > > Review request for KDE Frameworks. > > > Repository: solid > > > Description > --- > > Because of misplaced parenthesis, the parsing fails. > > > Diffs > - > > src/solid/devices/backends/udev/udevportablemediaplayer.cpp 907051c > > Diff: https://git.reviewboard.kde.org/r/128656/diff/ > > > Testing > --- > > Only compilation tested. > > > Thanks, > > Christoph Feck > >
Review Request 128656: [solid/backends/udev] Fix reading MPI values
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128656/ --- Review request for KDE Frameworks. Repository: solid Description --- Because of misplaced parenthesis, the parsing fails. Diffs - src/solid/devices/backends/udev/udevportablemediaplayer.cpp 907051c Diff: https://git.reviewboard.kde.org/r/128656/diff/ Testing --- Only compilation tested. Thanks, Christoph Feck
