Re: Review Request 128675: KUrlRequester: fix error box when selecting a file and reopening the file dialog.

2016-09-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128675/ --- (Updated Sept. 4, 2016, 9:53 p.m.) Status -- This change has been

Re: Autocorrection in framework

2016-09-04 Thread Martin Sandsmark
Hello! On Thu, Sep 01, 2016 at 11:04:47PM +0200, David Faure wrote: > Right, putting the autocorrect feature in sonnet looks like a good idea to me. > But ultimately it's up to the sonnet maintainer --> cc'ing Martin Sandsmark. I'm not opposed to putting it into Sonnet, but I don't have time to

Re: Review Request 128831: Check whether wallet is enabled in KWallet::isOpen()

2016-09-04 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128831/ --- (Updated Sept. 4, 2016, 11:20 nachm.) Review request for KDE Frameworks.

Review Request 128831: Check whether wallet is enabled in KWallet::isOpen()

2016-09-04 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128831/ --- Review request for KDE Frameworks. Bugs: 358260

Re: Review Request 128790: Call utempter manually

2016-09-04 Thread Thiago Macieira
> On Sept. 4, 2016, 2:13 p.m., Thiago Macieira wrote: > > What happens if one builds on a machine without utempter? Are we still linking to libutempter? - Thiago --- This is an automatically generated e-mail. To reply, visit:

Re: Autocorrection in framework

2016-09-04 Thread laurent Montel
Le dimanche 4 septembre 2016, 15:39:43 CEST Martin Sandsmark a écrit : > Hello! > > On Thu, Sep 01, 2016 at 11:04:47PM +0200, David Faure wrote: > > Right, putting the autocorrect feature in sonnet looks like a good idea to > > me. But ultimately it's up to the sonnet maintainer --> cc'ing Martin

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-09-04 Thread kfunk (Kevin Funk)
kfunk added a comment. Here's the backtrace (note: using Qt 5.6 branch): ntdll.dll!NtWaitForSingleObject() Unknown KernelBase.dll!7ffbcb2eaadf() Unknown > Qt5Core.dll!QWaitCondition::wait(QMutex * mutex=0x01c24fd16520, unsigned long

Re: Review Request 128790: Call utempter manually

2016-09-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128790/ --- (Updated Sept. 4, 2016, 10:20 a.m.) Review request for KDE Frameworks,