C++11 & friends
Hi all, I just saw a commit by Volker turning nullptr into Q_NULLPTR with the comment that Visual Studio 2012 does not support nullptr. While this change is trivial for obvious reasons, do we really need to do that? I am raising this question especially since KTextEditor seems to use 'nullptr' in several locations now for several releases - and noone complained. Are we supposed to turn nullptr in KTextEditor also into nullptr, or can we take the liberty and ditch Q_NULLPTR completely for all frameworks? Same also applies to 'override'. Best, Dominik
Re: Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- (Updated Sept. 10, 2016, 10:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit c784a879eaba0babc6274bc32e761772add3d4f8 by Antonio Rojas to branch master. Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole. Diffs - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas
Re: baloo + out-of-memory in file extractor
Hi, > Hi Christoph, > > On 10 September 2016 at 23:46, Christoph Cullmann wrote: Would it be a good idea to restrict the file extractor process to some >>> fixed amount of memory to use via setrlimit? (or more fancy stuff?) >>> >>> That would probably just make Baloo crash, so fixing the bug is probably >>> the better option. >> Actually, that we don't limit the resources + sandbox baloo_file_indexer is >> the >> bug, >> not that some meta info extractor is buggy (which should be fixed, too). >> >> ATM, the state is: >> >> 1) baloo is on per default >> 2) it will index at least your home >> 3) if it encounters any "bad" file, it will OOM you, in my case in a way >> that a normal user is doomed, as 1-2 seconds after login the machine is >> already >> halted. >> >> Given that e.g. your "Downloads" might even contain "evil" files from the >> net, >> at least some resource limit would be good and even better some sandbox, to >> avoid that >> the indexer which is easily pwn'd pwn's your session. > > You've got a point there. In that case, what I'd do is: > > 1) Limit resources on baloo_file_extractor. > 2) Try to detect if it crashes because it exceeded limits, not sure if > this is easily possible. > 3) Mark files causing such crashes as files that should be skipped, > and the user notified somehow (?). I think just mark any files as "skipped for the future" for which the indexer crashs. (if by hinting resource limit or just other index fail doesn't really matter, IMHO, beside that it perhaps should be logged somewhere) Other problem: after indexer crash, the DB is corrupted or locked. It seems one not really does any proper lmdb locking, baloo_file even just kills the lockfile on startup. > >> Beside that, a real other problem is, that baloo has close to zero error >> handling for its >> database, once one error happens, all further things will go down and never >> recover. >> >> e.g. one time balooctl wrongly use => goodbye >> https://bugs.kde.org/show_bug.cgi?id=368557 >> >> Interesting too: We use lmdb, which means, we memory map always, aka 32-bit >> machines will >> be out of memory if you have large indices like > 2GB :/ > > Nah, 32bit machines should have PAE. If they don't... I'm not willing > to make fundamental changes to how indexes are kept to support edge > cases like this. Disabling Baloo automatically if you detect machines > with a 32-bit address space is the way to go. PAE doesn't help there at all. (it only helps that your system can use more than 3/4GB, not one application) If you use lmdb, and lets say the file is 2GB, your applications 4GB of virtual spaces is halfed (and even more, as some parts are anyways used otherwise). Beside, other issue: ATM the index is fixed to max 5GB, after that, all things will fail, see bug https://bugs.kde.org/show_bug.cgi?id=364475, as I have seen index sizes > 2 GB, that will hit people, too. We should increase that limit IMHO and out-of-space should be handled at all I guess. > > I'd still wait for Pinak to comment on all of the above though. Sure. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/#review99061 --- Ship it! Ship It! - David Faure On Sept. 10, 2016, 7:15 p.m., Antonio Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128882/ > --- > > (Updated Sept. 10, 2016, 7:15 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > Launching .desktop files which have Terminal=true currently fails, because > kio adds to the konsole command the obsolete KDE4 command line options, which > are not recognized by the KF5 konsole. > > > Diffs > - > > src/core/desktopexecparser.cpp c526da7 > > Diff: https://git.reviewboard.kde.org/r/128882/diff/ > > > Testing > --- > > .desktop files with Terminal=true can be launched again from the Plasma menu > and with kioclient5 exec. > > > Thanks, > > Antonio Rojas > >
Re: Review Request/New Framework: KF5::SyntaxHighlighting
Hi, On 11/09/16 01:47, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) Thanks a lot for working on this. I noticed that KF5SyntaxHighlightingConfig.cmake.in searches for Qt5Widgets, but that doesn't seem to used in any public part of the framework (only tests). Also, some tests are failing here. Best regards, Michael
baloo + out-of-memory in file extractor
Hi Christoph, On 10 September 2016 at 23:46, Christoph Cullmann wrote: >>> Would it be a good idea to restrict the file extractor process to some >> fixed amount of memory >>> to use via setrlimit? (or more fancy stuff?) >> >> That would probably just make Baloo crash, so fixing the bug is probably >> the better option. > Actually, that we don't limit the resources + sandbox baloo_file_indexer is > the bug, > not that some meta info extractor is buggy (which should be fixed, too). > > ATM, the state is: > > 1) baloo is on per default > 2) it will index at least your home > 3) if it encounters any "bad" file, it will OOM you, in my case in a way > that a normal user is doomed, as 1-2 seconds after login the machine is > already halted. > > Given that e.g. your "Downloads" might even contain "evil" files from the net, > at least some resource limit would be good and even better some sandbox, to > avoid that > the indexer which is easily pwn'd pwn's your session. You've got a point there. In that case, what I'd do is: 1) Limit resources on baloo_file_extractor. 2) Try to detect if it crashes because it exceeded limits, not sure if this is easily possible. 3) Mark files causing such crashes as files that should be skipped, and the user notified somehow (?). > Beside that, a real other problem is, that baloo has close to zero error > handling for its > database, once one error happens, all further things will go down and never > recover. > > e.g. one time balooctl wrongly use => goodbye > https://bugs.kde.org/show_bug.cgi?id=368557 > > Interesting too: We use lmdb, which means, we memory map always, aka 32-bit > machines will > be out of memory if you have large indices like > 2GB :/ Nah, 32bit machines should have PAE. If they don't... I'm not willing to make fundamental changes to how indexes are kept to support edge cases like this. Disabling Baloo automatically if you detect machines with a 32-bit address space is the way to go. I'd still wait for Pinak to comment on all of the above though. > I would like to help out with fixing this issues, but I think first some > consensus would be needed > how we want to go on with that. -- Boudhayan
Re: Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- (Updated Sept. 10, 2016, 7:15 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Leave %i alone, --icon still works in qt5 Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole. Diffs (updated) - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas
Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole. Diffs - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas
Re: Review Request/New Framework: KF5::SyntaxHighlighting
Hi, will take a look at the API that is exposed for this first version, too. Thanks already for stepping up to "framework" your pet project, this might avoid that we end up with "just one more" highlighting implementation and perhaps even QtCreator can somewhen use (aka copy) this one to have the same state ;=) KTextEditor migration to the library will take a bit, thought, as Volker stated, first only syntax definition files + lookup would be migrated. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: baloo + out-of-memory in file extractor (warning about the .mp3)
Hi, >> If you can consistently repro this, running under valgrind to check for >> leaks will also go a long way. > > https://github.com/taglib/taglib/blob/master/tests/data/toc_many_children.mp3 => Just as a warning: if you download that raw and have baloo indexing on, you are pwn'd ;=) Turn indexing off or download to some non-indexed dir. At least on current archlinux you OOM else in some seconds. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: baloo + out-of-memory in file extractor
Hi, > Hi, > > On 10 Sep 2016 19:42, "Christoph Cullmann" wrote: >> >> Hi, >> >> during the last night of the akademy for me in Berlin, baloo file > extractor OOM'd my notebook >> during extracting the tag info of the taglib unit test test-files. > > Is it possible to reproduce the issue and get a stack trace? > > If you can consistently repro this, running under valgrind to check for > leaks will also go a long way. https://github.com/taglib/taglib/blob/master/tests/data/toc_many_children.mp3 => I guess it is even because of that a regression test ;=) Perhaps my taglib is too old, in any case, see the answer below, fixing this is nice, but not the solution. > >> >> Would it be a good idea to restrict the file extractor process to some > fixed amount of memory >> to use via setrlimit? (or more fancy stuff?) > > That would probably just make Baloo crash, so fixing the bug is probably > the better option. Actually, that we don't limit the resources + sandbox baloo_file_indexer is the bug, not that some meta info extractor is buggy (which should be fixed, too). ATM, the state is: 1) baloo is on per default 2) it will index at least your home 3) if it encounters any "bad" file, it will OOM you, in my case in a way that a normal user is doomed, as 1-2 seconds after login the machine is already halted. Given that e.g. your "Downloads" might even contain "evil" files from the net, at least some resource limit would be good and even better some sandbox, to avoid that the indexer which is easily pwn'd pwn's your session. Beside that, a real other problem is, that baloo has close to zero error handling for its database, once one error happens, all further things will go down and never recover. e.g. one time balooctl wrongly use => goodbye https://bugs.kde.org/show_bug.cgi?id=368557 Interesting too: We use lmdb, which means, we memory map always, aka 32-bit machines will be out of memory if you have large indices like > 2GB :/ I would like to help out with fixing this issues, but I think first some consensus would be needed how we want to go on with that. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Re: Review Request 128881: Remove outdated code snippet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128881/ --- (Updated Sept. 10, 2016, 6:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 6a753b9e227cc5519243af39724927212299a079 by Elvis Angelaccio to branch master. Repository: kio Description --- This seems to come from KDE3 times. I guess should be safe to remove... Diffs - src/filewidgets/kfilewidget.h bbbfd02 Diff: https://git.reviewboard.kde.org/r/128881/diff/ Testing --- Thanks, Elvis Angelaccio
Re: Review Request 128881: Remove outdated code snippet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128881/#review99057 --- Ship it! Ship It! - David Faure On Sept. 10, 2016, 5:38 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128881/ > --- > > (Updated Sept. 10, 2016, 5:38 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > This seems to come from KDE3 times. I guess should be safe to remove... > > > Diffs > - > > src/filewidgets/kfilewidget.h bbbfd02 > > Diff: https://git.reviewboard.kde.org/r/128881/diff/ > > > Testing > --- > > > Thanks, > > Elvis Angelaccio > >
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 210 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 17:33:22 + Build duration: 4 min 43 sec CHANGE SET Revision c1a9ef3cb1e085bfdc2e56164b609f65f4f2a60a by elvis.angelaccio: (Improve KNewFileMenu constructor apidox) change: edit src/filewidgets/knewfilemenu.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 51 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 263/341 (77%)CLASSES 263/341 (77%)LINE 27910/51273 (54%)CONDITIONAL 15544/38067 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7752/8075 (96%)CONDITIONAL 4344/8500 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7778/14141 (55%)CONDITIONAL 4248/9067 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2312/7579 (31%)CONDITIONAL 921/4405 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 (47%)CONDITIONAL 1258/3434 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/65 (48%)CLASSES 31/65 (48%)LINE 3450/10887 (32%)CONDITIONAL 1654/6902 (24%)
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 210 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 17:33:22 + Build duration: 4 min 43 sec CHANGE SET Revision c1a9ef3cb1e085bfdc2e56164b609f65f4f2a60a by elvis.angelaccio: (Improve KNewFileMenu constructor apidox) change: edit src/filewidgets/knewfilemenu.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 51 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 263/341 (77%)CLASSES 263/341 (77%)LINE 27910/51273 (54%)CONDITIONAL 15544/38067 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7752/8075 (96%)CONDITIONAL 4344/8500 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7778/14141 (55%)CONDITIONAL 4248/9067 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2312/7579 (31%)CONDITIONAL 921/4405 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 (47%)CONDITIONAL 1258/3434 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/65 (48%)CLASSES 31/65 (48%)LINE 3450/10887 (32%)CONDITIONAL 1654/6902 (24%)
Review Request 128881: Remove outdated code snippet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128881/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- This seems to come from KDE3 times. I guess should be safe to remove... Diffs - src/filewidgets/kfilewidget.h bbbfd02 Diff: https://git.reviewboard.kde.org/r/128881/diff/ Testing --- Thanks, Elvis Angelaccio
Re: Review Request/New Framework: KF5::SyntaxHighlighting
Hi Volker, thanks for this initiative! On Sat, Sep 10, 2016 at 5:47 PM, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) > > This is a tier1/functional version of the Kate syntax highlighting engine. > It's not tied to a particular output format or editor engine, the interface is > basically just passing in a line of text and getting back a set of formatting > instructions. A QSyntaxHighlighter and a HTML CLI highlighter are included, > for example. > > Use Cases > > - I initially started this for use in GammaRay's QRC browser (which can embed > into QtCreator, making using the KXmlGui-dependent Kate part problematic) > - It's already used in KDAB's internal QML-based training presentation tool > - Kate, obviously (see below) > - possibly replacing a few hand-written highlighters in KDE PIM (Sieve, > message source, diff attachments), and enabling inline attachment highlighting > - the Kate team apparently also had some demand for this in the past, e.g. for > use in CLI tools > > Relation to Kate > > I showed my work on this to the Kate team at Akademy, originally to get help > regarding some semantic corner cases in the highlighting files, however the > feedback I got was a plan to turn this into a framework, and a migration > strategy for Kate, therefore the recent activity into that direction :) > > The migration would happen in small steps, the first one being Kate switching > to use the syntax definition files from the new library, as well as the > indexing and meta data loading code. More features would follow in the > subsequent releases, together with making the corresponding API officially > public. Future steps might include syncing the format/theme settings, > determining which syntax to use for a given file, and of course the ultimately > switching the entire syntax highlighting related code over to the new library. > > For this all to start, we'd need an initial KF5::SyntaxHighlighting release > first though, to not have KTextEditor depend on something unreleased. >From what I can see, the progress so far looks very promising, especially since you seem to be using this already in several places. :-) As you noted, the most important part is how to process. The idea of having an initial release in KDE Frameworks is fine, I would suggest that we need to agree the API is ok as is by then, and the API documentation is good [enough]. I already added some API docs, but the next days I can also look into the public interfaces again to see whether all makes sense from a KTextEditor perspective. Best, Dominik
Re: baloo + out-of-memory in file extractor
Hi, On 10 Sep 2016 19:42, "Christoph Cullmann" wrote: > > Hi, > > during the last night of the akademy for me in Berlin, baloo file extractor OOM'd my notebook > during extracting the tag info of the taglib unit test test-files. Is it possible to reproduce the issue and get a stack trace? If you can consistently repro this, running under valgrind to check for leaks will also go a long way. > > Would it be a good idea to restrict the file extractor process to some fixed amount of memory > to use via setrlimit? (or more fancy stuff?) That would probably just make Baloo crash, so fixing the bug is probably the better option. > > Greetings > Christoph -- Boudhayan Gupta > > -- > - Dr.-Ing. Christoph Cullmann - > AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com > Science Park 1 Tel: +49-681-38360-22 > 66123 Saarbrücken Fax: +49-681-38360-20 > GERMANYWWW: http://www.AbsInt.com > > Geschäftsführung: Dr.-Ing. Christian Ferdinand > Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Review Request/New Framework: KF5::SyntaxHighlighting
Hi, please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for becoming a framework :) This is a tier1/functional version of the Kate syntax highlighting engine. It's not tied to a particular output format or editor engine, the interface is basically just passing in a line of text and getting back a set of formatting instructions. A QSyntaxHighlighter and a HTML CLI highlighter are included, for example. Use Cases - I initially started this for use in GammaRay's QRC browser (which can embed into QtCreator, making using the KXmlGui-dependent Kate part problematic) - It's already used in KDAB's internal QML-based training presentation tool - Kate, obviously (see below) - possibly replacing a few hand-written highlighters in KDE PIM (Sieve, message source, diff attachments), and enabling inline attachment highlighting - the Kate team apparently also had some demand for this in the past, e.g. for use in CLI tools Relation to Kate I showed my work on this to the Kate team at Akademy, originally to get help regarding some semantic corner cases in the highlighting files, however the feedback I got was a plan to turn this into a framework, and a migration strategy for Kate, therefore the recent activity into that direction :) The migration would happen in small steps, the first one being Kate switching to use the syntax definition files from the new library, as well as the indexing and meta data loading code. More features would follow in the subsequent releases, together with making the corresponding API officially public. Future steps might include syncing the format/theme settings, determining which syntax to use for a given file, and of course the ultimately switching the entire syntax highlighting related code over to the new library. For this all to start, we'd need an initial KF5::SyntaxHighlighting release first though, to not have KTextEditor depend on something unreleased. Regards, Volker signature.asc Description: This is a digitally signed message part.
baloo + out-of-memory in file extractor
Hi, during the last night of the akademy for me in Berlin, baloo file extractor OOM'd my notebook during extracting the tag info of the taglib unit test test-files. Would it be a good idea to restrict the file extractor process to some fixed amount of memory to use via setrlimit? (or more fancy stuff?) Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 310 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/310/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:59 + Build duration: 19 min CHANGE SET Revision 4125136737e6cbad40ec1313e870b0a22a1c4c70 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33089/49334 (67%)CONDITIONAL 16810/32928 (51%) By packages autotests.src FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4108/4421 (93%)CONDITIONAL 1943/3952 (49%) autotests.src.vimode FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 (99%)CONDITIONAL 897/1658 (54%) src.buffer FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 (91%)CONDITIONAL 1256/1630 (77%) src.completion FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 (57%)CONDITIONAL 1206/2798 (43%) src.completion.expandingtree FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 79/354 (22%) src.dialogs FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 (0%) src.document FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1797/3215 (56%)CONDITIONAL 1499/3219 (47%) src.export FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 106/152 (70%) src.include.ktexteditor FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 (83%)CONDITIONAL 144/228 (63%) src.inputmode FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 40/89 (45%) src.mode FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 158/422 (37%)CONDITIONAL 97/269 (36%) src.printing FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 (0%) src.render FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 (75%)CONDITIONAL 620/932 (67%) src.schema FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 7/697 (1%) src.script FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 (66%)CONDITIONAL 294/556 (53%) src.search FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 (73%)CONDITIONAL 576/913 (63%) src.spellcheck FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 205/820 (25%) src.swapfile FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 60/203 (30%) src.syntax FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2151 (77%)CONDITIONAL 1059/1784 (59%) src.syntax.data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 73/92 (79%) src.undo FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 321/448 (72%) src.utils FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 (66%)CONDITIONAL 1332/2728 (49%) src.variableeditor FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 (0%) src.view FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3321/6291 (53%)CONDITIONAL 1492/3791 (39%) src.vimode FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 (80%)CONDITIONAL 1028/1751 (59%) src.vimode.config FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 (0%) src.vimode.emulatedcommandbar FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 (99%)CONDITIONAL 616/682 (90%) src.vimode.modes FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 (87%)CONDITIONAL 1860/2370 (78%)
Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 310 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/310/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:59 + Build duration: 19 min CHANGE SET Revision 4125136737e6cbad40ec1313e870b0a22a1c4c70 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33089/49334 (67%)CONDITIONAL 16810/32928 (51%) By packages autotests.src FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4108/4421 (93%)CONDITIONAL 1943/3952 (49%) autotests.src.vimode FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 (99%)CONDITIONAL 897/1658 (54%) src.buffer FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 (91%)CONDITIONAL 1256/1630 (77%) src.completion FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 (57%)CONDITIONAL 1206/2798 (43%) src.completion.expandingtree FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 79/354 (22%) src.dialogs FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 (0%) src.document FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1797/3215 (56%)CONDITIONAL 1499/3219 (47%) src.export FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 106/152 (70%) src.include.ktexteditor FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 (83%)CONDITIONAL 144/228 (63%) src.inputmode FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 40/89 (45%) src.mode FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 158/422 (37%)CONDITIONAL 97/269 (36%) src.printing FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 (0%) src.render FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 (75%)CONDITIONAL 620/932 (67%) src.schema FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 7/697 (1%) src.script FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 (66%)CONDITIONAL 294/556 (53%) src.search FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 (73%)CONDITIONAL 576/913 (63%) src.spellcheck FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 205/820 (25%) src.swapfile FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 60/203 (30%) src.syntax FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2151 (77%)CONDITIONAL 1059/1784 (59%) src.syntax.data FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 73/92 (79%) src.undo FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 321/448 (72%) src.utils FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 (66%)CONDITIONAL 1332/2728 (49%) src.variableeditor FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 (0%) src.view FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3321/6291 (53%)CONDITIONAL 1492/3791 (39%) src.vimode FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 (80%)CONDITIONAL 1028/1751 (59%) src.vimode.config FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 (0%) src.vimode.emulatedcommandbar FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 (99%)CONDITIONAL 616/682 (90%) src.vimode.modes FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 (87%)CONDITIONAL 1860/2370 (78%)
Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 215 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 13:10:49 + Build duration: 1 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 (76%)CONDITIONAL 78/148 (53%) By packages autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 59/118 (50%) src FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 19/30 (63%)
Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 215 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 13:10:49 + Build duration: 1 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 (76%)CONDITIONAL 78/148 (53%) By packages autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 59/118 (50%) src FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 19/30 (63%)
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 175 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/175/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 10 Sep 2016 12:57:45 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4483/11179 (40%)CONDITIONAL 2341/8419 (28%) By packages autotests FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/979 (95%)CONDITIONAL 596/1162 (51%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 (30%)CONDITIONAL 217/1152 (19%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1659/3603 (46%)CONDITIONAL 942/2698 (35%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 874/1564 (56%)CONDITIONAL 408/1018 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 323/1661 (19%)CONDITIONAL 150/1269 (12%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 1/970 (0%)
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 175 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/175/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 10 Sep 2016 12:57:45 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4483/11179 (40%)CONDITIONAL 2341/8419 (28%) By packages autotests FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/979 (95%)CONDITIONAL 596/1162 (51%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 (30%)CONDITIONAL 217/1152 (19%) src.plasma FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1659/3603 (46%)CONDITIONAL 942/2698 (35%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 874/1564 (56%)CONDITIONAL 408/1018 (40%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 323/1661 (19%)CONDITIONAL 150/1269 (12%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 1/970 (0%)
Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 208 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/208/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:39 + Build duration: 1 min 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/13 (15%)CLASSES 2/13 (15%)LINE 132/947 (14%)CONDITIONAL 66/564 (12%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 33/50 (66%) src.core FILES 1/12 (8%)CLASSES 1/12 (8%)LINE 76/891 (9%)CONDITIONAL 33/514 (6%)
Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 208 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/208/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:59:39 + Build duration: 1 min 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/13 (15%)CLASSES 2/13 (15%)LINE 132/947 (14%)CONDITIONAL 66/564 (12%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 33/50 (66%) src.core FILES 1/12 (8%)CLASSES 1/12 (8%)LINE 76/891 (9%)CONDITIONAL 33/514 (6%)
Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 214 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:54:58 + Build duration: 4 min 47 sec CHANGE SET Revision 74ba08b57036ce9faacfac1459c2303031244b60 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt
Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font
> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? I would use visibility and hint to show/hide the font's that are not available in the selected font. will the font change to "not selected" grayed out when you show all characters also the ones that aren't available? - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128680/#review98855 --- On Sept. 1, 2016, 4:45 nachm., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128680/ > --- > > (Updated Sept. 1, 2016, 4:45 nachm.) > > > Review request for KDE Frameworks, KDE Usability and Andreas Kainz. > > > Bugs: 97420 > https://bugs.kde.org/show_bug.cgi?id=97420 > > > Repository: kwidgetsaddons > > > Description > --- > > Adds a toolbutton to the right of the font combobox to control the "font > merging" property of QFont. When selected, characters which are not available > in the font are disabled. > > Seeking feedback about: > - placement of the button > - used icon (currently "format-text-strikethrough"; it shows an S character > which could stand for "substitution") > - action name and tooltip (see line 477 and 479) > - and code changes ;) > > I was unsure if the toolbutton could have a popup menu showing three options: > 1) show characters from all fonts > 2) disable characters not available in font > 3) hide characters not available in font > > but I did not implement it, because it felt odd not being able to see _which_ > characters are not available in the font. > > > Diffs > - > > src/kcharselect.cpp 30ddd34 > src/kcharselect_p.h db0259c > > Diff: https://git.reviewboard.kde.org/r/128680/diff/ > > > Testing > --- > > > File Attachments > > > Character table with font substitution (default) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png > Character table with dimming substituted characters > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png > > > Thanks, > > Christoph Feck > >
Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 207 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/207/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:54:58 + Build duration: 50 sec CHANGE SET Revision 9ac539cf4f8220a200b6eb4cf8885ed488129d83 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt Revision 52428f3e1b16e0b90066bcb7259eb7b37559d361 by Christophe Giboudeaux: (Don't install files twice.) change: edit src/core/CMakeLists.txt
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 209 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/209/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:40:48 + Build duration: 7 min 25 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 51 test(s)Failed: TestSuite.kiocore-threadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 262/340 (77%)CLASSES 262/340 (77%)LINE 27855/51234 (54%)CONDITIONAL 15500/38019 (41%) By packages autotests FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7713/8036 (96%)CONDITIONAL 4317/8452 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7770/14141 (55%)CONDITIONAL 4243/9067 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2312/7579 (31%)CONDITIONAL 921/4405 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 (46%)CONDITIONAL 1249/3434 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/65 (48%)CLASSES 31/65 (48%)LINE 3450/10887 (32%)CONDITIONAL 1653/6902 (24%)
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 174 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/174/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 10 Sep 2016 12:21:35 + Build duration: 33 sec CHANGE SET Revision 8f980541f556e63a3918fd5dda7919fe298bc2da by Christophe Giboudeaux: (Don't install files twice.) change: edit src/plasmaquick/CMakeLists.txt
Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:06:45 + Build duration: 7 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94748 (3%)CONDITIONAL 2832/151320 (2%) By packagesFILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/592 (0%)CONDITIONAL 4/681 (1%) autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 27/56 (48%) src FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 (11%)CONDITIONAL 811/18510 (4%) src.css FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 (0%)CONDITIONAL 32/15687 (0%) src.dom FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 (1%)CONDITIONAL 66/4876 (1%) src.ecma FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 (0%)CONDITIONAL 47/19677 (0%) src.editing FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 11/4033 (0%) src.html FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 (0%)CONDITIONAL 42/15981 (0%) src.imload FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 14/641 (2%) src.imload.decoders FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 10/684 (1%) src.misc FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 (23%)CONDITIONAL 707/5250 (13%) src.platform FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 (100%) src.platform.graphics FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 0/308 (0%) src.platform.graphics.qt FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/172 (0%) src.platform.text FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%) src.rendering FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 (0%)CONDITIONAL 95/32659 (0%) src.svg FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 (13%)CONDITIONAL 816/14527 (6%) src.svg.graphics FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 14/342 (4%) src.svg.graphics.qt FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 12/319 (4%) src.ui.findbar FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 8/908 (1%) src.ui.passwordbar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 39/106 (37%) src.xml FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 (1%)CONDITIONAL 59/13175 (0%) src.xpath FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 18/2724 (1%)
Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 101 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:06:45 + Build duration: 7 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 19/23 (83%)FILES 308/626 (49%)CLASSES 308/626 (49%)LINE 3032/94748 (3%)CONDITIONAL 2832/151320 (2%) By packagesFILES 2/8 (25%)CLASSES 2/8 (25%)LINE 2/592 (0%)CONDITIONAL 4/681 (1%) autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 53/57 (93%)CONDITIONAL 27/56 (48%) src FILES 20/31 (65%)CLASSES 20/31 (65%)LINE 931/8839 (11%)CONDITIONAL 811/18510 (4%) src.css FILES 12/25 (48%)CLASSES 12/25 (48%)LINE 32/9368 (0%)CONDITIONAL 32/15687 (0%) src.dom FILES 29/40 (73%)CLASSES 29/40 (73%)LINE 61/7091 (1%)CONDITIONAL 66/4876 (1%) src.ecma FILES 24/50 (48%)CLASSES 24/50 (48%)LINE 27/8351 (0%)CONDITIONAL 47/19677 (0%) src.editing FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 20/2100 (1%)CONDITIONAL 11/4033 (0%) src.html FILES 21/47 (45%)CLASSES 21/47 (45%)LINE 21/10643 (0%)CONDITIONAL 42/15981 (0%) src.imload FILES 4/31 (13%)CLASSES 4/31 (13%)LINE 24/854 (3%)CONDITIONAL 14/641 (2%) src.imload.decoders FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 19/616 (3%)CONDITIONAL 10/684 (1%) src.misc FILES 13/27 (48%)CLASSES 13/27 (48%)LINE 837/3716 (23%)CONDITIONAL 707/5250 (13%) src.platform FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/2 (0%)CONDITIONAL 0/0 (100%) src.platform.graphics FILES 0/16 (0%)CLASSES 0/16 (0%)LINE 0/534 (0%)CONDITIONAL 0/308 (0%) src.platform.graphics.qt FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/248 (0%)CONDITIONAL 0/172 (0%) src.platform.text FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/7 (0%)CONDITIONAL 0/4 (0%) src.rendering FILES 48/97 (49%)CLASSES 48/97 (49%)LINE 64/23896 (0%)CONDITIONAL 95/32659 (0%) src.svg FILES 72/147 (49%)CLASSES 72/147 (49%)LINE 746/5897 (13%)CONDITIONAL 816/14527 (6%) src.svg.graphics FILES 7/14 (50%)CLASSES 7/14 (50%)LINE 7/283 (2%)CONDITIONAL 14/342 (4%) src.svg.graphics.qt FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 6/156 (4%)CONDITIONAL 12/319 (4%) src.ui.findbar FILES 2/4 (50%)CLASSES 2/4 (50%)LINE 21/505 (4%)CONDITIONAL 8/908 (1%) src.ui.passwordbar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 28/60 (47%)CONDITIONAL 39/106 (37%) src.xml FILES 20/38 (53%)CLASSES 20/38 (53%)LINE 116/9560 (1%)CONDITIONAL 59/13175 (0%) src.xpath FILES 9/15 (60%)CLASSES 9/15 (60%)LINE 17/1373 (1%)CONDITIONAL 18/2724 (1%)
Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 70 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:18:30 + Build duration: 1 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) COBERTURA RESULTS Cobertura Coverage Report By packages
Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 70 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:18:30 + Build duration: 1 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) COBERTURA RESULTS Cobertura Coverage Report By packages
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 112 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:05:11 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 (68%)CONDITIONAL 2962/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 (94%)CONDITIONAL 891/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 (58%)CONDITIONAL 758/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 (73%)CONDITIONAL 1228/2054 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 112 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 12:05:11 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 (68%)CONDITIONAL 2962/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 (94%)CONDITIONAL 891/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 (58%)CONDITIONAL 758/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 (73%)CONDITIONAL 1228/2054 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:51:53 + Build duration: 7 min 34 sec CHANGE SET Revision 9581e05813ac8b15cff51ba6b6fd9b5135837143 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 51 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 263/341 (77%)CLASSES 263/341 (77%)LINE 27908/51273 (54%)CONDITIONAL 15533/38067 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7752/8075 (96%)CONDITIONAL 4344/8500 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7785/14141 (55%)CONDITIONAL 4247/9067 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2312/7579 (31%)CONDITIONAL 921/4405 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 (46%)CONDITIONAL 1249/3434 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/65 (48%)CLASSES 31/65 (48%)LINE 3449/10887 (32%)CONDITIONAL 1653/6902 (24%)
Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 82 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:55:12 + Build duration: 2 min 48 sec CHANGE SET Revision 17164ba33cda0063f3472d1d2572a27cb868557b by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 39/68 (57%)CLASSES 39/68 (57%)LINE 4010/9254 (43%)CONDITIONAL 2182/6447 (34%) By packages autotests FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 1345/1357 (99%)CONDITIONAL 603/1220 (49%) src FILES 28/57 (49%)CLASSES 28/57 (49%)LINE 2665/7897 (34%)CONDITIONAL 1579/5227 (30%)
Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 82 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:55:12 + Build duration: 2 min 48 sec CHANGE SET Revision 17164ba33cda0063f3472d1d2572a27cb868557b by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 39/68 (57%)CLASSES 39/68 (57%)LINE 4010/9254 (43%)CONDITIONAL 2182/6447 (34%) By packages autotests FILES 11/11 (100%)CLASSES 11/11 (100%)LINE 1345/1357 (99%)CONDITIONAL 603/1220 (49%) src FILES 28/57 (49%)CLASSES 28/57 (49%)LINE 2665/7897 (34%)CONDITIONAL 1579/5227 (30%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:51:53 + Build duration: 7 min 34 sec CHANGE SET Revision 9581e05813ac8b15cff51ba6b6fd9b5135837143 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 51 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 263/341 (77%)CLASSES 263/341 (77%)LINE 27908/51273 (54%)CONDITIONAL 15533/38067 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7752/8075 (96%)CONDITIONAL 4344/8500 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7785/14141 (55%)CONDITIONAL 4247/9067 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2312/7579 (31%)CONDITIONAL 921/4405 (21%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 434/832 (52%)CONDITIONAL 326/719 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 (46%)CONDITIONAL 1249/3434 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 375/753 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 102/138 (74%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/65 (48%)CLASSES 31/65 (48%)LINE 3449/10887 (32%)CONDITIONAL 1653/6902 (24%)
Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 100 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:42:01 + Build duration: 13 min CHANGE SET Revision c53bd7f8caa687ebcb159e3292b2ac70e92163df by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 111 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:44:33 + Build duration: 1 min 54 sec CHANGE SET Revision 5f45fbe8e392c710984b741eb2cf9750c0d55ec8 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5458/7983 (68%)CONDITIONAL 2949/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 (94%)CONDITIONAL 886/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 (58%)CONDITIONAL 757/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 (73%)CONDITIONAL 1221/2054 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 114 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/114/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:44:33 + Build duration: 2 min 5 sec CHANGE SET Revision 5f45fbe8e392c710984b741eb2cf9750c0d55ec8 by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5462/7983 (68%)CONDITIONAL 2956/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 (94%)CONDITIONAL 886/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 (58%)CONDITIONAL 755/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2798 (73%)CONDITIONAL 1230/2054 (60%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 81 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:41:05 + Build duration: 2 min 52 sec CHANGE SET No changes
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 113 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:33:47 + Build duration: 2 min 2 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 (68%)CONDITIONAL 2946/6138 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 (94%)CONDITIONAL 884/1768 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 (58%)CONDITIONAL 756/1888 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 (73%)CONDITIONAL 1221/2054 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » Linux,gcc - Build # 80 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:23:19 + Build duration: 4 min 47 sec CHANGE SET No changes
Jenkins-kde-ci: kcmutils master kf5-qt5 » Linux,gcc - Build # 69 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcmutils%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 10 Sep 2016 11:26:25 + Build duration: 7.6 sec CHANGE SET Revision 134dc2ac5f45bcffcbf440c45d0446792f58c1fb by scripty: (Upgrade KF5 version to 5.27.0.) change: edit CMakeLists.txt
