Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 121 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/121/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 04:45:53 +
Build duration: 2 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7983 
(68%)CONDITIONAL 2954/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 883/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1231/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 121 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/121/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 04:45:53 +
Build duration: 2 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7983 
(68%)CONDITIONAL 2954/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 883/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1231/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 128993: Drop obsolete version checks

[Laurent Montel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128993/#review99405
---


Ship it!




Ship It!

- Laurent Montel


On Sept. 21, 2016, 5:37 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128993/
> ---
> 
> (Updated Sept. 21, 2016, 5:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   autotests/minimaltest.cpp c9f49311427bdc362eafd522998699c1c31233d5 
>   autotests/plugintest.cpp c73d224aa151f5a7e2bbba04bb8234ea2f391e5c 
> 
> Diff: https://git.reviewboard.kde.org/r/128993/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 120 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/120/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 01:20:19 +
Build duration: 3 min 5 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5462/7982 
(68%)CONDITIONAL 2955/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2797 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 01:20:19 +
Build duration: 1 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 438/560 
(78%)CONDITIONAL 128/249 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 
(100%)CONDITIONAL 41/78 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 324/446 (73%)CONDITIONAL 
87/171 (51%)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 103 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 01:20:19 +
Build duration: 1 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 438/560 
(78%)CONDITIONAL 128/249 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 114/114 
(100%)CONDITIONAL 41/78 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 324/446 (73%)CONDITIONAL 
87/171 (51%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 01:18:44 +
Build duration: 2 min 8 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2946/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1223/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 22 Sep 2016 01:18:44 +
Build duration: 2 min 8 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2946/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1223/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 128983: Drop obsolete version check

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128983/#review99403
---


Ship it!




I'd say you can get these all in.

- Aleix Pol Gonzalez


On Sept. 21, 2016, 6:24 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128983/
> ---
> 
> (Updated Sept. 21, 2016, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 
> 
> Diff: https://git.reviewboard.kde.org/r/128983/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Review Request 128996: Don't generate appstream files for components that are not in rdn

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128996/
---

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
---

Appstream will spit them out anyway, better do it early in the process and with 
a warning.


Diffs
-

  KF5PackageMacros.cmake 7a12292 

Diff: https://git.reviewboard.kde.org/r/128996/diff/


Testing
---

Plasma Desktop doesn't generate information for offending components but also 
won't make the test fail.

```
  Appstream information won't be generated for kcm_splashscreen.
  Appstream information won't be generated for kcm_desktoptheme.
  Appstream information won't be generated for kcm_lookandfeel.
```


Thanks,

Aleix Pol Gonzalez

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99396
---


Ship it!




Inviala!

- Luigi Toscano


On Set. 21, 2016, 11:35 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Set. 21, 2016, 11:35 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

KF5/Qt5 and multiple QPAs

[René J . V . Bertin]

Hi,

Am I correct that Qt now provides a Wayland QPA and that users on Linux can now 
decide, in principle "on the fly" which displaying protocol a newly started 
application is going to use, presumably with a platform-wide default either 
hardwired into Qt or defined in some settings file?

If so, how does that work out with KF5 applications that get started by others? 
Say, a user with a Wayland-based desktop logs in over ssh+X11 and wants to run 
kate remotely with `kate -platform xcb`. A new session dbus will be started, 
and during Kate's start-up sequence kdeinit5 will start which will then start 
klauncher.

I just tried this on OS X (I have a working XCB QPA on my system, plus a 
patched dbus that works without launchd). kdeinit5 starts up fine because it's 
not a GUI app (I think), but klauncher is. It doesn't inherit the `-platform 
xcb` arguments, and thus fails because the Cocoa QPA only works locally.

Mostly asking out of curiosity, though I would of course appreciate it if on 
occasion I could use applications like Kate remotely.

Thanks,
René

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

[Milian Wolff]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128944/#review99391
---



personally, I don't think it's a good idea to use QString instead of QByteArray 
here. If that is really just for QStringRef in the function, wouldn't a simple 
view class on the byte array be the better choice? It's not much code to write, 
afaik you could even copy the code that is on gerrit somewhere for 
QByteArrayView. That way you will reduce the allocations but keep the data in 
UTF-8 instead of converting it to UTF-16. Also, your patch will probably use 
more memory now, or?


src/lib/plugin/desktopfileparser.cpp (line 99)


famous last words ;-)


- Milian Wolff


On Sept. 20, 2016, 11:19 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128944/
> ---
> 
> (Updated Sept. 20, 2016, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> While analising plasmashell under heaptrack, one of the sore spots is 
> temporary allocations within DesktopFileParser. This improves the situation 
> by:
> 
> * Only converting to QString/utf8 once.
> * Using QStringRef instead of fully splitting QString to parse them.
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/desktopfileparser.cpp 2eb198d 
>   src/lib/plugin/desktopfileparser_p.h c61b297 
> 
> Diff: https://git.reviewboard.kde.org/r/128944/diff/
> 
> 
> Testing
> ---
> 
> tests still pass, plasma still works normally.
> 
> heaptrack plasmashell:
> 
> after:
> allocations:4169312
> leaked allocations: 83225
> temporary allocations:  606902
> 
> before:
> allocations:4680691
> leaked allocations: 84825
> temporary allocations:  819292
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Review Request 128995: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128995/
---

Review request for KDE Frameworks and David Faure.


Repository: kinit


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/klauncher/klauncher.cpp 4d563d9d7e7cc150b692e6be78e8197de2725196 

Diff: https://git.reviewboard.kde.org/r/128995/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128994: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128994/
---

Review request for KDE Frameworks and Martin Gräßlin.


Repository: kglobalaccel


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/runtime/logging.cpp 26ff7542a42e75334df6895527c12915c9a90f7c 

Diff: https://git.reviewboard.kde.org/r/128994/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128993: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128993/
---

Review request for KDE Frameworks and Alex Merry.


Repository: kdesignerplugin


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/minimaltest.cpp c9f49311427bdc362eafd522998699c1c31233d5 
  autotests/plugintest.cpp c73d224aa151f5a7e2bbba04bb8234ea2f391e5c 

Diff: https://git.reviewboard.kde.org/r/128993/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128992: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128992/
---

Review request for KDE Frameworks and Marco Martin.


Repository: kdeclarative


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp 
351d99fc435f9ba8d58269e0b92dab3483f77580 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h 
b9177690a5268c26697a7f0b37470ef0058112c6 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 
ffcb4ee4b43f5d99f419ef0e1680064f57cb1002 

Diff: https://git.reviewboard.kde.org/r/128992/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128991: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128991/
---

Review request for KDE Frameworks and Ivan Čukić.


Repository: kactivities


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/lib/debug_p.cpp 97e39566ceef51dd0035b0625f1407a8b0fb1011 

Diff: https://git.reviewboard.kde.org/r/128991/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128988: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128988/
---

Review request for KDE Frameworks and David Faure.


Repository: kcrash


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/kcrash.cpp b8c6477a70291ca9c1f0efef3bba061b6af247b0 

Diff: https://git.reviewboard.kde.org/r/128988/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128987: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128987/
---

Review request for KDE Frameworks.


Repository: kauth


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/backends/dbus/DBusHelperProxy.cpp 
decc2676a005def1cb6feea0670f3eb981c4519d 
  src/kauthdebug.cpp fb57ddcc0e21eae25f079efc76ec0c05861ad2aa 
  src/kauthhelpersupport.cpp 318d3a0892b8bd18eb9d781b1bc6908afb6c29b2 

Diff: https://git.reviewboard.kde.org/r/128987/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128986: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128986/
---

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/plugins/hunspell/hunspelldebug.cpp 
5f9aebe0821cffb44adfe2b82595bce724dc53d7 
  src/plugins/voikko/voikkodebug.cpp c950c649b48e17143f206b990b57cf0033206df3 

Diff: https://git.reviewboard.kde.org/r/128986/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128982: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128982/
---

(Updated Sept. 21, 2016, 4:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit f9ed1d9c9f090457223c88df8729161bc811f0a2 by Heiko Becker 
to branch master.


Repository: karchive


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/karchivetest.cpp dd4ffe68f544fe836dd93b826822edc42590dad4 

Diff: https://git.reviewboard.kde.org/r/128982/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128985: Drop obsolete version checks

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128985/
---

Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/klinkitemselectionmodeltest.cpp 
1399700cf58dec0ca9f661b7bc2c361e0df2349e 
  autotests/kselectionproxymodeltest.cpp 
fbc26d880f27c9d14e0181cd4f8dcd2df99f9c52 
  src/klinkitemselectionmodel.cpp f6de1c1f22c723ab7556a9fb880dd70c745b3454 
  src/kselectionproxymodel.cpp 4ee510fe22899188757c9a681c0646aa9da4d843 

Diff: https://git.reviewboard.kde.org/r/128985/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128982: Drop obsolete version check

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128982/#review99385
---


Ship it!




Ship It!

- David Faure


On Sept. 21, 2016, 4:17 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128982/
> ---
> 
> (Updated Sept. 21, 2016, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp dd4ffe68f544fe836dd93b826822edc42590dad4 
> 
> Diff: https://git.reviewboard.kde.org/r/128982/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Review Request 128984: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128984/
---

Review request for KDE Frameworks.


Repository: kidletime


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/logging.cpp be0cee45adaa11de610c8157e1419d915f871fc0 

Diff: https://git.reviewboard.kde.org/r/128984/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128983: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128983/
---

Review request for KDE Frameworks and Michael Pyne.


Repository: kcoreaddons


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/desktoptojson/main.cpp 21a453c9b7565bf276ed6a09c60d923abb3426d3 

Diff: https://git.reviewboard.kde.org/r/128983/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128980: Use QTEST_GUILESS_MAIN

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128980/
---

(Updated Sept. 21, 2016, 4:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Volker Krause.


Changes
---

Submitted with commit 0fea247d1afdeccb2fbba9ce4375f108953701f4 by Heiko Becker 
to branch master.


Repository: syntax-highlighting


Description
---

Allowing the tests to pass without a running X server.


Diffs
-

  autotests/highlighter_benchmark.cpp 7c17101 
  autotests/htmlhighlighter_test.cpp bad322d 
  autotests/repository_benchmark.cpp 8a467f9 
  autotests/syntaxrepository_test.cpp 0011f7d 
  autotests/testhighlighter.cpp e903e97 
  autotests/theme_test.cpp f602e11 
  autotests/wildcardmatcher_test.cpp 3cf61bc 

Diff: https://git.reviewboard.kde.org/r/128980/diff/


Testing
---

Tests build and run fine.


Thanks,

Heiko Becker

Review Request 128982: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128982/
---

Review request for KDE Frameworks and David Faure.


Repository: karchive


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  autotests/karchivetest.cpp dd4ffe68f544fe836dd93b826822edc42590dad4 

Diff: https://git.reviewboard.kde.org/r/128982/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128980: Use QTEST_GUILESS_MAIN

[Volker Krause]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128980/#review99384
---


Ship it!




Ship It!

- Volker Krause


On Sept. 21, 2016, 3:34 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128980/
> ---
> 
> (Updated Sept. 21, 2016, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Volker Krause.
> 
> 
> Repository: syntax-highlighting
> 
> 
> Description
> ---
> 
> Allowing the tests to pass without a running X server.
> 
> 
> Diffs
> -
> 
>   autotests/highlighter_benchmark.cpp 7c17101 
>   autotests/htmlhighlighter_test.cpp bad322d 
>   autotests/repository_benchmark.cpp 8a467f9 
>   autotests/syntaxrepository_test.cpp 0011f7d 
>   autotests/testhighlighter.cpp e903e97 
>   autotests/theme_test.cpp f602e11 
>   autotests/wildcardmatcher_test.cpp 3cf61bc 
> 
> Diff: https://git.reviewboard.kde.org/r/128980/diff/
> 
> 
> Testing
> ---
> 
> Tests build and run fine.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128981: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128981/
---

(Updated Sept. 21, 2016, 6:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Rosca.


Changes
---

Submitted with commit 40dc1493ab859223a093a9b9f6f5c84795376066 by Heiko Becker 
to branch master.


Repository: bluez-qt


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/debug.cpp c6faad19d4239ce4be239dd43df9a654de9a8a29 

Diff: https://git.reviewboard.kde.org/r/128981/diff/


Testing
---


Thanks,

Heiko Becker

Re: Review Request 128981: Drop obsolete version check

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128981/#review99382
---


Ship it!




Ship It!

- David Rosca


On Sept. 21, 2016, 4:09 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128981/
> ---
> 
> (Updated Sept. 21, 2016, 4:09 p.m.)
> 
> 
> Review request for KDE Frameworks and David Rosca.
> 
> 
> Repository: bluez-qt
> 
> 
> Description
> ---
> 
> Frameworks already require Qt 5.5.0.
> 
> 
> Diffs
> -
> 
>   src/debug.cpp c6faad19d4239ce4be239dd43df9a654de9a8a29 
> 
> Diff: https://git.reviewboard.kde.org/r/128981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Review Request 128981: Drop obsolete version check

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128981/
---

Review request for KDE Frameworks and David Rosca.


Repository: bluez-qt


Description
---

Frameworks already require Qt 5.5.0.


Diffs
-

  src/debug.cpp c6faad19d4239ce4be239dd43df9a654de9a8a29 

Diff: https://git.reviewboard.kde.org/r/128981/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 128980: Use QTEST_GUILESS_MAIN

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128980/
---

Review request for KDE Frameworks and Volker Krause.


Repository: syntax-highlighting


Description
---

Allowing the tests to pass without a running X server.


Diffs
-

  autotests/highlighter_benchmark.cpp 7c17101 
  autotests/htmlhighlighter_test.cpp bad322d 
  autotests/repository_benchmark.cpp 8a467f9 
  autotests/syntaxrepository_test.cpp 0011f7d 
  autotests/testhighlighter.cpp e903e97 
  autotests/theme_test.cpp f602e11 
  autotests/wildcardmatcher_test.cpp 3cf61bc 

Diff: https://git.reviewboard.kde.org/r/128980/diff/


Testing
---

Tests build and run fine.


Thanks,

Heiko Becker

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Ralf Habacker]

> On Sept. 21, 2016, 12:38 nachm., Luigi Toscano wrote:
> > Would it make more sense to change meinproc5 to work like checkXML5 if 
> > invoked with that name (hardlink, copy, etc, a-la busybox)?
> 
> Ralf Habacker wrote:
> Sorry, I do not know the reasons why this tool has been created and has 
> not been integrated into meinproc5. You should ask the original author.
> 
> Luigi Toscano wrote:
> The original author (Laurent Montel, 
> https://websvn.kde.org/?view=revision=505145) don't remember much, 
> and I guess it's not relevant here. My question was: from a multiplatform 
> prospective, would this solution have any drawback? Where "this solution" is: 
> have a checkXML5(.exe) executable which is an hardlink (or a copy, I guess, 
> on Windows) to meinproc5, but exposing the behavior of the wrapper script?

Pro's:
- no additional source/cmake target/binary to maintain 

Neg's:
- increase the complexibility of meinproc5 caused by the need to support of 
additional 'checkXML5' use case
- more efforts required to maintain the related man pages caused by the dualism 
 e.g. 'Do I need to update "meinproc5" or "checkXML5" man page 
- duplicated executable on windows caused by pysical copy (hardlinks are not 
supported by cmake as far as I know)

Seeing this I would stay with the checkXML5 executable introduced with this 
request.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---


On Sept. 21, 2016, 11:35 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Sept. 21, 2016, 11:35 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Ralf Habacker]

> On Sept. 21, 2016, 12:38 nachm., Luigi Toscano wrote:
> > Would it make more sense to change meinproc5 to work like checkXML5 if 
> > invoked with that name (hardlink, copy, etc, a-la busybox)?

Sorry, I do not know the reasons why this tool has been created and has not 
been integrated into meinproc5. You should ask the original author.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---


On Sept. 21, 2016, 11:35 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Sept. 21, 2016, 11:35 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Ralf Habacker]

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed
> 
> Ralf Habacker wrote:
> To cross compile kdoctools for windows on e.g. linux native running tools 
> like meinproc5, docbookl10nhelper and checkXML5 are required. On 
> bootstrapping cross compile these native tools are created and packaged 
> together in a packages named mingwXX-cross-kf5-tools like similar cross 
> helper tools for example mingw32-cross-gcc.
> 
> Luigi Toscano wrote:
> Uhm, but normally we don't need it - can't this installation be done 
> under some condition, so that the default is not changed?

Sonnet for example installs similar tools 'parsetrigrams' and  'gentrigrams' 
also unconditional. On opensuse they are packaged as part of the development 
package. see 
https://build.opensuse.org/package/view_file/KDE:Frameworks5/sonnet/sonnet.spec?expand=1
 line 134,135.

If this is an absolute nogo there would be still the choice to use a specific 
configure time switch like INSTALL_ALL or similar ?


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Ralf Habacker]

> On Sept. 21, 2016, 1:52 nachm., Luigi Toscano wrote:
> > src/CMakeLists.txt, line 173
> > 
> >
> > docbookl10nhelper is not meant to be installed

To cross compile kdoctools for windows on e.g. linux native running tools like 
meinproc5, docbookl10nhelper and checkXML5 are required. On bootstrapping cross 
compile these native tools are created and packaged together in a packages 
named mingwXX-cross-kf5-tools like similar cross helper tools for example 
mingw32-cross-gcc.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---


On Sept. 21, 2016, 11:43 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 11:57:42 +
Build duration: 5 min 38 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.ksycocathreadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5467/7983 
(68%)CONDITIONAL 2972/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 
(94%)CONDITIONAL 897/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1763/3042 
(58%)CONDITIONAL 761/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 11:55:05 +
Build duration: 7 min 25 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2974/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 903/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1763/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 102 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 11:55:05 +
Build duration: 1 min 47 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 
test(s)Failed: TestSuite.kptyprocesstest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 419/560 
(75%)CONDITIONAL 119/249 (48%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 93/114 (82%)CONDITIONAL 
29/78 (37%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 326/446 (73%)CONDITIONAL 
90/171 (53%)

Re: Review Request 128970: Add cross compile support for meinproc5.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128970/#review99352
---




src/CMakeLists.txt 


So, I inherited kdoctools with this code commented - do you have an idea 
why it was like this, and why your patch would solve the (old) issues, or if 
they are not relevant anymore? My cross-compilation knowledge is limited.


- Luigi Toscano


On Sept. 21, 2016, 11:44 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128970/
> ---
> 
> (Updated Sept. 21, 2016, 11:44 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compile support for meinproc5.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128970/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/#review99351
---




src/CMakeLists.txt (line 173)


docbookl10nhelper is not meant to be installed


- Luigi Toscano


On Sept. 21, 2016, 11:43 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128969/
> ---
> 
> (Updated Sept. 21, 2016, 11:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Add cross compiling support for docbookl10nhelper.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
> 
> Diff: https://git.reviewboard.kde.org/r/128969/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 11:34:09 +
Build duration: 5 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5462/7983 
(68%)CONDITIONAL 2961/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1530 
(94%)CONDITIONAL 892/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 116 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/116/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 11:32:57 +
Build duration: 5 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7983 
(68%)CONDITIONAL 2956/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1440/1530 
(94%)CONDITIONAL 887/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1226/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 126494: Add cross compile support for desktoptojson.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126494/
---

(Updated Sept. 21, 2016, 1:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 6f20bfd27cb486136f3dec7264085db1a077ad1c by Ralf Habacker 
to branch master.


Repository: kcoreaddons


Description
---

Add cross compile support for desktoptojson.


Diffs
-

  KF5CoreAddonsConfig.cmake.in dce3a4e65599b286d8fedbaa20235f5025f509e8 

Diff: https://git.reviewboard.kde.org/r/126494/diff/


Testing
---

Cross compiled package has been build at 
https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-kcoreaddons


Thanks,

Ralf Habacker

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/
---

(Updated Sept. 21, 2016, 12:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 494c690b18ab1d61bfa7b9998d0f40411364a18c by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

The svg elements cache isn't really a "configuration" and it's not
something that should be overridden by global config settings.

Loading it as a simple config skips the cascading and saves reparsing
kdeglobals.


Diffs
-

  src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 

Diff: https://git.reviewboard.kde.org/r/128966/diff/


Testing
---


Thanks,

David Edmundson

Re: Review Request 128968: Convert checkxml5 into a qt executable for cross plattform support.

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128968/#review99350
---



Would it make more sense to change meinproc5 to work like checkXML5 if invoked 
with that name (hardlink, copy, etc, a-la busybox)?

- Luigi Toscano


On Sept. 21, 2016, 11:35 a.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128968/
> ---
> 
> (Updated Sept. 21, 2016, 11:35 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Convert checkxml5 into a qt executable for cross plattform support.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8674faaba6346156907aa5fbbea1ee2b38865eda 
>   checkXML5.in.cmake d7a57c78ec768a4eb9d3c669b8fe3bbef2991c93 
>   src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 
>   src/checkXML5.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128968/diff/
> 
> 
> Testing
> ---
> 
> compiled at 
> https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/#review99348
---


Ship it!




good catch

- Marco Martin


On Sept. 21, 2016, 6:13 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128966/
> ---
> 
> (Updated Sept. 21, 2016, 6:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The svg elements cache isn't really a "configuration" and it's not
> something that should be overridden by global config settings.
> 
> Loading it as a simple config skips the cascading and saves reparsing
> kdeglobals.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 
> 
> Diff: https://git.reviewboard.kde.org/r/128966/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 128969: Add cross compiling support for docbookl10nhelper.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128969/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Repository: kdoctools


Description
---

Add cross compiling support for docbookl10nhelper.


Diffs
-

  src/CMakeLists.txt 6f903b542bc9ba256dd379275567d5ff2127fe39 

Diff: https://git.reviewboard.kde.org/r/128969/diff/


Testing
---

compiled at 
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/kdoctools


Thanks,

Ralf Habacker

Review Request 128966: Don't include kdeglobals when dealing with a cache config

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

The svg elements cache isn't really a "configuration" and it's not
something that should be overridden by global config settings.

Loading it as a simple config skips the cascading and saves reparsing
kdeglobals.


Diffs
-

  src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 

Diff: https://git.reviewboard.kde.org/r/128966/diff/


Testing
---


Thanks,

David Edmundson