Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/ --- (Updated Oct. 5, 2016, 4:18 a.m.) Review request for KDE Frameworks and

Review Request 129104: Remove unused member var

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129104/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/ --- (Updated Oct. 5, 2016, 1:58 a.m.) Review request for KDE Frameworks and

Re: Review Request 129103: Generate metadata.json file at build time

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129103/ --- (Updated Oct. 5, 2016, 1:31 a.m.) Review request for KDE Frameworks and

Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 129103: Generate metadata.json file at build time

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129103/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 129092: Fix crashes in NotifyByAudio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/ --- (Updated Oct. 5, 2016, 12:41 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 199 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/199/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 21:59:18 + Build duration: 30 min CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 199 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/199/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 21:59:18 + Build duration: 29 min CHANGE SET Revision

Review Request 129100: Port some few remaining uses of pluginInfo to pluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129100/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/ --- (Updated Oct. 4, 2016, 9:58 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 198 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 18 min CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 198 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 18 min CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 198 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 198 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 198 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 3 min 5 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 198 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 3 min 5 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 198 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/198/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 21:09:41 + Build duration: 3 min 2 sec CHANGE SET Revision

Re: Review Request 129092: Fix crashes in NotifyByAudio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/#review99788 --- Ship it! - David Edmundson On Oct. 4, 2016, 8:54 p.m.,

Re: Review Request 129092: Fix crashes in NotifyByAudio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/ --- (Updated Oct. 4, 2016, 8:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 129092: Fix crashes in NotifyByAudio

> On Oct. 4, 2016, 8:18 a.m., David Edmundson wrote: > > Is it this? https://bugs.kde.org/show_bug.cgi?id=348414 Sadly I don't think so, i can only reproduce a crash at closing by doing what i say on Testing Done, it may fix it, but i can't prove it. I've looked at the code quite a lot and

Re: Review Request 129097: Define the ServiceType when found in the actual file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129097/ --- (Updated Oct. 4, 2016, 5:57 p.m.) Status -- This change has been

Re: Review Request 129097: Define the ServiceType when found in the actual file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129097/#review99773 --- eh... -1 Needs work - Aleix Pol Gonzalez On Oct. 4,

Review Request 129097: Define the ServiceType when found in the actual file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129097/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 197 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/197/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 12:47:29 + Build duration: 6 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 197 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/197/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 12:47:29 + Build duration: 6 min 9 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 197 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/197/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 12:47:29 + Build duration: 5 min 4 sec CHANGE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 197 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/197/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 12:47:29 + Build duration: 2 min 13 sec CHANGE SET

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129057/#review99765 --- Ship it! Ship It! - David Edmundson On Sept. 28, 2016,

Re: Review Request 129057: RFC: Make sense out of Plasma plugin metadata loading

> On Sept. 28, 2016, 3:56 p.m., David Edmundson wrote: > > +1 > > > > though I'd suggest to wait till the start of the next frameworks cycle > > before merging. bump. - Aleix --- This is an automatically generated e-mail. To reply,

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 196 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/196/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 10:23:16 + Build duration: 8 min 30 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 196 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/196/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 10:23:16 + Build duration: 7 min 17 sec CHANGE SET

Re: KDE Frameworks 5.27.0

I recommend rerolling kpty with 394eeff0dfba16de7418a25810edde66de541d61 Without this change it doesn't compile properly on most distros Jonathan On 2 October 2016 at 12:29, David Faure wrote: > Dear packagers, > > KDE Frameworks 5.27.0 has been uploaded to the usual place. > >

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 196 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/196/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 04 Oct 2016 10:23:16 + Build duration: 5 min 48 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 196 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/196/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 04 Oct 2016 10:23:16 + Build duration: 7 min 29 sec CHANGE

Re: Review Request 129090: use ECM variables to find binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129090/ --- (Updated Oct. 4, 2016, 12:20 p.m.) Status -- This change has been

Re: Review Request 129092: Fix crashes in NotifyByAudio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/#review99754 --- Is it this? https://bugs.kde.org/show_bug.cgi?id=348414

Re: Review Request 129092: Fix crashes in NotifyByAudio

> On Oct. 4, 2016, 7:32 a.m., Anthony Fieroni wrote: > > This is not a correct place to patch it. What is your used phonon backend? > > Albert Astals Cid wrote: > I disagree with you, none of the phonon backends call finished from stop, > because finished means "i reached the end of the

Re: Review Request 129092: Fix crashes in NotifyByAudio

> On Oct. 4, 2016, 4:32 a.m., Anthony Fieroni wrote: > > This is not a correct place to patch it. What is your used phonon backend? I disagree with you, none of the phonon backends call finished from stop, because finished means "i reached the end of the file" while stop just means stop. >