Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Tobias Berner 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 20, 2016, 7:52 a.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup


Diffs
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing (updated)
---

Builds fine. And it is actually working :)


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Tobias Berner 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 20, 2016, 7:47 a.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Changes
---

fix identation (4spaces)


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Gleb Popov 


> On Oct. 19, 2016, 11:07 p.m., Oswald Buddenhagen wrote:
> > an update about the runtime testing would be nice ;)

Here it is: https://git.reviewboard.kde.org/r/129197/

With this and that patch, the test passes on FreeBSD.


- Gleb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100144
---


On Oct. 19, 2016, 10:51 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 19, 2016, 10:51 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 4921e58 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Oswald Buddenhagen 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100144
---



an update about the runtime testing would be nice ;)


cmake/FindUTEMPTER.cmake (line 47)


just noticed: indentation wrong.


- Oswald Buddenhagen


On Oct. 19, 2016, 7:51 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 19, 2016, 7:51 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 4921e58 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Tobias Berner 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/
---

(Updated Oct. 19, 2016, 9:51 p.m.)


Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.


Changes
---

switch from "#if !defined(UTEMPTER_ULOG)" to "#ifndef UTEMPTER_ULOG".


Repository: kpty


Description
---

FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
`/usr/libexec/ulog-helper` [1].

It uses `login` instead of `add` and `logout` instead of `del`.


[1] 
https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake 4921e58 
  src/kpty.cpp 7bf31c3 

Diff: https://git.reviewboard.kde.org/r/129122/diff/


Testing
---

Builds fine. Still need to test if it is actually working.


Thanks,

Tobias Berner

Re: Adding new protocols to network KIO

2016-10-19 Thread David Faure 
Hi Gerhard,

I really don't know anything about zeroconf/avahi, but I see that the related 
code is in the framework kdnssd.  (Not sure how that interacts with KIO...)

Cc'ing the maintainer (Matthew Dawson), the KDE frameworks list, 
But looking at the git log it seems not much happened on that framework since 
the port to Qt5 ... so maybe it's just some porting bugs that haven't been 
caught yet. Happy debugging ;)


PS: I approved the KUrl change though, seems clear.

On mercredi 19 octobre 2016 17:51:07 CEST Gerhard Gappmeier wrote:
> Hallo David,
> 
> I tried to integrate a new protocol (OPC UA, a protocol for industrial
> automation technology) into network KIO (zeroconf).
> 
> OPC UA itself can make already use from Zeroconf inside UA applications to
> discover OPC UA servers. But I would like to integrate it also into Dolphin,
> so that you are able to connect to UA servers simply in Dolphin by clicking
> on discovered UA servers, very similar to SSH, SFTP, etc.
> 
> Using avahi service files it is very easy for Linux based servers to
> announce themselves without programming anything. Simply put the service
> file into /etc/avahi/services.
> Example:
> 
>   %h
>   
> _opcua._tcp
> 4840
>   
> 
> 
> This way the service appears using "avahi-browse -a".
> 
> Also in KDE4 it appears in dolphin in network://
> In KDE5 it does not appear, it seems this get filtered somehow.
> 
> Now I've two questions:
> 1.) How to get KDE5 to show this service
> 2.) How to configure KDE or Freedesktop MIME stuff so that with a click on
> the service in Dolphin an associated application gets started.
> 
> I was already able to make xdg-open (which calls kde-open) working with
> opc.tcp:// urls following this description:
> http://edoceo.com/howto/xfce-custom-uri-handler
> (Actually I needed to fix a bug to make this workingin KDE4, see
> https://git.reviewboard.kde.org/r/129208/ )
> 
> But Dolphin or the network KIO seems to need additional configuration.
> But I don't know the details and could not find any documentation on this
> topic.
> 
> I hope you can help me with this or give me a contact which knows about
> this. Thx a lot.


-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Review Request 129223: ClipboardUpdated: fix another crash on Wayland

2016-10-19 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129223/
---

Review request for KDE Frameworks.


Bugs: 359883
https://bugs.kde.org/show_bug.cgi?id=359883


Repository: kio


Description
---

Same rationale as https://git.reviewboard.kde.org/r/129222/

Though in this case the crash could also be fixed in KCoreAddons, by checking 
the pointer passed to KUrlMimeData::urlsFromMimeData(). Not sure which strategy 
is the best...


Diffs
-

  src/widgets/clipboardupdater.cpp a459aa777ae5bc328cf8807827ed24ddaf952d6d 

Diff: https://git.reviewboard.kde.org/r/129223/diff/


Testing
---


Thanks,

Elvis Angelaccio

Re: Review Request 129223: ClipboardUpdater: fix another crash on Wayland

2016-10-19 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129223/
---

(Updated Oct. 19, 2016, 3:36 p.m.)


Review request for KDE Frameworks.


Summary (updated)
-

ClipboardUpdater: fix another crash on Wayland


Bugs: 359883
https://bugs.kde.org/show_bug.cgi?id=359883


Repository: kio


Description
---

Same rationale as https://git.reviewboard.kde.org/r/129222/

Though in this case the crash could also be fixed in KCoreAddons, by checking 
the pointer passed to KUrlMimeData::urlsFromMimeData(). Not sure which strategy 
is the best...


Diffs
-

  src/widgets/clipboardupdater.cpp a459aa777ae5bc328cf8807827ed24ddaf952d6d 

Diff: https://git.reviewboard.kde.org/r/129223/diff/


Testing
---


Thanks,

Elvis Angelaccio

Review Request 129222: ClipboardUpdater: fix crash on Wayland

2016-10-19 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129222/
---

Review request for KDE Frameworks.


Bugs: 370520
https://bugs.kde.org/show_bug.cgi?id=370520


Repository: kio


Description
---

QClipboard::mimeData() can return a nullptr on Wayland. The documentation of 
the method doesn't say that the pointer can never be null, anyway.


Diffs
-

  src/widgets/clipboardupdater.cpp a459aa777ae5bc328cf8807827ed24ddaf952d6d 

Diff: https://git.reviewboard.kde.org/r/129222/diff/


Testing
---


Thanks,

Elvis Angelaccio

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 340 - Fixed!

2016-10-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/340/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Oct 2016 13:15:02 +
Build duration: 12 min

CHANGE SET
Revision b2ddfb6ca19087f0e02d6af251819454bc9be7f9 by kainz.a: (remove sass file 
cause it's located in 64px)
  change: delete icons/mimetypes/text-x-sass.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 340 - Fixed!

2016-10-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/340/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Oct 2016 13:15:02 +
Build duration: 12 min

CHANGE SET
Revision b2ddfb6ca19087f0e02d6af251819454bc9be7f9 by kainz.a: (remove sass file 
cause it's located in 64px)
  change: delete icons/mimetypes/text-x-sass.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 342 - Fixed!

2016-10-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/342/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Oct 2016 13:15:02 +
Build duration: 4 min 4 sec

CHANGE SET
Revision b2ddfb6ca19087f0e02d6af251819454bc9be7f9 by kainz.a: (remove sass file 
cause it's located in 64px)
  change: delete icons/mimetypes/text-x-sass.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 342 - Fixed!

2016-10-19 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/342/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 19 Oct 2016 13:15:02 +
Build duration: 4 min 4 sec

CHANGE SET
Revision b2ddfb6ca19087f0e02d6af251819454bc9be7f9 by kainz.a: (remove sass file 
cause it's located in 64px)
  change: delete icons/mimetypes/text-x-sass.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Oswald Buddenhagen 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129122/#review100127
---



doesn't look fundamentally wrong ^^


src/kpty.cpp (line 78)


no space after the !

or just use ifndef


- Oswald Buddenhagen


On Oct. 13, 2016, 2:08 p.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129122/
> ---
> 
> (Updated Oct. 13, 2016, 2:08 p.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald 
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> FreeBSD does not have `/usr/libexec/*/utempter`. It does however have 
> `/usr/libexec/ulog-helper` [1].
> 
> It uses `login` instead of `add` and `logout` instead of `del`.
> 
> 
> [1] 
> https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake 9773963 
>   src/kpty.cpp 7bf31c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129122/diff/
> 
> 
> Testing
> ---
> 
> Builds fine. Still need to test if it is actually working.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>