Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Andreas Sturmlechner
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > >

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Andreas Sturmlechner
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > >

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Harald Sitter
> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. You take

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 268 - Fixed!

2016-11-18 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/268/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 22:15:43 + Build duration: 1 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 268 - Fixed!

2016-11-18 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/268/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 22:15:43 + Build duration: 1 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

[KUnitConversion] Question about overloading operators

2016-11-18 Thread Ander Pijoan
Hi all, First of all sorry if this email should be in another list. I have a small question about summing, subtracting, multiplying... Values. I see that the operators have not been overloaded. Should we extend the Value class and overload them or there is a more straightforward way of operating

Re: Review Request 129426: refactor gpg finding

2016-11-18 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/#review100933 --- CMakeLists.txt (line 37)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 281 - Unstable!

2016-11-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/281/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 18:31:56 + Build duration: 33 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux,gcc - Build # 267 - Failure!

2016-11-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/267/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 18:46:46 + Build duration: 2 min 35 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 276 - Unstable!

2016-11-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/276/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 18:25:58 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 146 - Fixed!

2016-11-18 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 17:44:23 + Build duration: 6 min 16 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 146 - Fixed!

2016-11-18 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Nov 2016 17:44:23 + Build duration: 6 min 16 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: RE : Re: Send Email with attachment with my Qt Application

2016-11-18 Thread Boudhayan Gupta
Hi Charles-Elie, On 17 November 2016 at 12:08, Charles-Élie G wrote: > Hi, > > In fact I think that KService must be built with CMake and after be used > with QMake or CMake. No ? Yes, that is correct. It must be built with CMake. We generate PRI files that enable it to be

Re: Review Request 128442: [KIconDialog] Allow showing icons from all categories

2016-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128442/ --- (Updated Nov. 18, 2016, 5:57 p.m.) Status -- This change has been

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

2016-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128680/ --- (Updated Nov. 18, 2016, 3:51 p.m.) Status -- This change has been

Review Request 129426: refactor gpg finding

2016-11-18 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/ --- Review request for KDE Frameworks. Repository: kwallet Description

[Differential] [Planned Changes To] D3393: Make compile against WinXP SDK

2016-11-18 Thread kfunk (Kevin Funk)
kfunk planned changes to this revision. kfunk added inline comments. INLINE COMMENTS > dhaumann wrote in kioglobal_p_win.cpp:87 > Or should it just return false in this case? Thinking about it, yep, probably better that way. Will update the patch. REVISION DETAIL

Re: kapidox and non-frameworks source

2016-11-18 Thread René J . V . Bertin
On Friday November 18 2016 11:19:41 Olivier Churlaud wrote: Hi, I don't think there's anything personal in your reply so I'm keeping it on the ML, for general reference. > Could you be more specific? > - What are you running it on? > - Did you add a metainfo.yaml? A README.md or a

RE : Re: Send Email with attachment with my Qt Application

2016-11-18 Thread Charles-Élie G
Hi, In fact I think that KService must be built with CMake and after be used with QMake or CMake. No ? ++ Charlie Envoyé de mon Galaxy S6 Orange Message d'origine De : Christoph Feck Date : 16/11/2016 21:36 (GMT+01:00) À : kde-frameworks-devel@kde.org Objet :

kapidox and non-frameworks source

2016-11-18 Thread René J . V . Bertin
Hi, I've been having issues generating API docs with KApiDox v. 5.24.0 and later, at least for projects that aren't KF5 frameworks. The online documentation of the framework itself (https://api.kde.org/frameworks/kapidox/html/index.html) suggests that this shouldn't matter, but with version

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129298/#review100927 --- Ship it! Ship It! - Marco Martin On Nov. 17, 2016, 4

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Marco Martin
> On Nov. 17, 2016, 5:06 p.m., Marco Martin wrote: > > like it, still have some issues with the > > my concern is that an id by itself is not really identifying information > > enough (would in this case for instance colorschemes.knsrc in the url > > identify something on the server which can

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Dan Leinir Turthra Jensen
> On Nov. 17, 2016, 5:06 p.m., Marco Martin wrote: > > like it, still have some issues with the > > my concern is that an id by itself is not really identifying information > > enough (would in this case for instance colorschemes.knsrc in the url > > identify something on the server which can

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

2016-11-18 Thread Luke Dashjr
> On Nov. 17, 2016, 9:18 p.m., Dominik Haumann wrote: > > src/utils/document.cpp, line 97 > > > > > > Is this correct? y and x are switched, do you know any reason for this? > > Did you test? I just copied the

Re: Review Request 129398: Restore KTextEditor Document Dbus bindings

2016-11-18 Thread Luke Dashjr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129398/ --- (Updated Nov. 18, 2016, 8:53 a.m.) Review request for Kate, KDE