Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

2016-12-26 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101583
---


Ship it!




Ship It!

- Martin Klapetek


On Dec. 26, 2016, 5:54 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> ---
> 
> (Updated Dec. 26, 2016, 5:54 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> "no_reason_specified" looks annoying reason
> 
> 
> Diffs
> -
> 
>   src/knotificationrestrictions.h e9179ae 
>   src/knotificationrestrictions.cpp 5f5d908 
> 
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129706: Don't focus progress windows

2016-12-26 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101581
---



Use QWidget::setAttribute with Qt::WA_ShowWithoutActivating

- Martin Gräßlin


On Dec. 26, 2016, 4:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Dec. 26, 2016, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> If there is already a window with focus, re-set focus to that so we
>  don't steal focus. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when this is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Re: Review Request 129706: Don't focus progress windows

2016-12-26 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101580
---




src/kwidgetjobtracker.cpp (line 82)


You can try
vi->setWindowFlags(windowFlags() | Qt::WindowDoesNotAcceptFocus);

I didn't know there is input required widget ?


- Anthony Fieroni


On Дек. 26, 2016, 5:15 след обяд, Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Дек. 26, 2016, 5:15 след обяд)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> If there is already a window with focus, re-set focus to that so we
>  don't steal focus. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when this is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

[Differential] [Request, 15 lines] D3812: Deprecate Plasma::Package API in PluginLoader

2016-12-26 Thread Martin Gräßlin 
graesslin created this revision.
graesslin added reviewers: Plasma, Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As Plasma::Package is deprecated API using Plasma::Package should also
  be deprecated.

REPOSITORY
  R242 Plasma Frameworks

BRANCH
  deprecate-package-in-pluginloader

REVISION DETAIL
  https://phabricator.kde.org/D3812

AFFECTED FILES
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, #frameworks
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 129706: Don't focus progress windows

2016-12-26 Thread Martin Tobias Holmedahl Sandsmark 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/
---

Review request for KDE Frameworks, Albert Astals Cid and David Faure.


Bugs: 333934
https://bugs.kde.org/show_bug.cgi?id=333934


Repository: kjobwidgets


Description
---

If there is already a window with focus, re-set focus to that so we
 don't steal focus. This is especially important since there's a 0.5s
 delay before the window is shown so people often start interacting with
 the original window when this is shown.


Diffs
-

  src/kwidgetjobtracker.cpp 585867a 

Diff: https://git.reviewboard.kde.org/r/129706/diff/


Testing
---

Job progress widgets don't steal focus anymore.


Thanks,

Martin Tobias Holmedahl Sandsmark