date:20161227


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/328/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 02:58:48 +
Build duration: 7 min 39 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29455/51489 
(57%)CONDITIONAL 16161/38631 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7831/8155 
(96%)CONDITIONAL 4387/8582 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7894/14168 
(56%)CONDITIONAL 4321/9233 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3454/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3780 
(47%)CONDITIONAL 1261/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3625/11007 
(33%)CONDITIONAL 1745/7096 (25%)

Jenkins-kde-ci: kjs master stable-kf5-qt5 » Linux,gcc - Build # 154 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjs%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/154/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 02:43:42 +
Build duration: 3 min 1 sec

CHANGE SET
No changes

Jenkins-kde-ci: kjs master kf5-qt5 » Linux,gcc - Build # 151 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/151/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 02:22:55 +
Build duration: 30 sec

CHANGE SET
No changes

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 131 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/131/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 02:06:45 +
Build duration: 43 sec

CHANGE SET
No changes

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 126 - Failure!


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/126/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 02:01:07 +
Build duration: 1 min 5 sec

CHANGE SET
No changes

Re: Scheduled downtime: spring.kde.org

2016-12-27 Thread Ben Cooksley

Hi all,

The system upgrade has now been completed - all of the previously
mentioned services should now be back online.
Please let us know if you find anything which is not functioning correctly.

Thanks,
Ben

Re: Review Request 129658: KConfigDialogManager: cleanup static maps



> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..
> 
> Anthony Fieroni wrote:
> Maybe you should keep all deprecated classes hardcoded.
> 
> Elvis Angelaccio wrote:
> Yeah.
> @Albert: it's ok for you if I only remove the kdelibs3 class names? If 
> you want I can also split this patch in 2 commits (one for the QMetaObject 
> conversion and another one for the kdelibs3 cleanup).

having two patches is a much easier way to be able to review them i'd say.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps



> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..
> 
> Anthony Fieroni wrote:
> Maybe you should keep all deprecated classes hardcoded.

Yeah.
@Albert: it's ok for you if I only remove the kdelibs3 class names? If you want 
I can also split this patch in 2 commits (one for the QMetaObject conversion 
and another one for the kdelibs3 cleanup).


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Anthony Fieroni



> On Дек. 27, 2016, 11:16 след обяд, Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html
> 
> Elvis Angelaccio wrote:
> Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from 
> KF5 and KButtonGroup from kdelibs4support at the same time..

Maybe you should keep all deprecated classes hardcoded.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Дек. 16, 2016, 5:05 след обяд, Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Дек. 16, 2016, 5:05 след обяд)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: All Frameworks modules are now available as repositories on Phabricator

2016-12-27 Thread Ben Cooksley

On Wed, Dec 28, 2016 at 8:56 AM, Luigi Toscano  wrote:
> Elvis Angelaccio ha scritto:
>> On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano  
>> wrote:
>>> ... so that it's easier to use Differential for reviews.
>>
>> Thanks!
>> What about tasks? Should we create a Workboard for the Frameworks
>> project? Or is it planned that each framework be a Project with its
>> own workboard?
>
> This is entirely up to each maintainer. I personally think that 80% of the
> modules in Frameworks don't need a separate project for each of them, but
> again, if someone needs a separate project (and workboard), sure, it can be
> created.

For this very reason, as a general rule we'll only be creating
projects on a as-needed / requested basis (as a forest of empty and
unused projects splinters focus, makes it harder for new people to get
involved, etc)

>
> Ciao
> --
> Luigi
>

Cheers,
Ben

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-27 Thread ltoscano (Luigi Toscano)

ltoscano added a reviewer: KDE Buildsystem.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D2854

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, staniek, #frameworks, #kde_buildsystem
Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

[Differential] [Updated] D3733: Force colored warnings in ninja's output

2016-12-27 Thread ltoscano (Luigi Toscano)

ltoscano added a reviewer: KDE Buildsystem.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3733

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #frameworks, #kde_buildsystem

Re: Review Request 129658: KConfigDialogManager: cleanup static maps



> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.
> 
> Elvis Angelaccio wrote:
> Why? Isn't it deprecated? 
> https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html

Ah wait, I see it now: a kf5 app could be using KConfigDialogManager from KF5 
and KButtonGroup from kdelibs4support at the same time..


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps



> On Dec. 27, 2016, 9:18 p.m., Christoph Feck wrote:
> > className() is just a char pointer. Is it possible to convert the maps to 
> > not use QString?

I don't think so, they are public api, e.g. `static QHash 
*changedMap();`


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101612
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps



> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote:
> > -1 Don't break what is not broken.
> > 
> > First thing i check "KButtonGroup", is already wrong to be removed.

Why? Isn't it deprecated? 
https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129709: Fix checking for valid date entered

2016-12-27 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129709/#review101609
---



There is autotests/kdatecomboboxtest.cpp. Does it need adaptions? If not, does 
it still pass?

- Christoph Feck


On Dec. 27, 2016, 6:46 p.m., David Jarvie wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129709/
> ---
> 
> (Updated Dec. 27, 2016, 6:46 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Checks to determine whether an entered date is valid are wrong or missing in 
> various places in the code. This is due to:
> - not testing if a minimum or maximum date is set before comparing a date to 
> the minimum/maximum;
> - always rejecting new minimum/maximum dates if the other maximum/minimum 
> date is not set;
> - not testing dates for validity when set by the date picker or menu.
> 
> This results in the following bugs currently:
> - When an up/down arrow or page up/down key is pressed to change the date, it 
> is always considered invalid and the date is not changed.
> - When the DateKeywords option is set, the only date which is displayed in 
> the menu is "No Date".
> - setMinimumDate() and resetMinimumDate() do nothing if no maximum date is 
> currently set.
> - setMaximumDate() and resetMaximumDate() do nothing if no minimum date is 
> currently set.
> - resetDateRange() does nothing.
> 
> This patch fixes the above bugs.
> 
> Documentation comments in the header file are also improved.
> 
> 
> Diffs
> -
> 
>   src/kdatecombobox.h d9a20ca 
>   src/kdatecombobox.cpp ad1d085 
> 
> Diff: https://git.reviewboard.kde.org/r/129709/diff/
> 
> 
> Testing
> ---
> 
> Tested with KAlarm, including setting DateKeywords. The bugs described above 
> are now fixed.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

Re: Review Request 129709: Fix checking for valid date entered


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129709/#review101613
---



I'd say this could really do with some autotests

- Albert Astals Cid


On Dec. 27, 2016, 5:46 p.m., David Jarvie wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129709/
> ---
> 
> (Updated Dec. 27, 2016, 5:46 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Checks to determine whether an entered date is valid are wrong or missing in 
> various places in the code. This is due to:
> - not testing if a minimum or maximum date is set before comparing a date to 
> the minimum/maximum;
> - always rejecting new minimum/maximum dates if the other maximum/minimum 
> date is not set;
> - not testing dates for validity when set by the date picker or menu.
> 
> This results in the following bugs currently:
> - When an up/down arrow or page up/down key is pressed to change the date, it 
> is always considered invalid and the date is not changed.
> - When the DateKeywords option is set, the only date which is displayed in 
> the menu is "No Date".
> - setMinimumDate() and resetMinimumDate() do nothing if no maximum date is 
> currently set.
> - setMaximumDate() and resetMaximumDate() do nothing if no minimum date is 
> currently set.
> - resetDateRange() does nothing.
> 
> This patch fixes the above bugs.
> 
> Documentation comments in the header file are also improved.
> 
> 
> Diffs
> -
> 
>   src/kdatecombobox.h d9a20ca 
>   src/kdatecombobox.cpp ad1d085 
> 
> Diff: https://git.reviewboard.kde.org/r/129709/diff/
> 
> 
> Testing
> ---
> 
> Tested with KAlarm, including setting DateKeywords. The bugs described above 
> are now fixed.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-27 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101612
---



className() is just a char pointer. Is it possible to convert the maps to not 
use QString?

- Christoph Feck


On Dec. 16, 2016, 4:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129659: KConfigDialogManager: improve documentation for custom widgets


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129659/#review101611
---


Ship it!




Ship It!

- Albert Astals Cid


On Dec. 16, 2016, 3:44 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129659/
> ---
> 
> (Updated Dec. 16, 2016, 3:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> It was not 100% clear how to use custom widgets: propertyMap() contains only 
> USER properties, so there is no need to add custom widgets there if one is 
> using the non-USER `kcfg_property` property.
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 1e27ed29d8ff12a2e3e4c99853fbebc4f95b6cad 
> 
> Diff: https://git.reviewboard.kde.org/r/129659/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101610
---



-1 Don't break what is not broken.

First thing i check "KButtonGroup", is already wrong to be removed.

- Albert Astals Cid


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

[Differential] [Accepted] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

2016-12-27 Thread aacid (Albert Astals Cid)

aacid accepted this revision.
aacid added a reviewer: aacid.
This revision is now accepted and ready to land.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  kglobalaccel-test-mode

REVISION DETAIL
  https://phabricator.kde.org/D3689

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks, aacid
Cc: aacid

Re: Review Request 129659: KConfigDialogManager: improve documentation for custom widgets


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129659/#review101607
---



Ping?

- Elvis Angelaccio


On Dec. 16, 2016, 3:44 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129659/
> ---
> 
> (Updated Dec. 16, 2016, 3:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> It was not 100% clear how to use custom widgets: propertyMap() contains only 
> USER properties, so there is no need to add custom widgets there if one is 
> using the non-USER `kcfg_property` property.
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 1e27ed29d8ff12a2e3e4c99853fbebc4f95b6cad 
> 
> Diff: https://git.reviewboard.kde.org/r/129659/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129658: KConfigDialogManager: cleanup static maps


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129658/#review101606
---



Ping?

- Elvis Angelaccio


On Dec. 16, 2016, 3:05 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129658/
> ---
> 
> (Updated Dec. 16, 2016, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> The static maps s_changedMaps() and s_propertyMap() still contain a bunch of 
> old class names (even from kdelibs3 times!). This patch replaces most of the 
> hardcoded class names with `QMetaObject::className()`, to ensure compile-time 
> checks and that we don't use non-kf5 classes. We keep the hardcoded names 
> only for widgets in frameworks we don't depen on (KCompletion, KTextWidgets, 
> KIO).
> 
> 
> Diffs
> -
> 
>   src/kconfigdialogmanager.h 4660805ed12d97c2f9c87fdd247ed46f96fd4f22 
>   src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/129658/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: All Frameworks modules are now available as repositories on Phabricator

2016-12-27 Thread Luigi Toscano

Elvis Angelaccio ha scritto:
> On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano  
> wrote:
>> ... so that it's easier to use Differential for reviews.
> 
> Thanks!
> What about tasks? Should we create a Workboard for the Frameworks
> project? Or is it planned that each framework be a Project with its
> own workboard?

This is entirely up to each maintainer. I personally think that 80% of the
modules in Frameworks don't need a separate project for each of them, but
again, if someone needs a separate project (and workboard), sure, it can be
created.

Ciao
-- 
Luigi

Re: All Frameworks modules are now available as repositories on Phabricator

On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano  wrote:
> ... so that it's easier to use Differential for reviews.

Thanks!
What about tasks? Should we create a Workboard for the Frameworks
project? Or is it planned that each framework be a Project with its
own workboard?

>
> --
> Luigi

Elvis

Re: Minimum required cmake version

2016-12-27 Thread Aleix Pol

On Tue, Dec 27, 2016 at 7:25 PM, Sven Brauch  wrote:
> On 27/12/16 19:23, Aleix Pol wrote:
>> Makes sense, although you still won't be able to compile these
>> frameworks on CentOS 6.8 even if we fix that, right?
> I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of
> "cmake". That's why I was running cmake 2.8 so far, and noticed this issue.
>
> It doesn't prevent me from compiling, it just doesn't make sense to
> specify 2.8 as the minimum if it doesn't actually work (and was
> confusing to find out).
>
> Sven
>

Now everything makes sense, thanks!

I confirm Q_GADGET is mentioned in cmake 3.0.0 codebase while it isn't
in 2.8.11.
+1 on changing to 3.0.

Aleix

Re: Minimum required cmake version

2016-12-27 Thread Sven Brauch

On 27/12/16 19:23, Aleix Pol wrote:
> Makes sense, although you still won't be able to compile these
> frameworks on CentOS 6.8 even if we fix that, right?
I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of
"cmake". That's why I was running cmake 2.8 so far, and noticed this issue.

It doesn't prevent me from compiling, it just doesn't make sense to
specify 2.8 as the minimum if it doesn't actually work (and was
confusing to find out).

Sven



signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

2016-12-27 Thread Aleix Pol

On Tue, Dec 27, 2016 at 7:20 PM, Sven Brauch  wrote:
> Hi,
>
> On 27/12/16 19:18, Aleix Pol wrote:
>> Have you checked that changing to cmake 3.0 actually solves this
>> problem?
> I have 3.6 on the same system and with that it works. I don't have 3.0. :/
>
> However, 3.0 docs explicitly mentions Q_GADGET.

Makes sense, although you still won't be able to compile these
frameworks on CentOS 6.8 even if we fix that, right?

Aleix

Re: Minimum required cmake version

2016-12-27 Thread Sven Brauch

Hi,

On 27/12/16 19:18, Aleix Pol wrote:
> Have you checked that changing to cmake 3.0 actually solves this
> problem?
I have 3.6 on the same system and with that it works. I don't have 3.0. :/

However, 3.0 docs explicitly mentions Q_GADGET.

Greetings,
Sven



signature.asc
Description: OpenPGP digital signature

Re: Minimum required cmake version

2016-12-27 Thread Aleix Pol

On Tue, Dec 27, 2016 at 5:48 PM, Sven Brauch  wrote:
> Hi,
>
> building on CentOS 6.8, I noticed some frameworks (namely KAuth,
> KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to
> be related with moc'ing the Q_GADGET macro. Still, they specify cmake
> 2.8 as the minimum required cmake version.
>
> Do we
>  - attempt to fix this with cmake 2.8
>  - bump the required cmake version to 3.0 for these frameworks
>  - bump the required cmake version to 3.0 for all frameworks?
>
> Greetings,
> Sven

Hi Sven,
Have you checked that changing to cmake 3.0 actually solves this
problem? If so, I'd say 3.0 (June 2014) is an acceptable minimum cmake
version.

Aleix

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 327 - Still Unstable!


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/327/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Dec 2016 17:57:06 +
Build duration: 16 min

CHANGE SET
Revision 76f89c46d8645eec53795b26f1af7d669cea2c50 by David Faure: (Fix 
CMakeLists.txt for windows, blindly, since the windows guys report)
  change: edit src/ioslaves/trash/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29447/51489 
(57%)CONDITIONAL 16160/38631 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7828/8155 
(96%)CONDITIONAL 4386/8582 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7893/14168 
(56%)CONDITIONAL 4320/9233 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3448/7559 
(46%)CONDITIONAL 1280/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/842 (53%)CONDITIONAL 
329/745 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 
(46%)CONDITIONAL 1252/3460 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 
(63%)CONDITIONAL 411/833 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3625/11007 
(33%)CONDITIONAL 1745/7096 (25%)

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

2016-12-27 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129704/
---

(Updated Dec. 27, 2016, 6:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit dc4474125ca85003ade1550517f602cde1b70ab8 by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

They're supposed to do the same, completely different codebases. Also some 
things had to be ported.

I'd recommend everything to be ported to use kpackagetool (knsrc files!) but 
still it's better to at least make sure we stick to one set of features.


Diffs
-

  src/plasmapkg/CMakeLists.txt 7d3df5d22 
  src/plasmapkg/main.cpp dfbd2f4c3 
  src/plasmapkg/plasmapkg.h 3383980db 
  src/plasmapkg/plasmapkg.cpp 3724ae85e 

Diff: https://git.reviewboard.kde.org/r/129704/diff/


Testing
---

`plasmapkg2 --help` returns `kpackagetool5`'s.


Thanks,

Aleix Pol Gonzalez

Minimum required cmake version

2016-12-27 Thread Sven Brauch

Hi,

building on CentOS 6.8, I noticed some frameworks (namely KAuth,
KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to
be related with moc'ing the Q_GADGET macro. Still, they specify cmake
2.8 as the minimum required cmake version.

Do we
 - attempt to fix this with cmake 2.8
 - bump the required cmake version to 3.0 for these frameworks
 - bump the required cmake version to 3.0 for all frameworks?

Greetings,
Sven




signature.asc
Description: OpenPGP digital signature

Re: Review Request 129709: Fix checking for valid date entered

2016-12-27 Thread David Jarvie


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129709/
---

(Updated Dec. 27, 2016, 5:46 p.m.)


Review request for KDE Frameworks and John Layt.


Changes
---

Updated to fix (re)setMinimumDate(), (re)setMaximumDate() and to check dates 
for validity if entered via date picker or menu.


Repository: kwidgetsaddons


Description (updated)
---

Checks to determine whether an entered date is valid are wrong or missing in 
various places in the code. This is due to:
- not testing if a minimum or maximum date is set before comparing a date to 
the minimum/maximum;
- always rejecting new minimum/maximum dates if the other maximum/minimum date 
is not set;
- not testing dates for validity when set by the date picker or menu.

This results in the following bugs currently:
- When an up/down arrow or page up/down key is pressed to change the date, it 
is always considered invalid and the date is not changed.
- When the DateKeywords option is set, the only date which is displayed in the 
menu is "No Date".
- setMinimumDate() and resetMinimumDate() do nothing if no maximum date is 
currently set.
- setMaximumDate() and resetMaximumDate() do nothing if no minimum date is 
currently set.
- resetDateRange() does nothing.

This patch fixes the above bugs.

Documentation comments in the header file are also improved.


Diffs (updated)
-

  src/kdatecombobox.h d9a20ca 
  src/kdatecombobox.cpp ad1d085 

Diff: https://git.reviewboard.kde.org/r/129709/diff/


Testing
---

Tested with KAlarm, including setting DateKeywords. The bugs described above 
are now fixed.


Thanks,

David Jarvie

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-12-27 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/#review101602
---




src/kwindowsystem.cpp (lines 728 - 732)


why did you ifdef the section? It's just a runtime switch not depending on 
any platform specific libraries like the X11 case.



src/platforms/osx/kwindowinfo.mm (line 33)


what's "Ext"?



src/platforms/osx/kwindowinfo.mm (line 36)


?



src/platforms/osx/kwindowinfo.mm (lines 38 - 40)


why are there both public and private variables? For a d-ptr class I don't 
really understand this



src/platforms/osx/kwindowinfo.mm (lines 273 - 276)


?



src/platforms/osx/kwindowinfo.mm (line 336)


QByteArrayLiteral



src/platforms/osx/kwindowinfo.mm (line 346)


QByteArrayLiteral



src/platforms/osx/kwindowinfo.mm (line 349)


I'm pretty sure the NETWM spec is irrelevant on cocoa



src/platforms/osx/kwindowinfo_p_cocoa.h (line 74)


wtf is that?



src/platforms/osx/kwindowsystem.cpp (lines 47 - 53)


?



src/platforms/osx/kwindowsystem_mac_p.h (line 24)


do we really need this? That's way too much ifedery for me. Either we have 
that feature or not. Have finished things I don't want to see in our code.



src/platforms/osx/kwindowsystem_macobjc.mm (lines 63 - 65)


?



src/platforms/osx/kwindowsystem_macobjc.mm (line 104)


is there a possibility that Qt does not use Cocoa?



src/platforms/osx/kwindowsystem_macobjc.mm (line 108)


?



src/platforms/osx/kwindowsystem_macobjc.mm (lines 111 - 113)


?



src/platforms/osx/kwindowsystem_macobjc.mm (lines 137 - 138)


?



src/platforms/osx/kwindowsystem_macobjc.mm (lines 286 - 295)


?



src/platforms/osx/kwindowsystem_macobjc.mm (lines 301 - 324)


?



src/platforms/osx/kwindowsystem_macobjc.mm (line 518)


?



src/platforms/osx/plugin.h (line 2)


I'm certainly not the author of this header file



src/platforms/osx/plugin.cpp (line 2)


Also not the author of this file.


- Martin Gräßlin


On Dec. 27, 2016, 5 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126291/
> ---
> 
> (Updated Dec. 27, 2016, 5 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> KWindowSystem has been lacking a platform plugin for OS X. This RR presents a 
> "backport" of the modified KDE4 KWindowSystem implementation that has been 
> used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.
> 
> I have made some initial steps to remove deprecated Carbon API calls, but 
> this is clearly a work in progress.
> 
> Open questions include
> - is there any justification to run an event handler (or Cocoa observer) to 
> keep track of running applications, possibly even listing all their open 
> windows?
> - is there any use for the Qt event listener framework (cf. the 
> NETEventFilter in the X11 plugin)? I haven't yet had time to try to figure 
> out what this "could be good for", and am very open to suggestions in this 
> departments.
> - one application for such an event filter would be a listener that catches 
> the opening and closing of all windows by the running process, and keeps 
> track of their `WId`s. A new method could then be added (to `KWindowInfo`?) 
> to distinguish `WId`s created by the running application from "foreign" ones 
> (useful also on Wayland and MS Windows).
> 
> `KWindowSystem::setMainWindow` should become a front for payload provided

Re: Review Request 129706: Don't focus progress windows

2016-12-27 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129706/#review101604
---


Ship it!




Ship It!

- Martin Gräßlin


On Dec. 27, 2016, 1:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129706/
> ---
> 
> (Updated Dec. 27, 2016, 1:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Martin 
> Gräßlin.
> 
> 
> Bugs: 333934
> https://bugs.kde.org/show_bug.cgi?id=333934
> 
> 
> Repository: kjobwidgets
> 
> 
> Description
> ---
> 
> Show the job tracking widget without stealing focus, e. g. from Kate
>  when saving to FTP. This is especially important since there's a 0.5s
>  delay before the window is shown so people often start interacting with
>  the original window when the job progress is shown.
> 
> 
> Diffs
> -
> 
>   src/kwidgetjobtracker.cpp 585867a 
> 
> Diff: https://git.reviewboard.kde.org/r/129706/diff/
> 
> 
> Testing
> ---
> 
> Job progress widgets don't steal focus anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 280 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/280/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 27 Dec 2016 17:21:19 +
Build duration: 11 min

CHANGE SET
Revision 4798310ed7885db9f665a488e583df7a911c7d58 by Martin Gräßlin: (Deprecate 
Plasma::Package API in PluginLoader)
  change: edit src/plasma/pluginloader.cpp
  change: edit src/plasma/pluginloader.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4499/11233 
(40%)CONDITIONAL 2355/8468 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1883 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1664/3601 
(46%)CONDITIONAL 954/2697 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 875/1567 
(56%)CONDITIONAL 403/1028 (39%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 335/1705 
(20%)CONDITIONAL 157/1297 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1140 (1%)CONDITIONAL 
1/982 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 280 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/280/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 27 Dec 2016 17:21:19 +
Build duration: 11 min

CHANGE SET
Revision 4798310ed7885db9f665a488e583df7a911c7d58 by Martin Gräßlin: (Deprecate 
Plasma::Package API in PluginLoader)
  change: edit src/plasma/pluginloader.cpp
  change: edit src/plasma/pluginloader.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4499/11233 
(40%)CONDITIONAL 2355/8468 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1883 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1664/3601 
(46%)CONDITIONAL 954/2697 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 875/1567 
(56%)CONDITIONAL 403/1028 (39%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 335/1705 
(20%)CONDITIONAL 157/1297 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1140 (1%)CONDITIONAL 
1/982 (0%)

[Differential] [Closed] D3812: Deprecate Plasma::Package API in PluginLoader

2016-12-27 Thread Martin Gräßlin

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4798310ed788: Deprecate Plasma::Package API in 
PluginLoader (authored by graesslin).

REPOSITORY
  R242 Plasma Frameworks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3812?vs=9366=9395

REVISION DETAIL
  https://phabricator.kde.org/D3812

AFFECTED FILES
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 129709: Fix checking for valid date entered

2016-12-27 Thread David Jarvie


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129709/
---

Review request for KDE Frameworks and John Layt.


Repository: kwidgetsaddons


Description
---

In two places, the checks to determine whether an entered date is valid is 
wrong, due to not testing whether a minimum or maximum date is set before 
comparing to the minimum/maximum date. When a minimum and maximum date is not 
set, this results in the following bugs currently:
- When an up/down arrow or page up/down key is pressed to change the date, it 
is always considered invalid and the date is not changed.
- When the DateKeywords option is set, the only date which is displayed for 
selection is "No Date".

This fixes the checks so that if a minimum date is not set, the date is always 
treated as complying with the minimum, and the maximum check is similarly fixed.

Documentation comments in the header file are also improved.


Diffs
-

  src/kdatecombobox.h d9a20ca 
  src/kdatecombobox.cpp ad1d085 

Diff: https://git.reviewboard.kde.org/r/129709/diff/


Testing
---

Tested with KAlarm, including setting DateKeywords. The bugs described above 
are now fixed.


Thanks,

David Jarvie

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

2016-12-27 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126369/
---

(Updated Dec. 27, 2016, 5:40 p.m.)

Review request for KDE Software on Mac OS X and KDE Frameworks.

Changes
---

really get rid of the setIconWithMask method.

Repository: knotifications

Description
---

OS X has a number of limitations in features used by KNotifications, notably
concerning the status notifier item (aka system tray icon).

This RR will likely evolve to address multiple limitations (at least also the
NeedsAttention state); at the moment it only proposes an emulation of
`QMenu::addSection`.

`QMenu::addSection` works by adding a QAction with a "texted separator" at the
insertion location. Texted separators do not exist in menu items in the OS X
"global" menubar (they become regular separators), and Qt will not provide a
platform-specific implementation. Loss of the section title text is maybe not
always an issue, but I think it is in the system tray menu. I therefore propose
to emulate `QMenu::addSection` by replacing the texted separator with an
inactive (disabled) menu item that shows the text, followed by a standard
separator. Menus in the notification area are much less subject to interface
guidelines, so the presence of an item icon is acceptable and IMO useful for
the `titleAction`.

Testing the NeedsAttention state with the tests/kstatusnotifieritemtest
application leads to disappearance of the menubar icon, i.e. the access to the
notifier menu becomes invisible rather than blinking (which is what I get on
Linux using the same packaging). Adding a few qDebug statements shows that the
`attentionIcon` is empty.
I'd appreciate a crash course how this feature is supposed to work, so I can
see if an OS X implementation might be feasible.

Diffs (updated)
-

CMakeLists.txt 06a4966
src/CMakeLists.txt 7eb3125
src/knotification.cpp 57a701c
src/kstatusnotifieritem.cpp 1cd5e00
tests/kstatusnotifieritemtest.cpp 973fc85

Diff: https://git.reviewboard.kde.org/r/126369/diff/

Testing
---

On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.17.0 .

File Attachments

the systray icon & menu created by kstatusnotifieritemtest . This application
has no icon to show.

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/286037ae-07b3-454a-a226-1748854493a1__kstatusnotifieritemtest-systray.png
The systray icon and menu created by the KDE4 kwalletmanager (code has an
equivalent patch)

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/4fc9d4e4-1537-478c-9196-94cbc17b6b7c__kwalletmanager-systray.png
An Apple systray icon+menu that shows icons (which cannot be hidden)

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fc48a963-2e18-4396-bd38-062d41688118__Apple-systray-menu-with-icons.png
kstatusnotifieritemtest with added appIcon

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/e896e90d-f0a8-43f7-9199-847572832df7__kstatusnotifieritemtest-with-appIcon.png
kstatusnotifieritemtest-with-appIcon+attention.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/f41081db-8e09-4ea2-95c1-f507c62109d4__kstatusnotifieritemtest-with-appIconattention.png

Thanks,

René J.V. Bertin

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

2016-12-27 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126369/
---

(Updated Dec. 27, 2016, 5:31 p.m.)

Review request for KDE Software on Mac OS X and KDE Frameworks.

Changes
---

refactored

Summary (updated)
-

[OS X] adaptation(s) to platform limitations

Repository: knotifications

Description
---

OS X has a number of limitations in features used by KNotifications, notably
concerning the status notifier item (aka system tray icon).

This RR will likely evolve to address multiple limitations (at least also the
NeedsAttention state); at the moment it only proposes an emulation of
`QMenu::addSection`.

Diffs (updated)
-

CMakeLists.txt 06a4966
src/CMakeLists.txt 7eb3125
src/knotification.cpp 57a701c
src/kstatusnotifieritem.cpp 1cd5e00
src/kstatusnotifieritemprivate_p.h 87e909d
tests/kstatusnotifieritemtest.cpp 973fc85

Diff: https://git.reviewboard.kde.org/r/126369/diff/

Testing
---

On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.17.0 .

File Attachments

the systray icon & menu created by kstatusnotifieritemtest . This application
has no icon to show.

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/4fc9d4e4-1537-478c-9196-94cbc17b6b7c__kwalletmanager-systray.png
An Apple systray icon+menu that shows icons (which cannot be hidden)

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fc48a963-2e18-4396-bd38-062d41688118__Apple-systray-menu-with-icons.png
kstatusnotifieritemtest with added appIcon

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/e896e90d-f0a8-43f7-9199-847572832df7__kstatusnotifieritemtest-with-appIcon.png
kstatusnotifieritemtest-with-appIcon+attention.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/f41081db-8e09-4ea2-95c1-f507c62109d4__kstatusnotifieritemtest-with-appIconattention.png

Thanks,

René J.V. Bertin

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-12-27 Thread René J . V . Bertin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/
---

(Updated Dec. 27, 2016, 5 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

bump

refactored against v4.100.0-rc1-189-g824d4f2 for 5.30.0


Repository: kwindowsystem


Description
---

KWindowSystem has been lacking a platform plugin for OS X. This RR presents a 
"backport" of the modified KDE4 KWindowSystem implementation that has been used 
in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.

I have made some initial steps to remove deprecated Carbon API calls, but this 
is clearly a work in progress.

Open questions include
- is there any justification to run an event handler (or Cocoa observer) to 
keep track of running applications, possibly even listing all their open 
windows?
- is there any use for the Qt event listener framework (cf. the NETEventFilter 
in the X11 plugin)? I haven't yet had time to try to figure out what this 
"could be good for", and am very open to suggestions in this departments.
- one application for such an event filter would be a listener that catches the 
opening and closing of all windows by the running process, and keeps track of 
their `WId`s. A new method could then be added (to `KWindowInfo`?) to 
distinguish `WId`s created by the running application from "foreign" ones 
(useful also on Wayland and MS Windows).

`KWindowSystem::setMainWindow` should become a front for payload provided by 
the plugins. I'll leave that to the regular/official maintainer(s) of this 
framework.

This code could probably do with *lots* of comments; I'll try to add them as 
questions about this or that bit of code arise.


Diffs (updated)
-

  src/kwindowsystem.h a282ecd 
  src/kwindowsystem.cpp fda1682 
  src/platforms/osx/CMakeLists.txt 4fc3347 
  src/platforms/osx/cocoa.json PRE-CREATION 
  src/platforms/osx/kkeyserver.cpp 3ddb921 
  src/platforms/osx/kwindowinfo.cpp e8555bb 
  src/platforms/osx/kwindowinfo.mm PRE-CREATION 
  src/platforms/osx/kwindowinfo_mac_p.h c8f307e 
  src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION 
  src/platforms/osx/kwindowsystem.cpp 1758829 
  src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION 
  src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION 
  src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION 
  src/platforms/osx/plugin.h PRE-CREATION 
  src/platforms/osx/plugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126291/diff/


Testing
---

On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 .


Thanks,

René J.V. Bertin

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 390 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/390/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Dec 2016 15:20:23 +
Build duration: 3 min 5 sec

CHANGE SET
Revision 3b6a13347ca3ed1784c86434d5298c4ccd8856ef by kainz.a: (remove 
duplicated icons)
  change: edit icons-dark/applets/48/weather-overcast.svg
  change: edit icons-dark/applets/48/weather-fog.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 390 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/390/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Dec 2016 15:20:23 +
Build duration: 3 min 5 sec

CHANGE SET
Revision 3b6a13347ca3ed1784c86434d5298c4ccd8856ef by kainz.a: (remove 
duplicated icons)
  change: edit icons-dark/applets/48/weather-overcast.svg
  change: edit icons-dark/applets/48/weather-fog.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 393 - Fixed!


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/393/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 27 Dec 2016 15:20:23 +
Build duration: 3 min 8 sec

CHANGE SET
Revision 3b6a13347ca3ed1784c86434d5298c4ccd8856ef by kainz.a: (remove 
duplicated icons)
  change: edit icons-dark/applets/48/weather-overcast.svg
  change: edit icons-dark/applets/48/weather-fog.svg


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 393 - Fixed!