Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 175 - Unstable!

2017-01-02 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/175/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 03 Jan 2017 01:37:36 +
Build duration: 5 min 19 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5460/7987 
(68%)CONDITIONAL 2952/6144 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1531 
(94%)CONDITIONAL 883/1770 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1222/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Closed] D3912: kdoctools_install: match the full path for the program

2017-01-02 Thread ltoscano (Luigi Toscano)
This revision was automatically updated to reflect the committed changes.
Closed by commit R238:938e439db206: kdoctools_install: match the full path for 
the program (authored by ltoscano).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3912?vs=9597=9622

REVISION DETAIL
  https://phabricator.kde.org/D3912

AFFECTED FILES
  KF5DocToolsMacros.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #frameworks, #documentation, aacid


Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-02 Thread Albert Astals Cid


> On Jan. 2, 2017, 10:53 p.m., Albert Astals Cid wrote:
> > I don't think this makes any sense. I understand your pain, would i'd 
> > rather improve the search of hunspell than accept it's crap and you want 
> > people to override it.
> 
> Andreas Sturmlechner wrote:
> It sure ain't pretty. But then I don't know why the hunspell search is 
> done how it's done now. Is it just for lack of being able to set a minimum 
> version?

No idea to be honest, but personally i'd be much happier with a patch that sets 
a minimum version than this "i don't care let me through" one. Martin may feel 
differently, so let's wait for him to say something.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129742/#review101749
---


On Jan. 1, 2017, 11:01 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129742/
> ---
> 
> (Updated Jan. 1, 2017, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> HUNSPELL is optional, but its cmake module depends on updates on each
> future hunspell release to be found. Each time that happens, the user
> build is potentially silently missing a feature, because up to now it
> can not be reliably enabled, only disabled.
> 
> This was the least disruptive solution I could come up with.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb 
>   src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e 
> 
> Diff: https://git.reviewboard.kde.org/r/129742/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>



Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-02 Thread Andreas Sturmlechner


> On Jan. 2, 2017, 10:53 p.m., Albert Astals Cid wrote:
> > I don't think this makes any sense. I understand your pain, would i'd 
> > rather improve the search of hunspell than accept it's crap and you want 
> > people to override it.

It sure ain't pretty. But then I don't know why the hunspell search is done how 
it's done now. Is it just for lack of being able to set a minimum version?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129742/#review101749
---


On Jan. 1, 2017, 11:01 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129742/
> ---
> 
> (Updated Jan. 1, 2017, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> HUNSPELL is optional, but its cmake module depends on updates on each
> future hunspell release to be found. Each time that happens, the user
> build is potentially silently missing a feature, because up to now it
> can not be reliably enabled, only disabled.
> 
> This was the least disruptive solution I could come up with.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb 
>   src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e 
> 
> Diff: https://git.reviewboard.kde.org/r/129742/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>



Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129742/#review101749
---



I don't think this makes any sense. I understand your pain, would i'd rather 
improve the search of hunspell than accept it's crap and you want people to 
override it.

- Albert Astals Cid


On Jan. 1, 2017, 11:01 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129742/
> ---
> 
> (Updated Jan. 1, 2017, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> HUNSPELL is optional, but its cmake module depends on updates on each
> future hunspell release to be found. Each time that happens, the user
> build is potentially silently missing a feature, because up to now it
> can not be reliably enabled, only disabled.
> 
> This was the least disruptive solution I could come up with.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt edac12f6cdc1fddc7f6b9df0baeb519a6c6502fb 
>   src/plugins/CMakeLists.txt 58b254c670e7e57202bbc9c889c86a48041a044e 
> 
> Diff: https://git.reviewboard.kde.org/r/129742/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>



[Differential] [Accepted] D3912: kdoctools_install: match the full path for the program

2017-01-02 Thread aacid (Albert Astals Cid)
aacid accepted this revision.
aacid added a reviewer: aacid.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3912

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, #frameworks, #documentation, aacid


Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/#review101744
---


Ship it!




Ship It!

- René J.V. Bertin


On Jan. 2, 2017, 9:57 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129733/
> ---
> 
> (Updated Jan. 2, 2017, 9:57 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Symlinks to (desktop) files are still supported.
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
>   src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 
>   src/sycoca/vfolder_menu.cpp 5acbf8ac21a1a0170cee4aa96882bd97eb2a4f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/129733/diff/
> 
> 
> Testing
> ---
> 
> Added unittest (which failed before the fix, passes after the fix)
> 
> 
> Thanks,
> 
> David Faure
> 
>



Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/
---

(Updated Jan. 2, 2017, 8:57 p.m.)


Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.


Changes
---

Harmonize checks between the two places.


Repository: kservice


Description
---

Symlinks to (desktop) files are still supported.


Diffs (updated)
-

  autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
  src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 
  src/sycoca/vfolder_menu.cpp 5acbf8ac21a1a0170cee4aa96882bd97eb2a4f2a 

Diff: https://git.reviewboard.kde.org/r/129733/diff/


Testing
---

Added unittest (which failed before the fix, passes after the fix)


Thanks,

David Faure



Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread David Faure


> On Jan. 2, 2017, 8:29 p.m., René J.V. Bertin wrote:
> > Ship It!
> 
> René J.V. Bertin wrote:
> Oops, I was too fast.
> 
> David, on a whim I just tried
> 
> ```
> sudo ln -s ../../.. /opt/local/share/applications/kde4/testlink
> ```
> 
> which is the exact same kind of tarpit situation that got me the other 
> day. Your patch doesn't protect against it.

Reproduced. As I suspected it's the missing check in vfolder_menu.cpp. Updated 
patch coming up.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/#review101740
---


On Dec. 31, 2016, 1:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129733/
> ---
> 
> (Updated Dec. 31, 2016, 1:06 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Symlinks to (desktop) files are still supported.
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
>   src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 
> 
> Diff: https://git.reviewboard.kde.org/r/129733/diff/
> 
> 
> Testing
> ---
> 
> Added unittest (which failed before the fix, passes after the fix)
> 
> 
> Thanks,
> 
> David Faure
> 
>



Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin


> On Jan. 2, 2017, 9:29 p.m., René J.V. Bertin wrote:
> > Ship It!

Oops, I was too fast.

David, on a whim I just tried

```
sudo ln -s ../../.. /opt/local/share/applications/kde4/testlink
```

which is the exact same kind of tarpit situation that got me the other day. 
Your patch doesn't protect against it.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/#review101740
---


On Dec. 31, 2016, 2:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129733/
> ---
> 
> (Updated Dec. 31, 2016, 2:06 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Symlinks to (desktop) files are still supported.
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
>   src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 
> 
> Diff: https://git.reviewboard.kde.org/r/129733/diff/
> 
> 
> Testing
> ---
> 
> Added unittest (which failed before the fix, passes after the fix)
> 
> 
> Thanks,
> 
> David Faure
> 
>



Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/#review101740
---


Ship it!




Ship It!

- René J.V. Bertin


On Dec. 31, 2016, 2:06 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129733/
> ---
> 
> (Updated Dec. 31, 2016, 2:06 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Symlinks to (desktop) files are still supported.
> 
> 
> Diffs
> -
> 
>   autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
>   src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 
> 
> Diff: https://git.reviewboard.kde.org/r/129733/diff/
> 
> 
> Testing
> ---
> 
> Added unittest (which failed before the fix, passes after the fix)
> 
> 
> Thanks,
> 
> David Faure
> 
>



Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

2017-01-02 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129704/#review101738
---



unfortunately this has a significant problem:
see https://bugs.kde.org/show_bug.cgi?id=374463

the problem is that plasmapkg2 had several hardcoded things for type names 
different from their corresponding servicetype, for instance "theme" instead of 
"Plasma/Theme" "plasmoid" instead of "Plasma/Applet" etc.

knsrcfiles around were using those names, for instance for plasma theme, 
InstallationCommand=plasmapkg2 -t theme -i %f

this wrapper should convert those parameters to keep compatibility (we can port 
stuff in workspace using plasmapkg2, but retrocompatibility is needed for old 
workspace new frameworks)

- Marco Martin


On Dec. 27, 2016, 6:12 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129704/
> ---
> 
> (Updated Dec. 27, 2016, 6:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They're supposed to do the same, completely different codebases. Also some 
> things had to be ported.
> 
> I'd recommend everything to be ported to use kpackagetool (knsrc files!) but 
> still it's better to at least make sure we stick to one set of features.
> 
> 
> Diffs
> -
> 
>   src/plasmapkg/CMakeLists.txt 7d3df5d22 
>   src/plasmapkg/main.cpp dfbd2f4c3 
>   src/plasmapkg/plasmapkg.h 3383980db 
>   src/plasmapkg/plasmapkg.cpp 3724ae85e 
> 
> Diff: https://git.reviewboard.kde.org/r/129704/diff/
> 
> 
> Testing
> ---
> 
> `plasmapkg2 --help` returns `kpackagetool5`'s.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>



Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 171 - Fixed!

2017-01-02 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/171/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 02 Jan 2017 15:15:47 +
Build duration: 1 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5461/7986 
(68%)CONDITIONAL 2947/6142 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1531 
(94%)CONDITIONAL 880/1770 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1767/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2797 
(73%)CONDITIONAL 1220/2052 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 171 - Fixed!

2017-01-02 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/171/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 02 Jan 2017 15:15:47 +
Build duration: 1 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5461/7986 
(68%)CONDITIONAL 2947/6142 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1531 
(94%)CONDITIONAL 880/1770 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1767/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2797 
(73%)CONDITIONAL 1220/2052 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 129744: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129744/
---

(Updated Jan. 2, 2017, 2:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit d87e04671457c58d8aaee979ea92cd1bcd6ce800 by Albert Astals 
Cid to branch master.


Repository: kcoreaddons


Description
---

http://woboq.com/blog/q_enum.html


Diffs
-

  src/lib/jobs/kjob.h 44051da 
  src/lib/util/kformat.h e00e5bd 

Diff: https://git.reviewboard.kde.org/r/129744/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129745/
---

(Updated Jan. 2, 2017, 2:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 383bb299f4694d2609036b8061316ae4b80e3f75 by Albert Astals 
Cid to branch master.


Repository: kconfig


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  autotests/kconfigtest.h 0a3de47 
  src/core/kconfigbackend.h 631769b 
  src/core/kconfiggroup.h 3e0052a 

Diff: https://git.reviewboard.kde.org/r/129745/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129748: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129748/
---

(Updated Jan. 2, 2017, 3:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 438e287f8956a94b7e3c95be533836983176c52b by Albert Astals 
Cid to branch master.


Repository: kwayland


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/client/plasmawindowmodel.h cde2dbe 

Diff: https://git.reviewboard.kde.org/r/129748/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129747: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129747/
---

(Updated Jan. 2, 2017, 2:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit fa214681b57e0d553cb8b59b38112bc32ab93ff7 by Albert Astals 
Cid to branch master.


Repository: kitemmodels


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/kselectionproxymodel.h c61908e 

Diff: https://git.reviewboard.kde.org/r/129747/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129751: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129751/
---

(Updated Jan. 2, 2017, 5:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 429ff631c3f55851aa71dfa1d5bfff581f671340 by Albert Astals 
Cid to branch master.


Repository: networkmanager-qt


Description
---

Removed DeviceInterface from src/wirelessdevice.h since it doesn't exist
  

https://woboq.com/blog/q_enum.html


Diffs
-

  src/accesspoint.h 3fe8c6e 
  src/bluetoothdevice.h e962d81 
  src/device.h 467d7ee 
  src/manager.h ab01ab1 
  src/wirelessdevice.h cf8e451 

Diff: https://git.reviewboard.kde.org/r/129751/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129750/
---

(Updated Jan. 2, 2017, 2:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: solid


Description
---

in src/solid/power/power.h i changed States to InhibitionTypes since States 
doesn't exist

https://woboq.com/blog/q_enum.html


Diffs
-

  src/solid/devices/frontend/battery.h e7a9d6d 
  src/solid/devices/frontend/deviceinterface.h dd212cc 
  src/solid/devices/frontend/genericinterface.h cf043b1 
  src/solid/devices/frontend/networkshare.h 3cfde67 
  src/solid/devices/frontend/opticaldisc.h 9412b73 
  src/solid/devices/frontend/opticaldrive.h 6f70494 
  src/solid/devices/frontend/processor.h 2153b2c 
  src/solid/devices/frontend/storagedrive.h b2f70bc 
  src/solid/devices/frontend/storagevolume.h 59903ad 
  src/solid/power/inhibition.h 4616f39 
  src/solid/power/inhibitionjob.h 0c0c233 
  src/solid/power/job.h 789bc8c 
  src/solid/power/power.h 35f9032 

Diff: https://git.reviewboard.kde.org/r/129750/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129749: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129749/
---

(Updated Jan. 2, 2017, 2:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit e8b52f3509ba458c17f987d3f0d9c40487904d12 by Albert Astals 
Cid to branch master.


Repository: kwidgetsaddons


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/kactionselector.h 6e81644 
  src/kcapacitybar.h 1fd1be6 
  src/kdatecombobox.h 458c701 
  src/kdatetimeedit.h c713456 
  src/keditlistwidget.h ceb5f19 
  src/kled.h 34f98fb 
  src/kmessagewidget.h de0fdc6 
  src/kmultitabbar.h bf7d52c 
  src/knewpasswordwidget.h f63493f 
  src/kpageview.h 60a4557 
  src/kruler.h bb7f858 
  src/kselectaction.h ca69a28 
  src/ktimecombobox.h 8f40136 
  src/ktitlewidget.h 50b1569 

Diff: https://git.reviewboard.kde.org/r/129749/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129749: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Christoph Feck

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129749/#review101737
---


Ship it!




Ship It!

- Christoph Feck


On Jan. 2, 2017, 12:09 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129749/
> ---
> 
> (Updated Jan. 2, 2017, 12:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/kactionselector.h 6e81644 
>   src/kcapacitybar.h 1fd1be6 
>   src/kdatecombobox.h 458c701 
>   src/kdatetimeedit.h c713456 
>   src/keditlistwidget.h ceb5f19 
>   src/kled.h 34f98fb 
>   src/kmessagewidget.h de0fdc6 
>   src/kmultitabbar.h bf7d52c 
>   src/knewpasswordwidget.h f63493f 
>   src/kpageview.h 60a4557 
>   src/kruler.h bb7f858 
>   src/kselectaction.h ca69a28 
>   src/ktimecombobox.h 8f40136 
>   src/ktitlewidget.h 50b1569 
> 
> Diff: https://git.reviewboard.kde.org/r/129749/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Lamarque Souza

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129750/#review101731
---


Ship it!




Ship It!

- Lamarque Souza


On Jan. 2, 2017, 11:31 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129750/
> ---
> 
> (Updated Jan. 2, 2017, 11:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> in src/solid/power/power.h i changed States to InhibitionTypes since States 
> doesn't exist
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/solid/devices/frontend/battery.h e7a9d6d 
>   src/solid/devices/frontend/deviceinterface.h dd212cc 
>   src/solid/devices/frontend/genericinterface.h cf043b1 
>   src/solid/devices/frontend/networkshare.h 3cfde67 
>   src/solid/devices/frontend/opticaldisc.h 9412b73 
>   src/solid/devices/frontend/opticaldrive.h 6f70494 
>   src/solid/devices/frontend/processor.h 2153b2c 
>   src/solid/devices/frontend/storagedrive.h b2f70bc 
>   src/solid/devices/frontend/storagevolume.h 59903ad 
>   src/solid/power/inhibition.h 4616f39 
>   src/solid/power/inhibitionjob.h 0c0c233 
>   src/solid/power/job.h 789bc8c 
>   src/solid/power/power.h 35f9032 
> 
> Diff: https://git.reviewboard.kde.org/r/129750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129750/#review101729
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 12:31 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129750/
> ---
> 
> (Updated Jan. 2, 2017, 12:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> in src/solid/power/power.h i changed States to InhibitionTypes since States 
> doesn't exist
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/solid/devices/frontend/battery.h e7a9d6d 
>   src/solid/devices/frontend/deviceinterface.h dd212cc 
>   src/solid/devices/frontend/genericinterface.h cf043b1 
>   src/solid/devices/frontend/networkshare.h 3cfde67 
>   src/solid/devices/frontend/opticaldisc.h 9412b73 
>   src/solid/devices/frontend/opticaldrive.h 6f70494 
>   src/solid/devices/frontend/processor.h 2153b2c 
>   src/solid/devices/frontend/storagedrive.h b2f70bc 
>   src/solid/devices/frontend/storagevolume.h 59903ad 
>   src/solid/power/inhibition.h 4616f39 
>   src/solid/power/inhibitionjob.h 0c0c233 
>   src/solid/power/job.h 789bc8c 
>   src/solid/power/power.h 35f9032 
> 
> Diff: https://git.reviewboard.kde.org/r/129750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129751: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129751/#review101730
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 12:35 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129751/
> ---
> 
> (Updated Jan. 2, 2017, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> ---
> 
> Removed DeviceInterface from src/wirelessdevice.h since it doesn't exist
>   
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/accesspoint.h 3fe8c6e 
>   src/bluetoothdevice.h e962d81 
>   src/device.h 467d7ee 
>   src/manager.h ab01ab1 
>   src/wirelessdevice.h cf8e451 
> 
> Diff: https://git.reviewboard.kde.org/r/129751/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129748: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129748/#review101727
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 12:05 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129748/
> ---
> 
> (Updated Jan. 2, 2017, 12:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/client/plasmawindowmodel.h cde2dbe 
> 
> Diff: https://git.reviewboard.kde.org/r/129748/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129747: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129747/#review101726
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 11:54 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129747/
> ---
> 
> (Updated Jan. 2, 2017, 11:54 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/kselectionproxymodel.h c61908e 
> 
> Diff: https://git.reviewboard.kde.org/r/129747/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129746: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129746/#review101725
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 11:51 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129746/
> ---
> 
> (Updated Jan. 2, 2017, 11:51 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> ---
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/kdbusservice.h fedcf11 
> 
> Diff: https://git.reviewboard.kde.org/r/129746/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129745/#review101724
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 11:48 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129745/
> ---
> 
> (Updated Jan. 2, 2017, 11:48 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> https://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.h 0a3de47 
>   src/core/kconfigbackend.h 631769b 
>   src/core/kconfiggroup.h 3e0052a 
> 
> Diff: https://git.reviewboard.kde.org/r/129745/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Re: Review Request 129744: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129744/#review101723
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 2, 2017, 11:42 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129744/
> ---
> 
> (Updated Jan. 2, 2017, 11:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> http://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/lib/jobs/kjob.h 44051da 
>   src/lib/util/kformat.h e00e5bd 
> 
> Diff: https://git.reviewboard.kde.org/r/129744/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Review Request 129751: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129751/
---

Review request for KDE Frameworks.


Repository: networkmanager-qt


Description
---

Removed DeviceInterface from src/wirelessdevice.h since it doesn't exist
  

https://woboq.com/blog/q_enum.html


Diffs
-

  src/accesspoint.h 3fe8c6e 
  src/bluetoothdevice.h e962d81 
  src/device.h 467d7ee 
  src/manager.h ab01ab1 
  src/wirelessdevice.h cf8e451 

Diff: https://git.reviewboard.kde.org/r/129751/diff/


Testing
---


Thanks,

Albert Astals Cid



Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129750/
---

Review request for KDE Frameworks.


Repository: solid


Description
---

in src/solid/power/power.h i changed States to InhibitionTypes since States 
doesn't exist

https://woboq.com/blog/q_enum.html


Diffs
-

  src/solid/devices/frontend/battery.h e7a9d6d 
  src/solid/devices/frontend/deviceinterface.h dd212cc 
  src/solid/devices/frontend/genericinterface.h cf043b1 
  src/solid/devices/frontend/networkshare.h 3cfde67 
  src/solid/devices/frontend/opticaldisc.h 9412b73 
  src/solid/devices/frontend/opticaldrive.h 6f70494 
  src/solid/devices/frontend/processor.h 2153b2c 
  src/solid/devices/frontend/storagedrive.h b2f70bc 
  src/solid/devices/frontend/storagevolume.h 59903ad 
  src/solid/power/inhibition.h 4616f39 
  src/solid/power/inhibitionjob.h 0c0c233 
  src/solid/power/job.h 789bc8c 
  src/solid/power/power.h 35f9032 

Diff: https://git.reviewboard.kde.org/r/129750/diff/


Testing
---


Thanks,

Albert Astals Cid



Review Request 129749: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129749/
---

Review request for KDE Frameworks.


Repository: kwidgetsaddons


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/kactionselector.h 6e81644 
  src/kcapacitybar.h 1fd1be6 
  src/kdatecombobox.h 458c701 
  src/kdatetimeedit.h c713456 
  src/keditlistwidget.h ceb5f19 
  src/kled.h 34f98fb 
  src/kmessagewidget.h de0fdc6 
  src/kmultitabbar.h bf7d52c 
  src/knewpasswordwidget.h f63493f 
  src/kpageview.h 60a4557 
  src/kruler.h bb7f858 
  src/kselectaction.h ca69a28 
  src/ktimecombobox.h 8f40136 
  src/ktitlewidget.h 50b1569 

Diff: https://git.reviewboard.kde.org/r/129749/diff/


Testing
---


Thanks,

Albert Astals Cid



[Differential] [Accepted] D3850: Pass -fno-operator-names when supported

2017-01-02 Thread Ivan Čukić
ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  Fine by me.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3850

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, #buildsystem, ivan
Cc: rakuco, elvisangelaccio


Review Request 129748: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129748/
---

Review request for KDE Frameworks.


Repository: kwayland


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/client/plasmawindowmodel.h cde2dbe 

Diff: https://git.reviewboard.kde.org/r/129748/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129743: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129743/
---

(Updated Jan. 2, 2017, 11:04 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit f9d41ddd85d3e2f4eb87a094763898cd6a9fe448 by Albert Astals 
Cid to branch master.


Repository: bluez-qt


Description
---

http://woboq.com/blog/q_enum.html


Diffs
-

  src/agent.h e9c5160 
  src/device.h c0e19db 
  src/input.h b883c30 
  src/job.h b6bbd5b 
  src/mediaplayer.h 6f81b49 
  src/obextransfer.h 49cf6d7 
  src/pendingcall.h cd6205f 

Diff: https://git.reviewboard.kde.org/r/129743/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129743: Q_ENUMS -> Q_ENUM

2017-01-02 Thread David Rosca

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129743/#review101719
---


Ship it!




Ship It!

- David Rosca


On Jan. 2, 2017, 10:35 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129743/
> ---
> 
> (Updated Jan. 2, 2017, 10:35 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: bluez-qt
> 
> 
> Description
> ---
> 
> http://woboq.com/blog/q_enum.html
> 
> 
> Diffs
> -
> 
>   src/agent.h e9c5160 
>   src/device.h c0e19db 
>   src/input.h b883c30 
>   src/job.h b6bbd5b 
>   src/mediaplayer.h 6f81b49 
>   src/obextransfer.h 49cf6d7 
>   src/pendingcall.h cd6205f 
> 
> Diff: https://git.reviewboard.kde.org/r/129743/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Review Request 129747: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129747/
---

Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/kselectionproxymodel.h c61908e 

Diff: https://git.reviewboard.kde.org/r/129747/diff/


Testing
---


Thanks,

Albert Astals Cid



Review Request 129746: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129746/
---

Review request for KDE Frameworks.


Repository: kdbusaddons


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/kdbusservice.h fedcf11 

Diff: https://git.reviewboard.kde.org/r/129746/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129745/
---

(Updated Jan. 2, 2017, 10:48 a.m.)


Review request for KDE Frameworks.


Repository: kconfig


Description
---

https://woboq.com/blog/q_enum.html


Diffs (updated)
-

  autotests/kconfigtest.h 0a3de47 
  src/core/kconfigbackend.h 631769b 
  src/core/kconfiggroup.h 3e0052a 

Diff: https://git.reviewboard.kde.org/r/129745/diff/


Testing
---


Thanks,

Albert Astals Cid



Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129745/
---

Review request for KDE Frameworks.


Repository: kconfig


Description
---

https://woboq.com/blog/q_enum.html


Diffs
-

  src/gui/kstandardshortcut.cpp 6be6309 

Diff: https://git.reviewboard.kde.org/r/129745/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129723/
---

(Updated Jan. 2, 2017, 10:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 6fcc3bc6762f32cb152ea69ffdad3147c686a927 by Albert Astals 
Cid to branch master.


Repository: kparts


Description
---

What summary says


Diffs
-

  src/mainwindow.cpp b335598 

Diff: https://git.reviewboard.kde.org/r/129723/diff/


Testing
---


Thanks,

Albert Astals Cid



Review Request 129744: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129744/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

http://woboq.com/blog/q_enum.html


Diffs
-

  src/lib/jobs/kjob.h 44051da 
  src/lib/util/kformat.h e00e5bd 

Diff: https://git.reviewboard.kde.org/r/129744/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2017-01-02 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129723/#review101718
---


Ship it!




This is going to be called multiple times in apps with parts and plugins, but I 
guess that's OK, the developer will fix the bug and the user will check the 
checkbox.

- David Faure


On Jan. 2, 2017, 10:34 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129723/
> ---
> 
> (Updated Jan. 2, 2017, 10:34 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kparts
> 
> 
> Description
> ---
> 
> What summary says
> 
> 
> Diffs
> -
> 
>   src/mainwindow.cpp b335598 
> 
> Diff: https://git.reviewboard.kde.org/r/129723/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>



Review Request 129743: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129743/
---

Review request for KDE Frameworks.


Repository: bluez-qt


Description
---

http://woboq.com/blog/q_enum.html


Diffs
-

  src/agent.h e9c5160 
  src/device.h c0e19db 
  src/input.h b883c30 
  src/job.h b6bbd5b 
  src/mediaplayer.h 6f81b49 
  src/obextransfer.h 49cf6d7 
  src/pendingcall.h cd6205f 

Diff: https://git.reviewboard.kde.org/r/129743/diff/


Testing
---


Thanks,

Albert Astals Cid



Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

2017-01-02 Thread Anthony Fieroni


> On Ян. 2, 2017, 11:42 преди обяд, David Faure wrote:
> > src/extractorcollection.cpp, line 155
> > 
> >
> > Shouldn't this be the other way around?
> > 
> > You're looking for an extractor for type == 
> > application/vnd.oasis.opendocument.text.
> > You find an extractor for it.key() == application/zip.
> > That's not good, it won't know anything about OpenDocument stuff.
> > 
> > So you want db.mimeTypeForName(it.value()).inherits(mimetype), no?
> > 
> > KIO::PreviewJob iterates over type.allAncestors() instead, but now that 
> > I think about it, that seems overkill and doesn't do more than the 
> > suggested line above.

That was desired effect, i.e. we try to find more *abstract* parser. Does we 
can find any parser to 
db.mimeTypeForName(it.key()).inherits("application/vnd.oasis.opendocument.text")
 ? I don't think we can find someone or i'm in wrong :)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129720/#review101716
---


On Дек. 29, 2016, 9:17 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129720/
> ---
> 
> (Updated Дек. 29, 2016, 9:17 преди обяд)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> startsWith is a weak precondition + guard for duplicate plugin
> 
> 
> Diffs
> -
> 
>   src/extractorcollection.cpp d0fbbea 
> 
> Diff: https://git.reviewboard.kde.org/r/129720/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 355 - Fixed!

2017-01-02 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/355/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 02 Jan 2017 09:47:45 +
Build duration: 1 min 6 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 355 - Fixed!

2017-01-02 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/355/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 02 Jan 2017 09:47:45 +
Build duration: 1 min 6 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 354 - Failure!

2017-01-02 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/354/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 02 Jan 2017 09:42:02 +
Build duration: 23 sec

CHANGE SET
No changes


Re: Minimum required cmake version

2017-01-02 Thread David Faure
On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote:
> On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne  wrote:
> > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote:
> >> Hey,
> >> 
> >> On 27/12/16 19:30, Aleix Pol wrote:
> >> > +1 on changing to 3.0.
> >> 
> >> Thanks for your opinion on the matter. I also think we should just bump
> >> it, 3.0 is old enough -- as said it's even easily available on CentOS 6.
> >> 
> >> Question is, should I change it on _all_ frameworks or just those using
> >> Q_GADGET (i.e. those which actually need cmake 3)?
> > 
> > If we change the CMake requirement for one framework it should be
> > changed for them all.  They are tested, released, and supported as a
> > unit even though they have separate tiers and could theoretically be put
> > together in a piecemeal fashion.
> > 
> > There might also be an easy way to change it in extra-cmake-modules but
> > I think some of the buildsystem devs would know more about that.
> > 
> > Regards,
> > 
> >  - Michael Pyne
> 
> +1

No objection.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

2017-01-02 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129720/#review101716
---




src/extractorcollection.cpp (line 155)


Shouldn't this be the other way around?

You're looking for an extractor for type == 
application/vnd.oasis.opendocument.text.
You find an extractor for it.key() == application/zip.
That's not good, it won't know anything about OpenDocument stuff.

So you want db.mimeTypeForName(it.value()).inherits(mimetype), no?

KIO::PreviewJob iterates over type.allAncestors() instead, but now that I 
think about it, that seems overkill and doesn't do more than the suggested line 
above.


- David Faure


On Dec. 29, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129720/
> ---
> 
> (Updated Dec. 29, 2016, 7:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> startsWith is a weak precondition + guard for duplicate plugin
> 
> 
> Diffs
> -
> 
>   src/extractorcollection.cpp d0fbbea 
> 
> Diff: https://git.reviewboard.kde.org/r/129720/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129741: Add renaming capability to ioslaves

2017-01-02 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129741/#review101715
---



Renaming is really a special case of moving. Saying that "kio_trash doesn't 
support renaming" is correct but only a partial truth. It also doesn't support 
moving from trash:/ to trash:/subdir/. So it would be more correct to say that 
kio_trash supports moving trash-to-file and file-to-trash but not 
trash-to-trash.

So it seems to me that this patch models the wrong thing, and is likely to give 
us further trouble down the line.

I wonder if we could invent something more dynamic than the .protocol keys. An 
additional way to talk to a slave and ask if a specific operation (for specific 
URLs) is implemented. Something like KIO::CapabilityJob *job = 
KIO::capability(Move, url1, url2); connect; and in the slot, enable/disable the 
action accordingly. By default this would just use the information from the 
.protocol files, but in addition a new SlaveBase method (fake-virtual until 
KF6, using virtual_hook) would allow slaves to answer the query with more 
precision, depending on the actual URLs. What do you think?

Of course the alternative (which is actually simpler short term) is to 
implement renaming in kio_trash ;)
Actual renaming should be easy, moving between subdirs is a bit more tricky but 
doable too. I can take a look at that next weekend.

- David Faure


On Jan. 1, 2017, 11:01 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129741/
> ---
> 
> (Updated Jan. 1, 2017, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Emmanuel Pescosta.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> An ioslave protocol might support moving files but not "renaming" them 
> (rename here means "the F2 shortcut in filemanagers"). trash:/ is a good 
> example.
> 
> The new `renaming` field defaults to `moving`, so that we don't have to add 
> renaming=true to every protocol file out there.
> 
> 
> Diffs
> -
> 
>   src/core/kfileitemlistproperties.h 2b4a5b33166513493e6499e6479a04965a895b57 
>   src/core/kfileitemlistproperties.cpp 
> 5c6e6bba693f8b9bfc942ff39bee5d24f159fd7f 
>   src/core/kprotocolinfo.cpp 0290c63b37a45a22995238f9cfcc11b8334d339c 
>   src/core/kprotocolinfo_p.h 8d05bd194fdaa7b7e7552e0d1d22bf16b28ffbc1 
>   src/core/kprotocolmanager.h 13b8c0756f8e355b1ec84cdf1c44086f41fa05c5 
>   src/core/kprotocolmanager.cpp 9a0a96fe749a11c66a22bb3eff62d0601e3b7b36 
>   src/ioslaves/trash/tests/testtrash.cpp 
> 67a6130e7c86af00e596dc439125c29eb74fc99f 
>   src/ioslaves/trash/trash.json d7dc03eb073c7bfdde3c7eebfbac144ad62964fe 
>   src/protocoltojson/main.cpp 0bf3c7062d076412c779f6cae25a98e1b2c61be4 
> 
> Diff: https://git.reviewboard.kde.org/r/129741/diff/
> 
> 
> Testing
> ---
> 
> Using the new `supportsRenaming()` api from Dolphin, F2 in Trash is now 
> disabled. More context in https://git.reviewboard.kde.org/r/129714
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>