Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 397 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/397/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 22 Jan 2017 22:14:19 + Build duration: 15 min CHANGE SET Revision 97ba474388b3e3e98dec72c7cc5cdb0903f536a0 by

[Differential] [Commented On] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg added a comment. Also, kactivities-stats could use an .arcconfig REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, #frameworks, ivan, #kactivities

[Differential] [Updated] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg added reviewers: Frameworks, ivan, KActivities. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, #frameworks, ivan, #kactivities Cc: #frameworks

[Differential] [Request, 1 line] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The autotests/CMakeLists.txt doesn't add Boost_INCLUDE_DIR to the include search path (src/CMakeLists.txt does) so the autotests fail to

[Differential] [Updated] D3826: Detect inotify.

adridg marked 5 inline comments as done. adridg added inline comments. INLINE COMMENTS > kfunk wrote in FindInotify.cmake:51 > Style: Indent off Assuming that means "comments indent 0" and not "comments indentation should match surrounding indent, which is 4". It's a bit ambiguous. > kfunk

[Differential] [Updated, 79 lines] D3826: Detect inotify.

adridg updated this revision to Diff 10439. adridg added a comment. Restricted Application added projects: Frameworks, Buildsystem. - Follow up on review REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3826?vs=9401=10439 BRANCH inotify

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 396 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/396/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 22 Jan 2017 19:51:07 + Build duration: 16 min CHANGE SET Revision d252f7958633f3374e77e1cc52f11c534ca55219 by

Re: Review Request 129870: KEmoticons: use DBus to notify running processes of changes made in the KCM.

> On Jan. 22, 2017, 7:22 p.m., Milian Wolff wrote: > > lgtm, and I doubt that emoticons play a role for kate/kdevelop/krita or > > anything else on windows where dbus is usually disabled? If it's a problem, we could make the dbus stuff optional, i.e. it would all work for a standalone app,

Re: Review Request 129870: KEmoticons: use DBus to notify running processes of changes made in the KCM.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129870/#review102189 --- Ship it! lgtm, and I doubt that emoticons play a role

[Differential] [Updated, 25 lines] D4247: KIconEngine: Center icon in requested rect

drosca updated this revision to Diff 10438. drosca added a comment. Add autotest REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4247?vs=10437=10438 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4247 AFFECTED FILES

[Differential] [Commented On] D4234: Change algorithm for autobrace.

cactus added a comment. In https://phabricator.kde.org/D4234#79253, @brauch wrote: > I'm a bit skeptical, this means I can't add closing braces when they are missing ... Yes, I agree with you. If you are in this situation: (((|)) with | for the cursor, you must type 3 ')' to

[Differential] [Request, 10 lines] D4247: KIconEngine: Center icon in requested rect

drosca created this revision. drosca added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Match the behavior of Qt's internal icon engines. TEST PLAN Rendering is the same for unaffected icons + highdpi still works. Example case: Render icon

[Differential] [Commented On] D4234: Change algorithm for autobrace.

brauch added a comment. I'm a bit skeptical, this means I can't add closing braces when they are missing ... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cactus,

[Differential] [Commented On] D4190: Update file type on save only if path changes

cullmann added a comment. I am not sure if "path" is enough here, but also the filename is important. Could we not guard it with "filename changed" instead for local files? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4190 EMAIL PREFERENCES

[Differential] [Commented On] D4234: Change algorithm for autobrace.

cullmann added a comment. Given it eliminates some members, this looks nice, thought I don't use that feature enough to judge if the behavior change is wanted. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES

Review Request 129870: KEmoticons: use DBus to notify running processes of changes made in the KCM.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129870/ --- Review request for KDE Frameworks and Milian Wolff. Repository: