Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 397 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/397/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 22 Jan 2017 22:14:19 + Build duration: 15 min CHANGE SET Revision 97ba474388b3e3e98dec72c7cc5cdb0903f536a0 by David Faure: (autotest: relax expected value for directorySize(), on XFS it#039;s smaller) change: edit autotests/jobtest.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29544/51606 (57%)CONDITIONAL 16214/38743 (42%) By packages autotests FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7918/8245 (96%)CONDITIONAL 4429/8664 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7892/14179 (56%)CONDITIONAL 4337/9259 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3451/7559 (46%)CONDITIONAL 1278/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3780 (46%)CONDITIONAL 1252/3460 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 (63%)CONDITIONAL 411/833 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 372/594 (63%)CONDITIONAL 276/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11016 (33%)CONDITIONAL 1746/7096 (25%)
[Differential] [Commented On] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.
adridg added a comment. Also, kactivities-stats could use an .arcconfig REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, #frameworks, ivan, #kactivities Cc: #frameworks
[Differential] [Updated] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.
adridg added reviewers: Frameworks, ivan, KActivities. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D4248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, #frameworks, ivan, #kactivities Cc: #frameworks
[Differential] [Request, 1 line] D4248: Add Boost_INCLUDE_DIR to kactivities-stats autotests.
adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The autotests/CMakeLists.txt doesn't add Boost_INCLUDE_DIR to the include search path (src/CMakeLists.txt does) so the autotests fail to build with missing Boost includes. REPOSITORY R159 KActivities Statistics BRANCH fix-autotests REVISION DETAIL https://phabricator.kde.org/D4248 AFFECTED FILES autotests/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg Cc: #frameworks
[Differential] [Updated] D3826: Detect inotify.
adridg marked 5 inline comments as done.
adridg added inline comments.
INLINE COMMENTS
> kfunk wrote in FindInotify.cmake:51
> Style: Indent off
Assuming that means "comments indent 0" and not "comments indentation should
match surrounding indent, which is 4". It's a bit ambiguous.
> kfunk wrote in FindInotify.cmake:54
> Set `Inotify_LIBRARIES` & `Inotify_INCLUDE_DIRS` to empty string?
Yes, good point -- since the instructions will be to add
${Inotify_INCLUDE_DIRS} to the include path, they must be set to avoid warnings.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3826
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: adridg, apol, arrowdodger, #buildsystem, #frameworks, tcberner, ervin,
skelly, dfaure, kfunk
Cc: kfunk, #freebsd
[Differential] [Updated, 79 lines] D3826: Detect inotify.
adridg updated this revision to Diff 10439. adridg added a comment. Restricted Application added projects: Frameworks, Buildsystem. - Follow up on review REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3826?vs=9401=10439 BRANCH inotify REVISION DETAIL https://phabricator.kde.org/D3826 AFFECTED FILES find-modules/FindInotify.cmake EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, apol, arrowdodger, #buildsystem, #frameworks, tcberner, ervin, skelly, dfaure, kfunk Cc: kfunk, #freebsd
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 396 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/396/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 22 Jan 2017 19:51:07 + Build duration: 16 min CHANGE SET Revision d252f7958633f3374e77e1cc52f11c534ca55219 by kollix: (preserve group/owner on file copy) change: edit src/ioslaves/file/file_unix.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiogui-favicontest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 274/343 (80%)CLASSES 274/343 (80%)LINE 29479/51606 (57%)CONDITIONAL 16161/38743 (42%) By packages autotests FILES 67/67 (100%)CLASSES 67/67 (100%)LINE 7917/8245 (96%)CONDITIONAL 4427/8664 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 7851/14179 (55%)CONDITIONAL 4321/9259 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3452/7559 (46%)CONDITIONAL 1282/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 98/110 (89%)CONDITIONAL 43/72 (60%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1732/3780 (46%)CONDITIONAL 1212/3460 (35%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 (63%)CONDITIONAL 411/833 (49%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 144/256 (56%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3631/11016 (33%)CONDITIONAL 1746/7096 (25%)
Re: Review Request 129870: KEmoticons: use DBus to notify running processes of changes made in the KCM.
> On Jan. 22, 2017, 7:22 p.m., Milian Wolff wrote: > > lgtm, and I doubt that emoticons play a role for kate/kdevelop/krita or > > anything else on windows where dbus is usually disabled? If it's a problem, we could make the dbus stuff optional, i.e. it would all work for a standalone app, just not for the multi-process case. But since nobody has done that in KService (which requires DBus) and kemoticons requires KService, this change doesn't make anything worse for people allergic to DBus ;) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129870/#review102189 --- On Jan. 22, 2017, 11:48 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129870/ > --- > > (Updated Jan. 22, 2017, 11:48 a.m.) > > > Review request for KDE Frameworks and Milian Wolff. > > > Repository: kemoticons > > > Description > --- > > My recent performance fix stopped KEmoticons from reparsing kdeglobals > at ever call to currentThemeName(), which means that now we need to know > when to reparse. But actually by using a dbus signal we can just ship the > information in the signal, so no config file reparsing is needed. > > > Diffs > - > > CMakeLists.txt 58e57afe6c038b6491f2f163365ef6becb0214b3 > src/core/CMakeLists.txt 51d369a4333024806e28b92d4e7d471eb96e516a > src/core/kemoticons.cpp bb59d170720df7f0ee3cee20649a43e3f1f4440f > src/core/kemoticonsglobal.cpp PRE-CREATION > src/core/kemoticonsglobal_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129870/diff/ > > > Testing > --- > > Changing the emoticons theme in `kcmshell5 emoticons` while KMail is running. > Then switching to another message in KMail uses the newly selected icon > theme, without having to restart kmail. > > > Note: the "new" dependency on QtDBus isn't new, KEmoticons uses KService > which depends on DBus already. > > > Thanks, > > David Faure > >
Re: Review Request 129870: KEmoticons: use DBus to notify running processes of changes made in the KCM.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129870/#review102189 --- Ship it! lgtm, and I doubt that emoticons play a role for kate/kdevelop/krita or anything else on windows where dbus is usually disabled? - Milian Wolff On Jan. 22, 2017, 11:48 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129870/ > --- > > (Updated Jan. 22, 2017, 11:48 a.m.) > > > Review request for KDE Frameworks and Milian Wolff. > > > Repository: kemoticons > > > Description > --- > > My recent performance fix stopped KEmoticons from reparsing kdeglobals > at ever call to currentThemeName(), which means that now we need to know > when to reparse. But actually by using a dbus signal we can just ship the > information in the signal, so no config file reparsing is needed. > > > Diffs > - > > CMakeLists.txt 58e57afe6c038b6491f2f163365ef6becb0214b3 > src/core/CMakeLists.txt 51d369a4333024806e28b92d4e7d471eb96e516a > src/core/kemoticons.cpp bb59d170720df7f0ee3cee20649a43e3f1f4440f > src/core/kemoticonsglobal.cpp PRE-CREATION > src/core/kemoticonsglobal_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129870/diff/ > > > Testing > --- > > Changing the emoticons theme in `kcmshell5 emoticons` while KMail is running. > Then switching to another message in KMail uses the newly selected icon > theme, without having to restart kmail. > > > Note: the "new" dependency on QtDBus isn't new, KEmoticons uses KService > which depends on DBus already. > > > Thanks, > > David Faure > >
[Differential] [Updated, 25 lines] D4247: KIconEngine: Center icon in requested rect
drosca updated this revision to Diff 10438. drosca added a comment. Add autotest REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4247?vs=10437=10438 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4247 AFFECTED FILES autotests/kiconengine_unittest.cpp src/kiconengine.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #frameworks
[Differential] [Commented On] D4234: Change algorithm for autobrace.
cactus added a comment. In https://phabricator.kde.org/D4234#79253, @brauch wrote: > I'm a bit skeptical, this means I can't add closing braces when they are missing ... Yes, I agree with you. If you are in this situation: (((|)) with | for the cursor, you must type 3 ')' to close the brace. But this rarely happens. I find the current behavior much more embarrassing. I'm already used to this behavior because I use emacs and intellij idea and they work like that. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cactus, #ktexteditor Cc: brauch, cullmann, kwrite-devel, #frameworks
[Differential] [Request, 10 lines] D4247: KIconEngine: Center icon in requested rect
drosca created this revision. drosca added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Match the behavior of Qt's internal icon engines. TEST PLAN Rendering is the same for unaffected icons + highdpi still works. Example case: Render icon into QRect(0, 0, 12, 16) - KIconLoader returns QSize(12, 12) icon and KIconEngine would draw it at the top of the rect. This patch centers the icon in provided rect instead. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D4247 AFFECTED FILES src/kiconengine.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #frameworks
[Differential] [Commented On] D4234: Change algorithm for autobrace.
brauch added a comment. I'm a bit skeptical, this means I can't add closing braces when they are missing ... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cactus, #ktexteditor Cc: brauch, cullmann, kwrite-devel, #frameworks
[Differential] [Commented On] D4190: Update file type on save only if path changes
cullmann added a comment. I am not sure if "path" is enough here, but also the filename is important. Could we not guard it with "filename changed" instead for local files? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4190 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mperttunen, #ktexteditor Cc: cullmann, kwrite-devel, #frameworks
[Differential] [Commented On] D4234: Change algorithm for autobrace.
cullmann added a comment. Given it eliminates some members, this looks nice, thought I don't use that feature enough to judge if the behavior change is wanted. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cactus, #ktexteditor Cc: cullmann, kwrite-devel, #frameworks
Review Request 129870: KEmoticons: use DBus to notify running processes of changes made in the KCM.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129870/ --- Review request for KDE Frameworks and Milian Wolff. Repository: kemoticons Description --- My recent performance fix stopped KEmoticons from reparsing kdeglobals at ever call to currentThemeName(), which means that now we need to know when to reparse. But actually by using a dbus signal we can just ship the information in the signal, so no config file reparsing is needed. Diffs - CMakeLists.txt 58e57afe6c038b6491f2f163365ef6becb0214b3 src/core/CMakeLists.txt 51d369a4333024806e28b92d4e7d471eb96e516a src/core/kemoticons.cpp bb59d170720df7f0ee3cee20649a43e3f1f4440f src/core/kemoticonsglobal.cpp PRE-CREATION src/core/kemoticonsglobal_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129870/diff/ Testing --- Changing the emoticons theme in `kcmshell5 emoticons` while KMail is running. Then switching to another message in KMail uses the newly selected icon theme, without having to restart kmail. Note: the "new" dependency on QtDBus isn't new, KEmoticons uses KService which depends on DBus already. Thanks, David Faure
