[Differential] [Accepted] D4300: Simpler calculation of longest line limit

[Milian Wolff]

mwolff accepted this revision.
mwolff added a reviewer: mwolff.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4300

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor, mwolff
Cc: kwrite-devel, #frameworks, cullmann, kfunk, sars, dhaumann

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129892/#review102269
---



So, wait a minute i just quote you
*This patch attempts to fix it by iterating all the main windows when they are 
shown and if all the menubars of all mainwindows are native, then hides the 
show menu bar action (basically erasing it from existence).* from 
https://git.reviewboard.kde.org/r/129261/
*This has nothing to do with whether you are using Unity or Plasma* from 
https://git.reviewboard.kde.org/r/129885/
I want an explanation, i never use Unity, i will never use it, but i want know 
in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, wasNative 
== true ?
If so, i'm -1 for this approach

- Anthony Fieroni


On Ян. 27, 2017, 12:19 преди обяд, Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129892/
> ---
> 
> (Updated Ян. 27, 2017, 12:19 преди обяд)
> 
> 
> Review request for KDE Frameworks, Anthony Fieroni and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> It makes no sense to treat no menubars as all menubars native so just bail 
> early, the app is probably still in construction if there's no menubars but 
> it actually has a showmenubaraction.
> 
> 
> Diffs
> -
> 
>   src/kstandardaction.cpp 6e5bba7 
> 
> Diff: https://git.reviewboard.kde.org/r/129892/diff/
> 
> 
> Testing
> ---
> 
> Dolphin behaves better regarding the show menubar action.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Sonnet: Trigram data file for Greek

[John Salatas]

On 2017-01-24 04:03 PM, Christoph Feck wrote:

On 24.01.2017 19:45, John Salatas wrote:

On 2017-01-24 10:40 AM, Christoph Feck wrote:

On 24.01.2017 09:01, John Salatas wrote:
I just built a trigram data file (attached) for Greek language using 
a

wikipedia dump as corpus. Can I just push it to sonnet's git or do I
need to generate a differential review in phabricator or something?


Isn't Greek language automatically detected by Greek script? As far 
as

I know, no other language uses the Greek script.


It doesn't seem to be the case if it is mixed with other languages in
the same sentence, which is rather typical in technical documents that
contain English terms. For example the following excerpt from

https://el.wikipedia.org/wiki/Linux

Το Linux (Λίνουξ) ή GNU/Linux (Γκνού/Λίνουξ), είναι ένα λειτουργικό
σύστημα που αποτελείται από ελεύθερο λογισμικό. Η χρήση του είναι
παρόμοια με αυτή του Unix, αλλά όλος ο πηγαίος κώδικας του έχει 
γραφτεί

από την αρχή ως ελεύθερο λογισμικό υπό την ελεύθερη άδεια χρήσης GNU
General Public License.


Okey, this eventually has to be fixed, but if adding a Greek trigram
file improves detection, please add one.


added.


Thanks!

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129892/#review102263
---


Ship it!




Ship It!

- David Faure


On Jan. 26, 2017, 10:19 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129892/
> ---
> 
> (Updated Jan. 26, 2017, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Anthony Fieroni and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> It makes no sense to treat no menubars as all menubars native so just bail 
> early, the app is probably still in construction if there's no menubars but 
> it actually has a showmenubaraction.
> 
> 
> Diffs
> -
> 
>   src/kstandardaction.cpp 6e5bba7 
> 
> Diff: https://git.reviewboard.kde.org/r/129892/diff/
> 
> 
> Testing
> ---
> 
> Dolphin behaves better regarding the show menubar action.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129885: [KStandadAction] Correct menubars logic

[Albert Astals Cid]

> On Jan. 25, 2017, 11:15 p.m., Albert Astals Cid wrote:
> > I briefly looked at dolphins code a while ago and i'm pretty sure the code 
> > is wrong in dolphin
> 
> Albert Astals Cid wrote:
> BTW what do you mean with "Works correct on KDE"?
> 
> Anthony Fieroni wrote:
> The code in Dolphin isn't wrong, the application should be able to change 
> action state whenever he wants. So when spy show event there is no right way 
> to change action state in application. Your patch approach is to detemine 
> native menubars, in KDE i get allMenuBarsNative = false, wasNative = true, in 
> Unity i suppose to be true -> true.

This has nothing to do with whether you are using Unity or Plasma (which for 
some reason you keep wrongly calling KDE).

See https://git.reviewboard.kde.org/r/129892/


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129885/#review102239
---


On Jan. 25, 2017, 8:39 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129885/
> ---
> 
> (Updated Jan. 25, 2017, 8:39 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and David Faure.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> This patch (https://git.reviewboard.kde.org/r/129261/) is *ugly* makes side 
> effects on KDE menubars. Start Dolphin -> hide menubar -> restart it -> click 
> control button -> menubar action is checked.
> It hide all actions changed between updateAction calls e.g.
> updateAction (stores last state of checked and enable)
> application changed menu action like it want
> updateAction is called on show event -> discard modified states
> 
> 
> Diffs
> -
> 
>   src/kstandardaction.cpp 6e5bba7 
> 
> Diff: https://git.reviewboard.kde.org/r/129885/diff/
> 
> 
> Testing
> ---
> 
> Works correct on KDE, test it on Unity.
> Please don't make such a patch, respect application behavior.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129892/
---

Review request for KDE Frameworks, Anthony Fieroni and David Faure.


Repository: kconfigwidgets


Description
---

It makes no sense to treat no menubars as all menubars native so just bail 
early, the app is probably still in construction if there's no menubars but it 
actually has a showmenubaraction.


Diffs
-

  src/kstandardaction.cpp 6e5bba7 

Diff: https://git.reviewboard.kde.org/r/129892/diff/


Testing
---

Dolphin behaves better regarding the show menubar action.


Thanks,

Albert Astals Cid

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

[Demitrius Belai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/
---

(Updated Jan. 26, 2017, 9:30 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Hi,

This is same #105677 but for plasmapkg2


Diffs
-

  src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 

Diff: https://git.reviewboard.kde.org/r/126418/diff/


Testing
---


Thanks,

Demitrius Belai

[Differential] [Resigned From] D4253: redesign gwenview icon

[Albert Astals Cid]

aacid resigned from this revision.
aacid removed a reviewer: aacid.
aacid added a comment.


  I don't have an opinion, not good in saying which icon is nicer than others.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask, sandsmark, cfeck
Cc: adelsarto, alex-l, andreaska, #frameworks

[Differential] [Request, 2 lines] D4300: Simpler calculation of longest line limit

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
gszymaszek set the repository for this revision to R39 KTextEditor.
gszymaszek added a project: KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  As suggested in `TODO`, I’ve replaced two `log()` calls with a single 
`log2()` call.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4300

AFFECTED FILES
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, #frameworks, cullmann, kfunk, sars, dhaumann

[Differential] [Commented On] D4294: Latex Syntax: Fix identification of alignat environment end

[Dominik Haumann]

dhaumann added a comment.


  The patch is almost good: Whenever we change a .xml file, we also need to 
increase the version number in https://phabricator.kde.org/D4294

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hfujimoto, #framework_syntax_hightlighting
Cc: dhaumann, kwrite-devel, #frameworks, cullmann, vkrause

[Differential] [Commented On] D4253: redesign gwenview icon

[Andrea Del Sarto]

adelsarto added a comment.


  I also think that we shouldn't update the icon. I like the current one.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask, sandsmark, aacid, cfeck
Cc: adelsarto, alex-l, andreaska, #frameworks

[Differential] [Updated] D4253: redesign gwenview icon

[Alexey Varfolomeev]

varlesh added reviewers: sandsmark, aacid, cfeck.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask, sandsmark, aacid, cfeck
Cc: alex-l, andreaska, #frameworks

[Differential] [Commented On] D4253: redesign gwenview icon

[Alexey Varfolomeev]

varlesh added a comment.


  gwenview devs please tell what you like icon for Breeze 1 or 2?
  1:1
  F2181407: Снимок экрана от 2017-01-26 20-02-37.png 

  
  zoomed
  F2181414: Снимок экрана от 2017-01-26 20-10-44.png 

  
  SVG's:
  F2181423: 1-gwenview.svg 
  F2181424: 2- gwenview.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4253

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreask
Cc: alex-l, andreaska, #frameworks

[Differential] [Accepted] D4288: Add Kleopatra tray icon

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4288

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma, mart
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Alexey Varfolomeev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0fda78588faf: fix icons bittorrent-sync, codeblocks, 
darktable, ffmulticonverter (authored by varlesh).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4278?vs=10587&id=10591

REVISION DETAIL
  https://phabricator.kde.org/D4278

AFFECTED FILES
  icons/apps/48/bittorent-sync.svg
  icons/apps/48/bittorrent-sync.svg
  icons/apps/48/btsync-gui.svg
  icons/apps/48/codeblocks.svg
  icons/apps/48/darktable.svg
  icons/apps/48/ffmulticonverter.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, alex-l, andreaska, #breeze
Cc: alex-l, andreaska, #frameworks

[Differential] [Request, 4 lines] D4296: Fixed single line comments in Less starting new regions

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added a reviewer: Framework: Syntax Hightlighting.
gszymaszek set the repository for this revision to R216 Syntax Highlighting.
gszymaszek added a project: Framework: Syntax Hightlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  From bug 373002 :
  
  > If you type // in a Less (LESSCSS) file, Kate incorrectly opens a new 
region (it should do it in case of multiline comment, /*…*/). If you try to 
hide that region (using the arrow that's next to line number) it actually hides 
everything in the file starting from the comment.
  > 
  > Fixing this bug requires removing ' beginRegion="lessComment" ' from line 
924 (of less.xml) and incrementing file version number on line 3.
  > 
  > Single line comments are part of Less, as stated here:
  >  http://lesscss.org/features/#features-overview-feature-comments 

  
  This diff fixes the mentioned issue for me.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D4296

AFFECTED FILES
  data/syntax/less.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #framework_syntax_hightlighting
Cc: #frameworks, cullmann, vkrause, dhaumann

[Differential] [Closed] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d2c7435b1bc1: Dialog: Hide when focus changes to 
ConfigView with hideOnWindowDeactivate (authored by drosca).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4282?vs=10558&id=10590

REVISION DETAIL
  https://phabricator.kde.org/D4282

AFFECTED FILES
  src/plasmaquick/dialog.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Andreas Kainz]

andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4278

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, alex-l, andreaska, #breeze
Cc: alex-l, andreaska, #frameworks

[Differential] [Commented On] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Alexey Varfolomeev]

varlesh added a comment.


  diff updated:
  F2180675: Снимок экрана от 2017-01-26 17-54-36.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4278

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, alex-l, andreaska
Cc: alex-l, andreaska, #frameworks

[Differential] [Updated, 983 lines] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Alexey Varfolomeev]

varlesh updated this revision to Diff 10587.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4278?vs=10542&id=10587

REVISION DETAIL
  https://phabricator.kde.org/D4278

AFFECTED FILES
  icons/apps/48/bittorent-sync.svg
  icons/apps/48/bittorrent-sync.svg
  icons/apps/48/btsync-gui.svg
  icons/apps/48/codeblocks.svg
  icons/apps/48/darktable.svg
  icons/apps/48/ffmulticonverter.svg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, alex-l, andreaska
Cc: alex-l, andreaska, #frameworks

[Differential] [Accepted] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

[Demitrius Belai]

> On Jan. 21, 2017, 12:44 a.m., Albert Astals Cid wrote:
> > Unfortunately noone commited this patch and doesn't apply anymore, could 
> > you update it?
> 
> Demitrius Belai wrote:
> Sure. I have to submit new request review because the PackageStructure 
> plugin for kpackagetool5 must be in the kwin repository.

Done! #129891


- Demitrius


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/#review102134
---


On Dez. 18, 2015, 6:30 p.m., Demitrius Belai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126418/
> ---
> 
> (Updated Dez. 18, 2015, 6:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Hi,
> 
> This is same #105677 but for plasmapkg2
> 
> 
> Diffs
> -
> 
>   src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 
> 
> Diff: https://git.reviewboard.kde.org/r/126418/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Demitrius Belai
> 
>

[Differential] [Request, 2 lines] D4294: Latex Syntax: Fix identification of alignat environment end

[Hironori Fujimoto]

hfujimoto created this revision.
hfujimoto added a reviewer: Framework: Syntax Hightlighting.
hfujimoto added a subscriber: kwrite-devel.
hfujimoto set the repository for this revision to R216 Syntax Highlighting.
hfujimoto added a project: Framework: Syntax Hightlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Avoid identifying alignat as align in environment end.
  fix of bug 344562: https://bugs.kde.org/show_bug.cgi?id=344562

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D4294

AFFECTED FILES
  data/syntax/latex.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hfujimoto, #framework_syntax_hightlighting
Cc: kwrite-devel, #frameworks, cullmann, vkrause, dhaumann

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Alessandro Longo]

alex-l added a comment.


  For me new ones don't follow the guidelines and Breeze style. Please use the 
current icons as reference implementation.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4278

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, #breeze, andreaska, alex-l
Cc: alex-l, andreaska, #frameworks

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

[Demitrius Belai]

> On Jan. 21, 2017, 12:44 a.m., Albert Astals Cid wrote:
> > Unfortunately noone commited this patch and doesn't apply anymore, could 
> > you update it?

Sure. I have to submit new request review because the PackageStructure plugin 
for kpackagetool5 must be in the kwin repository.


- Demitrius


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/#review102134
---


On Dez. 18, 2015, 6:30 p.m., Demitrius Belai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126418/
> ---
> 
> (Updated Dez. 18, 2015, 6:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Hi,
> 
> This is same #105677 but for plasmapkg2
> 
> 
> Diffs
> -
> 
>   src/plasmapkg/plasmapkg.cpp 4626323cd5d1dc3a3147fe43102d901d615e0b66 
> 
> Diff: https://git.reviewboard.kde.org/r/126418/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Demitrius Belai
> 
>

[Differential] [Commented On] D4289: Add VLC tray icon

[Yunhe Guo]

guoyunhe added a comment.


  In https://phabricator.kde.org/D4289#80406, @andreaska wrote:
  
  > can you upload the svgz file cause I can't download it here.
  
  
  Uploaded

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma:_design
Cc: andreaska, guoyunhe, #frameworks

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

[Andreas Kainz]

andreaska added a comment.


  +1 bittorent sync
  +1 darktable
  +1 ffmulticonverter
  
  codeblocks is better but the hammer had to much different colors I think

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4278

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: varlesh, alex-l, #breeze, andreaska
Cc: alex-l, andreaska, #frameworks

[Differential] [Updated] D4288: Add Kleopatra tray icon

[Yunhe Guo]

guoyunhe updated the summary for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4288

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D4289: Add VLC tray icon

[Yunhe Guo]

guoyunhe updated the summary for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma:_design
Cc: andreaska, guoyunhe, #frameworks

[Differential] [Commented On] D4289: Add VLC tray icon

[Andreas Kainz]

andreaska added a comment.


  can you upload the svgz file cause I can't download it here.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4289

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma:_design
Cc: andreaska, guoyunhe, #frameworks

[Differential] [Request, 0 lines] D4289: Add VLC tray icon

[Yunhe Guo]

guoyunhe created this revision.
guoyunhe added a reviewer: Plasma: Design.
guoyunhe set the repository for this revision to R242 Plasma Framework 
(Library).
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  F2171236: Screenshot_20170126_110037.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4289

AFFECTED FILES
  src/desktoptheme/breeze/icons/vlc.svgz

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma:_design
Cc: guoyunhe, #frameworks

[Differential] [Request, 0 lines] D4288: Add Kleopatra tray icon

[Yunhe Guo]

guoyunhe created this revision.
guoyunhe added a reviewer: Plasma.
guoyunhe set the repository for this revision to R242 Plasma Framework 
(Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Add Kleopatra tray icon.
  
  F2167935: Screenshot_20170126_102312.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4288

AFFECTED FILES
  src/desktoptheme/breeze/icons/kleopatra.svgz

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: guoyunhe, #plasma
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas