[Differential] [Updated, 240 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide
kossebau updated this revision to Diff 10669. kossebau added a comment. deduplicate unit tests REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4329?vs=10667&id=10669 BRANCH fixKMessageWidgetInstantShowHide REVISION DETAIL https://phabricator.kde.org/D4329 AFFECTED FILES autotests/kmessagewidgetautotest.cpp autotests/kmessagewidgetautotest.h src/kmessagewidget.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, dhaumann
[Differential] [Request, 288 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide
kossebau created this revision. kossebau added reviewers: Frameworks, dhaumann. Restricted Application added a project: Frameworks. REVISION SUMMARY Calling animatedHide() on a not yet shown KMessageWidget instance was ignored when the parent And instant counter-direction updates (like it can happen due to complicated signal handling on UI updates) resulted in the last calls being ignored, so an instant hide after a show or an instant show after a hide were ineffective, resulting in wrong messages or wrongly no messages shown. TEST PLAN Works now in WIP KDevelop code, and new unit tests no longer fail. REPOSITORY R236 KWidgetsAddons BRANCH fixKMessageWidgetInstantShowHide REVISION DETAIL https://phabricator.kde.org/D4329 AFFECTED FILES autotests/kmessagewidgetautotest.cpp autotests/kmessagewidgetautotest.h src/kmessagewidget.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, dhaumann
Phabricator: All repositories registered - upcoming workflow changes
Hi everyone, We've just completed the registration of all mainline repositories (not including Websites or Sysadmin namespaced ones) on Phabricator. Thanks go to Luigi Toscano for providing significant assistance with this process. >From this point forward, communities should be moving away from Reviewboard to Phabricator for conducting code review. Sysadmin will be announcing a timeline for the shutdown of Reviewboard in the near future. Projects which haven't yet looked into Phabricator, including getting things like mailing list notifications and projects setup should do so as soon as practical. As part of the registration process, Sysadmin tagged repositories, associating them to Projects. These tags show what a repository is associated with and it's status. This includes things like whether development is currently active (the Historical Archival and Up For Adoption tags), which release unit it is part of (KDE Applications, Frameworks, etc) and the general development effort it is associated with. It would be appreciated if everyone could please check their repositories to ensure they've been tagged correctly. Adjustments can either be sent as replies to this email (include sysadmin@ in CC please) or by asking a member of the Community Admins project on Phabricator to make the change for you. Thanks, Ben Cooksley KDE Sysadmin
Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically erasing it from existence).* from > > https://git.reviewboard.kde.org/r/129261/ > > *This has nothing to do with whether you are using Unity or Plasma* from > > https://git.reviewboard.kde.org/r/129885/ > > I want an explanation, i never use Unity, i will never use it, but i want > > know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, > > wasNative == true ? > > If so, i'm -1 for this approach > > Albert Astals Cid wrote: > You don't seem to understand the code, what makes you think you're able > to give a -1 when you don't understand the code? > > You want an explanation? What makes you think you should be given one? > You're not the maintainer of the code, you have not contributed at all to > kconfigwidgets and on top of that you've been nothing other than agressive > both in this and in the other review request. > > Still i'll try to explain it to you, but don't think your attitude is > helping, it's not. > > > but i want know in Unity - Kate, Dolphin etc. on showEvent > allMenuBarsNative == true, wasNative == true ? > > This depends if it's the first show or not. On the first show obviously > wasNative will be false since it is how it is initialized in the constructor. > So on the first show it'll be allMenuBarsNative == true, wasNative == false > and on the second show, yes it will be allMenuBarsNative == true, wasNative > == true. > > I sincerely think the code is quite easy to understand, what you don't > understand? > > Anthony Fieroni wrote: > So when i know allMenuBarsNative == true, wasNative == true, why you > think that i'm not uderstainding? I'm against to store / restore menubar > chacked and visabiliity. > > Anthony Fieroni wrote: > >This depends if it's the first show or not. On the first show obviously > wasNative will be false since it is how it is initialized in the constructor. > So on the first show it'll be allMenuBarsNative == true, wasNative == false > and on the second show, yes it will be allMenuBarsNative == true, wasNative > == true. > > Albert, i know that, that's why i made that patch > https://git.reviewboard.kde.org/r/129885/ > > Albert Astals Cid wrote: > Do you know what a native menubar is? Can you explain why you are against > storing the state? I read this http://doc.qt.io/qt-5/qmenubar.html#nativeMenuBar-prop, personally i never use nor OSX nor Unity. I'm against because this is a bad practive, yeah i see new patch will work (logically, because i'm not test it) but i don't see any reason to do this when we can do it without. Now we insert new code rather than minimize it, my approach when i write code are: 1. simple logic 2. less code 3. less temporary state changes 4. less variables For me new code doesn't meet these conditions, i'm not a person who decide who will be pushed or not. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102269 --- On Ян. 27, 2017, 12:19 преди обяд, Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129892/ > --- > > (Updated Ян. 27, 2017, 12:19 преди обяд) > > > Review request for KDE Frameworks, Anthony Fieroni and David Faure. > > > Repository: kconfigwidgets > > > Description > --- > > It makes no sense to treat no menubars as all menubars native so just bail > early, the app is probably still in construction if there's no menubars but > it actually has a showmenubaraction. > > > Diffs > - > > src/kstandardaction.cpp 6e5bba7 > > Diff: https://git.reviewboard.kde.org/r/129892/diff/ > > > Testing > --- > > Dolphin behaves better regarding the show menubar action. > > > Thanks, > > Albert Astals Cid > >
[Differential] [Accepted] D4320: Don't fail when moving to the temp directory when installing
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> installation.cpp:546
> if (success) {
> +if (installpath.startsWith(QDir::tempPath()))
> +file.remove(installpath);
if () {
}
also, add a comment on what is doing here
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4320
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, mart
Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
> On gen. 27, 2017, 5:01 a.m., Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically erasing it from existence).* from > > https://git.reviewboard.kde.org/r/129261/ > > *This has nothing to do with whether you are using Unity or Plasma* from > > https://git.reviewboard.kde.org/r/129885/ > > I want an explanation, i never use Unity, i will never use it, but i want > > know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, > > wasNative == true ? > > If so, i'm -1 for this approach > > Albert Astals Cid wrote: > You don't seem to understand the code, what makes you think you're able > to give a -1 when you don't understand the code? > > You want an explanation? What makes you think you should be given one? > You're not the maintainer of the code, you have not contributed at all to > kconfigwidgets and on top of that you've been nothing other than agressive > both in this and in the other review request. > > Still i'll try to explain it to you, but don't think your attitude is > helping, it's not. > > > but i want know in Unity - Kate, Dolphin etc. on showEvent > allMenuBarsNative == true, wasNative == true ? > > This depends if it's the first show or not. On the first show obviously > wasNative will be false since it is how it is initialized in the constructor. > So on the first show it'll be allMenuBarsNative == true, wasNative == false > and on the second show, yes it will be allMenuBarsNative == true, wasNative > == true. > > I sincerely think the code is quite easy to understand, what you don't > understand? > > Anthony Fieroni wrote: > So when i know allMenuBarsNative == true, wasNative == true, why you > think that i'm not uderstainding? I'm against to store / restore menubar > chacked and visabiliity. > > Anthony Fieroni wrote: > >This depends if it's the first show or not. On the first show obviously > wasNative will be false since it is how it is initialized in the constructor. > So on the first show it'll be allMenuBarsNative == true, wasNative == false > and on the second show, yes it will be allMenuBarsNative == true, wasNative > == true. > > Albert, i know that, that's why i made that patch > https://git.reviewboard.kde.org/r/129885/ Do you know what a native menubar is? Can you explain why you are against storing the state? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102269 --- On gen. 26, 2017, 10:19 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129892/ > --- > > (Updated gen. 26, 2017, 10:19 p.m.) > > > Review request for KDE Frameworks, Anthony Fieroni and David Faure. > > > Repository: kconfigwidgets > > > Description > --- > > It makes no sense to treat no menubars as all menubars native so just bail > early, the app is probably still in construction if there's no menubars but > it actually has a showmenubaraction. > > > Diffs > - > > src/kstandardaction.cpp 6e5bba7 > > Diff: https://git.reviewboard.kde.org/r/129892/diff/ > > > Testing > --- > > Dolphin behaves better regarding the show menubar action. > > > Thanks, > > Albert Astals Cid > >
Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically erasing it from existence).* from > > https://git.reviewboard.kde.org/r/129261/ > > *This has nothing to do with whether you are using Unity or Plasma* from > > https://git.reviewboard.kde.org/r/129885/ > > I want an explanation, i never use Unity, i will never use it, but i want > > know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, > > wasNative == true ? > > If so, i'm -1 for this approach > > Albert Astals Cid wrote: > You don't seem to understand the code, what makes you think you're able > to give a -1 when you don't understand the code? > > You want an explanation? What makes you think you should be given one? > You're not the maintainer of the code, you have not contributed at all to > kconfigwidgets and on top of that you've been nothing other than agressive > both in this and in the other review request. > > Still i'll try to explain it to you, but don't think your attitude is > helping, it's not. > > > but i want know in Unity - Kate, Dolphin etc. on showEvent > allMenuBarsNative == true, wasNative == true ? > > This depends if it's the first show or not. On the first show obviously > wasNative will be false since it is how it is initialized in the constructor. > So on the first show it'll be allMenuBarsNative == true, wasNative == false > and on the second show, yes it will be allMenuBarsNative == true, wasNative > == true. > > I sincerely think the code is quite easy to understand, what you don't > understand? > > Anthony Fieroni wrote: > So when i know allMenuBarsNative == true, wasNative == true, why you > think that i'm not uderstainding? I'm against to store / restore menubar > chacked and visabiliity. >This depends if it's the first show or not. On the first show obviously >wasNative will be false since it is how it is initialized in the constructor. >So on the first show it'll be allMenuBarsNative == true, wasNative == false >and on the second show, yes it will be allMenuBarsNative == true, wasNative == >true. Albert, i know that, that's why i made that patch https://git.reviewboard.kde.org/r/129885/ - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102269 --- On Ян. 27, 2017, 12:19 преди обяд, Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129892/ > --- > > (Updated Ян. 27, 2017, 12:19 преди обяд) > > > Review request for KDE Frameworks, Anthony Fieroni and David Faure. > > > Repository: kconfigwidgets > > > Description > --- > > It makes no sense to treat no menubars as all menubars native so just bail > early, the app is probably still in construction if there's no menubars but > it actually has a showmenubaraction. > > > Diffs > - > > src/kstandardaction.cpp 6e5bba7 > > Diff: https://git.reviewboard.kde.org/r/129892/diff/ > > > Testing > --- > > Dolphin behaves better regarding the show menubar action. > > > Thanks, > > Albert Astals Cid > >
Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
> On Ян. 27, 2017, 7:01 преди обяд, Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically erasing it from existence).* from > > https://git.reviewboard.kde.org/r/129261/ > > *This has nothing to do with whether you are using Unity or Plasma* from > > https://git.reviewboard.kde.org/r/129885/ > > I want an explanation, i never use Unity, i will never use it, but i want > > know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, > > wasNative == true ? > > If so, i'm -1 for this approach > > Albert Astals Cid wrote: > You don't seem to understand the code, what makes you think you're able > to give a -1 when you don't understand the code? > > You want an explanation? What makes you think you should be given one? > You're not the maintainer of the code, you have not contributed at all to > kconfigwidgets and on top of that you've been nothing other than agressive > both in this and in the other review request. > > Still i'll try to explain it to you, but don't think your attitude is > helping, it's not. > > > but i want know in Unity - Kate, Dolphin etc. on showEvent > allMenuBarsNative == true, wasNative == true ? > > This depends if it's the first show or not. On the first show obviously > wasNative will be false since it is how it is initialized in the constructor. > So on the first show it'll be allMenuBarsNative == true, wasNative == false > and on the second show, yes it will be allMenuBarsNative == true, wasNative > == true. > > I sincerely think the code is quite easy to understand, what you don't > understand? So when i know allMenuBarsNative == true, wasNative == true, why you think that i'm not uderstainding? I'm against to store / restore menubar chacked and visabiliity. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102269 --- On Ян. 27, 2017, 12:19 преди обяд, Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129892/ > --- > > (Updated Ян. 27, 2017, 12:19 преди обяд) > > > Review request for KDE Frameworks, Anthony Fieroni and David Faure. > > > Repository: kconfigwidgets > > > Description > --- > > It makes no sense to treat no menubars as all menubars native so just bail > early, the app is probably still in construction if there's no menubars but > it actually has a showmenubaraction. > > > Diffs > - > > src/kstandardaction.cpp 6e5bba7 > > Diff: https://git.reviewboard.kde.org/r/129892/diff/ > > > Testing > --- > > Dolphin behaves better regarding the show menubar action. > > > Thanks, > > Albert Astals Cid > >
Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
> On Jan. 27, 2017, 5:01 a.m., Anthony Fieroni wrote: > > So, wait a minute i just quote you > > *This patch attempts to fix it by iterating all the main windows when they > > are shown and if all the menubars of all mainwindows are native, then hides > > the show menu bar action (basically erasing it from existence).* from > > https://git.reviewboard.kde.org/r/129261/ > > *This has nothing to do with whether you are using Unity or Plasma* from > > https://git.reviewboard.kde.org/r/129885/ > > I want an explanation, i never use Unity, i will never use it, but i want > > know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, > > wasNative == true ? > > If so, i'm -1 for this approach You don't seem to understand the code, what makes you think you're able to give a -1 when you don't understand the code? You want an explanation? What makes you think you should be given one? You're not the maintainer of the code, you have not contributed at all to kconfigwidgets and on top of that you've been nothing other than agressive both in this and in the other review request. Still i'll try to explain it to you, but don't think your attitude is helping, it's not. > but i want know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative > == true, wasNative == true ? This depends if it's the first show or not. On the first show obviously wasNative will be false since it is how it is initialized in the constructor. So on the first show it'll be allMenuBarsNative == true, wasNative == false and on the second show, yes it will be allMenuBarsNative == true, wasNative == true. I sincerely think the code is quite easy to understand, what you don't understand? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/#review102269 --- On Jan. 26, 2017, 10:19 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129892/ > --- > > (Updated Jan. 26, 2017, 10:19 p.m.) > > > Review request for KDE Frameworks, Anthony Fieroni and David Faure. > > > Repository: kconfigwidgets > > > Description > --- > > It makes no sense to treat no menubars as all menubars native so just bail > early, the app is probably still in construction if there's no menubars but > it actually has a showmenubaraction. > > > Diffs > - > > src/kstandardaction.cpp 6e5bba7 > > Diff: https://git.reviewboard.kde.org/r/129892/diff/ > > > Testing > --- > > Dolphin behaves better regarding the show menubar action. > > > Thanks, > > Albert Astals Cid > >
[Differential] [Abandoned] D4258: redesign gimp icon
varlesh abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4258 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: andreaska, alex-l, #frameworks
[Differential] [Abandoned] D4253: redesign gwenview icon
varlesh abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreask, sandsmark, cfeck Cc: adelsarto, alex-l, andreaska, #frameworks
Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/#review102297 --- Ship it! Great work. KAuth was really lacking documentation. I remember me cursing about the documentation being wrong quite often during the Qt 5 port. - Martin Gräßlin On Jan. 15, 2017, 6:10 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129842/ > --- > > (Updated Jan. 15, 2017, 6:10 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kauth > > > Description > --- > > This moves most of the example snippets (which were outdated) into real cmake > targets. We use the Doxygen `@snippet` magic to show them in the apidox. This > ensures that the example code is always compiled and stays up-to-date. > Some of the snippets are just removed, in particular the section about > executing the actions asynchronously, which predates the KJob (ExecuteJob) > usage. > > > Diffs > - > > CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 > examples/CMakeLists.txt PRE-CREATION > examples/client.cpp PRE-CREATION > examples/helper.cpp PRE-CREATION > metainfo.yaml f709143c00d70c834d6ccde103f575be3771d448 > src/kauthactionreply.h 6203df034483c102eb82220cca3dac313a094f41 > > Diff: https://git.reviewboard.kde.org/r/129842/diff/ > > > Testing > --- > > Examples targets build fine. > Ran kapidox locally, code snippets shows up in the documentation of the KAuth > namespace. > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/#review102296 --- Ping? - Elvis Angelaccio On Jan. 15, 2017, 5:10 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129842/ > --- > > (Updated Jan. 15, 2017, 5:10 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kauth > > > Description > --- > > This moves most of the example snippets (which were outdated) into real cmake > targets. We use the Doxygen `@snippet` magic to show them in the apidox. This > ensures that the example code is always compiled and stays up-to-date. > Some of the snippets are just removed, in particular the section about > executing the actions asynchronously, which predates the KJob (ExecuteJob) > usage. > > > Diffs > - > > CMakeLists.txt 58d0f2a5d6c2f442097a27e229a1b8cb3ec35f73 > examples/CMakeLists.txt PRE-CREATION > examples/client.cpp PRE-CREATION > examples/helper.cpp PRE-CREATION > metainfo.yaml f709143c00d70c834d6ccde103f575be3771d448 > src/kauthactionreply.h 6203df034483c102eb82220cca3dac313a094f41 > > Diff: https://git.reviewboard.kde.org/r/129842/diff/ > > > Testing > --- > > Examples targets build fine. > Ran kapidox locally, code snippets shows up in the documentation of the KAuth > namespace. > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129849/#review102295 --- Ping? - Elvis Angelaccio On Jan. 17, 2017, 10:47 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129849/ > --- > > (Updated Jan. 17, 2017, 10:47 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > --- > > While the layout of the tooltip sets the tooltip as parent of the content > widget, we don't really need to take ownership of it. We can just restore the > old parent once we are done. > This prevents a double delete crash if someone (by accident) deletes first > the tooltip and then the content. > > > Diffs > - > > autotests/ktooltipwidgettest.h 556d93edd7792736bb7b41761f2d8934395d2f3c > autotests/ktooltipwidgettest.cpp 89124c6b3f16b76a346a8c9c74ff2f9efe0c9e83 > src/ktooltipwidget.h cde7e66af797c9888dec59ef50831a2260a2c238 > src/ktooltipwidget.cpp 544eb74d005bb4c963c8cc6cd8b941c018cf463e > > Diff: https://git.reviewboard.kde.org/r/129849/diff/ > > > Testing > --- > > Test case reproduces the crash, which is fixed by the patch. > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129833/#review102294 --- Ping? - Elvis Angelaccio On Jan. 14, 2017, 6:54 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129833/ > --- > > (Updated Jan. 14, 2017, 6:54 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > --- > > Otherwise the tooltip will be visible but empty. > > > Diffs > - > > autotests/ktooltipwidgettest.h 556d93edd7792736bb7b41761f2d8934395d2f3c > autotests/ktooltipwidgettest.cpp 89124c6b3f16b76a346a8c9c74ff2f9efe0c9e83 > src/ktooltipwidget.cpp 979d4f71b5ebf9d0716e12453ecbfc88e48be72d > > Diff: https://git.reviewboard.kde.org/r/129833/diff/ > > > Testing > --- > > The new test case reproduces this issue. > > > Thanks, > > Elvis Angelaccio > >
[Differential] [Commented On] D4253: redesign gwenview icon
andreaska added a comment. Varlesh you do awesome icon work, but gwenview was changed some time ago so no icon redesign needed sorry. Please work on other icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreask, sandsmark, cfeck Cc: adelsarto, alex-l, andreaska, #frameworks
