[Differential] [Accepted] D4439: KDirWatch: fix memory leak on destruction.
mpyne accepted this revision. mpyne added a comment. The diff as proposed is just fine. I've been bitten by `qDeleteAll` at proc exit before when called on objects that have complex destructors, but that's not the case here. It would probably be a good idea to try to streamline the code structurally so that we don't have to hold pointers. But given the difficulty that it would entail, I think it would deserve either a separate Differential review, or to "upgrade" this review to focus on the structural change for its own sake, instead of just working on the memleak at process exit. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4439 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, aacid, mpyne Cc: markg, #frameworks
Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes
On Mon, Feb 06, 2017 at 11:35:15PM +0100, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > > Hi everyone, > > > > From this point forward, communities should be moving away from > > Reviewboard to Phabricator for conducting code review. Sysadmin will > > be announcing a timeline for the shutdown of Reviewboard in the near > > future. > > Today i wanted to commit https://phabricator.kde.org/D4432 since the person > that opened it does not have a developer account. > > > ouch, so i need his email, where do i get it? > > Nowhere it seems. > > I resorted to searching for it in identity.kde.org but i think that i can > only > do that because i have some special power over there that allows me to see > everyone's email, and even if everyone can, it's very cumbsersome, and > probably what i would end up doing is asking in Differential, the author > would > have to answer, potentially either him or me forgetting about it. In fairness to Phabricator there's been times where I've needed developer contact info *without* having a RR available. In the "good old days" we'd just use the kde-common/accounts file to lookup the developer's id and corresponding email address, and that worked fine. So I think Identity (and in general whatever our KDE organizational directory solution happens to be) is the proper solution -- although it shouldn't need superpowers to actually see those identities. And of course, there's no reason not to also show the email in Phabricator, which would be more helpful and developer-friendly. Regards, - Michael Pyne
Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes
El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > Hi everyone, > > From this point forward, communities should be moving away from > Reviewboard to Phabricator for conducting code review. Sysadmin will > be announcing a timeline for the shutdown of Reviewboard in the near > future. Today i wanted to commit https://phabricator.kde.org/D4432 since the person that opened it does not have a developer account. Easy peasy, it's just a line, i download the patch and then git commit --author ... and what, it says "Authored by rikmills" that's probably not the guys name, but i can click on the name and on https://phabricator.kde.org/p/rikmills/ i learn he is Rik Mills, good. $ git commit --author=="Rik Mills" fatal: --author 'Rik Mills' is not 'Name ' and matches no existing author ouch, so i need his email, where do i get it? Nowhere it seems. I resorted to searching for it in identity.kde.org but i think that i can only do that because i have some special power over there that allows me to see everyone's email, and even if everyone can, it's very cumbsersome, and probably what i would end up doing is asking in Differential, the author would have to answer, potentially either him or me forgetting about it. On reviewboard it was as simple as going to https://git.reviewboard.kde.org/users/rikmills/ (that i just realized i could have used instead of identity :D but it's going away so it's not a solution either). Cheers, Albert
Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review102430 --- See bug 37 for a regression. Not sure if it is fixable. - Christoph Feck On Dec. 29, 2016, 6:31 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129299/ > --- > > (Updated Dec. 29, 2016, 6:31 p.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kxmlgui > > > Description > --- > > Add a warning at the createGui stage about ambiguous shortcuts being found in > the same action collection. > > This is usually a developer issue, but the error message about ambiguity will > only show up when someone tries to use the shortcut, so it is relatively easy > to miss if you do not try all your actions via a shortcut. > > Also if the involved shortcut is one of the non primary shortcuts of edit_cut > + deletefile, just give it away, since it's Shift+Delete being fought over as > part of our defaults being ambiguous. > > > Diffs > - > > src/kxmlguiwindow.h 3c61939 > src/kxmlguiwindow.cpp 519fb26 > > Diff: https://git.reviewboard.kde.org/r/129299/diff/ > > > Testing > --- > > gwenview without any patch gives the warning > gwenview with https://git.reviewboard.kde.org/r/129717/ doesn't give the > warning (since it's using the standard actions instead of a own one for > delete) > gwenview with https://git.reviewboard.kde.org/r/129718/ doesn't give the > warning (since it's manually removing Shift+Delete for cut) > > > Thanks, > > Albert Astals Cid > >
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 242 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/242/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 19:04:24 + Build duration: 1 min 45 sec CHANGE SET Revision a714eec8bfb5f123bd7bdce8508455f649fe3af5 by martin.sandsmark: (Port some left-over debug output to categorized logging) change: edit src/CMakeLists.txt change: edit src/sycoca/kmimeassociations.cpp change: edit src/sycoca/kbuildsycoca.cpp change: edit src/services/kservicefactory.cpp change: edit src/services/kmimetypetrader.cpp change: edit src/services/kservicegroup.cpp change: edit src/sycoca/ksycocadict.cpp change: edit src/services/kservice.cpp change: edit src/sycoca/vfolder_menu.cpp change: add src/services/servicesdebug.cpp change: add src/services/servicesdebug.h change: edit src/sycoca/kctimefactory.cpp change: edit src/sycoca/kbuildservicefactory.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5483/8009 (68%)CONDITIONAL 2975/6230 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 (94%)CONDITIONAL 890/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 (58%)CONDITIONAL 764/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 (73%)CONDITIONAL 1236/2106 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 242 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/242/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 19:04:24 + Build duration: 1 min 45 sec CHANGE SET Revision a714eec8bfb5f123bd7bdce8508455f649fe3af5 by martin.sandsmark: (Port some left-over debug output to categorized logging) change: edit src/CMakeLists.txt change: edit src/sycoca/kmimeassociations.cpp change: edit src/sycoca/kbuildsycoca.cpp change: edit src/services/kservicefactory.cpp change: edit src/services/kmimetypetrader.cpp change: edit src/services/kservicegroup.cpp change: edit src/sycoca/ksycocadict.cpp change: edit src/services/kservice.cpp change: edit src/sycoca/vfolder_menu.cpp change: add src/services/servicesdebug.cpp change: add src/services/servicesdebug.h change: edit src/sycoca/kctimefactory.cpp change: edit src/sycoca/kbuildservicefactory.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5483/8009 (68%)CONDITIONAL 2975/6230 (48%) By packages autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1464/1554 (94%)CONDITIONAL 890/1792 (50%) src.kbuildsycoca FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 15/20 (75%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 (0%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 36/96 (38%) src.services FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 (58%)CONDITIONAL 764/1904 (40%) src.sycoca FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 (73%)CONDITIONAL 1236/2106 (59%) tests.pluginlocator FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 34/50 (68%)
[Differential] [Closed] D4463: Konqueror can no longer be selected as default file manager
This revision was automatically updated to reflect the committed changes. Closed by commit R226:c27a79e2dbab: Restore the ability to select Konqueror as the default file manager (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4463?vs=10973=10978#toc REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4463?vs=10973=10978 REVISION DETAIL https://phabricator.kde.org/D4463 AFFECTED FILES CMakeLists.txt kfmclient_dir.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #frameworks, dfaure
[Differential] [Accepted] D4463: Konqueror can no longer be selected as default file manager
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfmclient_dir.desktop:9 > +# Must be more than gwenview > +InitialPreference=10 > +NoDisplay=true Please make it 9, Dolphin has 10 as well, and Dolphin should be the default file manager. Gwenview has 8, so the comment would still be respected. While at it, adjust the comment to "less than Dolphin and more than Gwenview" :-) REPOSITORY R226 Konqueror REVISION DETAIL https://phabricator.kde.org/D4463 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #frameworks, dfaure
[Differential] [Request, 105 lines] D4463: Konqueror can no longer be selected as default file manager
marten created this revision.
marten added reviewers: Frameworks, dfaure.
marten set the repository for this revision to R226 Konqueror.
REVISION SUMMARY
Konqueror was originally able to be selected as the default file manager by
using kcmshell5 componentchooser ("Default Applications"). Now it does not
appear in the list of file manager applications.
This appears to be a result of commit
https://phabricator.kde.org/R226:456dec00e158ede269ec876cb28280f5b8d23fbb of 26
Sep 2016 ("More cleanup of the "profile" concept") removing
kfmclient_dir.desktop and no longer installing it. It's not clear whether this
was intentional, but this change restores that file and therefore the ability
to select Konqueror as a file manager.
TEST PLAN
Built konqueror with this change, checked that it can be selected as the
default file manager and that it is used correctly for that.
REPOSITORY
R226 Konqueror
REVISION DETAIL
https://phabricator.kde.org/D4463
AFFECTED FILES
CMakeLists.txt
kfmclient_dir.desktop
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: marten, #frameworks, dfaure
[Differential] [Closed] D4436: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c21ff749e646: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4436?vs=10916=10965 REVISION DETAIL https://phabricator.kde.org/D4436 AFFECTED FILES src/declarativeimports/plasmastyle/ButtonStyle.qml src/declarativeimports/plasmastyle/ToolButtonStyle.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D4436: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4436 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D4425: Add support for flatpak portals
jgrulich added inline comments. INLINE COMMENTS > apol wrote in knotificationmanager.cpp:93 > Maybe instead of querying for dbus things we could figure out a what > QPlatformTheme is in use somehow? Not sure how that would help. It would help maybe to detect whether we are in sandbox if we check whether the platform plugin is "flatpak", but with this check I want to make notifications work at least somehow, even in case we are in sandbox and the portal service is not available from some reason. If you use NotifyByPopup plugin in the sandbox then it will show the ugly notification on top of the screen instead so it's at least some notification. In case you would like to avoid displaying this ugly notification and rely on portals only then we can ignore this check and use NotifyByFlatpak regardless availability of the portal service. > apol wrote in notifybyflatpak.cpp:2 > Are you sure so many people? :P It's a modified "NotifyByPopup" plugin and I didn't change the copyright except adding myself. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jgrulich, mck182 Cc: broulik, apol, #frameworks
[Differential] [Commented On] D4425: Add support for flatpak portals
apol added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:93
> +
> +if (d->inSandbox) {
> +QDBusConnectionInterface *interface =
> QDBusConnection::sessionBus().interface();
Maybe instead of querying for dbus things we could figure out a what
QPlatformTheme is in use somehow?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4425
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jgrulich, mck182
Cc: broulik, apol, #frameworks
[Differential] [Closed] D4453: [ContainmentInterface] Also align containment context menu to panel
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b02bfdff71e: [ContainmentInterface] Also align containment context menu to panel (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4453?vs=10957=10959 REVISION DETAIL https://phabricator.kde.org/D4453 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D4453: [ContainmentInterface] Also align containment context menu to panel
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4453 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 2 lines] D4453: [ContainmentInterface] Also align containment context menu to panel
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There's no point in only aligning applet context menus to the panel. TEST PLAN Right-clicked my panel controller and the context menu is now aligned to the panel like all the other panel applet context menus REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4453 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 129911: Added property() method to TerminalInterface class
> On Feb. 5, 2017, 9:48 vorm., David Faure wrote: > > Alas, this is a binary incompatible change. It cannot be done this way. > > Solution 1: a V2 interface inheriting from this one (as we had in the past, > > IIRC). > > Solution 2: just use QObject dynamic properties, after documenting that in > > this header file. Thanks for the hint with the dynamic properties, used that and works fine - Sven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129911/#review102401 --- On Feb. 6, 2017, 9:03 vorm., Sven Fischer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129911/ > --- > > (Updated Feb. 6, 2017, 9:03 vorm.) > > > Review request for KDE Frameworks. > > > Repository: kparts > > > Description > --- > > For konsole KPart consumers it may be necessary to access the properties > of the konsole profile, e.g. the "Start in current session dir" to be > able to control the working directory in new KPart instantiation. > > A corresponding patch has been submitted to the konsole repository. > > > Diffs > - > > src/kde_terminal_interface.h f9603d120d5116db35ae60d65b2743a5aceaebac > > Diff: https://git.reviewboard.kde.org/r/129911/diff/ > > > Testing > --- > > Locally compile konsole against this changed header, and running a yakuake > instance against the patched konsole. > > > Thanks, > > Sven Fischer > >
Re: Review Request 129911: Added property() method to TerminalInterface class
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129911/ --- (Updated Feb. 6, 2017, 9:03 vorm.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kparts Description --- For konsole KPart consumers it may be necessary to access the properties of the konsole profile, e.g. the "Start in current session dir" to be able to control the working directory in new KPart instantiation. A corresponding patch has been submitted to the konsole repository. Diffs - src/kde_terminal_interface.h f9603d120d5116db35ae60d65b2743a5aceaebac Diff: https://git.reviewboard.kde.org/r/129911/diff/ Testing --- Locally compile konsole against this changed header, and running a yakuake instance against the patched konsole. Thanks, Sven Fischer
Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements
> On Feb. 5, 2017, 9:50 a.m., David Faure wrote: > > Can you also deprecate DrawFrame, then? > > Diego S. wrote: > How does stuff get deprecated in Frameworks? I don't have a lot of kde > development (or development in general) experience. I also don't have a > proper dev environment setup atm. > > David Faure wrote: > In general, with nifty *_DEPRECATED macros. But for enums I'm not sure, > so I did this, please check if what I wrote is correct: > > https://commits.kde.org/kio/8d9fde5daede2315a1d45052828c70f1496210a5 Looks ok to me. - Diego --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129921/#review102402 --- On Feb. 4, 2017, 9:51 p.m., Diego S. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129921/ > --- > > (Updated Feb. 4, 2017, 9:51 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio-extras > > > Description > --- > > This patch is part of https://git.reviewboard.kde.org/r/129918/ - see the > discussion on the old patch https://git.reviewboard.kde.org/r/118961/. > > Many thumbnail generators currently return ThumbCreator::DrawFrame in their > flags() function which causes a 90's style 1px "3d" border to be added to the > thumbnail image. > This causes problems when consumers of these thumbnails (like Dolphin) expect > a clean image representation of the file, without hard-coded design elements. > It also looks really bad when any resizing/scaling happens or when the > thumbnail is shown on a tooltip. Especially now that the UI has been > modernized with Breeze. > > > Diffs > - > > thumbnail/comiccreator.cpp d8f4473e1c7fa4595ad8defc406ad945d1ac38ac > thumbnail/djvucreator.cpp 1547831bfaa875a14a59659a2bebc86a2cd7c024 > thumbnail/htmlcreator.cpp 29d1902794abfa3cf8ba2ab97648e1bc2d8e7a73 > thumbnail/kritacreator.cpp 3b24bc3d2fa7b22662c25da1421cbd542d7efed6 > thumbnail/textcreator.cpp 7c0263c8e8cb4f88d1429b5714c51c2939d817f0 > > Diff: https://git.reviewboard.kde.org/r/129921/diff/ > > > Testing > --- > > Builds. > > > Thanks, > > Diego S. > >
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 424 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/424/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 08:13:22 + Build duration: 9 min 44 sec CHANGE SET Revision 8d9fde5daede2315a1d45052828c70f1496210a5 by David Faure: (deprecate DrawFrame, as discussed in) change: edit src/widgets/thumbcreator.h JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-threadtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 273/342 (80%)CLASSES 273/342 (80%)LINE 29685/51580 (58%)CONDITIONAL 16302/38725 (42%) By packages autotests FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7883/8210 (96%)CONDITIONAL 4416/8642 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8055/14179 (57%)CONDITIONAL 4411/9259 (48%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3449/7559 (46%)CONDITIONAL 1281/4381 (29%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 330/749 (44%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 (47%)CONDITIONAL 1277/3460 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 607/839 (72%) src.ioslaves.trash FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 (62%)CONDITIONAL 402/833 (48%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 150/546 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 16/26 (62%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 332/412 (81%) src.widgets FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3640/11025 (33%)CONDITIONAL 1748/7100 (25%)
Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements
> On Feb. 5, 2017, 9:50 a.m., David Faure wrote: > > Can you also deprecate DrawFrame, then? > > Diego S. wrote: > How does stuff get deprecated in Frameworks? I don't have a lot of kde > development (or development in general) experience. I also don't have a > proper dev environment setup atm. In general, with nifty *_DEPRECATED macros. But for enums I'm not sure, so I did this, please check if what I wrote is correct: https://commits.kde.org/kio/8d9fde5daede2315a1d45052828c70f1496210a5 - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129921/#review102402 --- On Feb. 4, 2017, 9:51 p.m., Diego S. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129921/ > --- > > (Updated Feb. 4, 2017, 9:51 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio-extras > > > Description > --- > > This patch is part of https://git.reviewboard.kde.org/r/129918/ - see the > discussion on the old patch https://git.reviewboard.kde.org/r/118961/. > > Many thumbnail generators currently return ThumbCreator::DrawFrame in their > flags() function which causes a 90's style 1px "3d" border to be added to the > thumbnail image. > This causes problems when consumers of these thumbnails (like Dolphin) expect > a clean image representation of the file, without hard-coded design elements. > It also looks really bad when any resizing/scaling happens or when the > thumbnail is shown on a tooltip. Especially now that the UI has been > modernized with Breeze. > > > Diffs > - > > thumbnail/comiccreator.cpp d8f4473e1c7fa4595ad8defc406ad945d1ac38ac > thumbnail/djvucreator.cpp 1547831bfaa875a14a59659a2bebc86a2cd7c024 > thumbnail/htmlcreator.cpp 29d1902794abfa3cf8ba2ab97648e1bc2d8e7a73 > thumbnail/kritacreator.cpp 3b24bc3d2fa7b22662c25da1421cbd542d7efed6 > thumbnail/textcreator.cpp 7c0263c8e8cb4f88d1429b5714c51c2939d817f0 > > Diff: https://git.reviewboard.kde.org/r/129921/diff/ > > > Testing > --- > > Builds. > > > Thanks, > > Diego S. > >
