[Differential] [Request, 64 lines] D4658: [KWidgetsAddons] Fix APIDOX issues raised by clang's -Wdocumentation

cfeck created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY As found by Kevin Funk. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4658 AFFECTED FILES src/kcapacitybar.h src/kcolorcombo.h src/kdatecombobox.h src/kd

[Differential] [Updated] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks Cc: graesslin

[Differential] [Updated, 43 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated the test plan for this revision. flherne updated this revision to Diff 11471. flherne added a comment. Update the commits / docstrings REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11439&id=11471 REVISION DETAIL https://ph

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 520 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/520/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 19:27:13 + Build duration: 3 min 21 sec CHANGE SET Revision 27b145b15509e50e7f6933046

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 520 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/520/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 19:27:13 + Build duration: 3 min 14 sec CHANGE SET Revision 27b145b15509e50e7f6933046d89b998

[Differential] [Closed] D4649: add a preview for the disk quota plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R266:27b145b15509: add a preview for the disk quota plasmoid (authored by mart). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4649?vs=11452&id=11468 REVISION DET

[Differential] [Accepted] D4649: add a preview for the disk quota plasmoid

andreaska accepted this revision. andreaska added a reviewer: andreaska. andreaska added a comment. This revision is now accepted and ready to land. thanks look good. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4649 EMAIL PREFERENCES https

[Differential] [Updated] D4649: add a preview for the disk quota plasmoid

mart added reviewers: VDG, andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4649 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #vdg, andreask Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jens

[Differential] [Request, 238 lines] D4649: add a preview for the disk quota plasmoid

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY disk quota plasmoid is in the default set in kdeplasma-addons, should have a preview REPOSI

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added inline comments. INLINE COMMENTS > kcolorscheme.h:316-318 > + * from the given KConfig. If null, the application's > KDE_COLOR_SCHEME_PATH > + * property will be used to load a KConfig. If this is also unset, the > + * system colors will be used. I wouldn't mention t

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added a comment. > That's not new, the property's been set here since at least the kdelibs split. I know, I was the one adding it :-) That's also why I think we could do that better than a property: it was intended as a way to communicate with the QStyle - the aim of the prope

[Differential] [Closed] D4646: Manager: Fix emitting deviceAdded twice when NM restarts

This revision was automatically updated to reflect the committed changes. Closed by commit R282:a183e1f346a4: Manager: Fix emitting deviceAdded twice when NM restarts (authored by drosca). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4646?vs=11444&i

[Differential] [Accepted] D4646: Manager: Fix emitting deviceAdded twice when NM restarts

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good. Thanks. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D4646 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Request, 62 lines] D4646: Manager: Fix emitting deviceAdded twice when NM restarts

drosca created this revision. drosca added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. TEST PLAN Restart NetworkManager -> deviceAdded only once for each device REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kd

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne added a comment. In https://phabricator.kde.org/D4637#87022, @graesslin wrote: > This is a sensible idea, though I wonder whether we should put it into something more concrete than a QProperty on the qApp. That's not new, the property's been set here

[Differential] [Updated, 26 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated this revision to Diff 11439. flherne added a comment. Tweak a comment. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11438&id=11439 REVISION DETAIL https://phabricator.kde.org/D4637 AFFECTED FILES src/kcolorscheme.cpp

[Differential] [Updated, 25 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated this revision to Diff 11438. flherne added a comment. Moved defaultConfig() out of the header in case someone includes it. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11417&id=11438 REVISION DETAIL https://phabricator.kd