[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

2017-02-19 Thread Kevin Funk
kfunk added a comment. Thanks for the investigation, Francis! \o/ REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks, graesslin Cc: kfunk, graesslin

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 565 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/565/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 02:00:06 + Build duration: 23 min CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 565 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/565/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 02:00:06 + Build duration: 23 min CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 562 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/562/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 02:00:06 + Build duration: 21 min CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 562 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/562/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 20 Feb 2017 02:00:06 + Build duration: 21 min CHANGE SET Revision

[Differential] [Abandoned] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-19 Thread Russell Greene
russellg abandoned this revision. REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, #frameworks

[Differential] [Commented On] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-19 Thread Russell Greene
russellg added a comment. Sounds good, that's good idea! REVISION DETAIL https://phabricator.kde.org/D4628 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, #frameworks

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 564 - Still Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/564/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 21:05:58 + Build duration: 9 min 19 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 561 - Still Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/561/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 21:16:13 + Build duration: 7 min 59 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 431 - Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/431/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 20:24:10 + Build duration: 20 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 252 - Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/252/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 20:36:57 + Build duration: 6 min 53 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 435 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/435/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 20:33:02 + Build duration: 5 min 56 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 435 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/435/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 20:33:02 + Build duration: 5 min 56 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Closed] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

2017-02-19 Thread Francis Herne
This revision was automatically updated to reflect the committed changes. Closed by commit R265:a3355b22954b: KColorScheme: default to application scheme if set by KColorSchemeManager (authored by flherne). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

Re: Exporting KFilePlaceEditDialog

2017-02-19 Thread Elvis Angelaccio
On Sun, Feb 19, 2017 at 6:51 PM, Albert Astals Cid wrote: > El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va > escriure: >> Hi, >> currently KFilePlaceEditDialog is not exported by kfilewidgets. As I >> understand it, it's supposed to be used only through

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 243 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/243/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 19:56:42 + Build duration: 2 min 1 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 563 - Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/563/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 19:46:43 + Build duration: 9 min 48 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 243 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/243/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 19:56:42 + Build duration: 2 min 1 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 19:33:20 + Build duration: 5 min 43 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

2017-02-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 19:33:20 + Build duration: 5 min 43 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 560 - Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/560/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 19:27:55 + Build duration: 8 min 2 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 521 - Still Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/521/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 18:41:18 + Build duration: 3 min 4 sec CHANGE SET No changes JUNIT RESULTS

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread Martin Gräßlin
Am 19. Februar 2017 18:00:07 MEZ schrieb David Faure : >On dimanche 19 février 2017 12:51:39 CET Martin Gräßlin wrote: >> Am 19. Februar 2017 11:21:18 MEZ schrieb David Faure : >> >Result: the test app shows the keypress events for Ctrl and Alt >> >(obviously), >>

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 521 - Still Unstable!

2017-02-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/521/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 19 Feb 2017 18:38:26 + Build duration: 19 min CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Closed] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-19 Thread John Salatas
This revision was automatically updated to reflect the committed changes. Closed by commit R39:1858d6fafb58: Consistent conversion from/to cursor to/from coordinates (authored by jsalatas). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4538?vs=11494=11507

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure
On dimanche 19 février 2017 18:23:02 CET René J.V. Bertin wrote: > You can define application-specific shortcuts in kglobalaccel, and its name > indicates (to me at least) that this is exactly what that framework + > daemon is about. No, kGLOBALaccel is about GLOBAL shortcuts. Where global means

Re: Exporting KFilePlaceEditDialog

2017-02-19 Thread Albert Astals Cid
El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va escriure: > Hi, > currently KFilePlaceEditDialog is not exported by kfilewidgets. As I > understand it, it's supposed to be used only through KFilePlacesView > (that's what gwenview and konqueror do). > > However, Dolphin

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread René J . V . Bertin
On Sunday February 19 2017 18:03:05 David Faure wrote: > Standard actions and shortcuts have nothing to do with global shortcuts, I > think you're confusing the two. Nope :) > > Standard actions and shortcuts are like Ctrl+C, Ctrl+V (and indeed F2 for > rename), they are handled in-process by

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure
On dimanche 19 février 2017 12:17:29 CET René J.V. Bertin wrote: > On Sunday February 19 2017 11:21:18 David Faure wrote: > > KStandardAction::renameFile(), with default shortcut F2, already exists. > > Apparently the naming is a bit too file-manager oriented, but this is the > > standard rename

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure
On dimanche 19 février 2017 12:51:39 CET Martin Gräßlin wrote: > Am 19. Februar 2017 11:21:18 MEZ schrieb David Faure : > >Result: the test app shows the keypress events for Ctrl and Alt > >(obviously), > >it does not show the keypress for K (good, this matches my > >expectation), >

[Differential] [Accepted] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

2017-02-19 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks, graesslin Cc:

[Differential] [Accepted] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-19 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for extending the test case + trying the KDevelop navigation! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES

[Differential] [Closed] D4190: Update file type on save only if path changes

2017-02-19 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:051d09bce3a7: Update file type on save only if path changes (authored by mperttunen, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4537: EditorConfig support

2017-02-19 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f9f133b6ac72: EditorConfig support (authored by gszymaszek, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11486=11499 REVISION

Exporting KFilePlaceEditDialog

2017-02-19 Thread Elvis Angelaccio
Hi, currently KFilePlaceEditDialog is not exported by kfilewidgets. As I understand it, it's supposed to be used only through KFilePlacesView (that's what gwenview and konqueror do). However, Dolphin is using its own implementation of KFilePlacesModel/KFilePlacesView. This is why Dolphin has its

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread René J . V . Bertin
On Sunday February 19 2017 11:21:18 David Faure wrote: > KStandardAction::renameFile(), with default shortcut F2, already exists. > Apparently the naming is a bit too file-manager oriented, but this is the > standard rename action. Indeed, I noticed it after hitting send. It's new in KF5

Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure
On dimanche 19 février 2017 10:33:31 CET René J.V. Bertin wrote: > Hello, > > A while back I ran into a situation where a custom shortcut (F2 for lowering > the window having focus) also triggered a rename action in KDevelop: > https://phabricator.kde.org/D1523 > > The idea came up on that

KStandardAction::rename ?

2017-02-19 Thread René J . V . Bertin
Hello, A while back I ran into a situation where a custom shortcut (F2 for lowering the window having focus) also triggered a rename action in KDevelop: https://phabricator.kde.org/D1523 The idea came up on that ticket to provide a central definition for shortcuts like that, e.g.