date:20170219

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

2017-02-19 Thread Kevin Funk

kfunk added a comment.


  Thanks for the investigation, Francis! \o/

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D4637

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #frameworks, graesslin
Cc: kfunk, graesslin

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 565 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/565/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 02:00:06 +
Build duration: 23 min

CHANGE SET
Revision 3b6c8b50ff1fcc8a0b00d4af89ee9860f247185a by John Salatas: 
(vimode_completion unit test failure)
  change: edit src/view/kateviewinternal.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 
66 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 33177/49261 
(67%)CONDITIONAL 16816/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1528/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 565 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/565/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 02:00:06 +
Build duration: 23 min

CHANGE SET
Revision 3b6c8b50ff1fcc8a0b00d4af89ee9860f247185a by John Salatas: 
(vimode_completion unit test failure)
  change: edit src/view/kateviewinternal.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 
66 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 33177/49261 
(67%)CONDITIONAL 16816/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1528/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 562 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/562/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 02:00:06 +
Build duration: 21 min

CHANGE SET
Revision 3b6c8b50ff1fcc8a0b00d4af89ee9860f247185a by John Salatas: 
(vimode_completion unit test failure)
  change: edit src/view/kateviewinternal.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 
66 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 33177/49261 
(67%)CONDITIONAL 16816/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1528/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 562 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/562/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 02:00:06 +
Build duration: 21 min

CHANGE SET
Revision 3b6c8b50ff1fcc8a0b00d4af89ee9860f247185a by John Salatas: 
(vimode_completion unit test failure)
  change: edit src/view/kateviewinternal.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 
66 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 33177/49261 
(67%)CONDITIONAL 16816/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1528/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

[Differential] [Abandoned] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-19 Thread Russell Greene

russellg abandoned this revision.

REVISION DETAIL
  https://phabricator.kde.org/D4628

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, #frameworks

[Differential] [Commented On] D4628: Add ability to disable saving in `KTextEditor::Document`

2017-02-19 Thread Russell Greene

russellg added a comment.


  Sounds good, that's good idea!

REVISION DETAIL
  https://phabricator.kde.org/D4628

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: russellg, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, #frameworks

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 564 - Still Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/564/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 21:05:58 +
Build duration: 9 min 19 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 
66 test(s)Failed: TestSuite.vimode_completion

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 32994/49261 
(67%)CONDITIONAL 16744/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5342/5569 
(96%)CONDITIONAL 824/1658 (50%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1529/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 561 - Still Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/561/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 21:16:13 +
Build duration: 7 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 
66 test(s)Failed: TestSuite.vimode_completion

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 32994/49261 
(67%)CONDITIONAL 16743/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5342/5569 
(96%)CONDITIONAL 824/1658 (50%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1528/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 431 - Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/431/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 20:24:10 +
Build duration: 20 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
53 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 272/341 (80%)CLASSES 272/341 (80%)LINE 29683/51574 
(58%)CONDITIONAL 16301/38721 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7883/8205 
(96%)CONDITIONAL 4414/8638 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8057/14178 
(57%)CONDITIONAL 4415/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3451/7559 
(46%)CONDITIONAL 1281/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1758/3780 
(47%)CONDITIONAL 1268/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 715/1139 
(63%)CONDITIONAL 411/833 (49%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3632/11025 
(33%)CONDITIONAL 1747/7100 (25%)

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 252 - Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/252/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 20:36:57 +
Build duration: 6 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
40 test(s)Failed: TestSuite.kglobalsettingstest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21685/42749 
(51%)CONDITIONAL 14662/36439 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11531/11783 
(98%)CONDITIONAL 8484/16824 (50%)
src.kdecore
FILES 74/93 (80%)CLASSES 74/93 (80%)LINE 9199/16821 
(55%)CONDITIONAL 5715/11771 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 435 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/435/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 20:33:02 +
Build duration: 5 min 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 273/342 (80%)CLASSES 273/342 (80%)LINE 29726/51609 
(58%)CONDITIONAL 16320/38743 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7918/8240 
(96%)CONDITIONAL 4426/8660 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8061/14178 
(57%)CONDITIONAL 4420/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3449/7559 
(46%)CONDITIONAL 1282/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 
(47%)CONDITIONAL 1277/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3640/11025 
(33%)CONDITIONAL 1748/7100 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 435 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/435/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 20:33:02 +
Build duration: 5 min 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 273/342 (80%)CLASSES 273/342 (80%)LINE 29726/51609 
(58%)CONDITIONAL 16320/38743 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7918/8240 
(96%)CONDITIONAL 4426/8660 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8061/14178 
(57%)CONDITIONAL 4420/9259 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3449/7559 
(46%)CONDITIONAL 1282/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1766/3780 
(47%)CONDITIONAL 1277/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 705/1139 
(62%)CONDITIONAL 402/833 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3640/11025 
(33%)CONDITIONAL 1748/7100 (25%)

[Differential] [Closed] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

2017-02-19 Thread Francis Herne

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:a3355b22954b: KColorScheme: default to application scheme 
if set by KColorSchemeManager (authored by flherne).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4637?vs=11471=11508

REVISION DETAIL
  https://phabricator.kde.org/D4637

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #frameworks, graesslin
Cc: graesslin

Re: Exporting KFilePlaceEditDialog

2017-02-19 Thread Elvis Angelaccio

On Sun, Feb 19, 2017 at 6:51 PM, Albert Astals Cid  wrote:
> El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va
> escriure:
>> Hi,
>> currently KFilePlaceEditDialog is not exported by kfilewidgets. As I
>> understand it, it's supposed to be used only through KFilePlacesView
>> (that's what gwenview and konqueror do).
>>
>> However, Dolphin is using its own implementation of
>> KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own
>> dialog to edit places, which is exactly the same as
>> KFilePlaceEditDialog but with more bugs, e.g. see [1].
>>
>> Could we make KFilePlaceEditDialog a public class? I don't really see
>> downsides in doing this. We reduce code duplication (by killing the
>> buggy Dolphin dialog) and Dolphin can still use its own model/view
>> places stuff (I tested it localy and seems to work).
>
> The other option is improving KFilePlacesModel/KFilePlacesView so that Dolphin
> can use it.
>
> Without knowing about them (which i don't) can't say what's better.
>
> Do you know what is stopping Dolphin using KFilePlacesModel/KFilePlacesView ?

The timeline:/ and search:/ urls mostly. There is also a grouping
feature but I'm not sure how that works.
Though I agree that in the long-term it would be better to improve the
upstream KFilePlacesModel/View...

>
> Cheers,
>   Albert
>
>>
>> Cheers,
>> Elvis
>>
>> [1]: https://bugs.kde.org/show_bug.cgi?id=376619
>
>

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 243 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/243/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 19:56:42 +
Build duration: 2 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5486/8010 
(68%)CONDITIONAL 2978/6230 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 
(94%)CONDITIONAL 890/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1768/3046 
(58%)CONDITIONAL 767/1904 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1236/2106 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 563 - Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/563/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 19:46:43 +
Build duration: 9 min 48 sec

CHANGE SET
Revision 1858d6fafb580c3fc5a53cdd0bf02a227fefd667 by John Salatas: (Consistent 
conversion from/to cursor to/from coordinates)
  change: edit src/view/kateview.cpp
  change: edit src/view/kateviewinternal.cpp
  change: edit autotests/src/kateview_test.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 
66 test(s)Failed: TestSuite.vimode_completion

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 32994/49261 
(67%)CONDITIONAL 16743/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5342/5569 
(96%)CONDITIONAL 824/1658 (50%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1532/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1529/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 243 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/243/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 19:56:42 +
Build duration: 2 min 1 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5486/8010 
(68%)CONDITIONAL 2978/6230 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1465/1555 
(94%)CONDITIONAL 890/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1768/3046 
(58%)CONDITIONAL 767/1904 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1236/2106 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 19:33:20 +
Build duration: 5 min 43 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5486/8010 
(68%)CONDITIONAL 2988/6230 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1467/1555 
(94%)CONDITIONAL 900/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 
(58%)CONDITIONAL 766/1904 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1237/2106 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 19:33:20 +
Build duration: 5 min 43 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 76/85 (89%)CLASSES 76/85 (89%)LINE 5486/8010 
(68%)CONDITIONAL 2988/6230 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1467/1555 
(94%)CONDITIONAL 900/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 30/31 (97%)CLASSES 30/31 (97%)LINE 1766/3046 
(58%)CONDITIONAL 766/1904 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1237/2106 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 560 - Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/560/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 19:27:55 +
Build duration: 8 min 2 sec

CHANGE SET
Revision 1858d6fafb580c3fc5a53cdd0bf02a227fefd667 by John Salatas: (Consistent 
conversion from/to cursor to/from coordinates)
  change: edit autotests/src/kateview_test.cpp
  change: edit src/view/kateview.cpp
  change: edit src/view/kateviewinternal.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 
66 test(s)Failed: TestSuite.vimode_completion

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 23/27 (85%)FILES 293/329 (89%)CLASSES 293/329 (89%)LINE 32994/49261 
(67%)CONDITIONAL 16744/32827 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4165/4478 
(93%)CONDITIONAL 1969/4000 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5342/5569 
(96%)CONDITIONAL 824/1658 (50%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1818/3216 
(57%)CONDITIONAL 1533/3238 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 165/427 (39%)CONDITIONAL 
99/265 (37%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1620/2077 
(78%)CONDITIONAL 1037/1708 (61%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3415/6298 
(54%)CONDITIONAL 1529/3795 (40%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 521 - Still Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/521/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 18:41:18 +
Build duration: 3 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 225/274 
(82%)CONDITIONAL 128/218 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 183/217 (84%)CONDITIONAL 
114/192 (59%)

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread Martin Gräßlin



Am 19. Februar 2017 18:00:07 MEZ schrieb David Faure :
>On dimanche 19 février 2017 12:51:39 CET Martin Gräßlin wrote:
>> Am 19. Februar 2017 11:21:18 MEZ schrieb David Faure :
>> >Result: the test app shows the keypress events for Ctrl and Alt
>> >(obviously),
>> >it does not show the keypress for K (good, this matches my
>> >expectation),
>> >BUT when I release K, the app receives a key *RELEASE* event for
>Key_K.
>> >
>> >Martin, is this a bug and is it fixable?
>> 
>> That is not a bug and is the expected and correct behavior. 
>
>Can you elaborate why this is expected? If I press a workspace-wide
>global 
>shortcut like Alt+F2 or Ctrl+Alt+K, then I intend for that to go to the
>
>workspace, not to the window with focus. The fact that this window does
>not 
>receive a keypress but receives a keyrelease for that key seems very 
>inconsistent and unexpected to me.

That is how X works *shrug*. It is quite normal that applications can get key 
release events for keys they did not get a press for.

Press a key then switch focus using the mouse and release the key. Same thing.

Also on Wayland quite normal. Except that the protocol informs which keys are 
currently pressed. But iirc Qt (rightly) ignores that information.

The application is at fault if it acts on a release without a press.

>
>> Also the window gets a focus out and focus on event.
>
>OK but that doesn't prevent processing the key release event.

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 521 - Still Unstable!

2017-02-19 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/521/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Feb 2017 18:38:26 +
Build duration: 19 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 225/274 
(82%)CONDITIONAL 128/218 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 183/217 (84%)CONDITIONAL 
114/192 (59%)

[Differential] [Closed] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-19 Thread John Salatas

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:1858d6fafb58: Consistent conversion from/to cursor to/from 
coordinates (authored by jsalatas).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4538?vs=11494=11507

REVISION DETAIL
  https://phabricator.kde.org/D4538

AFFECTED FILES
  autotests/src/kateview_test.cpp
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma, #ktexteditor, cullmann
Cc: brauch, cullmann, plasma-devel, kwrite-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure

On dimanche 19 février 2017 18:23:02 CET René J.V. Bertin wrote:
> You can define application-specific shortcuts in kglobalaccel, and its name
> indicates (to me at least) that this is exactly what that framework +
> daemon is about. 

No, kGLOBALaccel is about GLOBAL shortcuts.
Where global means workspace-wide, i.e. independently from which app/window 
has focus.
There is no need for a daemon for application shortcuts, standard or not.

> Not sure how, but apparently the kglobalaccel daemon has
> the possibility to send specific applications specific events in reaction
> to customisable keystrokes. 

Apps register a global shortcut and get notified by kglobalaccel.

> KWin shortcuts are defined through the
> Shortcuts KCM ("Shortcuts and Gestures" in KDE4), not in KWin's own
> configuration dialogs.

Yes.

Global != standard, I'm 500% sure of the above.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Exporting KFilePlaceEditDialog

2017-02-19 Thread Albert Astals Cid

El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va 
escriure:
> Hi,
> currently KFilePlaceEditDialog is not exported by kfilewidgets. As I
> understand it, it's supposed to be used only through KFilePlacesView
> (that's what gwenview and konqueror do).
> 
> However, Dolphin is using its own implementation of
> KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own
> dialog to edit places, which is exactly the same as
> KFilePlaceEditDialog but with more bugs, e.g. see [1].
> 
> Could we make KFilePlaceEditDialog a public class? I don't really see
> downsides in doing this. We reduce code duplication (by killing the
> buggy Dolphin dialog) and Dolphin can still use its own model/view
> places stuff (I tested it localy and seems to work).

The other option is improving KFilePlacesModel/KFilePlacesView so that Dolphin 
can use it. 

Without knowing about them (which i don't) can't say what's better.

Do you know what is stopping Dolphin using KFilePlacesModel/KFilePlacesView ?

Cheers,
  Albert

> 
> Cheers,
> Elvis
> 
> [1]: https://bugs.kde.org/show_bug.cgi?id=376619

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread René J . V . Bertin

On Sunday February 19 2017 18:03:05 David Faure wrote:

> Standard actions and shortcuts have nothing to do with global shortcuts, I 
> think you're confusing the two.

Nope :)
> 
> Standard actions and shortcuts are like Ctrl+C, Ctrl+V (and indeed F2 for 
> rename), they are handled in-process by each application who wants to support 
> them. So it's quite logical that you won't find that in kglobalaccel,
> which is about workspace-wide global shortcuts like Alt+F2 (krunner),
> mixer volume up/down, etc.

You can define application-specific shortcuts in kglobalaccel, and its name 
indicates (to me at least) that this is exactly what that framework + daemon is 
about. Not sure how, but apparently the kglobalaccel daemon has the possibility 
to send specific applications specific events in reaction to customisable 
keystrokes.
KWin shortcuts are defined through the Shortcuts KCM ("Shortcuts and Gestures" 
in KDE4), not in KWin's own configuration dialogs.

> > Any shortcut for raising or lowering windows would be a good example too.
> 
> This probably has focus-related side effects, making this more complex.

Possible, but in practice focus doesn't change when you raise (duh ;)) or even 
lower a window with the keyboard, i.e. without generating mouse events.

> The fact that this window does not
> receive a keypress but receives a keyrelease for that key seems very
> inconsistent and unexpected to me.

To me too. If it's supposed to receive a keyrelease it should also receive the 
corresponding keypress, I'd say. I can only see focus changes as a 
justification for receiving a keyrelease without keypress or vice-versa.

R

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure

On dimanche 19 février 2017 12:17:29 CET René J.V. Bertin wrote:
> On Sunday February 19 2017 11:21:18 David Faure wrote:
> > KStandardAction::renameFile(), with default shortcut F2, already exists.
> > Apparently the naming is a bit too file-manager oriented, but this is the
> > standard rename action.
> 
> Indeed, I noticed it after hitting send. It's new in KF5 though, at least
> I'm not seeing it in the kglobalaccel4 config pages. CC Milian.

Standard actions and shortcuts have nothing to do with global shortcuts, I 
think you're confusing the two.

Standard actions and shortcuts are like Ctrl+C, Ctrl+V (and indeed F2 for 
rename), they are handled in-process by each application who wants to support 
them. So it's quite logical that you won't find that in kglobalaccel,
which is about workspace-wide global shortcuts like Alt+F2 (krunner),
mixer volume up/down, etc.

> > I ran the test application attached, then typed Ctrl+Alt+K (global
> > shortcut
> > for changing the keyboard layout) (this is a better example than Alt+F2 to
> > pop up krunner because that steals focus anyway).
> 
> Any shortcut for raising or lowering windows would be a good example too.

This probably has focus-related side effects, making this more complex.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure

On dimanche 19 février 2017 12:51:39 CET Martin Gräßlin wrote:
> Am 19. Februar 2017 11:21:18 MEZ schrieb David Faure :
> >Result: the test app shows the keypress events for Ctrl and Alt
> >(obviously),
> >it does not show the keypress for K (good, this matches my
> >expectation),
> >BUT when I release K, the app receives a key *RELEASE* event for Key_K.
> >
> >Martin, is this a bug and is it fixable?
> 
> That is not a bug and is the expected and correct behavior. 

Can you elaborate why this is expected? If I press a workspace-wide global 
shortcut like Alt+F2 or Ctrl+Alt+K, then I intend for that to go to the 
workspace, not to the window with focus. The fact that this window does not 
receive a keypress but receives a keyrelease for that key seems very 
inconsistent and unexpected to me.

> Also the window gets a focus out and focus on event.

OK but that doesn't prevent processing the key release event.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

[Differential] [Accepted] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

2017-02-19 Thread Martin Gräßlin

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D4637

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #frameworks, graesslin
Cc: graesslin

[Differential] [Accepted] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-19 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for extending the test case + trying the KDevelop navigation!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma, #ktexteditor, cullmann
Cc: brauch, cullmann, plasma-devel, kwrite-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Closed] D4190: Update file type on save only if path changes

2017-02-19 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:051d09bce3a7: Update file type on save only if path 
changes (authored by mperttunen, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4190?vs=10504=11500

REVISION DETAIL
  https://phabricator.kde.org/D4190

AFFECTED FILES
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mperttunen, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, #frameworks

[Differential] [Closed] D4537: EditorConfig support

2017-02-19 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f9f133b6ac72: EditorConfig support (authored by 
gszymaszek, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11486=11499

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, cullmann, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

Exporting KFilePlaceEditDialog

2017-02-19 Thread Elvis Angelaccio

Hi,
currently KFilePlaceEditDialog is not exported by kfilewidgets. As I
understand it, it's supposed to be used only through KFilePlacesView
(that's what gwenview and konqueror do).

However, Dolphin is using its own implementation of
KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own
dialog to edit places, which is exactly the same as
KFilePlaceEditDialog but with more bugs, e.g. see [1].

Could we make KFilePlaceEditDialog a public class? I don't really see
downsides in doing this. We reduce code duplication (by killing the
buggy Dolphin dialog) and Dolphin can still use its own model/view
places stuff (I tested it localy and seems to work).

Cheers,
Elvis

[1]: https://bugs.kde.org/show_bug.cgi?id=376619

Re: Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread René J . V . Bertin

On Sunday February 19 2017 11:21:18 David Faure wrote:

> KStandardAction::renameFile(), with default shortcut F2, already exists.
> Apparently the naming is a bit too file-manager oriented, but this is the 
> standard rename action. 

Indeed, I noticed it after hitting send. It's new in KF5 though, at least I'm 
not seeing it in the kglobalaccel4 config pages.
CC Milian.

> I ran the test application attached, then typed Ctrl+Alt+K (global shortcut 
> for changing the keyboard layout) (this is a better example than Alt+F2 to 
> pop 
> up krunner because that steals focus anyway).

Any shortcut for raising or lowering windows would be a good example too.

> Result: the test app shows the keypress events for Ctrl and Alt (obviously),
> it does not show the keypress for K (good, this matches my expectation),
> BUT when I release K, the app receives a key *RELEASE* event for Key_K.

IIRC that's exactly what I'm seeing. I presume this is because shortcuts are 
typically handled at KeyPress, not KeyRelease. There are situations where that 
practice is debatable but most of the time it's what you'd expect, and if 
shortcuts are handled at KeyPress only the propagated KeyRelease "echo event" 
shouldn't trigger anything in the application having the focus window. Right?

I'll check KDevelop for handling KeyRelease events (if Milian doesn't beat me 
to it).

R.

Global shortcuts should not send keyrelease event to app with focus (Re: KStandardAction::rename ?)

2017-02-19 Thread David Faure

On dimanche 19 février 2017 10:33:31 CET René J.V. Bertin wrote:
> Hello,
> 
> A while back I ran into a situation where a custom shortcut (F2 for lowering
> the window having focus) also triggered a rename action in KDevelop:
> https://phabricator.kde.org/D1523
> 
> The idea came up on that ticket to provide a central definition for
> shortcuts like that, e.g. KStandardAction::rename . Has such an idea ever
> be considered?

KStandardAction::renameFile(), with default shortcut F2, already exists.
Apparently the naming is a bit too file-manager oriented, but this is the 
standard rename action. This is however totally unrelated to the "also 
triggers" problem you're mentioning. Retitling ;)

> The underlying issue here is probably that the custom KWin shortcut is
> defined through kglobalaccel (on a Plasma4 desktop) and that the keystroke
> isn't eaten but propagated to the (KF5) application having focus. Shouldn't
> it be configurable whether a custom keystroke is propagated or not?

I don't see why this should be "configurable".

I would expect global shortcuts to never propagate to the window with focus.

Let's test.
I ran the test application attached, then typed Ctrl+Alt+K (global shortcut 
for changing the keyboard layout) (this is a better example than Alt+F2 to pop 
up krunner because that steals focus anyway).

Result: the test app shows the keypress events for Ctrl and Alt (obviously),
it does not show the keypress for K (good, this matches my expectation),
BUT when I release K, the app receives a key *RELEASE* event for Key_K.

Martin, is this a bug and is it fixable?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
#include 
#include 
#include 
#include 

class MyPushButton : public QPushButton
{
public:
MyPushButton() : QPushButton(0) {
}
protected:
virtual void keyPressEvent(QKeyEvent* ev)
{
updateText(ev->key(), true);
}
virtual void keyReleaseEvent(QKeyEvent* ev)
{
updateText(ev->key(), false);
}
private:
void updateText(int key, bool press)
{
setText((press ? "PRESS " : "RELEASE " ) + QString::number(key) + " modifiers: 0x" + QString::number(QApplication::keyboardModifiers(), 16));
}
};

int main(int argc, char** argv )
{
QApplication app(argc, argv);

MyPushButton* button = new MyPushButton;
button->resize(300, 120);
button->show();

return app.exec();
}

KStandardAction::rename ?

2017-02-19 Thread René J . V . Bertin

Hello,

A while back I ran into a situation where a custom shortcut (F2 for lowering 
the window having focus) also triggered a rename action in KDevelop: 
https://phabricator.kde.org/D1523

The idea came up on that ticket to provide a central definition for shortcuts 
like that, e.g. KStandardAction::rename . Has such an idea ever be considered?

The underlying issue here is probably that the custom KWin shortcut is defined 
through kglobalaccel (on a Plasma4 desktop) and that the keystroke isn't eaten 
but propagated to the (KF5) application having focus. Shouldn't it be 
configurable whether a custom keystroke is propagated or not?

R

38 matches

Mail list logo