[Differential] [Request, 74 lines] D4733: Port to categorized logging and clean includes
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
Convert all occurrencies of q{Debug,Warning,Critical,...},
including the calls commented.
Cleanup for non-required includes of QDebug, and few extra comments.
TEST PLAN
Compiles
REPOSITORY
R238 KDocTools
BRANCH
categorized-logging
REVISION DETAIL
https://phabricator.kde.org/D4733
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
src/checkXML5.cpp
src/docbookl10nhelper.cpp
src/meinproc.cpp
src/meinproc_common.h
src/xslt.cpp
src/xslt_kde.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ltoscano
Cc: #frameworks, #documentation
[Differential] [Request, 2 lines] D4729: Fix disabling the spinner animation when Busy indicator has no opacity
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Unlike the visible property, the opacity does not inherit parent values
and refers to the relative opacity of that item.
The current style code is checking that an item we can't control
externally has an opacity > 0, this doesn't really acheive anything.
This was a breakage from when we ported *to* QtQuickControls 1.
TEST PLAN
I was running a plasmoid I had written years ago (my RSS tutorial)
and had abnormally high CPU usage in an animation that I didn't have then.
Code was:
BusyIndicator {
opacity: 0
running: true
}
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4729
AFFECTED FILES
src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4711: Ungrab mouse on menu close
mvourlakos added a comment. I just noticed... you dont have to go too far... any qt application using 5.8 has this problem... even qtcreator... showing a menu and then deactivating it from outside areas then the window needs a click from the user in order for this window to react properly REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, broulik, mart Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4711: Ungrab mouse on menu close
mvourlakos added a comment. You can observe the faulty behavior even with Qt's "Menu's Example". 1. Open any menu you want either with right click or from the menu 2. Close it by clicking in any outside area you want, that is (not inside the menu example window and not in the menu) 3. Observe that you can not even hover at the menus on top. For the window to work as expected someone must click first in the example window. at (3) the menu example window should work as normal... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, broulik, mart Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Abandoned] D4727: Avoid excessive debugging output for "Loaded URL="
kfunk abandoned this revision. kfunk added a comment. Okay, please do. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ltoscano Cc: #frameworks, #documentation
[Differential] [Requested Changes] D4727: Avoid excessive debugging output for "Loaded URL="
ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. I will work on switching to categorized logging (with logs like that hidden by defaults) REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ltoscano Cc: #frameworks, #documentation
[Differential] [Updated] D4727: Avoid excessive debugging output for "Loaded URL="
kfunk added a reviewer: ltoscano. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ltoscano Cc: #frameworks, #documentation
[Differential] [Updated] D4727: Avoid excessive debugging output for "Loaded URL="
kfunk added a reviewer: Frameworks. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4727 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks Cc: #frameworks, #documentation
[Differential] [Request, 4 lines] D4727: Avoid excessive debugging output for "Loaded URL="
kfunk created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D4727 AFFECTED FILES src/xslt.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk Cc: #frameworks, #documentation
[Differential] [Commented On] D4711: Ungrab mouse on menu close
anthonyfieroni added a comment. I'm not pretty sure, but https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#374 on click at other window we have enter && mouseGrabber REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, broulik, mart Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4711: Ungrab mouse on menu close
mvourlakos added a comment. In https://phabricator.kde.org/D4711#88621, @mart wrote: > do you know exactly what/where changed? sorry if this is irrelevant... I dont know if the above code works but in my code tree in latte dock I can not do anything to ungrabMouse in Qt 5.8 in case the user closes the menu by deactivating it with a click at the outside area (that is not the window area or the menu one)... I have filed a bug at: https://bugreports.qt.io/browse/QTBUG-59044 I thought that this might be relevant to my qt bug report... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, broulik, mart Cc: mvourlakos, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated] D4711: Ungrab mouse on menu close
mart added a comment. do you know exactly what/where changed? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, broulik, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4556: Ref/deref DataEngines even if the metadata is invalid
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4556 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4689: IconItem: Add roundToIconSize property
drosca added a comment. > they may end up looking a bit blurry They are SVGs in Breeze, so they won't look blurry, with other icon themes it may be an issue. But then again, the same issue is already there when you request big icon (for which roundToIconSize() returns the passed size ~ >128 pixels REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4679: [ConfigView] Honor KIOSK Control Module restrictions
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4679 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4689: IconItem: Add roundToIconSize property
mart added a comment. In https://phabricator.kde.org/D4689#88209, @drosca wrote: > Yes, I want to use it in plasma-pa applet for volume indicator icons (the small icon next to slider). Currently, they are too small but next round icon size is already too big. This change will make it possible to make them just few pixels bigger. can you post a screenshot on how they would look? they may end up looking a bit blurry REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 178 lines] D4707: move setImagePath logic into updateFrameData()
mart updated this revision to Diff 11632. mart added a comment. - more guards on null frame REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4707?vs=11627=11632 BRANCH arcpatch-D4707 REVISION DETAIL https://phabricator.kde.org/D4707 AFFECTED FILES src/plasma/framesvg.cpp src/plasma/private/framesvg_p.h src/plasma/svg.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Closed] D4658: [KWidgetsAddons] Fix APIDOX issues raised by clang's -Wdocumentation
This revision was automatically updated to reflect the committed changes. Closed by commit R236:8e360714a46a: Fix APIDOX issues raised by clang's -Wdocumentation (authored by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4658?vs=11476=11631#toc REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4658?vs=11476=11631 REVISION DETAIL https://phabricator.kde.org/D4658 AFFECTED FILES src/kcapacitybar.h src/kcolorcombo.h src/kdatecombobox.h src/kdatetimeedit.h src/kled.h src/kmimetypeeditor.h src/kpagedialog.h src/kpagewidget.h src/kpagewidgetmodel.h src/kpixmapsequence.h src/ksplittercollapserbutton.h src/ksqueezedtextlabel.h src/kstandardguiitem.h src/ktimecombobox.h src/ktitlewidget.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cfeck, #frameworks, aacid Cc: aacid
[Differential] [Updated, 2,989 lines] D4508: Plasma controls based on QtQuickControls2
mart updated this revision to Diff 11630. mart marked 2 inline comments as done. mart added a comment. updated with https://phabricator.kde.org/D4522 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11082=11630 BRANCH mart/qqc2style REVISION DETAIL https://phabricator.kde.org/D4508 AFFECTED FILES src/declarativeimports/CMakeLists.txt src/declarativeimports/plasmacomponents3/BusyIndicator.qml src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/CheckBox.qml src/declarativeimports/plasmacomponents3/CheckDelegate.qml src/declarativeimports/plasmacomponents3/CheckIndicator.qml src/declarativeimports/plasmacomponents3/ComboBox.qml src/declarativeimports/plasmacomponents3/Container.qml src/declarativeimports/plasmacomponents3/Control.qml src/declarativeimports/plasmacomponents3/Dial.qml src/declarativeimports/plasmacomponents3/Dialog.qml src/declarativeimports/plasmacomponents3/DialogButtonBox.qml src/declarativeimports/plasmacomponents3/Drawer.qml src/declarativeimports/plasmacomponents3/Frame.qml src/declarativeimports/plasmacomponents3/GroupBox.qml src/declarativeimports/plasmacomponents3/ItemDelegate.qml src/declarativeimports/plasmacomponents3/Label.qml src/declarativeimports/plasmacomponents3/Menu.qml src/declarativeimports/plasmacomponents3/MenuItem.qml src/declarativeimports/plasmacomponents3/Popup.qml src/declarativeimports/plasmacomponents3/ProgressBar.qml src/declarativeimports/plasmacomponents3/RadioButton.qml src/declarativeimports/plasmacomponents3/RadioDelegate.qml src/declarativeimports/plasmacomponents3/RadioIndicator.qml src/declarativeimports/plasmacomponents3/RangeSlider.qml src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/Slider.qml src/declarativeimports/plasmacomponents3/SpinBox.qml src/declarativeimports/plasmacomponents3/Switch.qml src/declarativeimports/plasmacomponents3/SwitchDelegate.qml src/declarativeimports/plasmacomponents3/SwitchIndicator.qml src/declarativeimports/plasmacomponents3/TabBar.qml src/declarativeimports/plasmacomponents3/TabButton.qml src/declarativeimports/plasmacomponents3/TextArea.qml src/declarativeimports/plasmacomponents3/TextField.qml src/declarativeimports/plasmacomponents3/ToolBar.qml src/declarativeimports/plasmacomponents3/ToolButton.qml src/declarativeimports/plasmacomponents3/ToolTip.qml src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml src/declarativeimports/plasmacomponents3/private/RoundShadow.qml src/declarativeimports/plasmacomponents3/private/TextFieldFocus.qml src/declarativeimports/plasmacomponents3/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated] D4508: Plasma controls based on QtQuickControls2
mart retitled this revision from "[WIP] Plasma controls based on QtQuickControls2" to "Plasma controls based on QtQuickControls2". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Closed] D4522: export implicitheight from background
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0fd0389f02b3: export implicitheight from background (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4522?vs=11108=11629 REVISION DETAIL https://phabricator.kde.org/D4522 AFFECTED FILES src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/CheckIndicator.qml src/declarativeimports/plasmacomponents3/ToolButton.qml src/declarativeimports/plasmacomponents3/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson Cc: #frameworks
[Differential] [Updated] D4707: move setImagePath logic into updateFrameData()
mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 170 lines] D4707: move setImagePath logic into updateFrameData()
mart updated this revision to Diff 11627. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. remove useless variable REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4707?vs=11593=11627 BRANCH arcpatch-D4707 REVISION DETAIL https://phabricator.kde.org/D4707 AFFECTED FILES src/plasma/framesvg.cpp src/plasma/private/framesvg_p.h src/plasma/svg.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4658: [KWidgetsAddons] Fix APIDOX issues raised by clang's -Wdocumentation
cfeck added inline comments. INLINE COMMENTS > aacid wrote in kpagewidget.h:143 > Does the other @param in this line also need to be @p ? Or even removed? You are correct. I just checked the rendering on api.kde.org, and both should just use @p, otherwise it would start a new line for the parameter description. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cfeck, #frameworks, aacid Cc: aacid
[Differential] [Requested Review] D4707: move setImagePath logic into updateFrameData()
mart requested review of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: #frameworks
[Differential] [Updated] D4707: move setImagePath logic into updateFrameData()
mart edited the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: #frameworks
[Differential] [Closed] D4713: Fix binding loop regression in FrameSVGItem
This revision was automatically updated to reflect the committed changes. Closed by commit R242:e301b636858b: Fix binding loop regression in FrameSVGItem (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4713?vs=11621=11623 REVISION DETAIL https://phabricator.kde.org/D4713 AFFECTED FILES src/plasma/framesvg.cpp src/plasma/private/framesvg_p.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, #frameworks, mart, broulik Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4713: Fix binding loop regression in FrameSVGItem
broulik accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4713 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, #frameworks, mart, broulik Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4713: Fix binding loop regression in FrameSVGItem
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4713 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, #frameworks, mart Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 17 lines] D4713: Fix binding loop regression in FrameSVGItem
davidedmundson updated this revision to Diff 11621. davidedmundson added a comment. Updated REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4713?vs=11609=11621 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4713 AFFECTED FILES src/plasma/framesvg.cpp src/plasma/private/framesvg_p.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, #frameworks, mart Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 901 lines] D4690: Import remote ioslave from plasma-workspace
elvisangelaccio updated this revision to Diff 11620. elvisangelaccio added a comment. - Removed redundant dir check - Removed unused include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4690?vs=11597=11620 BRANCH import-remote REVISION DETAIL https://phabricator.kde.org/D4690 AFFECTED FILES src/ioslaves/CMakeLists.txt src/ioslaves/remote/CMakeLists.txt src/ioslaves/remote/kdedmodule/CMakeLists.txt src/ioslaves/remote/kdedmodule/remotedirnotify.cpp src/ioslaves/remote/kdedmodule/remotedirnotify.desktop src/ioslaves/remote/kdedmodule/remotedirnotify.h src/ioslaves/remote/kdedmodule/remotedirnotifymodule.cpp src/ioslaves/remote/kdedmodule/remotedirnotifymodule.h src/ioslaves/remote/kio_remote.cpp src/ioslaves/remote/kio_remote.h src/ioslaves/remote/remote.json src/ioslaves/remote/remoteimpl.cpp src/ioslaves/remote/remoteimpl.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, davidedmundson Cc: ltoscano, #plasma, #frameworks
[Differential] [Request, 255 lines] D4716: Add some more directives to MIPS assembler highlighting
arichardson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add a few 64-bit MIPS instruction mnemonics Add c-preprocessor.xml highlighting file to be included Extracted and slightly modified from isocpp.xml Make GNU Assembler and MIPS assembler use c-preprocessor.xml This fixes highlighting of e.g. #include REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D4716 AFFECTED FILES data/syntax/c-preprocessor.xml data/syntax/gnuassembler.xml data/syntax/mips.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: arichardson, dhaumann, vkrause Cc: #frameworks
[Differential] [Requested Changes] D4713: Fix binding loop regression in FrameSVGItem
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.
i can reproduce kai's problems, luckily the fix seems easy
INLINE COMMENTS
> framesvg.cpp:757
> fd->theme = q->theme()->d;
> -updateAndSignalSizes();
> +if (updateType == UpdateFrameAndMargins) {
> +updateAndSignalSizes();
in order to restore the behavior before
https://phabricator.kde.org/R242:d8a1a9eb084b19e552c789244267f7346e1b27a8
you need to update the sizes anyways in this way (the resize event did that
anyways)
otherwise you can get a frame with uninitialized sizes
if (updateType == UpdateFrameAndMargins) {
updateAndSignalSizes();
} else {
updateSizes(fd);
}
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, #frameworks, mart
Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4713: Fix binding loop regression in FrameSVGItem
broulik added a comment. While this fixes the binding loop warnings, it doesn't fix the broken margins in places like NM list delegates. +1 nonetheless. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4713 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, #frameworks Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 129741: Add renaming capability to ioslaves
> On Jan. 2, 2017, 9:38 a.m., David Faure wrote: > > Renaming is really a special case of moving. Saying that "kio_trash doesn't > > support renaming" is correct but only a partial truth. It also doesn't > > support moving from trash:/ to trash:/subdir/. So it would be more correct > > to say that kio_trash supports moving trash-to-file and file-to-trash but > > not trash-to-trash. > > > > So it seems to me that this patch models the wrong thing, and is likely to > > give us further trouble down the line. > > > > I wonder if we could invent something more dynamic than the .protocol keys. > > An additional way to talk to a slave and ask if a specific operation (for > > specific URLs) is implemented. Something like KIO::CapabilityJob *job = > > KIO::capability(Move, url1, url2); connect; and in the slot, enable/disable > > the action accordingly. By default this would just use the information from > > the .protocol files, but in addition a new SlaveBase method (fake-virtual > > until KF6, using virtual_hook) would allow slaves to answer the query with > > more precision, depending on the actual URLs. What do you think? > > > > Of course the alternative (which is actually simpler short term) is to > > implement renaming in kio_trash ;) > > Actual renaming should be easy, moving between subdirs is a bit more tricky > > but doable too. I can take a look at that next weekend. > > Elvis Angelaccio wrote: > > Renaming is really a special case of moving. Saying that "kio_trash > doesn't support renaming" is correct but only a partial truth. It also > doesn't support moving from trash:/ to trash:/subdir/. So it would be more > correct to say that kio_trash supports moving trash-to-file and file-to-trash > but not trash-to-trash. > > Good point... > > Something like KIO::CapabilityJob *job = KIO::capability(Move, url1, > url2); connect; and in the slot, enable/disable the action accordingly. > > This would be more flexible indeed. On the other hand, it's more verbose > and low-level. Also, for the "renaming" case one needs a way to make up url2 > (url1 would just be the selected url in the dolphin view). > > Of course the alternative (which is actually simpler short term) is to > implement renaming in kio_trash ;) > > Definitely :) > All right, let's discuss this again later, waiting for news from > kio_trash. Renaming implemented in kio_trash (for toplevel entries) https://commits.kde.org/kio/20f0b84f51ff7f0767da118de79eda28af091ec9 - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129741/#review101715 --- On Jan. 1, 2017, 11:01 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129741/ > --- > > (Updated Jan. 1, 2017, 11:01 p.m.) > > > Review request for KDE Frameworks, David Faure and Emmanuel Pescosta. > > > Repository: kio > > > Description > --- > > An ioslave protocol might support moving files but not "renaming" them > (rename here means "the F2 shortcut in filemanagers"). trash:/ is a good > example. > > The new `renaming` field defaults to `moving`, so that we don't have to add > renaming=true to every protocol file out there. > > > Diffs > - > > src/core/kfileitemlistproperties.h 2b4a5b33166513493e6499e6479a04965a895b57 > src/core/kfileitemlistproperties.cpp > 5c6e6bba693f8b9bfc942ff39bee5d24f159fd7f > src/core/kprotocolinfo.cpp 0290c63b37a45a22995238f9cfcc11b8334d339c > src/core/kprotocolinfo_p.h 8d05bd194fdaa7b7e7552e0d1d22bf16b28ffbc1 > src/core/kprotocolmanager.h 13b8c0756f8e355b1ec84cdf1c44086f41fa05c5 > src/core/kprotocolmanager.cpp 9a0a96fe749a11c66a22bb3eff62d0601e3b7b36 > src/ioslaves/trash/tests/testtrash.cpp > 67a6130e7c86af00e596dc439125c29eb74fc99f > src/ioslaves/trash/trash.json d7dc03eb073c7bfdde3c7eebfbac144ad62964fe > src/protocoltojson/main.cpp 0bf3c7062d076412c779f6cae25a98e1b2c61be4 > > Diff: https://git.reviewboard.kde.org/r/129741/diff/ > > > Testing > --- > > Using the new `supportsRenaming()` api from Dolphin, F2 in Trash is now > disabled. More context in https://git.reviewboard.kde.org/r/129714 > > > Thanks, > > Elvis Angelaccio > >
