[Differential] [Request, 54 lines] D4831: Add new component for the greyed out labels in Item Delegates.

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Plasma code is full of Label {opacity: 0.6}. We shouldn't be hardcoding style into a UI, especially with magic

[Differential] [Updated] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

mgallien added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D4377 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: awilcox, mgallien Cc: #frameworks

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 522 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/522/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 17:41:52 + Build duration: 24 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 522 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/522/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 17:41:52 + Build duration: 24 min CHANGE SET Revision

[Differential] [Abandoned] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

subdiff abandoned this revision. subdiff added a comment. Not anymore relevant thanks to https://phabricator.kde.org/D4827. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4797 EMAIL PREFERENCES

[Differential] [Closed] D4827: possibility to use a fallback chain as prefix

This revision was automatically updated to reflect the committed changes. Closed by commit R242:916bcbf6c0ac: possibility to use a fallback chain as prefix (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D4827: possibility to use a fallback chain as prefix

mart abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: davidedmundson, broulik, plasma-devel,

[Differential] [Updated, 67 lines] D4827: possibility to use a fallback chain as prefix

mart updated this revision to Diff 11912. mart added a comment. - use m_prefixes.last() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4827?vs=11910=11912 BRANCH phab/framesvgFallback REVISION DETAIL

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvgitem.cpp:571-574 > this !found is a behavioural change on the existing code. > > Why are we adding it? before it did set the elementprefix on the framesvg regardless it was present or not, so this is done in order

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 522 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/522/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 17:41:52 + Build duration: 2 min 39 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 522 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/522/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Feb 2017 17:41:52 + Build duration: 2 min 39 sec CHANGE SET Revision

[Differential] [Requested Changes] D4827: possibility to use a fallback chain as prefix

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > framesvgitem.cpp:571-574 > +if (!found) { > +qWarning() << "The image" << m_frameSvg->imagePath() << "doesn't > contain any of

[Differential] [Accepted] D4827: possibility to use a fallback chain as prefix

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. note there is a minor API break for any JS code that does if (prefix === "someValue") but I've checked and no-one does...(and it would be a bit of a weird thing to

[Differential] [Updated, 66 lines] D4827: possibility to use a fallback chain as prefix

mart updated this revision to Diff 11910. mart added a comment. - logic all in applyPrefixes() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4827?vs=11904=11910 BRANCH phab/framesvgFallback REVISION DETAIL

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

mart added a comment. In https://phabricator.kde.org/D4827#90608, @davidedmundson wrote: > Either: > > a QML client could just do > prefix: frame.hasElementPrefix("toolbutton-pressed") ? "toolbutton-pressed" : "pressed" > > > > or this doesn't

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

davidedmundson added a comment. Either: a QML client could just do prefix: frame.hasElementPrefix("toolbutton-pressed") ? "toolbutton-pressed" : "pressed" or this doesn't work It's the same thing both are just using for

[Differential] [Updated] D4827: possibility to use a fallback chain as prefix

mart marked an inline comment as done. mart added a comment. In https://phabricator.kde.org/D4827#90599, @davidedmundson wrote: > > [15:20] ‎<‎notmart‎>‎ if the svg doesn't exists, it falls back to the breeze one > > ‎[15:20] ‎<‎notmart‎>‎ then all hasElementPrefix would check if said

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

mart added a comment. F2657134: Spectacle.X22789.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma

[Differential] [Commented On] D4827: possibility to use a fallback chain as prefix

davidedmundson added a comment. > [15:20] ‎<‎notmart‎>‎ if the svg doesn't exists, it falls back to the breeze one > ‎[15:20] ‎<‎notmart‎>‎ then all hasElementPrefix would check if said prefix exists in the breeze theme That's exactly what this code is doing, just in a much more

[Differential] [Changed Subscribers] D4827: possibility to use a fallback chain as prefix

broulik added inline comments. INLINE COMMENTS > framesvgitem.cpp:287 > +m_frameSvg->setElementPrefix(prefix); > +break; > +} Maybe print a warning if none found? Or how did the old code behave where we would always call this no matter if we had it? >

[Differential] [Request, 58 lines] D4827: possibility to use a fallback chain as prefix

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if a framesvgitem has an array as prefix, like FrameSvg { prefix: ["toolbutton-hover", "hover"] } it will

[Differential] [Updated] D4801: KNotifications cleanup

vpilo edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4801 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vpilo Cc: #frameworks

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

mart added a comment. In https://phabricator.kde.org/D4797#90144, @broulik wrote: > > So changing only the theme would mean to change the svg of `ButtonStyle`, which is not desirable. > > Then we need to introduce new elements in `widgets/button.svg` or a new `widget/toolbutton.svg`

[Differential] [Requested Changes] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. in general, this gives me the idea that it may be a good idea to try to expand framesvgitem api to have things like FrameSvgItem { prefix: ["toolbutton-normal",

[Differential] [Accepted] D4762: [SliderStyle] Allow providing a "hint-handle-size" element

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4762 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg, mart Cc:

[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

mart added a comment. In https://phabricator.kde.org/D4797#90142, @subdiff wrote: > In https://phabricator.kde.org/D4797#90126, @broulik wrote: > > > Design looks ok but still you can't change `ToolButtonStyle`, instead, the Breeze Plasma theme needs to be changed. > > > Sorry,

[Differential] [Commented On] D4689: IconItem: Add roundToIconSize property

drosca added inline comments. INLINE COMMENTS > sebas wrote in iconitem.cpp:313 > Changing roundToIconSize may change the size of the icon, so should we > trigger size changes (paintedWidth / paintedHeight / boundingRect likely? > Perhaps others.) and re-rendering here as well? Right now,

[Differential] [Updated, 68 lines] D4689: IconItem: Add roundToIconSize property

drosca updated this revision to Diff 11897. drosca added a comment. Rename getter Emit paintedSizeChanged + schedulePixmapUpdate REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4689?vs=11845=11897 BRANCH arcpatch-D4689 REVISION