D4931: Small cleanups

apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Move implementation to cpp file, port away from deprecated API. REPOSITORY R242 Plasma Framework (Library) BRANCH master

D4911: add Baloo DBus signals for moved or removed files

vhanda added a comment. I'm not the maintainer of Baloo any more, so I don't want to give it a clear Yes / No. This patch is going to be a big CPU hog. For files this will barely have an impact, but for folders of a large enough size, it's going to result in tons of dbus signals, and

D4630: Only register APPLE_* options if(APPLE)

apol added a comment. If nobody reviews I'll push during the next week. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4630 To: apol, #frameworks Cc: #build_system

D4911: add Baloo DBus signals for moved or removed files

apol added a reviewer: vhanda. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien, vhanda Cc: apol, #frameworks

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 455 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/455/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 22:22:43 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 455 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/455/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 22:22:43 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 482 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/482/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 22:29:01 + Build duration: 2 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 482 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/482/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 22:29:01 + Build duration: 2 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

D4847: KAuth integration in document saving

martinkostolny added a comment. I've learnt a few things about autotests (`KTextEditor::EditorPrivate::unitTestMode()` was really helpful, thanks!). I managed to create a test case, which allowed the code to go through KAuth action. But I was unsuccessful to finish it to my satisfaction - I

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 481 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/481/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 17:39:55 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 454 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/454/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 17:18:23 + Build duration: 22 min CHANGE SET Revision

D4733: Port to categorized logging and clean includes

This revision was automatically updated to reflect the committed changes. Closed by commit R238:cc022ff1e725: Port to categorized logging and clean includes (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4733?vs=12139=12140 REVISION

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 366 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/366/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 03 Mar 2017 16:56:45 + Build duration: 13 min CHANGE SET

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated March 3, 2017, 6:23 p.m.) Review request for KDE Software on

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 465-467 > > > > > > I would prefer to not introduce new platform specific code in the > > shared part. > > > > The

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 365 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/365/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 03 Mar 2017 16:56:46 + Build duration: 2 min 16 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 365 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/365/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 03 Mar 2017 16:56:46 + Build duration: 2 min 16 sec CHANGE SET Revision

D4733: Port to categorized logging and clean includes

ltoscano edited the summary of this revision. ltoscano edited the test plan for this revision. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D4733 To: ltoscano, kfunk Cc: #frameworks, #documentation

D4733: Port to categorized logging and clean includes

ltoscano updated this revision to Diff 12139. ltoscano added a comment. Recommitted after the revert now that KDocTools exports a proper shared library (the initial patch broke KIO). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4733?vs=11794=12139

D4733: Port to categorized logging and clean includes

ltoscano reopened this revision. ltoscano added a comment. This revision is now accepted and ready to land. I had to revert this because it broke KIO, as KDocTools exported only a static library. This forced me to finally implement a dynamic library, so now I can try to propose a new proper

D4769: Try to get the real port instead of always use DEFAULT_SFTP_PORT

This revision was automatically updated to reflect the committed changes. Closed by commit R320:40f1edc9a814: Try to get the real port instead of always use DEFAULT_SFTP_PORT (authored by xuetianweng). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4769?vs=11784=12138#toc REPOSITORY

D4911: add Baloo DBus signals for moved or removed files

mgallien updated this revision to Diff 12137. mgallien added a comment. add checks that the correct signal is sent during tests of MetadataMover REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4911?vs=12134=12137 BRANCH master REVISION DETAIL

Review Request 129983: [kio] Deleting files and directories from root owned location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- Review request for KDE Frameworks, David Faure and Elvis Angelaccio.

D4769: Try to get the real port instead of always use DEFAULT_SFTP_PORT

xuetianweng marked 2 inline comments as done. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D4769 To: xuetianweng, #frameworks, apol, dfaure Cc: dfaure

D4850: Use the new shared library exported by KDocTools

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9a942be78ff: Use the new shared library exported by KDocTools (authored by ltoscano). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4850?vs=11983=12136 REVISION

D4925: actually delete old theme caches

apol added inline comments. INLINE COMMENTS > theme_p.cpp:221 > + > +for (const QString : cacheDir.entryList()) { > if (currentCacheFileName.isEmpty() || Use entryInfoList? This way you won't have to construct the path again... > theme_p.cpp:270 > + > +for

D4911: add Baloo DBus signals for moved or removed files

apol added a comment. :) good, thanks, can you look into the autotests? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien Cc: apol, #frameworks

D4926: Fix cmake warning

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use the native dialog if there's no QApplication TEST PLAN Adds a test REPOSITORY R135 Integration for Qt applications in Plasma BRANCH

Jenkins-kde-ci: kdoctools master stable-kf5-qt5 » Linux,gcc - Build # 216 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdoctools%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/216/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 16:02:04 + Build duration: 49 sec CHANGE SET Revision

Jenkins-kde-ci: kdoctools master stable-kf5-qt5 » Linux,gcc - Build # 216 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdoctools%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/216/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 16:02:04 + Build duration: 49 sec CHANGE SET Revision

D4911: add Baloo DBus signals for moved or removed files

mgallien marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien Cc: apol, #frameworks

D4911: add Baloo DBus signals for moved or removed files

mgallien updated this revision to Diff 12134. mgallien added a comment. fix two new issues reported by apol REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4911?vs=12116=12134 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4911 AFFECTED

D4925: actually delete old theme caches

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QStandardPaths doesn't do file search by wildcards, that code was never actually functional TEST PLAN old kcache and

D4849: Export a proper shared library for KDocTools

This revision was automatically updated to reflect the committed changes. Closed by commit R238:620b0206ac89: Export a proper shared library for KDocTools (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4849?vs=12097=12132 REVISION

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 246 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/246/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 14:49:31 + Build duration: 7 min 52 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- (Updated mar. 3, 2017, 5:02 p.m.) Status -- This change has been

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When pressing the "Menu" key, pretend a right-click happened and show the containment context menu. TEST PLAN

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/ --- (Updated mar. 3, 2017, 4:52 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 364 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/364/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 03 Mar 2017 14:33:19 + Build duration: 2 min 21 sec CHANGE SET Revision

Jenkins-kde-ci: kdoctools master stable-kf5-qt5 » Linux,gcc - Build # 215 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdoctools%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/215/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 13:27:27 + Build duration: 2 min 8 sec CHANGE SET No changes

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Dec. 27, 2016, 6:39 p.m., Martin Gräßlin wrote: > > src/platforms/osx/kwindowinfo.mm, line 33 > > > > > > what's "Ext"? Stood for Extended. > On Dec. 27, 2016, 6:39 p.m., Martin Gräßlin wrote: > >

D4921: [Menu] Harmonize openRelative placement

subdiff created this revision. subdiff added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With https://phabricator.kde.org/D4867 the placement was already changed a bit, but mostly the correction if there is not enough screen space

D4919: Don't set acceptHoverEvents in DragArea as we don't use them

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4919 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4920: With Qt >= 5.8 use the new API to set scene graph backend

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4920 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4866: possible to set expanded=false for a containment

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fba9e9e151a9: possible to set expanded=false for a containment (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D4920: With Qt >= 5.8 use the new API to set scene graph backend

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4920 AFFECTED FILES

D4919: Don't set acceptHoverEvents in DragArea as we don't use them

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Looked for hoverEvent/Leave/Move in code We still get mouseMove whilst the user is dragging Checked Widget Explorer

D4866: possible to set expanded=false for a containment

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/collapse REVISION DETAIL https://phabricator.kde.org/D4866 To: mart, #plasma, broulik Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The current ones aren't really descriptive and vastly different from what Dolphin uses. BUG: 376321 TEST PLAN

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 451 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/451/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 12:35:51 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 451 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/451/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 12:35:51 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 256 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/256/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 12:36:36 + Build duration: 9 min 51 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 256 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/256/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 12:36:36 + Build duration: 9 min 51 sec CHANGE SET No changes JUNIT RESULTS Name:

D4911: add Baloo DBus signals for moved or removed files

apol added a comment. autotests would be very welcome! INLINE COMMENTS > transaction.cpp:134 > + > +const QVector children = docUrlDB.getChildren(parentId); > + Return right away? > apol wrote in metadatamover.cpp:49 > const auto & Uh you are right, no need for a const&, I assumed it

D4911: add Baloo DBus signals for moved or removed files

mgallien marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien Cc: apol, #frameworks

Re: Differential e-mail subject re-arrangement

Hi Ben. Thanks for your fixes, much appreciated. On jeudi 2 mars 2017 09:08:25 CET Ben Cooksley wrote: > We'd need a strong use case to explain to upstream why repository > should be in the Subject, IMHO the use case *is* strong. If you watch many repositories (as we do on this list), then

D4911: add Baloo DBus signals for moved or removed files

mgallien updated this revision to Diff 12116. mgallien added a comment. Fix issues reported by apol Not sure the list iteration on quint64 needs a const auto &. Will add automatic tests later and as soon as possible REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D4849: Export a proper shared library for KDocTools

dfaure added a comment. I think you can remove the static lib, yes. It didn't "look" like a proper KF5 lib, being the only static one, and the functions being undocumented, etc. REPOSITORY R238 KDocTools BRANCH sharedlib REVISION DETAIL https://phabricator.kde.org/D4849 To:

D4849: Export a proper shared library for KDocTools

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ltoscano wrote in docbookxslt_p.h:1 > This is not exported, can I fix it later with the other files? Sure. REPOSITORY R238 KDocTools BRANCH sharedlib REVISION

D4769: Try to get the real port instead of always use DEFAULT_SFTP_PORT

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good - just a minor nitpick on coding style / readability, feel free to push (either way, actually). INLINE COMMENTS > kio_sftp.cpp:605 > > + unsigned int effectivePort =

D4911: add Baloo DBus signals for moved or removed files

apol added inline comments. INLINE COMMENTS > metadatamover.cpp:47 > +{ > +auto childrenIds = tr.childrenDocumentId(parentId); > + make const > metadatamover.cpp:49 > + > +for (auto oneChildren : childrenIds) { > +

D4911: add Baloo DBus signals for moved or removed files

mgallien added a task: T4931: Incremental changes from Baloo (new tracks, modified tracks, removed tracks). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien Cc: #frameworks

D4911: add Baloo DBus signals for moved or removed files

mgallien removed a reviewer: kde-frameworks-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien Cc: #frameworks