anthonyfieroni added inline comments.
INLINE COMMENTS
> katetextbuffer.cpp:791
> */
> -QSaveFile saveFile(filename);
> -saveFile.setDirectWriteFallback(true);
> +QFileDevice *saveFile = new QSaveFile(filename);
> +static_cast(saveFile)->setDirectWriteFallback(true);
use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/
---
Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
martinkostolny updated this revision to Diff 12177.
martinkostolny added a comment.
Good point, thanks! I now the helper is really light-weight. Helper is now
only moving a temporary file and setting permissions/owner.
I've also added a unit test. It directly calls the action method
fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfilewidget.h:150
> */
> void setSelection(const QString );
>
This function only works correctly for URLs, as filenames can contain ':'s.
However,
On samedi 4 mars 2017 12:03:08 CET Frank Schäfer wrote:
> Hi,
>
> I'm trying to track down a bug which occurs when using
> QFileDialog::getSaveFileName in a Qt5-application.
> With option QFileDialog::DontUseNativeDialog a different dialog
> displayed, so a native file dialog seems to be used.
>
Hi,
I'm trying to track down a bug which occurs when using
QFileDialog::getSaveFileName in a Qt5-application.
With option QFileDialog::DontUseNativeDialog a different dialog
displayed, so a native file dialog seems to be used.
I've checked the source code of QFileDialog::getSaveFileName and
dfaure created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It turns out that setSelection() cannot take both relative paths (filenames)
and absolute URLs as input. "a:b" can be both, and URLs for files called "a#b"
were handled wrongly.
CCBUG:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126894/
---
(Updated March 4, 2017, 12:05 p.m.)
Status
--
This change has been
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/259/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Mar 2017 18:08:32 +
Build duration: 5 min 35 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/247/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Mar 2017 18:07:44 +
Build duration: 5 min 52 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/247/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Mar 2017 18:07:44 +
Build duration: 5 min 52 sec
CHANGE SET
No changes
JUNIT RESULTS
cullmann added a comment.
Hi,
I think this is a great thing to have!
My biggest complaint ATM is: I would not move the saving code out to the
helper binary, instead, it should stay in the place it is and we could just
save to a tmpfile and tell the helper to move that file over the
dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4932
To: dfaure, lesliezhai
Cc: #frameworks
dfaure added a comment.
I'm curious to find out whether the clang static analyzer still complains or
realizes this is fine now :)
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4932
To: dfaure, lesliezhai
Cc: #frameworks
lesliezhai accepted this revision.
lesliezhai added a comment.
This revision is now accepted and ready to land.
Hi David,
Looks good to me!
Regards,
Leslie Zhai
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4932
To: dfaure, lesliezhai
Cc:
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4630
To: apol, #frameworks, dfaure
Cc: #build_system
dfaure created this revision.
Restricted Application added a project: Frameworks.
TEST PLAN
kcmshell5 cookies
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4932
AFFECTED FILES
src/kcms/kio/kcookiesmanagement.cpp
To: dfaure, lesliezhai
Cc:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4931
To: apol, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, progwolff, lesliezhai,
18 matches
Mail list logo
