D5037: KTextEditor: prevent accidental zooming

rjvbb marked 2 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D5037 To: rjvbb, #ktexteditor Cc: dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12448. rjvbb edited the test plan for this revision. rjvbb added a comment. Was this what you had in mind? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5037?vs=12438=12448 REVISION DETAIL https://phabricator.kde.org/D5037 AFFECTED FILES

D5037: KTextEditor: prevent accidental zooming

dhaumann added a comment. Thinking aloud: Can you factor this out into a small helper class called WheelEventFilter or similar? I can imagine this would be cleaner. The code possibly would shrink down to something like: if (m_wheelEventFilter.processEvent(event)) { // ...

D5034: Add support for x-gvfs style options in fstab

broulik added inline comments. INLINE COMMENTS > dhaumann wrote in fstabdevice.cpp:40-41 > Did you intentionally switch vendor and product? I wondered that too, that's in the original patch, though, didn't really look into where this will end up, though :D REPOSITORY R245 Solid REVISION

D5034: Add support for x-gvfs style options in fstab

dhaumann added a comment. Just some minor comments, besides that, looks sane. INLINE COMMENTS > fstabdevice.cpp:40-41 > +if (m_device.startsWith(QLatin1String("//"))) { > +m_vendor = m_device.mid(2, m_device.indexOf(QLatin1String("/"), 2) - > 2); > +m_product =

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 465 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/465/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Mar 2017 19:52:43 + Build duration: 19 min CHANGE SET Revision d804fb5ef43e1a8df033eeb890e03d61efdf14b1 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 469 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/469/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Mar 2017 19:52:43 + Build duration: 19 min CHANGE SET Revision

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Am 13. März 2017 16:15:34 MEZ schrieb Kai Uwe Broulik : >‎ >> Macs however always have two-fingers secondary click; their magic >mouse have both (it's mouse-touchpad hybrid). > >If all else fails you could still Control click on Mac iirc. > >This feature would be useful

D5037: KTextEditor: prevent accidental zooming

rjvbb created this revision. rjvbb added a project: KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY KTextEditor::KateViewInternal::wheelEvent() implements text zoom in reaction to Ctrl+Wheel

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

‎ > Macs however always have two-fingers secondary click; their magic mouse have > both (it's mouse-touchpad hybrid). If all else fails you could still Control click on Mac iirc. This feature would be useful for Plasma on touchscreens though, faking a right click on  *touch* long-press. Maybe

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sun, Mar 12, 2017 at 4:03 AM, René J.V. Bertin wrote: > Hello, > > The other day I had to add a context menu to a widget (QPushbutton) > defined in a .ui file and went a bit further when I realised it could be > nice to be able to open such a menu without using a

D5034: Add support for x-gvfs style options in fstab

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY These fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI. For

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review102826 --- I'm not sure if we should show the warning dialog at the

D5032: drop examples dir

sitter added a comment. Not interesting enough to me. If someone finds it interesting, sure. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

D5032: drop examples dir

ltoscano added a comment. Couldn't it go to kdeexamples if interesting enough (or at least its frameworks branch, if any?) REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

D5032: drop examples dir

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - it does not build on its own (doesn't find_package anything) - it is not wired into the overall build (so you can't build it as part of

Re: Jenkins-kde-ci: knotifyconfig master kf5-qt5 » Linux, gcc - Build # 444 - Failure!

On Mon, Mar 13, 2017 at 3:29 AM, David Faure wrote: > On dimanche 12 mars 2017 11:45:40 CET no-re...@kde.org wrote: >> GENERAL INFO >> >> BUILD FAILURE >> Build URL: >> https://build.kde.org/job/knotifyconfig%20master%20kf5-qt5/PLATFORM=Linux,c >> ompiler=gcc/444/ Project:

D5001: Add support for killing a KAuth::ExecuteJob

leinir closed this revision. leinir added a comment. Closed by commit https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D5001 To: leinir, #frameworks, jriddell Cc: jriddell

D5003: Update docs to Frameworks API

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That looks about right to me! :) REPOSITORY R283 KAuth BRANCH docs REVISION DETAIL https://phabricator.kde.org/D5003 To: jriddell, leinir Cc: #frameworks