D5067: Specify qml-root-path as the share directory in the prefix

apol created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY This way androiddeployqt will scan the imports. Otherwise it wouldn't pull qtquickcontrols2 for me REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D5066: Provide device type for Low Energy devices

elvisangelaccio edited the test plan for this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D5066 To: elvisangelaccio, drosca Cc: #frameworks

D5066: Provide device type for Low Energy devices

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Bluetooth Low Energy devices have an invalid class value, so we cannot use it to deduce the type of the device. Instead we can use

D4847: KAuth integration in document saving

martinkostolny added a comment. I know there is a lot of other stuff going on. So just to be sure: am I supposed to do something else - are we waiting for me? Also if I'm too rookie for this, feel free to commandeer the revision. :) REPOSITORY R39 KTextEditor REVISION DETAIL

D5057: Add KAcceleratorManager

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. long due papercut :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5057 To: broulik, #plasma, mart Cc: mart, plasma-devel, #frameworks,

Re: Automatic Tests and Continuous Integration

Thanks David and Harald, I had already found some months ago that you have to go through "default" but had forgotten about it. Have a nice day Best regards 2017-03-15 13:57 GMT+01:00 Harald Sitter : > you need to drill down into the 'default' configuration >

D5057: Add KAcceleratorManager

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This way containment context menus and PlasmaComponents Menu get accelerators assigned to by default. CHANGELOG:

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 15, 2017, 7:36 a.m., David Faure wrote: > > src/ioslaves/file/kauth/helper.h, line 40 > > > > > > Can you name it mReply for readability? > > > > But in fact I wonder if it should really be a

D5056: [KCModuleProxy] Remove dead code

ltoscano added a comment. There is "Frameworks", which is added as subscriber (not reviewer), but that's enough to have the email landing on kde-frameworks-devel (which is how I saw this review). REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D5056 To: broulik,

D5056: [KCModuleProxy] Remove dead code

broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We don't want GUI stuff run as root, we have PolicyKit, there's no "rootInfo" anywhere anymore. More importantly, this empty if condition

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 13, 2017, 12:10 p.m., Elvis Angelaccio wrote: > > I'm not sure if we should show the warning dialog at the kio_file level. > > This would result in a double dialog when deleting files with Shift+Del > > from file managers. What about making jobuidelegate.cpp smarter? It could > >

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. > > Matthieu Gallien wrote: > I almost forgot to ask an automatic test for your fix.

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

This actually works pretty nicely: https://commits.kde.org/scratch/rjvbb/osx-integration/1bfc3c00293dff6c726d0853457ab09b560e3df9 - m_grabbing is still used to track whether the 1st mousebutton press must be resend after grabbing the gesture. I prefer that to using a separate object property,

Re: Automatic Tests and Continuous Integration

you need to drill down into the 'default' configuration http://i.imgur.com/D4Asuaa.png On Wed, Mar 15, 2017 at 10:10 AM, Matthieu Gallien wrote: > Hello, > > I am a bit lost when looking at both KFileMetaData projects under > build.kde.org. I am not able to get any

Re: Automatic Tests and Continuous Integration

On mercredi 15 mars 2017 10:10:25 CET Matthieu Gallien wrote: > Hello, > > I am a bit lost when looking at both KFileMetaData projects under > build.kde.org. I am not able to get any coverage, cppcheck or > automatic tests results. > > Am I looking at the wrong place ? > > Is it expected ?

Automatic Tests and Continuous Integration

Hello, I am a bit lost when looking at both KFileMetaData projects under build.kde.org. I am not able to get any coverage, cppcheck or automatic tests results. Am I looking at the wrong place ? Is it expected ? Thanks in advance for any help Best regards -- Matthieu Gallien

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Either way it remains tricky business doing this without any knowledge about the widget that's being grabbed. I've already seen cases where you open a menu with a single mouse click and then the context menu appeared as well a short while later. That looks as if even the standard behaviour of

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! > > Matthieu Gallien wrote: > KFileMetaData being in use by itself, IMHO Baloo problematics should not > block this correction. I almost forgot to ask an automatic test for your fix. Please do not ship without it. -

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote: > > Ship It! KFileMetaData being in use by itself, IMHO Baloo problematics should not block this correction. - Matthieu --- This is an automatically generated e-mail. To reply,

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102851 --- Ship it! Ship It! - Matthieu Gallien On mars 14,

Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

> On March 15, 2017, 6:13 a.m., Anthony Fieroni wrote: > > Ship It! Can you verify, https://git.reviewboard.kde.org/r/129703/ it is needed to limit CPU usage or to discard it? - Anthony --- This is an automatically generated e-mail.

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On mercredi 15 mars 2017 09:27:28 CET René J.V. Bertin wrote: > On Wednesday March 15 2017 09:07:48 David Faure wrote: > >Definitely. But there's another solution: QObject::setProperty, > >which supports dynamic properties so you can store anything you want in > >there. > I did think of something

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Wednesday March 15 2017 09:07:48 David Faure wrote: >Definitely. But there's another solution: QObject::setProperty, >which supports dynamic properties so you can store anything you want in there. I did think of something like that, but didn't get around yet to figuring out how. Any idea

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On dimanche 12 mars 2017 23:40:29 CET René J.V. Bertin wrote: > Proof of concept: > > https://commits.kde.org/scratch/rjvbb/osx-integration/1260a608db98cfd3d75bf1 > 5917945b59c81b1182 " storing all grabbed QObjects is potentially dangerous " Definitely. But there's another solution:

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review102848 --- src/ioslaves/file/file.cpp (line 1376)

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 12, 2017, 3:49 p.m., David Faure wrote: > > src/ioslaves/file/CMakeLists.txt, line 37 > > > > > > if (UNIX) > >add_subdirectory(kauth) > > endif() > > > > Apparently kauth doesn't