D4799: Delay notifications until desktop session has loaded

2017-03-22 Thread Valerio Pilo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:2d40672b0c85: Do not remove queued notifications when the 
fd.o service starts. Also start the… (authored by vpilo).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4799?vs=12377=12712

REVISION DETAIL
  https://phabricator.kde.org/D4799

AFFECTED FILES
  src/notifybypopup.cpp

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D5136: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol abandoned this revision.
apol added a comment.


  On ECM https://phabricator.kde.org/D5143

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, sitter, kfunk, aacid
Cc: ltoscano

D5143: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol created this revision.
Restricted Application added projects: Frameworks, Build System.

REVISION SUMMARY
  Makes it possible to fetch translations when building the project. To do so
  it fetches kde:releaseme and uses the new fetchpo.rb program to download the
  translations into the build directory.
  
  This should make it much easier to integrate translations in the development
  process.

TEST PLAN
  Downloaded and installed translations for some projects

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5143

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: apol, #frameworks, #build_system, kfunk, aacid, ltoscano

D5136: Introduce fetch-translations build command

2017-03-22 Thread Luigi Toscano 
ltoscano added a comment.


  I agree that it should go to ECM, and there are modules (for various reasons) 
with translations not handled by KI18n.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, sitter, kfunk, aacid
Cc: ltoscano

D5136: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol added a comment.


  In https://phabricator.kde.org/D5136#96878, @aacid wrote:
  
  > I'm not sure addign a dependency for releaseme in ki18n is a good idea to 
be honest.
  >
  > This very "only works for KDE-based applications", a third-party using k18n 
has no interest in this at all.
  >
  > Maybe it would make more sense in some of the *KDE* files ECM has?
  
  
  Maybe. My thinking was that we'll have to find ki18n anyway and ECM is 
already a dependency of ki18n. I can move it there, no problem.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, sitter, kfunk, aacid

D5136: Introduce fetch-translations build command

2017-03-22 Thread Kevin Funk 
kfunk added a comment.


  In https://phabricator.kde.org/D5136#96878, @aacid wrote:
  
  > I'm not sure addign a dependency for releaseme in ki18n is a good idea to 
be honest.
  >
  > This very "only works for KDE-based applications", a third-party using k18n 
has no interest in this at all.
  >
  > Maybe it would make more sense in some of the *KDE* files ECM has?
  
  
  Exactly what I told apol on IRC, too ;)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, sitter, kfunk, aacid

D5136: Introduce fetch-translations build command

2017-03-22 Thread Albert Astals Cid 
aacid added a comment.


  I'm not sure addign a dependency for releaseme in ki18n is a good idea to be 
honest.
  
  This very "only works for KDE-based applications", a third-party using k18n 
has no interest in this at all.
  
  Maybe it would make more sense in some of the *KDE* files ECM has?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, sitter, kfunk, aacid

D5136: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 12705.
apol added a comment.


  Address some issues

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5136?vs=12698=12705

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5136

AFFECTED FILES
  KF5I18nConfig.cmake.in

To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5136: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol marked 2 inline comments as done.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

2017-03-22 Thread Tobias C. Berner 
tcberner added a comment.


  F3114620: dolphin2.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, adridg, arrowdodger, rakuco, dfaure
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

2017-03-22 Thread Tobias C. Berner 
tcberner added reviewers: rakuco, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, adridg, arrowdodger, rakuco, dfaure
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

2017-03-22 Thread Tobias C. Berner 
tcberner added reviewers: adridg, arrowdodger.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, adridg, arrowdodger
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

2017-03-22 Thread Tobias C. Berner 
tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  It seems UDS_CREATION_TIME is never filled at all (as far as I could find in 
the short time I invested :D ).
  
  From the manpage:
  
st_birthtim  Time when the inode was created.
  
  This allows us to display file creation dates in (patched) dolphin.
  
  This is with respect to: 
  https://bugs.kde.org/show_bug.cgi?id=374063

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: tcberner
Cc: #frameworks

D5134: Don't exit if $DISPLAY is not set

2017-03-22 Thread Martin Gräßlin 
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  As I stumbled over that years ago: sorry I don't think that this is the 
proper solution. This is basically https://phabricator.kde.org/T4431 which is 
not yet implemented. What this change suggest is a rather hacky solution.
  
  Kinit if built with X11 is still requiring the DISPLAY variable all over the 
place. The only solution is to run an X server, even if it is not the X 
platform As we do on Plasma/Wayland

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D5134

To: aacid, graesslin
Cc: graesslin, rikmills, lukas, #frameworks

D5136: Introduce fetch-translations build command

2017-03-22 Thread Kevin Funk 
kfunk added inline comments.

INLINE COMMENTS

> KF5I18nConfig.cmake.in:12
> +
> +execute_process(COMMAND git config --get remote.origin.url
> +OUTPUT_VARIABLE reponame

Can you delay that git invocation to when the custom target is executed? 
Otherwise we also pay for this whenever `KF5I18nConfig.cmake` is included

> KF5I18nConfig.cmake.in:17
> +)
> +
> +if(exitCode GREATER 0)

Style: Remove newline

> KF5I18nConfig.cmake.in:24
> +OUTPUT "${CMAKE_BINARY_DIR}/releaseme"
> +COMMAND git clone "https://anongit.kde.org/releaseme.git;
> +COMMENT "Fetching releaseme scripts to download translations..."

`git clone --depth 0 ...`?

> KF5I18nConfig.cmake.in:30
> +COMMAND cmake -E remove_directory ${CMAKE_BINARY_DIR}/po
> +COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin stable 
> --project ${reponame} ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_BINARY_DIR}/po
> +COMMENT "Downloading translations..."

--origin stable being hard-coded doesn't look right

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5136: Introduce fetch-translations build command

2017-03-22 Thread Kevin Funk 
kfunk requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5133: Introduce fetchpo.rb

2017-03-22 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R572:474c8704ce76: Introduce fetchpo.rb (authored by apol).

REPOSITORY
  R572 releaseme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5133?vs=12696=12699

REVISION DETAIL
  https://phabricator.kde.org/D5133

AFFECTED FILES
  fetchpo.rb
  lib/releaseme/l10n.rb
  lib/releaseme/l10nstatistics.rb
  test/test_l10n.rb

To: apol, #frameworks, sitter

D5136: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol added a dependency: D5133: Introduce fetchpo.rb.
apol added a comment.


  FWIW, depends on https://phabricator.kde.org/D5133

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D5136

To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5133: Introduce fetchpo.rb

2017-03-22 Thread Aleix Pol Gonzalez 
apol added a dependent revision: D5136: Introduce fetch-translations build 
command.

REPOSITORY
  R572 releaseme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5133

To: apol, #frameworks, sitter

D5133: Introduce fetchpo.rb

2017-03-22 Thread Harald Sitter 
sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R572 releaseme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5133

To: apol, #frameworks, sitter

D5136: Introduce fetch-translations build command

2017-03-22 Thread Aleix Pol Gonzalez 
apol created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Makes it possible to fetch translations when building the project. To do so
  it fetches kde:releaseme and uses the new fetchpo.rb program to download the
  translations into the build directory.
  
  This should make it much easier to integrate translations in the development
  process.

TEST PLAN
  Used successfully with a couple of projects

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5136

AFFECTED FILES
  KF5I18nConfig.cmake.in

To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5133: Introduce fetchpo.rb

2017-03-22 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 12696.
apol added a comment.


  Address issue, use git.kde.org repo name as identifier

REPOSITORY
  R572 releaseme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5133?vs=12695=12696

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5133

AFFECTED FILES
  fetchpo.rb
  lib/releaseme/l10n.rb
  lib/releaseme/l10nstatistics.rb
  test/test_l10n.rb

To: apol, #frameworks, sitter

D5133: Introduce fetchpo.rb

2017-03-22 Thread Harald Sitter 
sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> l10n.rb:217
>  
> -def get(srcdir)
> -  # FIXME: this is later used as destination for the weirdest of 
> reasons...
> -  target = "#{srcdir}/po/"
> +def get(srcdir, target = "#{Dir.getwd}/#{srcdir}/po", allow_edit = true)
>Dir.mkdir(target)

File.expand_path

  def get(srcdir, target = File.expand_path("#{srcdir}/po"),
  allow_edit = true)

REPOSITORY
  R572 releaseme

REVISION DETAIL
  https://phabricator.kde.org/D5133

To: apol, #frameworks, sitter

D5133: Introduce fetchpo.rb

2017-03-22 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 12695.
apol added a comment.


  Address sitter concerns

REPOSITORY
  R572 releaseme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5133?vs=12693=12695

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5133

AFFECTED FILES
  fetchpo.rb
  lib/releaseme/l10n.rb
  lib/releaseme/l10nstatistics.rb
  test/test_l10n.rb

To: apol, #frameworks, sitter

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-03-22 Thread Chinmoy Ranjan Pradhan 


> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote:
> > src/ioslaves/file/kauth/file.actions, lines 1-5
> > 
> >
> > I don't see the advantage of using a single kauth action. This way you 
> > are generating only one "generic" polkit action that you can either enable 
> > or disable. Instead if we used one polkit action per operation (del, rmdir, 
> > etc.) we could allow a more fine-grained control. For example, a sysadmin 
> > could decide that the users can create files in write protected locations, 
> > but they cannot delete existing files.

Some operation may use more than one polkit action like Delete. If we use one 
polkit action per operation then we will have to provide credentials for every 
polkit action that operation might use. Though we can add necessary code for 
this but it will only complicate the matter.

> we could allow a more fine-grained control

Does this involve editing the policy file directly or just writing a config 
file? In later case we can provide control over execution of actions within the 
ioslave. 'execWithRoot' can perform a check prior to execution of the polkit 
action.


- Chinmoy Ranjan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129983/#review102932
---


On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129983/
> ---
> 
> (Updated March 14, 2017, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This is regarding the GSOC idea 
> https://community.kde.org/GSoC/2017/Ideas#Project:_Polkit_support_in_KIO.
> 
> This patch intends to demonstrate one possible approach to provide polkit 
> support in kio. Here its only for the delete operation. This is based on the 
> patch in task https://phabricator.kde.org/T5070.
> 
> The approach is as follows;
> 1. Whenever file ioslave gets access denied error it calls the method 
> *execWithRoot* with the action that requires priviledge, the path of items
>upon which action needs to be performed and a warning ID as arguments.
> 2. *execWithRoot* then executes the KAuth::Action *org.kde.kio.file.execute*. 
> 3. This Kauth::Action has its Persistence set too 'session'. This means that 
> after authentication the restrictions are dropped for a while, for
>about 5 minutes. This is similar to the behaviour of sudo command.
> 4. During this time we can perform any action as a privileged user without 
> any authentication. So to prevent any mishap i added a warning box which
>would popup before performing any action(only during this period).
> 5. After the said time interval the root privileges are droped and calling 
> *execWithRoot* should show the usual authentication dialog.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/file/CMakeLists.txt b9132ce 
>   src/ioslaves/file/file.h 109ea80 
>   src/ioslaves/file/file.cpp eaf6c88 
>   src/ioslaves/file/file_unix.cpp 82eb11a 
>   src/ioslaves/file/kauth/CMakeLists.txt PRE-CREATION 
>   src/ioslaves/file/kauth/file.actions PRE-CREATION 
>   src/ioslaves/file/kauth/helper.h PRE-CREATION 
>   src/ioslaves/file/kauth/helper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129983/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> warning dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

D5133: Introduce fetchpo.rb

2017-03-22 Thread Harald Sitter 
sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  I really think this should have a simple test case. In particular, the 
allow_edit behavior should be asserted somewhere. Also some style nitpicks.

INLINE COMMENTS

> fetchpo.rb:52
> +
> +elements = ReleaseMe::Project.from_xpath(options.project)
> +unless elements.count == 1

Unless you want this to work even for !git builds I'd really advise that you 
get attempt to find the git remote URL and use `Project.from_repo_url` to 
resolve that into a `Project`. `from_xpath` is slower and less reliable than 
`from_repo_url`.

> fetchpo.rb:54
> +unless elements.count == 1
> +warn "found #{elements.count} elements for #{options.project}"
> +exit 2

2 space indentation for new code please.

> l10n.rb:217
>  
> -def get(srcdir)
> -  # FIXME: this is later used as destination for the weirdest of 
> reasons...
> -  target = "#{srcdir}/po/"
> +def get(srcdir, target = nil, allow_edit = true)
> +  if not target

These additions are missing a test case :P

> l10n.rb:219
> +  if not target
> +  target = "#{Dir.getwd}/#{srcdir}/po"
> +  end

Bunch of style problems here. TLDR code I want at the bottom.

`Dir.pwd` + modifier `if` (when the line doesn't exceed 80 chars) + `unless` is 
preferred for style reasons (https://github.com/bbatsov/ruby-style-guide)

i.e.

`target = "#{Dir.pwd}/#{srcdir}/po" unless target`

That said, instead of expanding with `Dir.pwd` manually you'd want to 
`File.expand_path("#{srcdir}/po")`. If `srcdir` is already an absolute path it 
will append /po, if it is not it will be turned into an absolute path relative 
to pwd whilest also expanding `~` correctly 
http://ruby-doc.org/core-2.4.0/File.html#method-c-expand_path

Also, in ruby, method params are evaluated as they appear, so since `target` is 
after srcdir you can already deref srcdir.

Putting everything together this can be expressed in the method definition 
without any if:

  def get(srcdir, target = File.expand_path("#{srcdir}/po"),
  allow_edit = true)

> l10n.rb:291
>  
> -if has_translation
> -  # Update CMakeLists.txt
> -  CMakeEditor.append_po_install_instructions!(Dir.pwd, 'po')
> -else
> -  # Remove the empty translations directory
> -  Dir.delete('po')
> +if allow_edit
> +if has_translation

I think the ifs here need to be moved inside out.

  if has_translations
 cmakeappendcrap if allow_edit
  else
 Dir.delete('po')
  end

(allow_edit shouldn't have an impact on cleaning up the dangling po dir)

REPOSITORY
  R572 releaseme

REVISION DETAIL
  https://phabricator.kde.org/D5133

To: apol, #frameworks, sitter

D5134: Don't exit if $DISPLAY is not set

2017-03-22 Thread Albert Astals Cid 
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The fact that kinit was build with X11 doesn't mean it will be using X11 at 
runtime

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5134

AFFECTED FILES
  src/kdeinit/kinit.cpp
  src/wrapper.cpp

To: aacid
Cc: #frameworks

D5133: Introduce fetchpo.rb

2017-03-22 Thread Aleix Pol Gonzalez 
apol created this revision.

REVISION SUMMARY
  Adds an executable that will allow to retrieve translations for a checked out
  project.

TEST PLAN
  tests still pass

REPOSITORY
  R572 releaseme

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5133

AFFECTED FILES
  fetchpo.rb
  lib/releaseme/l10n.rb
  lib/releaseme/l10nstatistics.rb
  test/test_l10n.rb

To: apol, #frameworks, sitter

D4799: Delay notifications until desktop session has loaded

2017-03-22 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D4799: Delay notifications until desktop session has loaded

2017-03-22 Thread Valerio Pilo 
vpilo added a comment.


  Ping
  
  [my excuses if it's not good practice to do so]

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 380 - Unstable!

2017-03-22 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/380/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 22 Mar 2017 13:12:01 +
Build duration: 2 min 25 sec

CHANGE SET
Revision 088a79d131f7e192724978566e67b26b30632674 by Marco Martin: (correct 
maskRequestedPrefix when no prefix is used)
  change: edit src/plasma/framesvg.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.plasma-dialogstatetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5024/11933 
(42%)CONDITIONAL 2746/9020 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1064/1133 
(94%)CONDITIONAL 669/1358 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 
(31%)CONDITIONAL 325/1354 (24%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 
(47%)CONDITIONAL 988/2673 (37%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 
(56%)CONDITIONAL 431/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 553/1846 
(30%)CONDITIONAL 305/1433 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1209 (1%)CONDITIONAL 
1/988 (0%)

D4921: [Menu] Harmonize openRelative placement

2017-03-22 Thread Roman Gilg 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:28ad7879d3e6: [Menu] Harmonize openRelative placement 
(authored by subdiff).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4921?vs=12126=12681

REVISION DETAIL
  https://phabricator.kde.org/D4921

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: subdiff, #plasma, hein
Cc: #frameworks, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 379 - Fixed!

2017-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/379/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 22 Mar 2017 10:21:51 +
Build duration: 3 min 3 sec

CHANGE SET
Revision 28ad7879d3e62da1f2145c552234546a8ff1337f by subdiff: ([Menu] Harmonize 
openRelative placement)
  change: edit src/declarativeimports/plasmacomponents/qmenu.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5061/11933 
(42%)CONDITIONAL 2747/9014 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1088/1133 
(96%)CONDITIONAL 684/1358 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 
(31%)CONDITIONAL 325/1354 (24%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1673/3556 
(47%)CONDITIONAL 969/2667 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 
(56%)CONDITIONAL 431/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 565/1846 
(31%)CONDITIONAL 310/1433 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1209 (1%)CONDITIONAL 
1/988 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 379 - Fixed!

2017-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/379/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 22 Mar 2017 10:21:51 +
Build duration: 3 min 3 sec

CHANGE SET
Revision 28ad7879d3e62da1f2145c552234546a8ff1337f by subdiff: ([Menu] Harmonize 
openRelative placement)
  change: edit src/declarativeimports/plasmacomponents/qmenu.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5061/11933 
(42%)CONDITIONAL 2747/9014 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1088/1133 
(96%)CONDITIONAL 684/1358 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 
(31%)CONDITIONAL 325/1354 (24%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1673/3556 
(47%)CONDITIONAL 969/2667 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 
(56%)CONDITIONAL 431/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 565/1846 
(31%)CONDITIONAL 310/1433 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1209 (1%)CONDITIONAL 
1/988 (0%)

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-03-22 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129983/#review102932
---




src/ioslaves/file/kauth/file.actions (lines 1 - 5)


I don't see the advantage of using a single kauth action. This way you are 
generating only one "generic" polkit action that you can either enable or 
disable. Instead if we used one polkit action per operation (del, rmdir, etc.) 
we could allow a more fine-grained control. For example, a sysadmin could 
decide that the users can create files in write protected locations, but they 
cannot delete existing files.


- Elvis Angelaccio


On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129983/
> ---
> 
> (Updated March 14, 2017, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> This is regarding the GSOC idea 
> https://community.kde.org/GSoC/2017/Ideas#Project:_Polkit_support_in_KIO.
> 
> This patch intends to demonstrate one possible approach to provide polkit 
> support in kio. Here its only for the delete operation. This is based on the 
> patch in task https://phabricator.kde.org/T5070.
> 
> The approach is as follows;
> 1. Whenever file ioslave gets access denied error it calls the method 
> *execWithRoot* with the action that requires priviledge, the path of items
>upon which action needs to be performed and a warning ID as arguments.
> 2. *execWithRoot* then executes the KAuth::Action *org.kde.kio.file.execute*. 
> 3. This Kauth::Action has its Persistence set too 'session'. This means that 
> after authentication the restrictions are dropped for a while, for
>about 5 minutes. This is similar to the behaviour of sudo command.
> 4. During this time we can perform any action as a privileged user without 
> any authentication. So to prevent any mishap i added a warning box which
>would popup before performing any action(only during this period).
> 5. After the said time interval the root privileges are droped and calling 
> *execWithRoot* should show the usual authentication dialog.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/file/CMakeLists.txt b9132ce 
>   src/ioslaves/file/file.h 109ea80 
>   src/ioslaves/file/file.cpp eaf6c88 
>   src/ioslaves/file/file_unix.cpp 82eb11a 
>   src/ioslaves/file/kauth/CMakeLists.txt PRE-CREATION 
>   src/ioslaves/file/kauth/file.actions PRE-CREATION 
>   src/ioslaves/file/kauth/helper.h PRE-CREATION 
>   src/ioslaves/file/kauth/helper.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129983/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> warning dialog
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/03/09/d42570e8-aedf-4c02-801e-362a68755c2c__polkit_integration.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>