D5104: Error page, correctly load the image (with a real URL)
ltoscano added a comment. Thanks for checking: with this patch you should not see the error that I reported in the summary/commit message. Is it the case? If it is, I guess that the patch can go in. It's interesting to note that I have the same issue that you reported on one of my two machines; it works on the other. Same operating system, same configuration, same kdesrc-build O.o. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D5104 To: ltoscano Cc: mpyne, #frameworks
D5160: Set implicit size from source size for image/SVG URL sources.
drosca added a comment. You don't reset the implicitSize anywhere, so if you do setSource(QImage) and then setSource(QIcon) it will still have the implicitSize of the previously set QImage. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5160 To: hein, #plasma, mart, davidedmundson Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5160: Set implicit size from source size for image/SVG URL sources.
hein updated this revision to Diff 12755. hein added a comment. Always update implicit size. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5160?vs=12752&id=12755 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5160 AFFECTED FILES src/declarativeimports/core/iconitem.cpp To: hein, #plasma, mart, davidedmundson Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5160: Set implicit size from source size for image/SVG URL sources.
hein added a comment. That was me being sleepy and trying to be smart and cunning and avoid busywork :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5160 To: hein, #plasma, mart, davidedmundson Cc: drosca, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5160: Set implicit size from source size for image/SVG URL sources.
hein added a dependent revision: D5162: Port custom image mode to IconItem.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5160 To: hein, #plasma, mart, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5160: Set implicit size from source size for image/SVG URL sources.
hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This allows users of IconItem to know the aspect ratio of the source document, which can be used to size the item or set applet size hints to accomodate non-square images better. This will be used in a patch to Kicker/Dashboard that ports a use of Image in its CompactRepresentation to IconItem to get the hover highlight effect even for a custom button image. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5160 AFFECTED FILES src/declarativeimports/core/iconitem.cpp To: hein, #plasma, mart, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D3987: Use nullptr in all Frameworks (just diff in KIO shown here)
kossebau closed this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D3987 To: kfunk, #frameworks, dfaure, kossebau Cc: skelly, kossebau, dfaure, graesslin
D3987: Use nullptr in all Frameworks (just diff in KIO shown here)
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D3987#96434, @kfunk wrote:
> In https://phabricator.kde.org/D3987#96418, @kossebau wrote:
>
> > In https://phabricator.kde.org/D3987#95858, @kfunk wrote:
> >
> > > Closing. This Diff refactored the code technically correct.
> >
> >
> > Technically correct, as in: it builds.
> > But semantically it is incorrect and a regression when it comes to
flags, especially as high level languages are made for humans in the first
line, not compilers ;)
>
>
> Not true, the patch does /not/ change behavior. See explanation in
https://phabricator.kde.org/D3987#78426.
Na, I meant, for the human reader it is semantically incorrect to pass a
(null) pointer as value for a set of bitflags :) Type mismatch in human brain :)
(additional false brain alarm when one knows QFlags stores using an `int`,
which we learnt in school to not always have bitsize of pointer type)
(Personally I count that QFlags constructor hack for dealing with literal 0
values by that pointer-type overload an example of a hack blowing up with
language changes,
and now feeding nonsense stuff into the dependencies, next to bogus API dox
in Qt itself, "zero must be a literal 0 value." when the default value shown
right above is Q_NULLPTR, and compilers starting to complain about literal 0
being used (http://doc.qt.io/qt-5/qflags.html#QFlags-2). And my bug filed got
instantly bounced, API quality seems to be not a shared value among everyone...
tss...
>>> If you want to replace `MyFlags flags = nullptr` by `... = {}` please do
so in a follow-up patch/review.
>>
>> Seems you do not see yourself in the duty to do the fix-up. so I have to
scratch this itch myself, tss :)
>
> Yes, honestly I think either way is fine (`nullptr` or `{}`). Get... used
to the new look I'd say ;)
Eh, I am too old to add another code-reading exception to my stable brain,
but too young yet to not stand up and fight non-sense ;) Also have I had to
explain too many artifacts in code to too many beginners, so I rather invest my
free time into sane code ;)
So will soon make contact with that clang-tidy then, openSUSE not having it
as package invites me anyway to build/run from sources...
Revision hopefully now unlocked for closing by selecting "Accept Revision"
action, too bad I could not convince you to improve this yourself :)
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D3987
To: kfunk, #frameworks, dfaure, kossebau
Cc: skelly, kossebau, dfaure, graesslin
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
kfunk added inline comments. INLINE COMMENTS > config-kioslave-file.h.cmake:13 > > +/* Defined if st_birthime is defined */ > +#cmakedefine01 HAVE_ST_BIRTHTIME Note: typo REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: kfunk, emmanuelp, #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
tcberner updated this revision to Diff 12745. tcberner added a comment. Fix typo. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12744&id=12745 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED FILES src/ioslaves/file/CMakeLists.txt src/ioslaves/file/config-kioslave-file.h.cmake src/ioslaves/file/file.cpp To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: kfunk, emmanuelp, #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
tcberner updated this revision to Diff 12744. tcberner added a comment. Add `#cmakedefine01 HAVE_ST_BIRTHTIME` to `config-kioslave-file.h.cmake` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12743&id=12744 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED FILES src/ioslaves/file/CMakeLists.txt src/ioslaves/file/config-kioslave-file.h.cmake src/ioslaves/file/file.cpp To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: emmanuelp, #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
tcberner updated this revision to Diff 12743. tcberner added a comment. Use cmake to check for `st_birthime`. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5138?vs=12704&id=12743 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 AFFECTED FILES src/ioslaves/file/CMakeLists.txt src/ioslaves/file/file.cpp To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: emmanuelp, #frameworks
D5143: Introduce fetch-translations build command
sitter added a comment. A couple of things I am not sure about - defaults to stable translations, I'd say it should default to trunk. e.g. playground and kdereview don't even have stable - considering one has to enable this feature in the cmakecache I think it should be made a dependency of target all. having to manually enable the feature and then also manually run fetch-translations seems a bit meh, at least on first run, on subsequent runs with $build/po/ present I'd agree with it not fetching everything again. Lastly, you need to retrigger cmake after the fetchpo.rb script was run. ki18n_install uses a GLOB to find all languages, but that GLOB is only refreshed on cmake runs, so the first time it GLOBS there is nothing and once fetch-translations was run the user needs to manually run cmake again to make the GLOB actually find something. So what happens is: git clone kde:ksysguard mkdir ksysguard/build cd ksysguard/build cmake .. -DKDE_L10N...etc make fetch-translations cmake .. # excess cmake call necessary to actually be able to build the now fetched translations make make install It's also pretty bad because ki18n doesn't actually tell you about the problem but simply doesn't build the translations and then you have people like me going ❓❓😱❓❓ INLINE COMMENTS > apol wrote in KDECMakeSettings.cmake:302 > A first approach used it, I decided to remove it because it didn't add much... Fair enough. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5143 To: apol, #frameworks, #build_system, kfunk, aacid, ltoscano Cc: sitter
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 381 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/381/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 23 Mar 2017 14:23:34 + Build duration: 12 min CHANGE SET Revision 244baaf928645e79a8e4ceb9c8cde67659523c28 by Marco Martin: (add a new property in containment, for an edit mode) change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp change: edit src/scriptengines/qml/plasmoid/containmentinterface.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5059/11940 (42%)CONDITIONAL 2765/9022 (31%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1087/1133 (96%)CONDITIONAL 683/1358 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 (31%)CONDITIONAL 325/1354 (24%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 (47%)CONDITIONAL 988/2673 (37%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 (56%)CONDITIONAL 431/1064 (41%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 565/1846 (31%)CONDITIONAL 310/1433 (22%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1216 (1%)CONDITIONAL 1/990 (0%)
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 381 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/381/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 23 Mar 2017 14:23:34 + Build duration: 12 min CHANGE SET Revision 244baaf928645e79a8e4ceb9c8cde67659523c28 by Marco Martin: (add a new property in containment, for an edit mode) change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp change: edit src/scriptengines/qml/plasmoid/containmentinterface.h JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5059/11940 (42%)CONDITIONAL 2765/9022 (31%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1087/1133 (96%)CONDITIONAL 683/1358 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 (31%)CONDITIONAL 325/1354 (24%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 (47%)CONDITIONAL 988/2673 (37%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 (56%)CONDITIONAL 431/1064 (41%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 565/1846 (31%)CONDITIONAL 310/1433 (22%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1216 (1%)CONDITIONAL 1/990 (0%)
D5153: add a new property in containment, for an edit mode
This revision was automatically updated to reflect the committed changes. Closed by commit R242:244baaf92864: add a new property in containment, for an edit mode (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5153?vs=12733&id=12735 REVISION DETAIL https://phabricator.kde.org/D5153 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/containmentinterface.h To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 383 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/383/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 23 Mar 2017 14:23:34 + Build duration: 2 min 53 sec CHANGE SET Revision 244baaf928645e79a8e4ceb9c8cde67659523c28 by Marco Martin: (add a new property in containment, for an edit mode) change: edit src/scriptengines/qml/plasmoid/containmentinterface.h change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.plasma-dialogstatetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5024/11940 (42%)CONDITIONAL 2746/9022 (30%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1064/1133 (94%)CONDITIONAL 669/1358 (49%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 683/2187 (31%)CONDITIONAL 325/1354 (24%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 (47%)CONDITIONAL 988/2673 (37%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 (56%)CONDITIONAL 431/1064 (41%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 553/1846 (30%)CONDITIONAL 305/1433 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1216 (1%)CONDITIONAL 1/990 (0%)
kde-frameworks-devel@kde.org
mwolff added a comment. Yes, please reserve it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5102 To: sars, #kate, #ktexteditor, dhaumann Cc: mwolff, dhaumann, kwrite-devel, #frameworks
D5153: add a new property in containment, for an edit mode
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editMode REVISION DETAIL https://phabricator.kde.org/D5153 To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5153: add a new property in containment, for an edit mode
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY used for opening the handles when the toolbox is open or potentially other places TEST PLAN handles open REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editMode REVISION DETAIL https://phabricator.kde.org/D5153 AFFECTED FILES src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/containmentinterface.h To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5143: Introduce fetch-translations build command
apol updated this revision to Diff 12732. apol added a comment. Add documentation REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5143?vs=12711&id=12732 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5143 AFFECTED FILES kde-modules/KDECMakeSettings.cmake To: apol, #frameworks, #build_system, kfunk, aacid, ltoscano Cc: sitter
D5143: Introduce fetch-translations build command
apol marked 2 inline comments as done.
apol added a comment.
will send another review with the documentation
INLINE COMMENTS
> sitter wrote in KDECMakeSettings.cmake:302
> I wonder if we shouldn't use `ExternalProject` here. The advantage being that
> cmake would manage the clone and make sure it is updated as necessary.
> Disadvantageously, it doesn't seem to do `depth=1` presently 🐛, so I am not
> sure this would be a net-win.
>
> include(ExternalProject)
> ExternalProject_Add(releaseme
> PREFIX "${CMAKE_BINARY_DIR}/releaseme"
> GIT_REPOSITORY https://anongit.kde.org/releaseme.git
> CONFIGURE_COMMAND ""
> BUILD_COMMAND ""
> INSTALL_COMMAND ""
> )
>
> (NOTE: dependable target would then be `releaseme`, also paths change with
> this)
A first approach used it, I decided to remove it because it didn't add much...
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5143
To: apol, #frameworks, #build_system, kfunk, aacid, ltoscano
Cc: sitter
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
dfaure added a comment. Ah yes OK, the extraction on Linux is indeed not done in those Qt patches either. Nevermind ;) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: emmanuelp, #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
emmanuelp added a comment. In https://phabricator.kde.org/D5138#97024, @adridg wrote: > So, Linux, sort out your *stat(2) interfaces first and we'll get back to you. xstat patches have been merged into 4.11 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: emmanuelp, #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
adridg accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
adridg added a comment. Further to the Linux bits: while ext4 and btrfs have the necessary fields, stat(2) doesn't expose them, xstat(2) doesn't exist yet (see LWN from a few years back), and extracting the info using other tools depends on fun stuff like knowing what kind of filesystem the file resides on (e.g. debugfs is a userland tool that can get the bits, if it's allowed to open the raw filesystem device *and* it's ext[234]). So, Linux, sort out your *stat(2) interfaces first and we'll get back to you. tcberner: points to be had for doing a cmake-time check for the presence of that field, since NetBSD has it as well. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
dfaure added a comment. The comment about ctime is still true ;-) For Linux support, I suppose https://codereview.qt-project.org/167049 has what we need. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
adridg added a comment. Might want to add a comment about "this is the actual inode creation time; support depends on the underlying filesystem (e.g. UFS and ZFS have this information, NFS doesn't)", and change the comment about buff.st_ctime and KDE 2.0. In addition, please insert the creation time information only if buff.st_birthtime is useful. On an FS that doesn't support the information, you'll get 0; but time_t is (on FreeBSD x86 anyway) signed, so 0 or < 0 are in theory legitimate timestamps; for simplicity probably use only positive timestamps. On Linux (replying to DFaure), ext4 supports birthtime (crtime), but stat(2) doesn't have a way to report that information; I'll dig into GNU coreutils a little (e.g. 20 minutes, tops) to see how they get at, and report, the information. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, arrowdodger, rakuco, dfaure, adridg Cc: #frameworks
D5134: Don't exit if $DISPLAY is not set
aacid added a comment. > Kinit if built with X11 is still requiring the DISPLAY variable all over the place. The only solution is to run an X server, even if it is not the X platform As we do on Plasma/Wayland I don't know what you mean by "only solution" because with this change things seem to work fine for me (and I'm not running an X server) Reading the code the only thing that seems I am missing is startup notification. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D5134 To: aacid, graesslin Cc: graesslin, rikmills, lukas, #frameworks
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
arrowdodger accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks
D5143: Introduce fetch-translations build command
sitter added inline comments.
INLINE COMMENTS
> KDECMakeSettings.cmake:74
> # - ``APPLE_SUPPRESS_X11_WARNING`` option since 5.14.0
>
>
> #=
Needs documentation for the l10n awesomeness.
> KDECMakeSettings.cmake:280
> +if(KDE_L10N_DOWNLOAD_TRANSLATIONS)
> +set(_EXTRA_ARGS "ALL")
> +else()
This is not used anywhere, is it?
> KDECMakeSettings.cmake:302
> +
> +add_custom_command(
> +OUTPUT "${CMAKE_BINARY_DIR}/releaseme"
I wonder if we shouldn't use `ExternalProject` here. The advantage being that
cmake would manage the clone and make sure it is updated as necessary.
Disadvantageously, it doesn't seem to do `depth=1` presently 🐛, so I am not
sure this would be a net-win.
include(ExternalProject)
ExternalProject_Add(releaseme
PREFIX "${CMAKE_BINARY_DIR}/releaseme"
GIT_REPOSITORY https://anongit.kde.org/releaseme.git
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND ""
)
(NOTE: dependable target would then be `releaseme`, also paths change with this)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5143
To: apol, #frameworks, #build_system, kfunk, aacid, ltoscano
Cc: sitter
D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Feel like implementing it for Linux, too? ;-) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks
