GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/490/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 02:00:53 +
Build duration: 17 min
CHANGE SET
Revision 8578ef2096212f6eecd8ec809edf59c7436177ab
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/490/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 02:00:53 +
Build duration: 17 min
CHANGE SET
Revision 8578ef2096212f6eecd8ec809edf59c7436177ab
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D5104#97246, @ltoscano wrote:
> Thanks for checking: with this patch you should not see the error that I
reported in the summary/commit message. Is it the
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/175/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 01:11:47 +
Build duration: 3 min 2 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kapidox%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/175/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 01:11:47 +
Build duration: 3 min 2 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kapidox%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 30 Mar 2017 01:11:47 +
Build duration: 2 min 39 sec
CHANGE SET
Revision
mgallien added a comment.
Sorry for the long delay before any actions from me.
Could you update the patch such that one can apply it to the current
filemetadata repository (seems like you are renaming from
kfilemetadata-5.23.0/autotests/samplefiles/testexternalwriter/main.py.old to
apol updated this revision to Diff 12987.
apol added a comment.
Remove unneeded changes
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5167?vs=12931=12987
BRANCH
fetchbuildtime
REVISION DETAIL
https://phabricator.kde.org/D5167
AFFECTED FILES
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
When using a regular JavaScript Array as model and omitting certain roles
(e.g. not having a "text" for a separator) it
mart updated this revision to Diff 12978.
mart added a comment.
- revisions not useful here
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5243?vs=12977=12978
BRANCH
phab/implicitSize
REVISION DETAIL
mart updated this revision to Diff 12977.
mart marked an inline comment as done.
mart added a comment.
- use q_revision
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5243?vs=12975=12977
BRANCH
phab/implicitSize
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:4468076a41f9: explicitly set NO_CMAKE_FIND_ROOT_PATH
(authored by sitter).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5218?vs=12914=12976
REVISION DETAIL
mart updated this revision to Diff 12975.
mart added a comment.
- remove leftover
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5243?vs=12974=12975
BRANCH
phab/implicitSize
REVISION DETAIL
https://phabricator.kde.org/D5243
davidedmundson added inline comments.
INLINE COMMENTS
> iconitem.cpp:89
> {
> +if (m_implicitHeightSetByUser) return;
> if (!m_imageIcon.isNull()) {
this line seems leftover from something?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if the user code did something like
IconItem {
implicitWidth: 32
implicitHeight: 32
}
then never
davidedmundson updated this revision to Diff 12962.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.
Thanks.
Issues addressed
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5208?vs=12892=12962
BRANCH
master
REVISION
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/
---
Review request for KDE Frameworks and Stefan Brüns.
Repository: kwallet
Hi,
I'm trying to make Krita use QSaveFile instead of the home-grown
mess of temporary files that get copied over the original file
after saving succeeded. The problem is that Krita, like Calligra,
uses KArchive. And KArchive, even when a KZip is created with
an existing QIODevice, decides on its
martinkostolny added a comment.
Sure, no problem :).
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4847
To: martinkostolny, dhaumann, #ktexteditor, dfaure
Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin,
davidedmundson, palant,
dhaumann added a comment.
Could you wait with this commit until after the 5.33 tag? Then we have 1
month instead of 3 days to find and fix regressions. The tag will happen this
Saturday. :)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4847
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R159:3e991da0ecac: Fix build with Qt 5.9 (authored by apol).
REPOSITORY
R159 KActivities Statistics
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5233?vs=12944=12954
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R275:e2951a24bab6: Fix build with Qt branch 5.9 (authored by
apol).
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5231?vs=12942=12953
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8d42e0072f46: [ModelContextMenu] Use Instantiator instead
of Repeater-and-reparent-hack (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5231
To: apol, #frameworks, kfunk
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R159 KActivities Statistics
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5233
To: apol, #frameworks, ivan, kfunk
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:70c2485b2684: [KCModuleProxy] Remove dead code (authored
by broulik).
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5056?vs=12490=12948
REVISION DETAIL
dfaure accepted this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4847
To: martinkostolny, dhaumann, #ktexteditor, dfaure
Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin,
davidedmundson, palant, kwrite-devel, #frameworks,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I don't know anything about this code, but if it's dead, it's dead.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D5056
To: broulik, dfaure
Cc: ltoscano,
28 matches
Mail list logo
