cullmann added a comment.
Thanks!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4847
To: martinkostolny, dhaumann, #ktexteditor, dfaure
Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin,
davidedmundson, palant, kwrite-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ae60880c5f9b: KAuth integration in document saving
(authored by martinkostolny).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4847?vs=12941=13049
REVISION
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Thanks for your contribution.
Could you check if other tests in KFileMetaData need also that ?
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
ochurlaud edited the summary of this revision.
ochurlaud added reviewers: kossebau, KDevelop.
REPOSITORY
R264 KApiDox
REVISION DETAIL
https://phabricator.kde.org/D5275
To: ochurlaud, kossebau, #kdevelop
Cc: #frameworks, #documentation, skadinna
ochurlaud created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REPOSITORY
R264 KApiDox
BRANCH
olivier/do_qch
REVISION DETAIL
https://phabricator.kde.org/D5275
AFFECTED FILES
On Sat, 1 Apr 2017, David Faure wrote:
>
> Oh.
>
> Yes I think a qobject_cast(device) might be necessary in
> KArchive, in order to call commit() rather than close().
> That would work, right?
>
> Feel like adding a unittest for this?
Sure, I'll take a look tomorrow.
--
Boudewijn Rempt |
heikobecker created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Allowing the tests to pass without a running X server.
TEST PLAN
Test still passes
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5274
