graesslin added a comment.
In https://phabricator.kde.org/D5405#101628, @stikonas wrote:
> Ok, so let us not change kcoreaddons now although it's still something that
could have better default behaviour in KF6.
My comment was not meant as a stop-this-effort comment. If we can
This revision was automatically updated to reflect the committed changes.
Closed by commit R313:2d9c893adef9: Fix build with Qt 5.9 (authored by apol).
REPOSITORY
R313 KHtml
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5392?vs=13311=13369
REVISION DETAIL
mgallien updated this revision to Diff 13367.
mgallien added a comment.
update copyright
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13366=13367
BRANCH
qtmultimedia
REVISION DETAIL
https://phabricator.kde.org/D5417
AFFECTED FILES
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
the new extractor is not as good as the taglib built one but depend only
on QtMultimedia
the quality of the extraction depends on
stikonas abandoned this revision.
stikonas added a comment.
Ok, so let us not change kcoreaddons now although it's still something that
could have better default behaviour in KF6.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5405
To: stikonas, mpyne,
graesslin added a comment.
In https://phabricator.kde.org/D5405#101626, @ltoscano wrote:
> In https://phabricator.kde.org/D5405#101624, @graesslin wrote:
>
> > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote:
> >
> > > In https://phabricator.kde.org/D5405#101615,
ltoscano added a comment.
In https://phabricator.kde.org/D5405#101624, @graesslin wrote:
> In https://phabricator.kde.org/D5405#101621, @ltoscano wrote:
>
> > In https://phabricator.kde.org/D5405#101615, @graesslin wrote:
> >
> > > The desktop file name should follow the way how
graesslin added a comment.
In https://phabricator.kde.org/D5405#101621, @ltoscano wrote:
> In https://phabricator.kde.org/D5405#101615, @graesslin wrote:
>
> > The desktop file name should follow the way how the dbus name is created.
If the applications are broken, then they are
nalvarez added a comment.
Are you saying the d-bus service name should be equal to the .desktop
filename? I don't see where this requirement comes from.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5405
To: stikonas, mpyne, kossebau, aacid, ltoscano
Cc:
ltoscano added a comment.
In https://phabricator.kde.org/D5405#101615, @graesslin wrote:
> The desktop file name should follow the way how the dbus name is created.
If the applications are broken, then they are broken. Given that I mentioned
this several times at KDE conferences,
graesslin added a comment.
The desktop file name should follow the way how the dbus name is created. If
the applications are broken, then they are broken. Given that I mentioned this
several times at KDE conferences, blogged about it, sent mails to KDE devel
lists I assume the application
ltoscano added a comment.
One thing for sure: the code should be moved back to the constructor, and not
dynamically at each call of desktopFileName(), or it would be a behavioral
change. (Or at least it should be probably cached if we get an agreement in
breaking this).
And regarding
ltoscano added a comment.
In https://phabricator.kde.org/D5405#101577, @kossebau wrote:
> In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
>
> > I'm still confused. Documentation or not, bad usage or not, is it correct
that desktop file name is constructed from both the
stikonas added a comment.
In fact API documentation says explicitely that
> IMPORTANT: if the organization domain is set, the .desktop file that
describes your application should have an entry like
X-DBUS-ServiceName=reversed_domain.kmyapp For instance kwrite passes
ltoscano added a comment.
In https://phabricator.kde.org/D5405#101575, @mak wrote:
> In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
>
> > I'm still confused. Documentation or not, bad usage or not, is it correct
that desktop file name is constructed from both the
stikonas added a comment.
In https://phabricator.kde.org/D5405#101575, @mak wrote:
> In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
>
> > I'm still confused. Documentation or not, bad usage or not, is it correct
that desktop file name is constructed from both the
kossebau added a comment.
In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
> I'm still confused. Documentation or not, bad usage or not, is it correct
that desktop file name is constructed from both the organization domain AND the
homepage?
In the current KAboutData
mak added a comment.
In https://phabricator.kde.org/D5405#101574, @ltoscano wrote:
> I'm still confused. Documentation or not, bad usage or not, is it correct
that desktop file name is constructed from both the organization domain AND the
homepage?
Yes. See
ltoscano added a comment.
I'm still confused. Documentation or not, bad usage or not, is it correct
that desktop file name is constructed from both the organization domain AND the
homepage?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D5405
To: stikonas,
kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.
Having slept over this one night, I still think that this change should be
not the way to go to fix the seen issues.
The actual problem is bad usage in application code,
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Let Karchive be an optional build dependency of KFileMetaData
TEST PLAN
Still build with or without KArchive
REPOSITORY
R286
turbov added a comment.
my 2 cents:
I've used the syntax made by Ernst quite a long time and pretty happy w/ it :)
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5338
To: kfunk, vkrause, kwrite-devel, dhaumann
Cc: turbov, emaurer,
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 12:26:33 +
Build duration: 8 min 4 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 12:26:33 +
Build duration: 8 min 4 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 12:26:33 +
Build duration: 2 min 38 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 12:26:33 +
Build duration: 2 min 38 sec
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 12:03:37 +
Build duration: 12 min
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 12 Apr 2017 12:03:37 +
Build duration: 3 min 3 sec
CHANGE SET
Revision
emaurer added a comment.
> Heya,
>
> indeed, I saw that you had a set of valid keywords. If you're okay with it
I'll just pull them in myself & then push this patch. We can work together on
adding more stuff to it later on, no problem.
sure, feel free to use from mine for a pushing
kfunk added a comment.
In https://phabricator.kde.org/D5338#101466, @emaurer wrote:
> In https://phabricator.kde.org/D5338#100575, @kfunk wrote:
>
> > In https://phabricator.kde.org/D5338#100509, @dhaumann wrote:
> >
> > > Oh, and see this:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130084/
---
(Updated April 12, 2017, 11:39 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130084/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
emaurer added a comment.
In https://phabricator.kde.org/D5338#100575, @kfunk wrote:
> In https://phabricator.kde.org/D5338#100509, @dhaumann wrote:
>
> > Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5
>
>
> What the... Created at almost the exact same time?
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:925ec8a17ffb: always close the downloaded file after
downloading (authored by mart).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5402?vs=13331=13344
REVISION
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Yes, good catch. I am unsure of why that happened, but i quite agree, that
certainly needs to happen whether or not a redirection has been involved.
REPOSITORY
R304 KNewStuff
BRANCH
tcanabrava added a comment.
In https://phabricator.kde.org/D5400#101353, @ltoscano wrote:
> General issue: KCompletion is a tier2 framework, and this introduces a
dependency on KXmlGui, tier3.
I wasn't aware of that - I'll move this to KXmlGui as it makes sense.
REPOSITORY
36 matches
Mail list logo
