mgallien added a reviewer: kfunk.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5443
To: mgallien, kfunk
Cc: #frameworks
kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in kaboutdata.h:314
> Update from irc: both @ltoscano and me could reproduce by patching
> kpartloader or okteta that with some current KF (e.g. 5.32) the i18n calls
> done as part of the KAboutData constructor call seem to fail
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/515/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 14 Apr 2017 01:56:44 +
Build duration: 6 min 15 sec
CHANGE SET
Revision e011b901edd84107598fdd1c39c7588755edde0e
kossebau added inline comments.
INLINE COMMENTS
> ltoscano wrote in kaboutdata.h:314
> To put it straight: I don't know (and I can't investigate properly now). But
> if you create the KAboutData instance before the call to QApplication, part
> of the "About " dialog is untranslated.
Update
kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in kaboutdata.h:314
> Why should it happen before? (sorry for being stubborn and curious here, I
> want to make sure to understand all code, to then also write proper warnings
> in the dox when needed, so people know they should
ltoscano added inline comments.
INLINE COMMENTS
> kossebau wrote in kaboutdata.h:314
> Why should it happen before? (sorry for being stubborn and curious here, I
> want to make sure to understand all code, to then also write proper warnings
> in the dox when needed, so people know they should
kossebau added a subscriber: dfaure.
kossebau added inline comments.
INLINE COMMENTS
> ltoscano wrote in kaboutdata.h:314
> The QApplication instance should happen before this line, not just before
> setApplicationData (that's what Albert was trying to explain).
Why should it happen before?
ltoscano requested changes to this revision.
ltoscano added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kaboutdata.cpp:689
>
> KAboutData ::setOrganizationDomain(const QByteArray )
> {
I would add something like
// KF6: if desktopFileName has not been
kossebau created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Adds an example for setting the metadata of an application using KAboutData
together with KI18n and KDBusAddons.
Extends and improves notes about when and why to set the organizationDomain
apol updated this revision to Diff 13404.
apol added a comment.
AUTHOR_WARNING
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5167?vs=13392=13404
BRANCH
fetchbuildtime
REVISION DETAIL
https://phabricator.kde.org/D5167
AFFECTED FILES
CMakeLists.txt
guoyunhe created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
It is a modified version of SCSS syntax. Major difference is variable start
with @ instead of $. It performs better with LESS' nested
On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote:
> Hello,
>
> I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am
> getting compilation errors in the automatic tests and have an hard time
> getting it to works nominally.
Paste the errors please, maybe we can
kfunk added a comment.
For -Wdate-time:
https://lxr.kde.org/search?_filestring=&_string=__DATE__
https://lxr.kde.org/search?_filestring=&_string=__TIME__
-> Only around ~10 locations affected, mainly Krita/Digikam/Amarok stuff. The
use of __DATE__ & __TIME__ should just be avoided.
kfunk edited the summary of this revision.
kfunk edited the test plan for this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5430
To: kfunk
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
-Wvla: Warn because it's non-standard feature, not supported by MSVC to date
-Wdate-time: Warn because using
Hello,
I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am
getting compilation errors in the automatic tests and have an hard time
getting it to works nominally.
Is there public servers currently testing KDE Frameworks 5 including
KFileMetaData ?
Should I switch to
sitter added inline comments.
INLINE COMMENTS
> KF5I18NMacros.cmake:136
> +function(ki18n_install_ts_files _lang)
> +message(WARNING "KI18N_INSTALL_TS_FILES is deprecated!")
> +ki18n_install(${_lang})
Please use `message(AUTHOR_WARNING ...` this warning has only relevance to a
apol updated this revision to Diff 13392.
apol marked 2 inline comments as done.
apol added a comment.
Address some issues pointed at by sitter
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5167?vs=13118=13392
BRANCH
fetchbuildtime
REVISION DETAIL
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/515/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:49:36 +
Build duration: 19 min
CHANGE SET
Revision 99b3a4c920aee7bdce20f7bfedadf9bb183b8f3c
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/515/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:49:36 +
Build duration: 19 min
CHANGE SET
Revision 99b3a4c920aee7bdce20f7bfedadf9bb183b8f3c
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:99b3a4c920ae: Fix KDirlister Gui Test setting URL scheme
twice (authored by davidedmundson).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5299?vs=13087=13384
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/399/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:01:58 +
Build duration: 4 min 0 sec
CHANGE SET
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/399/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Thu, 13 Apr 2017 11:01:58 +
Build duration: 4 min 0 sec
CHANGE SET
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1387b5efe31e: Guard against Applet not loading
AppletInterface (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
stikonas added a comment.
> ! In https://phabricator.kde.org/D5405#101683, @graesslin wrote:
> My comment was not meant as a stop-this-effort comment. If we can improve
here to do more sane things I'm all for it.
No, it's not your comment. We were discussing this on #kde-devel and it
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D5423
To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks,
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This can happen if an applet has invalid metadata, it doesn't have a
script engine set (X-Plasma-API) so it
27 matches
Mail list logo
