D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

2017-04-23 Thread Andrius Štikonas
stikonas accepted this revision. REPOSITORY R244 KCoreAddons BRANCH improveKAboutDataAPIDox REVISION DETAIL https://phabricator.kde.org/D5439 To: kossebau, #frameworks, aacid, mpyne, ltoscano, stikonas Cc: dfaure

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

2017-04-23 Thread Luigi Toscano
ltoscano accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH improveKAboutDataAPIDox REVISION DETAIL https://phabricator.kde.org/D5439 To: kossebau, #frameworks, aacid, mpyne, ltoscano, stikonas Cc: dfaure

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

2017-04-23 Thread Michael Pyne
mpyne accepted this revision. mpyne added a comment. I think the API dox fixes are fine to go in. We can add i18n-related warnings in a separate patch as you suggest. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5439 To: kossebau, #frameworks, aacid, mpyne,

D5550: Fix property changes being missed immediately after an obejct is added

2017-04-23 Thread David Rosca
drosca created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Fix race condition when property changes may be missed if the property is changed immediately after the object is created. The issue was that the connection to PropertyChanged signal was

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-23 Thread Lamarque Souza
> On April 22, 2017, 10:27 a.m., Lamarque Souza wrote: > > autotests/CMakeLists.txt, line 66 > > > > > > CMake's developers recommend using else() instead of > > else(). The part used to be required with cmake

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-23 Thread KJ Tsanaktsidis
> On April 22, 2017, 10:27 a.m., Lamarque Souza wrote: > > autotests/CMakeLists.txt, line 66 > > > > > > CMake's developers recommend using else() instead of > > else(). The part used to be required with cmake

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-23 Thread KJ Tsanaktsidis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/ --- (Updated April 23, 2017, 9:56 a.m.) Review request for KDE Frameworks.

Re: Review Request 130069: Reproducible builds: drop version from XMLGUI_COMPILING_OS

2017-04-23 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130069/ --- (Updated April 23, 2017, 7:50 a.m.) Status -- This change has been