D5515: Update the ungrabMouse hack for Qt 5.8

anthonyfieroni added a comment. David, it's sould be done in plasma-framework too. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson, #plasma, mart Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr, progwolff,

D5574: Don't set ItemHasContents in DropArea

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D5574 To: davidedmundson, #plasma, aacid Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed,

D5574: Don't set ItemHasContents in DropArea

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY ItemHasContents means we get included in generating the QSG node treeview when we render. This item doesn't

D5573: Don't accept hover events in the DragArea

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We don't actually process hoverEnter/move events, so there's no need to have the overhead of having them sent to

D5556: build: Remove KService dependency

palokisa added a comment. In https://phabricator.kde.org/D5556#104466, @apol wrote: > Yes, do you have commit/push access? Otherwise we'll push it ourselves. As I don't know, what are you talking about... probably not REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabr

D5556: build: Remove KService dependency

apol added a comment. Yes, do you have commit/push access? Otherwise we'll push it ourselves. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: #frameworks

D5556: build: Remove KService dependency

palokisa added a comment. Sorry, I'm not familiar with the phabricator process... should I take some action now? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: #frameworks

D5557: fix basename handling of po files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Lgtm, thanks for the test! INLINE COMMENTS > build-pofiles.cmake:35 > +# https://bugs.kde.org/show_bug.cgi?id=379116 > +string(REGEX REPLACE "^(.+)(\\.[^.]+)$" "\\1" name ${name}) >

D5556: build: Remove KService dependency

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: #frameworks

D5515: Update the ungrabMouse hack for Qt 5.8

This revision was automatically updated to reflect the committed changes. Closed by commit R242:29f1ee385891: Update the ungrabMouse hack for Qt 5.8 (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5515?vs=13747&i

D5515: Update the ungrabMouse hack for Qt 5.8

davidedmundson updated this revision to Diff 13747. davidedmundson added a comment. Rewrote with a runtime check and a link to a qt bug report REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5515?vs=13609&id=13747 BRANCH origin-master (

D5463: Pug/Jade Syntax

guoyunhe updated this revision to Diff 13734. guoyunhe added a comment. Remove mimetype REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5463?vs=13459&id=13734 REVISION DETAIL https://phabricator.kde.org/D5463 AFFECTED FILES data/syntax/pug.

D5463: Pug/Jade Syntax

vkrause added a comment. yep, keep the mimetype field empty in that case REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 22, 2017, 10:27 a.m., Lamarque Souza wrote: > > autotests/CMakeLists.txt, line 66 > > > > > > CMake's developers recommend using else() instead of > > else(). The part used to be required with cmake

D5463: Pug/Jade Syntax

guoyunhe added a comment. I found this part might be a bug in this syntax highlight: mimetype="text/plain" It will highlight all plain text file to pug syntax. Should I just change mimetype to empty? Not sure how to write it for files that don't have registered mimetype. REPOSITO

D5557: fix basename handling of po files

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY get_filename_component(... ... NAME_WE) gets the name without the *longest* extension. in case of 'org.kde.plasma.kittens.po' that would lea