D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

2017-04-25 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R237:3ad00c4e56eb: Fix relativePath calculation in KDesktopFile::locateLocal() (authored by wbauer). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5502?vs=13778=13798

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

2017-04-25 Thread Matthew Dawson
mdawson accepted this revision. mdawson added a comment. This revision is now accepted and ready to land. LGTM! Thanks for working on this. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D5502 To: wbauer, #frameworks, mdawson Cc: mdawson, #frameworks

D5587: Improvements

2017-04-25 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Make sure we don't leak XmlLoader instances Only rewrite the cache if it changed REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5587 AFFECTED FILES

D5573: Don't accept hover events in the DragArea

2017-04-25 Thread Albert Astals Cid
aacid added a comment. What about in the FolderView side? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D5573 To: davidedmundson, #plasma Cc: aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5573: Don't accept hover events in the DragArea

2017-04-25 Thread David Edmundson
davidedmundson added a comment. In https://phabricator.kde.org/D5573#104619, @aacid wrote: > "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this worth adding an auto test somewhere? Maybe, but it'd be testing that an item doesn't do what it had no reason

D5573: Don't accept hover events in the DragArea

2017-04-25 Thread Albert Astals Cid
aacid added a comment. "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this worth adding an auto test somewhere? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D5573 To: davidedmundson, #plasma Cc: aacid, plasma-devel, #frameworks,

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 404 - Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/404/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 25 Apr 2017 14:13:12 + Build duration: 4 min 47 sec CHANGE SET

D5297: [TextFieldStyle] Fix textField is not defined error

2017-04-25 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:884f89b9b038: [TextFieldStyle] Fix textField is not defined error (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

2017-04-25 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R244:f01e8b41f622: API dox: more info about KAboutData's orgDomain/desktopFileName properties (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

2017-04-25 Thread Wolfgang Bauer
wbauer updated this revision to Diff 13778. wbauer added a comment. added more test cases as suggested REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5502?vs=13693=13778 REVISION DETAIL https://phabricator.kde.org/D5502 AFFECTED FILES

Re: KDE Frameworks in Conan.io (et al.)?

2017-04-25 Thread Aleix Pol
On Tue, Apr 25, 2017 at 5:02 AM, Luiz Romário Santana Rios wrote: > Hello, all. > > I don't know if this has been discussed already, but I think it would > be interesting to have some Frameworks available on Conan.io[1]. Conan > is a package manager, much similar to Rust's

D5556: build: Remove KService dependency

2017-04-25 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R268:3670b49d5721: build: Remove KService dependency (authored by apol). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5556?vs=13727=13774 REVISION DETAIL

KDirWatch issue

2017-04-25 Thread Martin Koller
Hi, just wondering if I'm doing something wrong or there really is a bug in KDirWatch (I'm on openSuse Leap 42.2, KF5 5.33.0) From the docs I understand that when I call KDirWatch::stopDirScan(dir); ... create files in the dir ... KDirWatch::restartDirScan(dir) it should not emit the dirty

KDE Frameworks in Conan.io (et al.)?

2017-04-25 Thread Luiz Romário Santana Rios
Hello, all. I don't know if this has been discussed already, but I think it would be interesting to have some Frameworks available on Conan.io[1]. Conan is a package manager, much similar to Rust's Cargo or Python's pip, except it's distributed. Inqlude[2] has something more or less in the same

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 537 - Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/537/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 08:39:00 + Build duration: 7 min 46 sec CHANGE SET No changes JUNIT RESULTS Name:

D5557: fix basename handling of po files

2017-04-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R249:7bce4e812836: fix basename handling of po files (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5557?vs=13728=13770 REVISION DETAIL

D5515: Update the ungrabMouse hack for Qt 5.8

2017-04-25 Thread Anthony Fieroni
anthonyfieroni added a comment. David, it's sould be done in plasma-framework too. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson, #plasma, mart Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr,

D5574: Don't set ItemHasContents in DropArea

2017-04-25 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D5574 To: davidedmundson, #plasma, aacid Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,