D5623: fix build against Android NDK (API Level 21 is required)

mgallien updated this revision to Diff 13901. mgallien added a comment. added a comment and also modify the commit message REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5623?vs=13887=13901 BRANCH master REVISION DETAIL

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128574/ --- (Updated April 27, 2017, 11:59 p.m.) Review request for KDE Frameworks,

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

> On apr 27, 2017, 7:58 p.m., Elvis Angelaccio wrote: > > src/filewidgets/kdirsortfilterproxymodel.cpp, lines 79-81 > > > > > > Please use `m_collator.setNumericMode(m_naturalSorting);` instead. It > > would

D5623: fix build against Android NDK (API Level 21 is required)

apol added a reviewer: Frameworks. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5623 To: mgallien, #android, #frameworks Cc: apol, #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

apol added a comment. +1 LGTM. Maybe you can specify on the commit message that `attr/xattr.h` isn't present on the Android NDK and add a comment on the ifdef wouldn't hurt either. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5623 To: mgallien,

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

> On Nov. 27, 2016, 7:17 p.m., Konstantinos Smanis wrote: > > I can confirm that the patch indeed resolves the natural sorting issue in > > KDirSortFilterProxyModel, which is a logical bug (an omission) introduced > > at some point during the KF5 kio port. It's been there since the initial >

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 559 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/559/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Apr 2017 21:12:04 + Build duration: 2 min 13 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 560 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/560/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Apr 2017 21:12:04 + Build duration: 34 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 559 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/559/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Apr 2017 20:47:34 + Build duration: 28 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 558 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/558/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Apr 2017 20:47:34 + Build duration: 1 min 39 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 557 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/557/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Apr 2017 20:42:34 + Build duration: 27 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 558 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/558/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Apr 2017 20:42:34 + Build duration: 29 sec CHANGE SET Revision

D5455: Extend Programmer's Guide with notes about influence of setlocale()

ilic added a comment. I guess not bad to mention this stuff, but I would make following adaptations: 1. Move the section as subsection of "Controlling Language Of Catalog to Use", and give it a more focused ( title, e.g. "Placing i18n calls before creation of QCoreApplication". 2.

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128574/#review103143 --- Fix it, then Ship it! This is clearly a porting bug. The

D5623: fix build against Android NDK (API Level 21 is required)

mgallien added a reviewer: Android. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5623 To: mgallien, #android Cc: #frameworks

D5623: fix build against Android NDK (API Level 21 is required)

mgallien created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY fix build against Android NDK (API Level 21 is required) TEST PLAN Test compilation under linux and Android REPOSITORY R286

Heads-up : automoc changes in CMake 3.8

Hi, CMake 3.8 comes with a change that could break compilation under certain circumstances.(*) in CMake < 3.8, automoc'ed files are stored in . Starting with CMake 3.8, they're now created in : /_autogen/include What does it change ? In most cases, nothing. moc files will be re-created. The

Re: Review Request 128672: some fixes for javascript Math object

> On des. 21, 2016, 10:24 p.m., Albert Astals Cid wrote: > > src/kjs/math_object.cpp, line 112 > > > > > > Why this change? > > Viktor Mv wrote: > `1.0 / log(10.0)` gives `0.43429448190325176`, not

Re: Review Request 128672: some fixes for javascript Math object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128672/#review103139 --- This code clearly misses some tests. I'm also concerned

D5455: Extend Programmer's Guide with notes about influence of setlocale()

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks a bit convoluted way of explaining not to use i18n before Q*Application, but i guess it works :) REPOSITORY R249 KI18n BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL

D5605: Allow multiple categories with the same name

davidedmundson added inline comments. INLINE COMMENTS > atticaprovider.cpp:129 > qCDebug(KNEWSTUFFCORE) << "Adding category: " << category.name() > << category.displayName(); > -mCategoryMap[category.name()] = category; > +

Re: Review Request 128672: some fixes for javascript Math object

> On Dec. 21, 2016, 9:24 p.m., Albert Astals Cid wrote: > > src/kjs/math_object.cpp, line 112 > > > > > > Why this change? `1.0 / log(10.0)` gives `0.43429448190325176`, not `0.4342944819032518` - Viktor

D5573: Don't accept hover events in the DragArea

This revision was automatically updated to reflect the committed changes. Closed by commit R296:3743d6400da9: Don't accept hover events in the DragArea (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5573?vs=13766=13881

D5574: Don't set ItemHasContents in DropArea

This revision was automatically updated to reflect the committed changes. Closed by commit R296:dec0d3d1c4f5: Don't set ItemHasContents in DropArea (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5574?vs=13767=13882 REVISION

D5455: Extend Programmer's Guide with notes about influence of setlocale()

kossebau added a comment. ping? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 404 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/404/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 27 Apr 2017 13:59:31 + Build duration: 4 min 29 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 404 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/404/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 27 Apr 2017 13:59:31 + Build duration: 4 min 29 sec CHANGE SET Revision

D5603: Install Plasma Components 3 so they can be used

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d3ed006a1fa4: Install Plasma Components 3 so they can be used (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5615: fix include path in KF5PackageMacros.cmake

jriddell abandoned this revision. jriddell added a comment. submitted REVISION DETAIL https://phabricator.kde.org/D5615 To: jriddell, #frameworks, mart Cc: apol

D5615: fix include path in KF5PackageMacros.cmake

jriddell added a comment. works if I add a .cmake to the end of the include() value REVISION DETAIL https://phabricator.kde.org/D5615 To: jriddell, #frameworks, mart Cc: apol

D5615: fix include path in KF5PackageMacros.cmake

jriddell updated this revision to Diff 13865. jriddell added a comment. without changing include path CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5615?vs=13863=13865 REVISION DETAIL https://phabricator.kde.org/D5615 AFFECTED FILES KF5PackageMacros.cmake To: jriddell,

D5615: fix include path in KF5PackageMacros.cmake

apol added inline comments. INLINE COMMENTS > KF5PackageMacros.cmake:4 > +set(CMAKE_MODULE_PATH ${ECM_KDE_MODULE_DIR}) > include(KDEInstallDirs) > How about `include(${ECM_KDE_MODULE_DIR}/KDEInstallDirs)`? This way we don't mess with CMAKE_MODULE_PATH. REPOSITORY R290 KPackage REVISION

D5611: [RenameDialog] Enforce plain text format

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5611 To: broulik, kde-frameworks-devel, apol Cc: #frameworks

D5615: fix include path in KF5PackageMacros.cmake

jriddell created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY KF5PackageMacros.cmake uses ECM without setting the include path so it can't be found. This isn't usually seen as usually something else will set the path before this.

D5611: [RenameDialog] Enforce plain text format

broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN Created a file named `hello` and no longer get my dialog broken by it formatting the file name in huge letters :) REPOSITORY R241 KIO REVISION

D5603: Install Plasma Components 3 so they can be used

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks, awesome now =) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5603 To: davidedmundson, #plasma, mart Cc: mart,