D5455: Extend Programmer's Guide with notes about influence of setlocale()

2017-05-06 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R249:db45cf7242d7: Extend Programmer's Guide with notes about influence of setlocale() (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D5455: Extend Programmer's Guide with notes about influence of setlocale()

2017-05-06 Thread Chusslove Illich
ilic accepted this revision. ilic added a comment. All good to me. REPOSITORY R249 KI18n BRANCH addNoteAboutGettextLocaleIssuse REVISION DETAIL https://phabricator.kde.org/D5455 To: kossebau, #frameworks, ilic, aacid Cc: aacid

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-05-06 Thread Ben Cooksley
> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. This patch broke the MSVC build and will be reverted shortly.

D5455: Extend Programmer's Guide with notes about influence of setlocale()

2017-05-06 Thread Friedrich W. H. Kossebau
kossebau added a comment. In https://phabricator.kde.org/D5455#107095, @kossebau wrote: > BTW, the `` and `\ref x` seems not to work (only reused that for consistency), will do a separate patch later which follows instructions from

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 413 - Unstable!

2017-05-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/413/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 06 May 2017 13:03:50 + Build duration: 12 min CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 412 - Unstable!

2017-05-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/412/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 06 May 2017 13:03:50 + Build duration: 12 min CHANGE SET Revision

Re: KConfigDialogManager and QButtonGroup

2017-05-06 Thread Martin Koller
On Samstag, 6. Mai 2017 13:48:00 CEST David Faure wrote: > On samedi 6 mai 2017 11:41:41 CEST Martin Koller wrote: > > On Samstag, 6. Mai 2017 11:20:06 CEST David Faure wrote: > > > On lundi 1 mai 2017 20:31:28 CEST Martin Koller wrote: > > > > from Qt4 days, where the groupBox > > > > did also

Re: KConfigDialogManager and QButtonGroup

2017-05-06 Thread David Faure
On samedi 6 mai 2017 11:41:41 CEST Martin Koller wrote: > On Samstag, 6. Mai 2017 11:20:06 CEST David Faure wrote: > > On lundi 1 mai 2017 20:31:28 CEST Martin Koller wrote: > > > from Qt4 days, where the groupBox > > > did also manage the buttons, whereby now you need a QButtonGroup class. > > >

D5725: Workaround for MSVC and catalog loading

2017-05-06 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R238:b308f0cdb338: Workaround for MSVC and catalog loading (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5725?vs=14182=14198 REVISION DETAIL

D5725: Workaround for MSVC and catalog loading

2017-05-06 Thread Ben Cooksley
bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Code looks fine from my perspective, let's confirm this fixes things. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D5725 To: ltoscano,

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread Ben Cooksley
On Sat, May 6, 2017 at 10:15 PM, Elvis Angelaccio wrote: > On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote: >> >> Hi everyone, >> >> This is going to be quite a long email, my apologies in advance for that. >> If you use the CI system regularly as part of your

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread Elvis Angelaccio
On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote: Hi everyone, This is going to be quite a long email, my apologies in advance for that. If you use the CI system regularly as part of your development flow it is important you read this email in it's entirety as your action will probably

Re: KConfigDialogManager and QButtonGroup

2017-05-06 Thread Martin Koller
On Dienstag, 2. Mai 2017 11:30:04 CEST Albert Astals Cid wrote: > El dilluns, 1 de maig de 2017, a les 20:31:28 CEST, Martin Koller va escriure: > > Hi, > > > > trying to fix https://bugs.kde.org/show_bug.cgi?id=378930 > > > > I see that the mboxresource has a configuration dialog which uses > >

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread René J . V . Bertin
On Saturday May 06 2017 22:01:58 Ben Cooksley wrote: >On Sat, May 6, 2017 at 9:58 PM, René J.V. Bertin wrote: >> On Saturday May 06 2017 21:37:51 Ben Cooksley wrote: >> >>>'Platforms' on which they build. At the moment we have three Platforms >>>available: Ubuntu Xenial Qt

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread Ben Cooksley
On Sat, May 6, 2017 at 9:58 PM, René J.V. Bertin wrote: > On Saturday May 06 2017 21:37:51 Ben Cooksley wrote: > >>'Platforms' on which they build. At the moment we have three Platforms >>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7. >>Adding additional

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread René J . V . Bertin
On Saturday May 06 2017 21:37:51 Ben Cooksley wrote: >'Platforms' on which they build. At the moment we have three Platforms >available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7. >Adding additional Platforms to this mix is fairly easy, as long as the >code can be built there. Qt

Re: KConfigDialogManager and QButtonGroup

2017-05-06 Thread Martin Koller
On Samstag, 6. Mai 2017 11:20:06 CEST David Faure wrote: > On lundi 1 mai 2017 20:31:28 CEST Martin Koller wrote: > > from Qt4 days, where the groupBox > > did also manage the buttons, whereby now you need a QButtonGroup class. > > That's a Qt3-Qt4 change, not a Qt4-Qt5 change ;) Now you see how

Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread Ben Cooksley
Hi everyone, This is going to be quite a long email, my apologies in advance for that. If you use the CI system regularly as part of your development flow it is important you read this email in it's entirety as your action will probably be required. If you are aware of a list I have missed in the

D5639: Internal cache for provider data on initialisation

2017-05-06 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > engine.cpp:196 > +XmlLoader *loader = > EngineProviderLoaders()->localData().value(m_providerFileUrl); > +if(loader) { > +qCDebug(KNEWSTUFFCORE) << "Duplicate xml loader for this url, so > use that" <<

Re: Android bulding guide

2017-05-06 Thread David Faure
On jeudi 4 mai 2017 17:19:57 CEST Fernando Theirs wrote: > Hi everyone! > > I'm working with Qt and I have to port a Linux application to Android. > Basically I need to manage some compressed files (targz, zip, among others) > and in Qt Forum they recommend me to use KArchive. > > I started

Re: KConfigDialogManager and QButtonGroup

2017-05-06 Thread David Faure
On lundi 1 mai 2017 20:31:28 CEST Martin Koller wrote: > from Qt4 days, where the groupBox > did also manage the buttons, whereby now you need a QButtonGroup class. That's a Qt3-Qt4 change, not a Qt4-Qt5 change ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-06 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > httpworker.cpp:41 > +QStorageInfo storageInfo(cacheLocation); > +cache.setMaximumCacheSize(storageInfo.bytesTotal() / 1000); > +

Re: KDirWatch issue

2017-05-06 Thread David Faure
On mercredi 3 mai 2017 12:05:47 CEST Albert Astals Cid wrote: > El dimecres, 3 de maig de 2017, a les 11:53:02 CEST, Albert Astals Cid va > > escriure: > > El dilluns, 24 d’abril de 2017, a les 20:08:26 CEST, Martin Koller va > > > > escriure: > > > Hi, > > > > > > just wondering if I'm doing

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 168 - Fixed!

2017-05-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/168/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 06 May 2017 08:16:36 + Build duration: 1 min 34 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 168 - Fixed!

2017-05-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/168/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 06 May 2017 08:16:36 + Build duration: 1 min 34 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 410 - Fixed!

2017-05-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/410/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 06 May 2017 06:11:44 + Build duration: 4 min 55 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 410 - Fixed!

2017-05-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/410/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 06 May 2017 06:11:44 + Build duration: 4 min 55 sec CHANGE SET No

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 410 - Fixed!

2017-05-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/410/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 06 May 2017 06:11:44 + Build duration: 5 min 6 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 410 - Fixed!

2017-05-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/410/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 06 May 2017 06:11:44 + Build duration: 5 min 6 sec CHANGE SET No changes