jgrulich added a comment.
Looks good, it really doesn't make sense to use pid when running app in
flatpak, because you cannot guarantee what pid it will get and without that you
cannot allow dbus access in app's flatpak manifest.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
graesslin requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr,
graesslin added a comment.
In https://phabricator.kde.org/D5757#108115, @mart wrote:
> In https://phabricator.kde.org/D5757#108070, @graesslin wrote:
>
> > Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
>
>
> isn't it covered by
no,
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/540/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 09 May 2017 04:39:27 +
Build duration: 6 min 16 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/540/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 09 May 2017 04:39:27 +
Build duration: 6 min 16 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/556/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 09 May 2017 04:39:36 +
Build duration: 1 min 12 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/556/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 09 May 2017 04:39:36 +
Build duration: 1 min 12 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
patrickelectric abandoned this revision.
patrickelectric added a comment.
Problem solved with
https://phabricator.kde.org/R266:2b49fafc60235a83ffd8b92a24f800d622cc3050
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5646
To: patrickelectric, #kate, andreaska
mart updated this revision to Diff 14320.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- since 5.35
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14276=14320
BRANCH
phab/abovebelow
mart updated this revision to Diff 14311.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
apply workaround when we have only parentItem
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kdewebkit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/555/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 19:48:29 +
Build duration: 5.5 sec
CHANGE SET
No changes
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/539/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 19:33:48 +
Build duration: 1 min 53 sec
CHANGE SET
No changes
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/553/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 19:19:32 +
Build duration: 5 min 52 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/553/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 19:19:32 +
Build duration: 5 min 52 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ecee5fc8e3cc: fix build against Android NDK (API Level 21
is required) (authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
apol edited the test plan for this revision.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:416c7e9facf9: Change default pkgconfig install path for
FreeBSD (authored by tcberner).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Well, for me that looks good now
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk,
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Flatpak requests us to list the services that will be exposed to the outside,
better have it the name of the application without a random number in the end.
In these systems the pid doesn't add
mkoller created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch basically delays the connect to the layoutChanged model signal
until it emits its completed() signal.
Therefore the many calls
mart added a comment.
In https://phabricator.kde.org/D5757#108070, @graesslin wrote:
> Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
isn't it covered by
QTest::newRow("keepAbove") << ::keepAboveRequested <<
davidedmundson added a comment.
looks sensible.
Is this only needed for a specific version of Qt? In either case can you
check on the Qt 5.7 machine.
INLINE COMMENTS
> qmenu.cpp:112
> +
> +QQuickItem *item = qobject_cast(m_visualParent.data());
> +if (item) {
there's a
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5745
To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg,
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg,
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
this ensure two things:
- submenus have the main menu as transientParent
- the visualParent window() is used as
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
tcberner marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system
tcberner updated this revision to Diff 14296.
tcberner added a comment.
- Turn around cases of the if-clause.
- Fix cmake `matches` -> `MATCHES`.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5766?vs=14285=14296
BRANCH
master
REVISION
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart,
El dilluns, 8 de maig de 2017, a les 17:32:35 CEST, David Faure va escriure:
> On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote:
> > > I think the point is that we *want* the notification to happen after
> > > restartDirScan, in the cases where stopDirScan/restartDirScan is used.
> >
> >
On lundi 8 mai 2017 16:14:47 CEST Albert Astals Cid wrote:
> > I think the point is that we *want* the notification to happen after
> > restartDirScan, in the cases where stopDirScan/restartDirScan is used.
>
> No, we actually have a test that proves that we get to signal after
> restartDirScan
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system
kfunk added inline comments.
INLINE COMMENTS
> ECMGeneratePkgConfigFile.cmake:172
>if(EGPF_INSTALL)
> -set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE
> PATH "The directory where pkgconfig will be installed to.")
> +if(NOT CMAKE_SYSTEM_NAME matches "FreeBSD")
El dissabte, 6 de maig de 2017, a les 10:44:42 CEST, David Faure va escriure:
> On mercredi 3 mai 2017 12:05:47 CEST Albert Astals Cid wrote:
> > El dimecres, 3 de maig de 2017, a les 11:53:02 CEST, Albert Astals Cid va
> >
> > escriure:
> > > El dilluns, 24 d’abril de 2017, a les 20:08:26 CEST,
tcberner updated this revision to Diff 14285.
tcberner added a comment.
Drop space after `if`.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5766?vs=14284=14285
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5766
AFFECTED
tcberner created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
FreeBSD, opposed to most other sytems, does not install pkgconfig files to
lib/pkgconfig, but to
Matthieu Gallien ha scritto:
> Hello,
>
> Currently KFileMetaData is a tier 2 framework even when you remove all
> optional dependencies on other frameworks due to a dependency on ki18n.
>
> I would like to know if people think it would be possible to transition it to
> depend on Qt for i18n
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5623
To: mgallien, #android, #frameworks, apol
Cc: apol, #frameworks
Hello,
Currently KFileMetaData is a tier 2 framework even when you remove all
optional dependencies on other frameworks due to a dependency on ki18n.
I would like to know if people think it would be possible to transition it to
depend on Qt for i18n so as to lower its tier ?
Currently, ki18n
mart updated this revision to Diff 14276.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
autotest
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14273=14276
BRANCH
phab/abovebelow
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
You also still need to extend PlasmaWindowModel and the unit tests.
Everywhere in the kwayland codebase requestToggleMinimized pops up should also
have a codepath for these new ones.
mart updated this revision to Diff 14273.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- since 5.35
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14263=14273
BRANCH
phab/abovebelow
hein requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein
Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed,
mgallien added a comment.
Ping
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5623
To: mgallien, #android, #frameworks
Cc: apol, #frameworks
hein added inline comments.
INLINE COMMENTS
> plasmawindowmanagement.h:407
> +
> +/**
> + * Requests the window at this model row index have its keep above state
> toggled.
All these need @since
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart,
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
client requests to toggle those states, to be used by libtaskmanager
TEST PLAN
setting keep above from the
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/567/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 06:16:43 +
Build duration: 1 min 10 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kactivities-stats%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/567/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 06:16:43 +
Build duration: 1 min 10 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kactivities-stats%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/573/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 06:15:23 +
Build duration: 1 min 5 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kactivities-stats%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/573/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 06:15:23 +
Build duration: 1 min 5 sec
CHANGE SET
No changes
JUNIT RESULTS
50 matches
Mail list logo
