Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux,gcc - Build # 255 - Unstable!

2017-05-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/255/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 12 May 2017 19:00:42 + Build duration: 1 min 2 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 414 - Unstable!

2017-05-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/414/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 12 May 2017 18:53:32 + Build duration: 4 min 6 sec CHANGE SET Revision

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-12 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R263:b5af0296cb2f: When building menu hyerarchies, parent menus to their containers (authored by mart). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D5773: [WIP] workarounds for menu positioning

2017-05-12 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:680a8a9e2832: [WIP] workarounds for menu positioning (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5773?vs=1=14445

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-12 Thread Marco Martin
mart retitled this revision from "[WIP] when building menu hyerarchies, parent menus to their containers" to "When building menu hyerarchies, parent menus to their containers". REPOSITORY R263 KXmlGui BRANCH phab/reparentmenus REVISION DETAIL https://phabricator.kde.org/D5806 To: mart,

D5806: [WIP] when building menu hyerarchies, parent menus to their containers

2017-05-12 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. *hierarchy looks sensible. Add a comment in the code as to why we're doing this. REPOSITORY R263 KXmlGui BRANCH phab/reparentmenus REVISION DETAIL

D5773: [WIP] workarounds for menu positioning

2017-05-12 Thread David Edmundson
davidedmundson added a comment. don't keep [WIP} in the title though :) REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D5773 REVISION DETAIL https://phabricator.kde.org/D5773 To: mart, #plasma, #plasma_on_wayland, davidedmundson Cc: davidedmundson, plasma-devel,

D5773: [WIP] workarounds for menu positioning

2017-05-12 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D5773 REVISION DETAIL https://phabricator.kde.org/D5773 To: mart, #plasma, #plasma_on_wayland, davidedmundson Cc: davidedmundson,

D5773: [WIP] workarounds for menu positioning

2017-05-12 Thread Marco Martin
mart updated this revision to Diff 1. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - remove duplication REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5773?vs=14438=1

D5747: add pid to plasma window management protocol

2017-05-12 Thread Sebastian Kügler
sebas updated this revision to Diff 14442. sebas added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - Update docs: the pid is just set, but doesn't logically change - ws-- REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D5747: add pid to plasma window management protocol

2017-05-12 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > plasmawindowmodel.cpp:84 > > + > QObject::connect(window, ::activeChanged, q, Unrelated newline > plasma-window-management.xml:263 > + >

D5773: [WIP] workarounds for menu positioning

2017-05-12 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > qmenu.cpp:117 > +m_menu->windowHandle()->setTransientParent(item->window()); > +} > } we always do this in ::open() so why have this chunk? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D5773: [WIP] workarounds for menu positioning

2017-05-12 Thread Marco Martin
mart updated this revision to Diff 14438. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - more aggressive reparenting in open() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5757: add requestToggleKeepAbove/below

2017-05-12 Thread Martin Flöser
graesslin added a comment. Your tests in plasma window management do not test the new requests. INLINE COMMENTS > test_wayland_windowmanagement.cpp:483 > +using namespace KWayland::Server; > +// this test verifies setting the showing desktop state > +

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 413 - Fixed!

2017-05-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/413/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 12 May 2017 14:58:50 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 413 - Fixed!

2017-05-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/413/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 12 May 2017 14:58:50 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 414 - Fixed!

2017-05-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/414/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 12 May 2017 14:58:50 + Build duration: 4 min 58 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 414 - Fixed!

2017-05-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/414/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Fri, 12 May 2017 14:58:50 + Build duration: 4 min 58 sec CHANGE

D5745: recreate plasmashellsurf on exposed, destoy on hidden

2017-05-12 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:fd2e850156ac: recreate plasmashellsurf on exposed, destoy on hidden (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5745: recreate plasmashellsurf on exposed, destoy on hidden

2017-05-12 Thread Marco Martin
mart updated this revision to Diff 14435. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14247=14435 BRANCH

D5745: recreate plasmashellsurf on exposed, destoy on hidden

2017-05-12 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. some code comments would be good. you can copy update https://phabricator.kde.org/T6064 REPOSITORY R242 Plasma Framework (Library) BRANCH phab/recreateshell REVISION

D5747: add pid to plasma window management protocol

2017-05-12 Thread Eike Hein
hein accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5747 To: sebas, #plasma, hein, graesslin Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-12 Thread David Edmundson
davidedmundson added a comment. Alternate suggestion: register app-name + QDbus::connection()->baseServiceName. it'll be guaranteed unique. (though does anything even use the DBus service name in multi mode? It doesn't seem to be very useful. kquitapp5 doesn't support it.)

D5775: Don't include the pid in the dbus path when on flatpak

2017-05-12 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D5775#108938, @jgrulich wrote: > Problem is that the name, even when the pid would be unique, won't be predictable. You still need to change it to something like org.kde.appName.pid so you can use org.kde.appName.* in flatpak