winterz added a comment.
Because Hannah told me the script doesn't work on Windows.
let's look at validate-svg.sh.
you need a working unix 'find' command (not the WIndows find command) as well
as xmllint for the bash script to work.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
heikobecker added a comment.
Ping? Not sure what to do with this, still would like to hear something from
@skelly. Or should I just go ahead and use ClangConfig.cmake (meaning dropping
the version requirement, I don't have any older clang versions around to easily
test it.)
REPOSITORY
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We only need to pass TRANSLATION_DOMAIN when compiling the C++ code since
it's the only part that contains i18n() calls.
Reason: The
El dijous, 25 de maig de 2017, a les 1:02:58 CEST, Stephen Kelly va escriure:
> On 04/15/2017 10:53 PM, Luca Beltrame wrote:
> > I can't understand the error thrown by ki18n (when it does not build) or
> > I'd have attempted to fix it myself...
>
> Hi, sorry for my delayed response.
>
> Should
aacid added a comment.
I don't understand, you say it has bash, so why are you commenting out the
bash related code?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5975
To: winterz
Cc: aacid, #frameworks
apol updated this revision to Diff 14866.
apol added a comment.
Removed unrelated changes
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5979?vs=14865=14866
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5979
AFFECTED FILES
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Update the state before emitting, otherwise things could be not consistent
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5979
AFFECTED FILES
tfry updated this revision to Diff 14863.
tfry added a comment.
Switch to QThreadStorage, use quintptr as suggested, add auto-test.
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5966?vs=14831=14863
BRANCH
master
REVISION DETAIL
winterz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The GoW package on Windows has bash. We don't want to find bash on Windows.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:c02c4806c9bf: Fix property changes being missed
immediately after an obejct is added (authored by drosca).
REPOSITORY
R269 BluezQt
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:2b0b904ee0e9: Fix KSNIs being unable to register service
under flatpak (authored by davidedmundson).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
jgrulich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5970
To: davidedmundson, #frameworks, jgrulich
Cc: jgrulich
jgrulich added a comment.
+1
I tested this change with flatpak and it works as it should.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D5970
To: davidedmundson, #frameworks
Cc: jgrulich
tfry added a comment.
In https://phabricator.kde.org/D5966#111878, @rjvbb wrote:
> but I also didn't verify if QSet::insert is thread-safe.
Ouch, you're right, it isn't. QThreadStorage it shall be, then (until we can
use thread_local). That also handles thread-destruction,
rjvbb added a comment.
Using QSet was my suggestion, if cheaper than QThreadStorage - something I
didn't check, but I also didn't verify if QSet::insert is thread-safe.
About C++11: since when exactly does Qt require C++11 again?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
15 matches
Mail list logo
