aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6226
To: dfaure, aacid
Cc: apol, #frameworks
mart marked an inline comment as done.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
progwolff, lesliezhai, ali-mohamed,
mart retitled this revision from "Introduce aboutToShow() signal" to "Make sure
size is final after showEvent".
mart edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc:
mart updated this revision to Diff 15462.
mart added a comment.
update size in showevent
update size in showevent, get rid of aboutToShow signal
showing and hiding mainItem (as opposed to its window)
had repercussions on the size calculation, giving it
a stuttering appearance when
anthonyfieroni added inline comments.
INLINE COMMENTS
> activeconnection.h:77
> +DeviceRealizeFailedReason, /**< Could not create the software device
> link. */
> +DeviceRemoved /** < The device this connection depended on
> disappeared. */
> +};
All others are composed
davidedmundson added a comment.
> There is just one minor problem, with two stateChanged() signals you will
need to specify to which signal you want
> to connect to when using Qt5 syntax for signals/slots and without that you
won't compile current code, i.e. of plasma-nm
I think we're
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:980d4edf2b52: add an extractor using qtmultimedia
(authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=15454=15461
REVISION DETAIL
> On April 1, 2017, 9:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
>
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
>
> I've tried to test migration today but it didn't work. May as well have
> nothing to do with te patch and be caused by the
apol added a comment.
+1 makes sense
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D6226
To: dfaure
Cc: apol, #frameworks
> On April 1, 2017, 7:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
>
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
>
> I've tried to test migration today but it didn't work. May as well have
> nothing to do with te patch and be caused by the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review103324
---
One thing that didn't go very smoothly: migration of the
> On April 1, 2017, 9:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
>
> Andreas Sturmlechner wrote:
> Thanks, anyone else who wants to +1?
>
> I've tried to test migration today but it didn't work. May as well have
> nothing to do with te patch and be caused by the
dfaure created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Qt supports this string representation for Qt::KeypadModifier since 5.1
but this code didn't support that modifier.
This is the easy
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
qtmultimedia
REVISION DETAIL
https://phabricator.kde.org/D5417
To: mgallien, #frameworks, dfaure
Cc: dfaure, #frameworks
14 matches
Mail list logo
