aacid added inline comments.
INLINE COMMENTS
> valeriymalov wrote in kbookmarkmanager.cpp:341
> Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since
> it doesn't change the object, yet we need to emit non-const singal error. So
> should it be const or not?
>
> Also,
Hi,
A bit off-topic, but after my recent run-in with icon themes I had a look at
the Breeze icons build system to see how it creates the binary resource.
My own theme uses inheritance, so I think that in order to create an .rcc
resource from it I'd first need to merge the themes it inherits,
Could it be I'll have to start hacking around in
KIconLoader::loadMimeTypeIcon()?
David Faure wrote:
> * 78e572dadf - Revert "use transientparent directly" (7 days ago)
> []
> * 4690808e65 - use transientparent directly (5 weeks ago)
>
Thanks, cherry-picking 78e572dadf resolves the issue without any further
changes
required.
I'll check the proposed Qt change
Sebastian Kügler wrote:
> A screenshot says more than a thousand words... :)
You asked for it ;)
Snippets from KDevelop (1st) and Dolphin (2nd), kept as small as possible.
The round icons with arrows and the silver'ish folder icons are from my custom
icon theme (these sourced from Ciment),
On dinsdag 20 juni 2017 16:10:59 CEST René J.V. Bertin wrote:
> So where do those icons come from, and why are some applications immune?
> Pointers highly appreciated!
A screenshot says more than a thousand words... :)
--
sebas
http://www.kde.org | http://vizZzion.org
On Tuesday June 20 2017 16:10:59 René J.V. Bertin wrote:
> Other applications like KDevelop still work as I expect them to, even in
> their implementation of such navigation views.
In case that helps: KDevelop does show the wrong icons for symlinks.
R.
On Tuesday June 20 2017 13:19:51 David Faure wrote:
>k-f-d is the proper place for this discussion => CC'ed.
I know, at least theoretically. In practice I didn't want to create noise there
where it might not interest the majority and fail to reach the person(s) most
likely to have an answer.
On mardi 20 juin 2017 13:01:29 CEST René J.V. Bertin wrote:
> Hi,
>
> Apologies for writing you directly and not a generic mailing list.
>
> I noticed an issue that was introduced by one of the relatively few changes
> to KXmlGui between v5.32.0 and v5.35.0 : the QtCurve configuration dialog
>
This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.
Closed by commit R263:951bc8a9b3c9: API dox: add notes to KActionCollection
about QAction ownership handling (authored by kossebau).
CHANGED PRIOR TO COMMIT
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.7/12/
Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 20 Jun 2017 08:15:11 +
Build duration:
1 min 18 sec and counting
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kactioncollection.h:325
> *
> + * The ownership of the action object is not transferred. If the action
> is destroyed
> + * it will be removed
12 matches
Mail list logo
